@pareto4/pp-core 1.9.0 → 1.11.0

package/scripts/gen-platform-bindings-schema.cjs

@@ -0,0 +1,148 @@
+#!/usr/bin/env node
+'use strict';
+
+/**
+ * Generates schemas/platform-bindings.schema.json's three GENERATED values
+ * from src/platform-bindings.cts's exported constants (via the COMPILED
+ * pp-core/bin/lib/platform-bindings.cjs). Commit the result; CI re-runs the
+ * script's --check arm and fails on drift.
+ *
+ * This script owns EXACTLY three values in the schema — the JSON pointers
+ * `properties.platform.properties.repo.pattern`,
+ * `properties.client.properties.vaultRepo.pattern`, and (34-02)
+ * `properties.schemaVersion.default`. Every other field in
+ * schemas/platform-bindings.schema.json is hand-authored and must be edited
+ * by hand. `--write` additionally normalizes the whole file's JSON
+ * formatting (two-space indent, single trailing newline).
+ *
+ * BUILD ORDER: this script requires the COMPILED
+ * pp-core/bin/lib/platform-bindings.cjs, so it must run AFTER `build:lib` in
+ * the `build` npm script chain — running it before the TypeScript build
+ * would throw a missing-module error.
+ *
+ * Usage:
+ *   node scripts/gen-platform-bindings-schema.cjs              # print to stdout
+ *   node scripts/gen-platform-bindings-schema.cjs --write      # write the schema
+ *   node scripts/gen-platform-bindings-schema.cjs --check      # exit 1 if committed schema is stale
+ *   node scripts/gen-platform-bindings-schema.cjs --schema <path>  # override the target file
+ */
+
+const fs = require('node:fs');
+const path = require('node:path');
+
+const { ExitError, runMain } = require('./lib/cli-exit.cjs');
+
+const ROOT = path.resolve(__dirname, '..');
+const DEFAULT_SCHEMA_PATH = path.join(ROOT, 'schemas', 'platform-bindings.schema.json');
+
+const PLATFORM_REPO_POINTER = 'properties.platform.properties.repo.pattern';
+const VAULT_REPO_POINTER = 'properties.client.properties.vaultRepo.pattern';
+// 34-02: carries CONTRACT_SCHEMA_VERSION into the schema as `default`, never
+// `const`/`enum` — JSON Schema treats `default` as annotation-only, so this
+// documents the current contract without constraining validation. Using
+// `const`/`enum` here would reject every existing `1.0.0` binding and break
+// Phase 32 D-08.
+const CONTRACT_VERSION_POINTER = 'properties.schemaVersion.default';
+
+/**
+ * Two-space-indented JSON with a single trailing newline — the format the
+ * committed schema file already uses.
+ */
+function serialize(obj) {
+  return JSON.stringify(obj, null, 2) + '\n';
+}
+
+/**
+ * Build the regenerated schema object: read and parse `schemaPath`, then
+ * assign the two owned pattern values from the compiled library. Throws an
+ * ExitError if either exported pattern source is missing or empty — a
+ * silently-empty pattern written into the schema would accept everything.
+ */
+function buildSchema(schemaPath) {
+  const lib = require(path.join(ROOT, 'pp-core', 'bin', 'lib', 'platform-bindings.cjs'));
+  const { PLATFORM_REPO_PATTERN_SOURCE, VAULT_REPO_PATTERN_SOURCE, CONTRACT_SCHEMA_VERSION } = lib;
+
+  if (typeof PLATFORM_REPO_PATTERN_SOURCE !== 'string' || PLATFORM_REPO_PATTERN_SOURCE.length === 0) {
+    throw new ExitError(
+      1,
+      'pp-core/bin/lib/platform-bindings.cjs does not export a non-empty PLATFORM_REPO_PATTERN_SOURCE — ' +
+        'run `npm run build:lib` first.',
+    );
+  }
+  if (typeof VAULT_REPO_PATTERN_SOURCE !== 'string' || VAULT_REPO_PATTERN_SOURCE.length === 0) {
+    throw new ExitError(
+      1,
+      'pp-core/bin/lib/platform-bindings.cjs does not export a non-empty VAULT_REPO_PATTERN_SOURCE — ' +
+        'run `npm run build:lib` first.',
+    );
+  }
+  if (typeof CONTRACT_SCHEMA_VERSION !== 'string' || !/^\d+\.\d+\.\d+$/.test(CONTRACT_SCHEMA_VERSION)) {
+    throw new ExitError(
+      1,
+      'pp-core/bin/lib/platform-bindings.cjs does not export a semver-triplet CONTRACT_SCHEMA_VERSION — ' +
+        'run `npm run build:lib` first.',
+    );
+  }
+
+  const schema = JSON.parse(fs.readFileSync(schemaPath, 'utf8'));
+  schema.properties.platform.properties.repo.pattern = PLATFORM_REPO_PATTERN_SOURCE;
+  schema.properties.client.properties.vaultRepo.pattern = VAULT_REPO_PATTERN_SOURCE;
+  schema.properties.schemaVersion.default = CONTRACT_SCHEMA_VERSION;
+  return schema;
+}
+
+function parseSchemaPathArg(argv) {
+  const idx = argv.indexOf('--schema');
+  if (idx === -1) return DEFAULT_SCHEMA_PATH;
+  const value = argv[idx + 1];
+  if (!value) {
+    throw new ExitError(1, '--schema requires a path argument');
+  }
+  return path.resolve(value);
+}
+
+function main() {
+  const argv = process.argv.slice(2);
+  const schemaPath = parseSchemaPathArg(argv);
+
+  if (argv.includes('--check')) {
+    const committed = fs.readFileSync(schemaPath, 'utf8');
+    const live = serialize(buildSchema(schemaPath));
+    if (committed !== live) {
+      const committedObj = JSON.parse(committed);
+      const liveObj = JSON.parse(live);
+      process.stderr.write(
+        schemaPath + ' is stale. The generator owns exactly three values:\n' +
+        '  ' + PLATFORM_REPO_POINTER + '\n' +
+        '  ' + VAULT_REPO_POINTER + '\n' +
+        '  ' + CONTRACT_VERSION_POINTER + '\n\n' +
+        '  ' + PLATFORM_REPO_POINTER + '\n' +
+        '    committed: ' + JSON.stringify(committedObj.properties.platform.properties.repo.pattern) + '\n' +
+        '    live:      ' + JSON.stringify(liveObj.properties.platform.properties.repo.pattern) + '\n' +
+        '  ' + VAULT_REPO_POINTER + '\n' +
+        '    committed: ' + JSON.stringify(committedObj.properties.client.properties.vaultRepo.pattern) + '\n' +
+        '    live:      ' + JSON.stringify(liveObj.properties.client.properties.vaultRepo.pattern) + '\n' +
+        '  ' + CONTRACT_VERSION_POINTER + '\n' +
+        '    committed: ' + JSON.stringify(committedObj.properties.schemaVersion.default) + '\n' +
+        '    live:      ' + JSON.stringify(liveObj.properties.schemaVersion.default) + '\n\n' +
+        'Run:\n' +
+        '  node scripts/gen-platform-bindings-schema.cjs --write' +
+        (schemaPath === DEFAULT_SCHEMA_PATH ? '' : ' --schema ' + schemaPath) +
+        '\n',
+      );
+      throw new ExitError(1);
+    }
+    process.stdout.write(schemaPath + ' is up to date.\n');
+    return;
+  }
+
+  if (argv.includes('--write')) {
+    fs.writeFileSync(schemaPath, serialize(buildSchema(schemaPath)));
+    process.stdout.write('Wrote ' + schemaPath + '\n');
+    return;
+  }
+
+  process.stdout.write(serialize(buildSchema(schemaPath)));
+}
+
+runMain(main);

package/scripts/lint-allow-test-rule-refs.allowlist.json

@@ -326,5 +326,12 @@
   "tests/workflow-size-budget.test.cjs :: source-text-is-the-product",
   "tests/workspace.test.cjs :: source-text-is-the-product",
   "tests/worktree-cleanup.test.cjs :: source-text-is-the-product",
-  "tests/worktree.test.cjs :: source-text-is-the-product"
+  "tests/worktree.test.cjs :: source-text-is-the-product",
+  "tests/comp-01-provider-off-by-default.test.cjs :: validates runtime CLI stdout/stderr/on-disk-config behavior, not source grep",
+  "tests/discovery-annotations.test.cjs :: source-text-is-the-product",
+  "tests/discovery-architecture-deliverables.test.cjs :: source-text-is-the-product",
+  "tests/discovery-to-build-canonical-refs.test.cjs :: source-text-is-the-product",
+  "tests/discovery-to-build-fixture.test.cjs :: source-text-is-the-product",
+  "tests/discovery-to-build-path-contract.test.cjs :: source-text-is-the-product",
+  "tests/release-smoke-discuss-plan-execute.install.test.cjs :: integration-test-input"
 ]

package/scripts/lint-descriptions.cjs

@@ -18,7 +18,9 @@ const path = require('path');
 const { ExitError, runMain } = require('./lib/cli-exit.cjs');
 
 const MAX_LENGTH = 100;
-const COMMANDS_DIR = path.join(__dirname, '..', 'commands', 'gsd');
+// D-12 flat-hyphen rename (05-04): command files live flat at commands/pp-<cmd>.md,
+// no longer under a legacy nested subdirectory (mirrors lint-command-contract.cjs's COMMANDS_DIR).
+const COMMANDS_DIR = path.join(__dirname, '..', 'commands');
 
 /**
  * Parse the description field from frontmatter in a .md file.

package/scripts/lint-legacy-dir-name.cjs

@@ -53,6 +53,11 @@ const ALLOWLIST_FILES = new Set([
   'README.ko-KR.md',
   'README.pt-BR.md',
   'README.zh-CN.md',
+  // Generated snapshot of every grandfathered legacy-token reference in the tree,
+  // so it quotes those lines by construction — including this file's own comment
+  // above. Scanning it here is circular: the baseline cannot carry per-line allow
+  // markers without breaking its byte-for-byte match against the real sources.
+  'tests/rename-guard-baseline.json',
 ]);
 
 const ALLOWLIST_DIR_PREFIXES = [

package/scripts/lint-test-file-count.allowlist.json

@@ -179,12 +179,21 @@
     },
     "vault": {
       "files": [
+        "vault-practices.property.test.cjs",
         "vault-read-path.test.cjs",
         "vault-security.test.cjs",
         "vault-status-check.test.cjs",
         "vault.test.cjs"
       ],
-      "issue": "v1.7.0 Client Vault Load — four distinct concerns: vault.test (fetch/status/summary unit), vault-security (VSEC-02/03 write-guard + secret/fence), vault-read-path (VGATE-03 SUMMARY pointer), vault-status-check (VGATE-02 gate-query handler)"
+      "issue": "v1.7.0 Client Vault Load — four distinct concerns: vault.test (fetch/status/summary unit), vault-security (VSEC-02/03 write-guard + secret/fence), vault-read-path (VGATE-03 SUMMARY pointer), vault-status-check (VGATE-02 gate-query handler). Phase 24-02 added vault-practices.property.test.cjs (fast-check fuzz of the practices glob-fallback compiler + a practices-frontmatter round-trip, PRAC-02) — it is grouped under this bucket rather than \"vault-practices\" because the test-file-count lint's hyphen-prefix matcher treats \"vault-practices.property\" (period before \"property\") as starting with \"vault-\" before it can match the more specific \"vault-practices-\" prefix; the module it actually tests is pp-core/bin/lib/vault-practices.cjs, not vault.cjs."
+    },
+    "vault-practices": {
+      "files": [
+        "vault-practices-examples.test.cjs",
+        "vault-practices-matcher.test.cjs",
+        "vault-practices.test.cjs"
+      ],
+      "issue": "Phase 24 (24-01/24-02/24-04) — three distinct concerns for pp-core/bin/lib/vault-practices.cjs: vault-practices.test (24-01 parser/validation/discovery unit tests), vault-practices-matcher.test (24-02 glob matcher + two-bucket result + report unit tests), vault-practices-examples.test (24-04 shipped-example drift guard + minimal-comments global-bucket smoke case, PRAC-03 Success Criterion 3). All three test the same production module and are each independently load-bearing; consolidating would blur distinct plan-level verification gates."
     }
   }
 }