@pareto4/pp-core 1.17.1 → 1.19.0

package/pp-core/bin/lib/vault-update.cjs

@@ -15,9 +15,7 @@
  * Two steps, so the confirmation is explicit and works the same for a person
  * and for an agent shell: without `--yes` it only reports the plan
  * (current → target) and writes nothing; with `--yes` it writes
- * `client.vaultRef`, fetches the vault at the new version, and reports any
- * practice whose `schemaVersion` is newer than this pp-core supports (the
- * vault version a project picks implies a minimum pp-core, never the reverse).
+ * `client.vaultRef` and fetches the vault at the new version.
  * It never commits: the command it prints is the operator's to run.
  *
  * ADR-457 build-at-publish: this TypeScript file is the SOURCE OF TRUTH. It
@@ -48,8 +46,6 @@ const { redactCloneTarget } = vaultModule;
 /** How many tags a report lists — enough to pick from, bounded for a long history. */
 exports.AVAILABLE_TAGS_CAP = 10;
 const BINDINGS_FILE = '.platform-bindings.json';
-/** Matches the degrade warning `parsePracticeFile` emits for a newer schemaVersion. */
-const NEWER_SCHEMA_WARNING_RE = /schemaVersion \d+ is newer than this pp-core supports/;
 // ─── Helpers ─────────────────────────────────────────────────────────────────
 function isObject(v) {
     return v !== null && typeof v === 'object' && !Array.isArray(v);
@@ -92,17 +88,6 @@ function runFetch(root, opts) {
         warnings,
     };
 }
-function findNewerSchemaPractices(root, opts) {
-    // eslint-disable-next-line @typescript-eslint/no-require-imports
-    const discover = opts._discover ?? require('./vault-practices.cjs').discoverPracticeFiles;
-    const discovery = discover(root);
-    const ids = [];
-    for (const entry of discovery.degraded ?? []) {
-        if (entry.warnings.some((w) => NEWER_SCHEMA_WARNING_RE.test(w)) && !ids.includes(entry.id))
-            ids.push(entry.id);
-    }
-    return ids;
-}
 // ─── vaultUpdate ─────────────────────────────────────────────────────────────
 /**
  * Plan — and with `apply` perform — a move of the project's client vault to
@@ -124,9 +109,9 @@ function vaultUpdate(cwd, opts = {}) {
         from: null,
         to: null,
         latest: null,
+        newer: null,
         available: [],
         fetch: null,
-        newerSchemaPractices: [],
         nextStep: null,
     };
     const fail = (reason, message) => ({
@@ -168,6 +153,9 @@ function vaultUpdate(cwd, opts = {}) {
     tags = [...new Set(tags)].sort((a, b) => (0, semver_compare_cjs_1.compareSemverCore)(b, a));
     result.available = tags.slice(0, exports.AVAILABLE_TAGS_CAP);
     result.latest = tags[0] ?? null;
+    if (result.from && result.latest && (0, semver_compare_cjs_1.isStableTripletSemver)(result.from) && (0, semver_compare_cjs_1.compareSemverCore)(result.latest, result.from) > 0) {
+        result.newer = result.latest;
+    }
     if (tags.length === 0) {
         return fail('no_tags', `The vault repo "${redactCloneTarget(repo)}" has no stable vX.Y.Z tag to pin to.`);
     }
@@ -213,12 +201,6 @@ function vaultUpdate(cwd, opts = {}) {
     catch {
         applied.fetch = { source: 'error', ref: null, warnings: ['The vault could not be fetched at the new version — run "pp-tools vault fetch" to retry.'] };
     }
-    try {
-        applied.newerSchemaPractices = findNewerSchemaPractices(root, opts);
-    }
-    catch {
-        applied.newerSchemaPractices = [];
-    }
     return applied;
 }
 /** Plain-text rendering of a `vaultUpdate` result for the non-`--raw` CLI path. */
@@ -232,9 +214,6 @@ function renderVaultUpdate(r) {
         for (const w of r.fetch.warnings)
             lines.push(w);
     }
-    if (r.newerSchemaPractices.length > 0) {
-        lines.push(`${r.newerSchemaPractices.length} practice(s) in this vault version were written for a newer pp-core and apply only in degraded form: ${r.newerSchemaPractices.join(', ')}. Update pp-core to apply them fully.`);
-    }
     if (r.nextStep) {
         lines.push(r.applied ? `Commit the change: ${r.nextStep}` : `To apply: ${r.nextStep}`);
     }