@pareto4/pp-core 1.13.0 → 1.18.0

package/pp-core/bin/lib/vault-update.cjs

@@ -1,8 +1,8 @@
 "use strict";
 /**
- * src/vault-update.cts — `pp-tools vault update [<tag>] [--yes]`.
+ * src/vault-update.cts — `pp-tools vault update [<tag>] [--yes]` (PBI 74316).
  *
- * Moves a project to another version of its client vault. The
+ * FORK-ONLY. Moves a project to another version of its client vault. The
  * vault version is a PROJECT property: `client.vaultRef` in the committed
  * `.platform-bindings.json` is the one place it lives, so no pp-core release
  * can move it — changing it is a deliberate act, and this is its command.
@@ -15,20 +15,9 @@
  * Two steps, so the confirmation is explicit and works the same for a person
  * and for an agent shell: without `--yes` it only reports the plan
  * (current → target) and writes nothing; with `--yes` it writes
- * `client.vaultRef`, fetches the vault at the new version, and reports any
- * practice whose `schemaVersion` is newer than this pp-core supports (the
- * vault version a project picks implies a minimum pp-core, never the reverse).
+ * `client.vaultRef` and fetches the vault at the new version.
  * It never commits: the command it prints is the operator's to run.
  *
- * With no `<tag>` it proposes the newest stable `vX.Y.Z` tag of the configured
- * vault repository, listed with `git ls-remote` at the same clone target the
- * fetch uses (`resolveClientCoordinates` + `composeCloneTarget`). Nothing here
- * reads an org profile for a version: the vault version is the project's.
- *
- * Every repository coordinate it prints goes through `redactCloneTarget`, and
- * every value it echoes from the bindings file or the command line is
- * bounded to one short line.
- *
  * ADR-457 build-at-publish: this TypeScript file is the SOURCE OF TRUTH. It
  * compiles to the git-ignored `pp-core/bin/lib/vault-update.cjs`.
  */
@@ -48,8 +37,8 @@ const compose_bindings_cjs_1 = require("./compose-bindings.cjs");
 const git_provider_cjs_1 = require("./git-provider.cjs");
 const vault_coordinates_cjs_1 = require("./vault-coordinates.cjs");
 const platform_bindings_cjs_1 = require("./platform-bindings.cjs");
-// The one coordinate redactor. Cycle-free — src/vault.cts imports nothing from
-// this module; the lazy `require` in runFetch exists for the `_fetch` seam default.
+// VAULT-EGRESS-1 (quick 261005-8py): the one coordinate redactor. Cycle-free — src/vault.cts imports
+// nothing from this module; the lazy `require` in runFetch exists for the `_fetch` seam default.
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 const vaultModule = require("./vault.cjs");
 const { redactCloneTarget } = vaultModule;
@@ -57,8 +46,6 @@ const { redactCloneTarget } = vaultModule;
 /** How many tags a report lists — enough to pick from, bounded for a long history. */
 exports.AVAILABLE_TAGS_CAP = 10;
 const BINDINGS_FILE = '.platform-bindings.json';
-/** Matches the degrade warning `parsePracticeFile` emits for a newer schemaVersion. */
-const NEWER_SCHEMA_WARNING_RE = /schemaVersion \d+ is newer than this pp-core supports/;
 // ─── Helpers ─────────────────────────────────────────────────────────────────
 function isObject(v) {
     return v !== null && typeof v === 'object' && !Array.isArray(v);
@@ -66,11 +53,6 @@ function isObject(v) {
 function usableString(v) {
     return typeof v === 'string' && v.trim() !== '' ? v.trim() : null;
 }
-/** A value from the bindings file or the command line, made safe to print: one line, at most 80 characters. */
-function shown(v) {
-    const flat = v.replace(/[\u0000-\u001F\u007F]+/g, ' ').trim();
-    return flat.length > 80 ? `${flat.slice(0, 80)}…` : flat;
-}
 function resolveRoot(cwd) {
     try {
         return (0, project_root_cjs_1.findProjectRoot)(cwd) || cwd;
@@ -103,21 +85,9 @@ function runFetch(root, opts) {
     return {
         source: typeof manifest.source === 'string' ? manifest.source : 'unknown',
         ref: typeof manifest.ref === 'string' ? manifest.ref : null,
-        tier: typeof manifest.tier === 'string' ? manifest.tier : null,
         warnings,
     };
 }
-function findNewerSchemaPractices(root, opts) {
-    // eslint-disable-next-line @typescript-eslint/no-require-imports
-    const discover = opts._discover ?? require('./vault-practices.cjs').discoverPracticeFiles;
-    const discovery = discover(root);
-    const ids = [];
-    for (const entry of discovery.degraded ?? []) {
-        if (entry.warnings.some((w) => NEWER_SCHEMA_WARNING_RE.test(w)) && !ids.includes(entry.id))
-            ids.push(entry.id);
-    }
-    return ids;
-}
 // ─── vaultUpdate ─────────────────────────────────────────────────────────────
 /**
  * Plan — and with `apply` perform — a move of the project's client vault to
@@ -141,7 +111,6 @@ function vaultUpdate(cwd, opts = {}) {
         latest: null,
         available: [],
         fetch: null,
-        newerSchemaPractices: [],
         nextStep: null,
     };
     const fail = (reason, message) => ({
@@ -173,8 +142,7 @@ function vaultUpdate(cwd, opts = {}) {
     let tags;
     try {
         const provider = (0, git_provider_cjs_1.resolveProvider)(root).provider;
-        // The same host chain the fetch uses (client.vaultHost, platform host, provider default).
-        const host = (0, vault_coordinates_cjs_1.resolveClientCoordinates)(root, provider).host;
+        const host = usableString(client.vaultHost) ?? (0, vault_coordinates_cjs_1.resolvePlatformHost)(root).host ?? (0, vault_coordinates_cjs_1.defaultHostForProvider)(provider);
         const target = (0, git_provider_cjs_1.composeCloneTarget)(provider, repo, host);
         tags = (0, compose_bindings_cjs_1.listStableTagsAt)(target.url, { _lsRemote: opts._lsRemote });
     }
@@ -190,10 +158,10 @@ function vaultUpdate(cwd, opts = {}) {
     const requested = usableString(opts.target);
     const to = requested ? matchRequestedTag(requested, tags) : tags[0];
     if (!to) {
-        return fail('unknown_tag', `The vault repo has no tag "${shown(requested ?? "")}". Available (newest first): ${result.available.join(', ')}.`);
+        return fail('unknown_tag', `The vault repo has no tag "${requested}". Available (newest first): ${result.available.join(', ')}.`);
     }
     result.to = to;
-    const fromLabel = result.from === null ? 'main (unpinned)' : shown(result.from);
+    const fromLabel = result.from ?? 'main (unpinned)';
     if (result.from === to) {
         return { ...result, ok: true, message: `The project is already on vault ${to}.` };
     }
@@ -227,13 +195,7 @@ function vaultUpdate(cwd, opts = {}) {
         applied.fetch = runFetch(root, opts);
     }
     catch {
-        applied.fetch = { source: 'error', ref: null, tier: null, warnings: ['The vault could not be fetched at the new version — run "pp-tools vault fetch" to retry.'] };
-    }
-    try {
-        applied.newerSchemaPractices = findNewerSchemaPractices(root, opts);
-    }
-    catch {
-        applied.newerSchemaPractices = [];
+        applied.fetch = { source: 'error', ref: null, warnings: ['The vault could not be fetched at the new version — run "pp-tools vault fetch" to retry.'] };
     }
     return applied;
 }
@@ -244,21 +206,10 @@ function renderVaultUpdate(r) {
         lines.push(`Newest available: ${r.latest}.`);
     }
     if (r.fetch) {
-        if (r.fetch.tier !== null && r.fetch.tier !== 'client' && r.fetch.source !== 'error') {
-            // A fallback-tier fetch is not the client vault at the new version, and
-            // must not read as if it were.
-            lines.push(`The client vault at ${r.to ?? 'the new version'} was NOT loaded: the fetch fell back to the ${r.fetch.tier} tier` +
-                `${r.fetch.ref ? ` at ${r.fetch.ref}` : ''}. Check access to the client vault, then run "pp-tools vault fetch".`);
-        }
-        else {
-            lines.push(`Fetched the vault: ${r.fetch.source}${r.fetch.ref ? ` at ${r.fetch.ref}` : ''}.`);
-        }
+        lines.push(`Fetched the vault: ${r.fetch.source}${r.fetch.ref ? ` at ${r.fetch.ref}` : ''}.`);
         for (const w of r.fetch.warnings)
             lines.push(w);
     }
-    if (r.newerSchemaPractices.length > 0) {
-        lines.push(`${r.newerSchemaPractices.length} practice(s) in this vault version were written for a newer pp-core and apply only in degraded form: ${r.newerSchemaPractices.join(', ')}. Update pp-core to apply them fully.`);
-    }
     if (r.nextStep) {
         lines.push(r.applied ? `Commit the change: ${r.nextStep}` : `To apply: ${r.nextStep}`);
     }