@pareto4/pp-core 1.13.0 → 1.17.1

package/pp-core/bin/lib/init-interactive.cjs

@@ -118,15 +118,88 @@ function renderComposeConfirm(prompter, info) {
 async function runInitInteractive(cwd, prompter, opts = {}) {
     const sessionOpts = { offline: opts.offline === true, _globalRoot: opts._globalRoot };
     let wroteBinding = false;
+    // PBI 74299: answers the session filled in itself are shown once each, as
+    // soon as they are decided, so the operator sees every value before the
+    // compose confirmation.
+    const shownAutoAnswers = new Set();
     for (let steps = 1; steps <= MAX_SESSION_STEPS; steps++) {
         const state = (0, init_contract_cjs_1.initSessionNext)(cwd, sessionOpts);
         if (state.error !== undefined) {
             prompter.print(`Error: ${state.message ?? state.error}`);
             return { ok: false, wroteBinding, steps, violations: [] };
         }
+        for (const auto of state.autoAnswered ?? []) {
+            if (shownAutoAnswers.has(auto.id))
+                continue;
+            shownAutoAnswers.add(auto.id);
+            const why = auto.source === 'derived' ? 'derived' : 'set by the org profile';
+            prompter.print(`  ${auto.id} = ${auto.value} (${why})`);
+        }
         if (state.done) {
             if (wroteBinding) {
-                prompter.print('Done — .platform-bindings.json was composed and written.');
+                // OD-1: the done line names the capability the session just armed and
+                // the step that is now live, so an operator is not left to discover
+                // either from the config file.
+                //
+                // 07-09 (WR-07): a READING, not a claim. The arming write happens
+                // only on an ABSENT key, so an operator's explicit `false` — and a
+                // hand-edited non-boolean — are still there when the session ends.
+                // Printing the armed line over either of those would make the last
+                // line `pp-tools init` prints contradict the config file it just
+                // finished writing, which is precisely the
+                // tool-reports-a-state-that-isn't-real failure this phase exists to
+                // end.
+                const vaultState = (0, init_contract_cjs_1.readVaultEnabledState)(cwd).state;
+                if (vaultState === 'off') {
+                    prompter.print('Done — .platform-bindings.json was composed and written; vault.enabled was left at false ' +
+                        'as this project set it, so the vault capability stays off and /pp-init Step 2.6 stays ' +
+                        'inert (arm it with pp-tools config-set vault.enabled true).');
+                }
+                else if (vaultState === 'malformed') {
+                    prompter.print('Done — .platform-bindings.json was composed and written; vault.enabled holds a non-boolean ' +
+                        'value and was left untouched — pp-tools query init-contract --verify reports it as ' +
+                        'INIT_VAULT_ENABLED_MALFORMED; store the boolean with pp-tools config-set vault.enabled true.');
+                }
+                else if (vaultState === 'armed') {
+                    // Quick 260915-lmc: vault.practices_enabled is armed beside it under
+                    // the same absent-only rule, so the line names it only when the
+                    // READING says true — an explicit false is the project's choice and
+                    // is not contradicted here.
+                    const practicesArmed = (0, init_contract_cjs_1.readVaultPracticesEnabledState)(cwd).state === 'armed';
+                    // Quick 260916-s5n: vault.required is named only when the READING
+                    // says armed, by the same rule — an explicit false is the project's
+                    // choice and the last line printed must not contradict it.
+                    const requiredArmed = (0, init_contract_cjs_1.readVaultRequiredState)(cwd).state === 'armed';
+                    // Built as a head plus two OPTIONAL clauses carrying no terminator
+                    // of their own, with exactly one full stop appended at the end. The
+                    // stop used to live inside the practices branch, which made every
+                    // further clause a sentence continuing past its own period.
+                    const head = 'Done — .platform-bindings.json was composed and written; vault.enabled is now true ' +
+                        '(the vault capability is armed — /pp-init Step 2.6 probes reachability next)';
+                    // 15-REVIEW WR-09: in standards mode no phase records practices (the
+                    // practices planner fragment and trace gates are filtered out), so the
+                    // clause names what IS recorded and checked there, whatever the
+                    // practices switch reads.
+                    const practicesClause = (0, init_contract_cjs_1.readVaultStandardsModeActive)(cwd)
+                        ? '; vault.mode is standards, so each plan records which client standards documents governed it ' +
+                            '(<vault_standards>), checked by the vault.trace gate'
+                        : practicesArmed
+                            ? '; vault.practices_enabled is true, so each phase records which client vault practices it applied'
+                            : '';
+                    const requiredClause = requiredArmed
+                        ? '; vault.required is true, so a client vault miss, a failed fetch or an unwritable vault summary ' +
+                            'stops the build at plan:pre and execute:pre'
+                        : '';
+                    prompter.print(head + practicesClause + requiredClause + '.');
+                }
+                else {
+                    // 'absent' — unreachable after an approved compose (the arming
+                    // write fires on exactly this state), kept defensive for the case
+                    // where that write itself failed. It says only what is certain:
+                    // the binding was written, and it does NOT claim the capability is
+                    // on, because the key is not there to say so.
+                    prompter.print('Done — .platform-bindings.json was composed and written.');
+                }
             }
             else if (typeof state.info === 'string') {
                 prompter.print(state.info);
@@ -168,9 +241,8 @@ async function runInitInteractive(cwd, prompter, opts = {}) {
                 preselectedLabel: state.preselectedLabel,
                 optionalAnswer: state.optionalAnswer,
             });
-            // A detected org profile is a hint, never a default: the driver has no
-            // default-acceptance path, and the answer goes to initSessionAnswer
-            // verbatim, which owns the none/blank decline.
+            // UAT-13-F2: the driver has no default-acceptance path, on purpose — the
+            // answer goes to initSessionAnswer verbatim, which owns the none/blank decline.
             const result = (0, init_contract_cjs_1.initSessionAnswer)(cwd, stepId, answer, sessionOpts);
             if (result.ok) {
                 if (stepId === 'compose_confirm') {

package/pp-core/bin/lib/init.cjs

@@ -32,7 +32,6 @@ const worktreeSafety = require("./worktree-safety.cjs");
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- planning-workspace.cjs is an export= CommonJS module
 const planningWorkspace = require("./planning-workspace.cjs");
 const secrets_cjs_1 = require("./secrets.cjs");
-const phase_tier_cjs_1 = require("./phase-tier.cjs");
 // eslint-disable-next-line @typescript-eslint/no-require-imports -- plan-scan.cjs is an export= CommonJS module
 const scanPhasePlans = require("./plan-scan.cjs");
 const state_document_cjs_1 = require("./state-document.cjs");
@@ -189,7 +188,8 @@ function getInitGitState(cwd) {
  * Quick 261007-jkl, D2 (todo "init execute-phase returns null phase_dir for an
  * archived phase") put the "is this archived match the current milestone's?"
  * compare HERE, for these four verbs only; every other consumer of the raw
- * locator kept the archive fall-through with no compare. The decision now lives in ONE owner, src/phase-scope.cts, which
+ * locator kept the archive fall-through with no compare (PBI 75323, quick
+ * 261009-gvf). The decision now lives in ONE owner, src/phase-scope.cts, which
  * every consumer shares: a phase archived in the CURRENT milestone keeps its
  * match, directory and artifacts; a PRIOR milestone's archived phase whose
  * number the current ROADMAP reuses is dropped (the pins in tests/init.test.cjs
@@ -222,26 +222,6 @@ function resolvePhaseForInit(cwd, phase) {
     }
     return { phaseInfo, roadmapPhase };
 }
-/**
- * The phase's resolved ceremony tier for an init payload (src/phase-tier.cts).
- * Init's gate booleans (`research_enabled`, `plan_checker_enabled`,
- * `verifier_enabled`, …) are read from this, never from raw config, so a
- * workflow that reads init reads the tier-resolved set.
- */
-function initPhaseTier(cwd, phase, options) {
-    const flag = options['tier'];
-    let cli = null;
-    if (typeof flag === 'string') {
-        const v = flag.trim().toLowerCase();
-        if (!(0, phase_tier_cjs_1.isPhaseTier)(v))
-            error(`--tier needs one of ${phase_tier_cjs_1.PHASE_TIERS.join(', ')}`);
-        cli = v;
-    }
-    return (0, phase_tier_cjs_1.resolvePhaseTierForProject)(cwd, phase, cli);
-}
-function phaseTierSummary(t) {
-    return { tier: t.tier, source: t.source, gates: t.gates, suppressed: t.suppressed };
-}
 function cmdInitExecutePhase(cwd, phase, raw, options = {}) {
     if (!phase) {
         error('phase required for init execute-phase');
@@ -255,7 +235,6 @@ function cmdInitExecutePhase(cwd, phase, raw, options = {}) {
         : null;
     const phase_req_ids = reqExtracted && reqExtracted !== 'TBD' ? reqExtracted : null;
     const wf = (config.workflow ?? {});
-    const tier = initPhaseTier(cwd, phase, options);
     const result = {
         executor_model: resolveModelInternal(cwd, 'pp-executor'),
         verifier_model: resolveModelInternal(cwd, 'pp-verifier'),
@@ -267,12 +246,7 @@ function cmdInitExecutePhase(cwd, phase, raw, options = {}) {
         branching_strategy: config.branching_strategy,
         phase_branch_template: config.phase_branch_template,
         milestone_branch_template: config.milestone_branch_template,
-        verifier_enabled: tier.gates.verifier,
-        code_review_enabled: tier.gates.code_review,
-        security_enforcement_enabled: tier.gates.security_enforcement,
-        nyquist_validation_enabled: tier.gates.nyquist_validation,
-        install_verification_enabled: tier.gates.install_verification,
-        phase_tier: phaseTierSummary(tier),
+        verifier_enabled: config.verifier,
         phase_found: !!phaseInfo,
         phase_dir: phaseInfo?.['directory'] || null,
         phase_number: phaseInfo?.['phase_number'] || null,
@@ -357,22 +331,15 @@ function cmdInitPlanPhase(cwd, phase, raw, options = {}) {
     assertValidGranularityOverride(granularityOverride, error);
     const granularity = resolveGranularityInternal(cwd, 'planning', granularityOverride || undefined);
     const wf = (config.workflow ?? {});
-    const tier = initPhaseTier(cwd, phase, options);
     const result = {
         researcher_model: resolveModelInternal(cwd, 'pp-phase-researcher'),
         planner_model: resolveModelInternal(cwd, 'pp-planner'),
         checker_model: resolveModelInternal(cwd, 'pp-plan-checker'),
         tdd_mode: options['tdd'] || Boolean(wf['tdd_mode']) || false,
         granularity,
-        research_enabled: tier.gates.research,
-        plan_checker_enabled: tier.gates.plan_check,
-        plan_check_passes: tier.gates.plan_check_passes,
-        nyquist_validation_enabled: tier.gates.nyquist_validation,
-        pattern_mapper_enabled: tier.gates.pattern_mapper,
-        post_planning_gaps_enabled: tier.gates.post_planning_gaps,
-        security_enforcement_enabled: tier.gates.security_enforcement,
-        plan_bounce_enabled: tier.gates.plan_bounce,
-        phase_tier: phaseTierSummary(tier),
+        research_enabled: wf['research'],
+        plan_checker_enabled: config.plan_checker,
+        nyquist_validation_enabled: wf['nyquist_validation'],
         commit_docs: config.commit_docs,
         text_mode: config.text_mode,
         auto_advance: !!(config.auto_advance),
@@ -603,10 +570,14 @@ function cmdInitNewMilestone(cwd, raw) {
     };
     output(withProjectRoot(cwd, result), raw);
 }
-function cmdInitQuick(cwd, description, raw) {
-    const config = loadConfig(cwd);
-    const now = new Date();
-    const slug = description ? generateSlugInternal(description)?.substring(0, 40) : null;
+/**
+ * The quick-task id for a moment: `yymmdd` + `-` + the two-second block of the
+ * local day in base 36, padded to three (`261011-8yt`). A pure function of
+ * `now`, extracted verbatim from `cmdInitQuick` (16-05, D-29) so the plan-id
+ * owner (`SCAFFOLD_PLAN_ID_RE`, src/vault-standards.cts) is tested over ids the
+ * engine itself builds, all-digit and lettered, rather than over hand-typed ones.
+ */
+function buildQuickId(now) {
     const yy = String(now.getFullYear()).slice(-2);
     const mm = String(now.getMonth() + 1).padStart(2, '0');
     const dd = String(now.getDate()).padStart(2, '0');
@@ -614,7 +585,13 @@ function cmdInitQuick(cwd, description, raw) {
     const secondsSinceMidnight = now.getHours() * 3600 + now.getMinutes() * 60 + now.getSeconds();
     const timeBlocks = Math.floor(secondsSinceMidnight / 2);
     const timeEncoded = timeBlocks.toString(36).padStart(3, '0');
-    const quickId = dateStr + '-' + timeEncoded;
+    return dateStr + '-' + timeEncoded;
+}
+function cmdInitQuick(cwd, description, raw) {
+    const config = loadConfig(cwd);
+    const now = new Date();
+    const slug = description ? generateSlugInternal(description)?.substring(0, 40) : null;
+    const quickId = buildQuickId(now);
     const branchSlug = slug || 'quick';
     const quickBranchName = config.quick_branch_template
         ? config.quick_branch_template
@@ -676,22 +653,16 @@ function cmdInitResume(cwd, raw) {
     };
     output(withProjectRoot(cwd, result), raw);
 }
-function cmdInitVerifyWork(cwd, phase, raw, options = {}) {
+function cmdInitVerifyWork(cwd, phase, raw) {
     if (!phase) {
         error('phase required for init verify-work');
     }
     const config = loadConfig(cwd);
     const { phaseInfo } = resolvePhaseForInit(cwd, phase);
-    const tier = initPhaseTier(cwd, phase, options);
     const result = {
         planner_model: resolveModelInternal(cwd, 'pp-planner'),
         checker_model: resolveModelInternal(cwd, 'pp-plan-checker'),
         commit_docs: config.commit_docs,
-        plan_checker_enabled: tier.gates.plan_check,
-        plan_check_passes: tier.gates.plan_check_passes,
-        security_enforcement_enabled: tier.gates.security_enforcement,
-        nyquist_validation_enabled: tier.gates.nyquist_validation,
-        phase_tier: phaseTierSummary(tier),
         phase_found: !!phaseInfo,
         phase_dir: phaseInfo?.['directory'] || null,
         phase_number: phaseInfo?.['phase_number'] || null,
@@ -1882,6 +1853,8 @@ module.exports = {
     cmdInitNewProject,
     cmdInitNewMilestone,
     cmdInitQuick,
+    // 16-05 (D-29): the pure quick-id builder, so the plan-id owner is tested over real ids.
+    buildQuickId,
     cmdInitIngestDocs,
     cmdInitResume,
     cmdInitVerifyWork,

package/pp-core/bin/lib/install-profiles.cjs

@@ -27,7 +27,7 @@ const shell_command_projection_cjs_1 = require("./shell-command-projection.cjs")
  */
 const PROFILES = Object.freeze({
     core: Object.freeze([
-        // init is the front door every installer/hook/no-project message
+        // PBI 75232: init is the front door every installer/hook/no-project message
         // names, so it ships in every profile — a minimal install must not print a
         // start command it did not install.
         'init',

package/pp-core/bin/lib/io.cjs

@@ -187,6 +187,12 @@ const ERROR_REASON = Object.freeze({
     VAULT_PROMOTE_TARGET_REFUSED: 'vault_promote_target_refused',
     VAULT_PROMOTE_CONCURRENT_EDIT: 'vault_promote_concurrent_edit',
     VAULT_PROMOTE_TRANSPORT_FAILED: 'vault_promote_transport_failed',
+    // vault.mode (Vault Assurance 13-03, D-08/D-14): an unrecognised mode value,
+    // and the standards-mode promote refusal
+    VAULT_MODE_INVALID: 'vault_mode_invalid',
+    // 13-REVIEW WR-01: the mode resolver failed; refused like an invalid value
+    VAULT_MODE_UNRESOLVED: 'vault_mode_unresolved',
+    VAULT_PROMOTE_NOT_APPLICABLE: 'vault_promote_not_applicable',
     // discovery rollup (discovery-v2 Phase 1: D-07/D-08 gate)
     DISCOVERY_ROLLUP_PARSE_FAILED: 'discovery_rollup_parse_failed',
     DISCOVERY_ROLLUP_MISMATCH: 'discovery_rollup_mismatch',
@@ -201,6 +207,8 @@ const ERROR_REASON = Object.freeze({
     DISCOVERY_ELEMENT_SWEEP_FAILED: 'discovery_element_sweep_failed',
     // discovery scope re-baselining (discovery-v2 Phase 5: D-72/D-73 gate)
     DISCOVERY_REBASELINE_CHECK_FAILED: 'discovery_rebaseline_check_failed',
+    // discovery vault context record (PBI 75336)
+    DISCOVERY_VAULT_CHECK_FAILED: 'discovery_vault_check_failed',
     // generic
     USAGE: 'usage',
     UNKNOWN: 'unknown',