@parcel/transformer-postcss 2.0.0-beta.3.1 → 2.0.0-dev.1515

package/lib/PostCSSTransformer.js

@@ -4,130 +4,95 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
+function _rust() {
+  const data = require("@parcel/rust");
+  _rust = function () {
+    return data;
+  };
+  return data;
+}
 function _utils() {
   const data = require("@parcel/utils");
-
   _utils = function () {
     return data;
   };
-
   return data;
 }
-
 function _plugin() {
   const data = require("@parcel/plugin");
-
   _plugin = function () {
     return data;
   };
-
-  return data;
-}
-
-function _fileSystemLoader() {
-  const data = _interopRequireDefault(require("css-modules-loader-core/lib/file-system-loader"));
-
-  _fileSystemLoader = function () {
-    return data;
-  };
-
   return data;
 }
-
 function _nullthrows() {
   const data = _interopRequireDefault(require("nullthrows"));
-
   _nullthrows = function () {
     return data;
   };
-
   return data;
 }
-
 function _path() {
   const data = _interopRequireDefault(require("path"));
-
   _path = function () {
     return data;
   };
-
   return data;
 }
-
 function _semver() {
   const data = _interopRequireDefault(require("semver"));
-
   _semver = function () {
     return data;
   };
-
   return data;
 }
-
 function _postcssValueParser() {
   const data = _interopRequireDefault(require("postcss-value-parser"));
-
   _postcssValueParser = function () {
     return data;
   };
-
-  return data;
-}
-
-function _postcssModules() {
-  const data = _interopRequireDefault(require("postcss-modules"));
-
-  _postcssModules = function () {
-    return data;
-  };
-
   return data;
 }
-
-function _loadConfig() {
-  const data = require("./loadConfig");
-
-  _loadConfig = function () {
+var _loadConfig = require("./loadConfig");
+var _constants = require("./constants");
+function _diagnostic() {
+  const data = require("@parcel/diagnostic");
+  _diagnostic = function () {
     return data;
   };
-
   return data;
 }
-
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
-
 const COMPOSES_RE = /composes:.+from\s*("|').*("|')\s*;?/;
 const FROM_IMPORT_RE = /.+from\s*(?:"|')(.*)(?:"|')\s*;?/;
-
-var _default = new (_plugin().Transformer)({
+const LEGACY_MODULE_RE = /@value|:export|(:global|:local|:import)(?!\s*\()/i;
+const MODULE_BY_NAME_RE = /\.module\./;
+var _default = exports.default = new (_plugin().Transformer)({
   loadConfig({
     config,
     options,
     logger
   }) {
-    return (0, _loadConfig().load)({
+    return (0, _loadConfig.load)({
       config,
       options,
       logger
     });
   },
-
   canReuseAST({
     ast
   }) {
-    return ast.type === 'postcss' && _semver().default.satisfies(ast.version, '^8.2.1');
+    return ast.type === 'postcss' && _semver().default.satisfies(ast.version, _constants.POSTCSS_RANGE);
   },
-
   async parse({
     asset,
     config,
     options
   }) {
-    if (!config) {
+    let isLegacy = await isLegacyCssModule(asset);
+    if (!config && !isLegacy) {
       return;
     }
-
     const postcss = await loadPostcss(options, asset.filePath);
     return {
       type: 'postcss',
@@ -137,62 +102,139 @@ var _default = new (_plugin().Transformer)({
       }).toJSON()
     };
   },
-
   async transform({
     asset,
     config,
     options,
-    resolve
+    resolve,
+    logger
   }) {
     asset.type = 'css';
+    let isLegacy = await isLegacyCssModule(asset);
+    if (isLegacy && !config) {
+      config = {
+        raw: {},
+        filePath: '',
+        hydrated: {
+          plugins: [],
+          from: asset.filePath,
+          to: asset.filePath,
+          modules: {}
+        }
+      };
+
+      // TODO: warning?
+    }
 
     if (!config) {
       return [asset];
     }
-
     const postcss = await loadPostcss(options, asset.filePath);
+    let ast = (0, _nullthrows().default)(await asset.getAST());
+    let program = postcss.fromJSON(ast.program);
     let plugins = [...config.hydrated.plugins];
     let cssModules = null;
-
     if (config.hydrated.modules) {
-      plugins.push((0, _postcssModules().default)({
+      asset.meta.cssModulesCompiled = 'postcss';
+      let code = asset.isASTDirty() ? null : await asset.getCode();
+      if (Object.keys(config.hydrated.modules).length === 0 && code && !isLegacy && !LEGACY_MODULE_RE.test(code)) {
+        let filename = _path().default.basename(config.filePath);
+        let message;
+        let configKey;
+        let hint;
+        if (config.raw.modules) {
+          message = (0, _diagnostic().md)`The "modules" option in __${filename}__ can be replaced with configuration for @parcel/transformer-css to improve build performance.`;
+          configKey = '/modules';
+          hint = (0, _diagnostic().md)`Remove the "modules" option from __${filename}__`;
+        } else {
+          message = (0, _diagnostic().md)`The "postcss-modules" plugin in __${filename}__ can be replaced with configuration for @parcel/transformer-css to improve build performance.`;
+          configKey = '/plugins/postcss-modules';
+          hint = (0, _diagnostic().md)`Remove the "postcss-modules" plugin from __${filename}__`;
+        }
+        if (filename === 'package.json') {
+          configKey = `/postcss${configKey}`;
+        }
+        let hints = ['Enable the "cssModules" option for "@parcel/transformer-css" in your package.json'];
+        if (plugins.length === 0) {
+          message += (0, _diagnostic().md)` Since there are no other plugins, __${filename}__ can be deleted safely.`;
+          hints.push((0, _diagnostic().md)`Delete __${filename}__`);
+        } else {
+          hints.push(hint);
+        }
+        let codeFrames;
+        if (_path().default.extname(filename) !== '.js') {
+          let contents = await asset.fs.readFile(config.filePath, 'utf8');
+          codeFrames = [{
+            language: 'json',
+            filePath: config.filePath,
+            code: contents,
+            codeHighlights: (0, _diagnostic().generateJSONCodeHighlights)(contents, [{
+              key: configKey,
+              type: 'key'
+            }])
+          }];
+        } else {
+          codeFrames = [{
+            filePath: config.filePath,
+            codeHighlights: [{
+              start: {
+                line: 1,
+                column: 1
+              },
+              end: {
+                line: 1,
+                column: 1
+              }
+            }]
+          }];
+        }
+        logger.warn({
+          message,
+          hints,
+          documentationURL: 'https://parceljs.org/languages/css/#enabling-css-modules-globally',
+          codeFrames
+        });
+      }
+
+      // TODO: should this be resolved from the project root?
+      let postcssModules = await options.packageManager.require('postcss-modules', asset.filePath, {
+        range: '^4.3.0',
+        saveDev: true,
+        shouldAutoInstall: options.shouldAutoInstall
+      });
+      plugins.push(postcssModules({
         getJSON: (filename, json) => cssModules = json,
-        Loader: createLoader(asset, resolve),
-        generateScopedName: (name, filename) => `_${name}_${(0, _utils().md5FromString)(_path().default.relative(options.projectRoot, filename)).substr(0, 6)}`,
+        Loader: await createLoader(asset, resolve, options),
+        generateScopedName: (name, filename) => `${name}_${(0, _rust().hashString)(_path().default.relative(options.projectRoot, filename)).substr(0, 6)}`,
         ...config.hydrated.modules
       }));
-    }
-
-    let ast = (0, _nullthrows().default)(await asset.getAST());
-    let program = postcss.fromJSON(ast.program);
-    let code = asset.isASTDirty() ? null : await asset.getCode();
-
-    if (code == null || COMPOSES_RE.test(code)) {
-      program.walkDecls(decl => {
-        let [, importPath] = FROM_IMPORT_RE.exec(decl.value) || [];
-
-        if (decl.prop === 'composes' && importPath != null) {
-          let parsed = (0, _postcssValueParser().default)(decl.value);
-          parsed.walk(node => {
-            if (node.type === 'string') {
-              asset.addDependency({
-                moduleSpecifier: importPath,
-                loc: {
-                  filePath: asset.filePath,
-                  start: decl.source.start,
-                  end: {
-                    line: decl.source.start.line,
-                    column: decl.source.start.column + importPath.length
+      if (code == null || COMPOSES_RE.test(code)) {
+        program.walkDecls(decl => {
+          let [, importPath] = FROM_IMPORT_RE.exec(decl.value) || [];
+          if (decl.prop === 'composes' && importPath != null) {
+            let parsed = (0, _postcssValueParser().default)(decl.value);
+            parsed.walk(node => {
+              if (node.type === 'string') {
+                asset.addDependency({
+                  specifier: importPath,
+                  specifierType: 'url',
+                  loc: {
+                    filePath: asset.filePath,
+                    start: decl.source.start,
+                    end: {
+                      line: decl.source.start.line,
+                      column: decl.source.start.column + importPath.length
+                    }
                   }
-                }
-              });
-            }
-          });
-        }
-      });
-    } // $FlowFixMe Added in Flow 0.121.0 upgrade in #4381
-
+                });
+              }
+            });
+          }
+        });
+      }
+    }
 
+    // $FlowFixMe Added in Flow 0.121.0 upgrade in #4381
     let {
       messages,
       root
@@ -202,47 +244,50 @@ var _default = new (_plugin().Transformer)({
       version: '8.2.1',
       program: root.toJSON()
     });
-
     for (let msg of messages) {
       if (msg.type === 'dependency') {
-        asset.addIncludedFile(msg.file);
+        asset.invalidateOnFileChange(msg.file);
+      } else if (msg.type === 'dir-dependency') {
+        var _msg$glob;
+        let pattern = `${msg.dir}/${(_msg$glob = msg.glob) !== null && _msg$glob !== void 0 ? _msg$glob : '**/*'}`;
+        let files = await (0, _utils().glob)(pattern, asset.fs, {
+          onlyFiles: true
+        });
+        for (let file of files) {
+          asset.invalidateOnFileChange(_path().default.normalize(file));
+        }
+        asset.invalidateOnFileCreate({
+          glob: pattern
+        });
       }
     }
-
     let assets = [asset];
-
     if (cssModules) {
       // $FlowFixMe
       let cssModulesList = Object.entries(cssModules);
-      let deps = asset.getDependencies().filter(dep => !dep.isURL);
+      let deps = asset.getDependencies().filter(dep => dep.priority === 'sync');
       let code;
-
       if (deps.length > 0) {
         code = `
-          module.exports = Object.assign({}, ${deps.map(dep => `require(${JSON.stringify(dep.moduleSpecifier)})`).join(', ')}, ${JSON.stringify(cssModules, null, 2)});
+          module.exports = Object.assign({}, ${deps.map(dep => `require(${JSON.stringify(dep.specifier)})`).join(', ')}, ${JSON.stringify(cssModules, null, 2)});
         `;
       } else {
-        code = cssModulesList.map( // This syntax enables shaking the invidual statements, so that unused classes don't even exist in JS.
+        code = cssModulesList.map(
+        // This syntax enables shaking the invidual statements, so that unused classes don't even exist in JS.
         ([className, classNameHashed]) => `module.exports[${JSON.stringify(className)}] = ${JSON.stringify(classNameHashed)};`).join('\n');
       }
-
       asset.symbols.ensure();
-
       for (let [k, v] of cssModulesList) {
         asset.symbols.set(k, v);
       }
-
       asset.symbols.set('default', 'default');
       assets.push({
         type: 'js',
-        filePath: asset.filePath + '.js',
         content: code
       });
     }
-
     return assets;
   },
-
   async generate({
     asset,
     ast,
@@ -257,45 +302,46 @@ var _default = new (_plugin().Transformer)({
       content: code
     };
   }
-
 });
-
-exports.default = _default;
-
-function createLoader(asset, resolve) {
-  return class extends _fileSystemLoader().default {
+async function createLoader(asset, resolve, options) {
+  let {
+    default: FileSystemLoader
+  } = await options.packageManager.require('postcss-modules/build/css-loader-core/loader', asset.filePath);
+  return class extends FileSystemLoader {
     async fetch(composesPath, relativeTo) {
       let importPath = composesPath.replace(/^["']|["']$/g, '');
       let resolved = await resolve(relativeTo, importPath);
-
       let rootRelativePath = _path().default.resolve(_path().default.dirname(relativeTo), resolved);
-
-      let root = _path().default.resolve('/'); // fixes an issue on windows which is part of the css-modules-loader-core
+      let root = _path().default.resolve('/');
+      // fixes an issue on windows which is part of the css-modules-loader-core
       // see https://github.com/css-modules/css-modules-loader-core/issues/230
-
-
       if (rootRelativePath.startsWith(root)) {
         rootRelativePath = rootRelativePath.substr(root.length);
       }
-
       let source = await asset.fs.readFile(resolved, 'utf-8');
       let {
         exportTokens
-      } = await this.core.load(source, rootRelativePath, undefined, this.fetch.bind(this));
+      } = await this.core.load(source, rootRelativePath, undefined,
+      // $FlowFixMe[method-unbinding]
+      this.fetch.bind(this));
       return exportTokens;
     }
-
     get finalSource() {
       return '';
     }
-
   };
 }
-
 function loadPostcss(options, from) {
   return options.packageManager.require('postcss', from, {
-    range: '^8.2.1',
+    range: _constants.POSTCSS_RANGE,
     saveDev: true,
     shouldAutoInstall: options.shouldAutoInstall
   });
+}
+async function isLegacyCssModule(asset) {
+  if (!MODULE_BY_NAME_RE.test(asset.filePath)) {
+    return false;
+  }
+  let code = await asset.getCode();
+  return LEGACY_MODULE_RE.test(code);
 }

package/lib/constants.js

@@ -0,0 +1,7 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.POSTCSS_RANGE = void 0;
+const POSTCSS_RANGE = exports.POSTCSS_RANGE = '^8.2.1';

package/lib/loadConfig.js

@@ -4,157 +4,159 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.load = load;
-
 function _path() {
   const data = _interopRequireDefault(require("path"));
-
   _path = function () {
     return data;
   };
-
   return data;
 }
-
-function _utils() {
-  const data = require("@parcel/utils");
-
-  _utils = function () {
+function _diagnostic() {
+  const data = require("@parcel/diagnostic");
+  _diagnostic = function () {
     return data;
   };
-
   return data;
 }
-
 function _nullthrows() {
   const data = _interopRequireDefault(require("nullthrows"));
-
   _nullthrows = function () {
     return data;
   };
-
   return data;
 }
-
 function _clone() {
   const data = _interopRequireDefault(require("clone"));
-
   _clone = function () {
     return data;
   };
-
-  return data;
-}
-
-function _loadPlugins() {
-  const data = _interopRequireDefault(require("./loadPlugins"));
-
-  _loadPlugins = function () {
-    return data;
-  };
-
   return data;
 }
-
+var _constants = require("./constants");
+var _loadPlugins = _interopRequireDefault(require("./loadPlugins"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
-
-const MODULE_BY_NAME_RE = /\.module\./;
-
-async function configHydrator(configFile, config, resolveFrom, options) {
-  // Use a basic, modules-only PostCSS config if the file opts in by a name
-  // like foo.module.css
-  if (configFile == null && config.searchPath.match(MODULE_BY_NAME_RE)) {
-    configFile = {
-      plugins: {
-        'postcss-modules': {}
-      }
-    };
-    resolveFrom = __filename;
-  }
-
+async function configHydrator(configFile, config, resolveFrom, options, logger) {
   if (configFile == null) {
     return;
-  } // Load the custom config...
-
+  }
 
+  // Load the custom config...
   let modulesConfig;
   let configFilePlugins = (0, _clone().default)(configFile.plugins);
-
   if (configFilePlugins != null && typeof configFilePlugins === 'object' && configFilePlugins['postcss-modules'] != null) {
     modulesConfig = configFilePlugins['postcss-modules'];
     delete configFilePlugins['postcss-modules'];
   }
-
   if (!modulesConfig && configFile.modules) {
     modulesConfig = {};
   }
+  let plugins = await (0, _loadPlugins.default)(configFilePlugins, (0, _nullthrows().default)(resolveFrom), options);
 
-  let plugins = await (0, _loadPlugins().default)(configFilePlugins, (0, _nullthrows().default)(resolveFrom), options); // contents is either:
+  // contents is either:
   // from JSON:    { plugins: { 'postcss-foo': { ...opts } } }
   // from JS (v8): { plugins: [ { postcssPlugin: 'postcss-foo', ...visitor callback functions } ]
   // from JS (v7): { plugins: [ [Function: ...] ]
-
   let pluginArray = Array.isArray(configFilePlugins) ? configFilePlugins : Object.keys(configFilePlugins);
-
   for (let p of pluginArray) {
     if (typeof p === 'string') {
       config.addDevDependency({
-        moduleSpecifier: p,
+        specifier: p,
         resolveFrom: (0, _nullthrows().default)(resolveFrom)
       });
     }
   }
-
-  config.setResult({
+  let redundantPlugins = pluginArray.filter(p => p === 'autoprefixer' || p === 'postcss-preset-env');
+  if (redundantPlugins.length > 0) {
+    let filename = _path().default.basename(resolveFrom);
+    let isPackageJson = filename === 'package.json';
+    let message;
+    let hints = [];
+    if (!isPackageJson && redundantPlugins.length === pluginArray.length) {
+      message = (0, _diagnostic().md)`Parcel includes CSS transpilation and vendor prefixing by default. PostCSS config __${filename}__ contains only redundant plugins. Deleting it may significantly improve build performance.`;
+      hints.push((0, _diagnostic().md)`Delete __${filename}__`);
+    } else {
+      message = (0, _diagnostic().md)`Parcel includes CSS transpilation and vendor prefixing by default. PostCSS config __${filename}__ contains the following redundant plugins: ${[...redundantPlugins].map(p => _diagnostic().md.underline(p))}. Removing these may improve build performance.`;
+      hints.push((0, _diagnostic().md)`Remove the above plugins from __${filename}__`);
+    }
+    let codeFrames;
+    if (_path().default.extname(filename) !== '.js') {
+      let contents = await options.inputFS.readFile(resolveFrom, 'utf8');
+      let prefix = isPackageJson ? '/postcss' : '';
+      codeFrames = [{
+        language: 'json',
+        filePath: resolveFrom,
+        code: contents,
+        codeHighlights: (0, _diagnostic().generateJSONCodeHighlights)(contents, redundantPlugins.map(plugin => ({
+          key: `${prefix}/plugins/${plugin}`,
+          type: 'key'
+        })))
+      }];
+    } else {
+      codeFrames = [{
+        filePath: resolveFrom,
+        codeHighlights: [{
+          start: {
+            line: 1,
+            column: 1
+          },
+          end: {
+            line: 1,
+            column: 1
+          }
+        }]
+      }];
+    }
+    logger.warn({
+      message,
+      hints,
+      documentationURL: 'https://parceljs.org/languages/css/#default-plugins',
+      codeFrames
+    });
+  }
+  return {
     raw: configFile,
+    filePath: resolveFrom,
     hydrated: {
       plugins,
       from: config.searchPath,
       to: config.searchPath,
       modules: modulesConfig
     }
-  });
+  };
 }
-
 async function load({
   config,
   options,
   logger
 }) {
-  let configFile = await config.getConfig(['.postcssrc', '.postcssrc.json', '.postcssrc.js', 'postcss.config.js'], {
+  if (!config.isSource) {
+    return;
+  }
+  let configFile = await config.getConfig(['.postcssrc', '.postcssrc.json', '.postcssrc.js', '.postcssrc.cjs', '.postcssrc.mjs', 'postcss.config.js', 'postcss.config.cjs', 'postcss.config.mjs'], {
     packageKey: 'postcss'
   });
   let contents = null;
-
   if (configFile) {
     config.addDevDependency({
-      moduleSpecifier: 'postcss',
-      resolveFrom: config.searchPath
+      specifier: 'postcss',
+      resolveFrom: config.searchPath,
+      range: _constants.POSTCSS_RANGE
     });
     contents = configFile.contents;
-    let isDynamic = configFile && _path().default.extname(configFile.filePath) === '.js';
-
+    let isDynamic = configFile && _path().default.extname(configFile.filePath).endsWith('js');
     if (isDynamic) {
       // We have to invalidate on startup in case the config is non-deterministic,
       // e.g. using unknown environment variables, reading from the filesystem, etc.
       logger.warn({
         message: 'WARNING: Using a JavaScript PostCSS config file means losing out on caching features of Parcel. Use a .postcssrc(.json) file whenever possible.'
       });
-      config.shouldInvalidateOnStartup(); // Also add the config as a dev dependency so we attempt to reload in watch mode.
-
-      config.addDevDependency({
-        moduleSpecifier: (0, _utils().relativePath)(_path().default.dirname(config.searchPath), configFile.filePath),
-        resolveFrom: config.searchPath
-      });
     }
-
     if (typeof contents !== 'object') {
       throw new Error('PostCSS config should be an object.');
     }
-
     if (contents.plugins == null || typeof contents.plugins !== 'object' || Object.keys(contents.plugins).length === 0) {
       throw new Error('PostCSS config must have plugins');
     }
   }
-
-  return configHydrator(contents, config, configFile === null || configFile === void 0 ? void 0 : configFile.filePath, options);
+  return configHydrator(contents, config, configFile === null || configFile === void 0 ? void 0 : configFile.filePath, options, logger);
 }

package/lib/loadPlugins.js

@@ -4,7 +4,6 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = loadExternalPlugins;
-
 async function loadExternalPlugins(plugins, relative, options) {
   if (Array.isArray(plugins)) {
     return Promise.all(plugins.map(p => loadPlugin(p, relative, null, options.packageManager, options.shouldAutoInstall)).filter(Boolean));
@@ -15,20 +14,16 @@ async function loadExternalPlugins(plugins, relative, options) {
     return [];
   }
 }
-
 async function loadPlugin(pluginArg, relative, options = {}, packageManager, shouldAutoInstall) {
   if (typeof pluginArg !== 'string') {
     return pluginArg;
   }
-
   let plugin = await packageManager.require(pluginArg, relative, {
     shouldAutoInstall
   });
   plugin = plugin.default || plugin;
-
   if (options != null && typeof options === 'object' && Object.keys(options).length > 0) {
     plugin = plugin(options);
   }
-
   return plugin.default || plugin;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parcel/transformer-postcss",
-  "version": "2.0.0-beta.3.1",
+  "version": "2.0.0-dev.1515+9d5643b9b",
   "license": "MIT",
   "publishConfig": {
     "access": "public"
@@ -17,20 +17,21 @@
   "source": "src/PostCSSTransformer.js",
   "engines": {
     "node": ">= 12.0.0",
-    "parcel": "^2.0.0-beta.1"
+    "parcel": "^2.0.0-dev.1513+9d5643b9b"
   },
   "dependencies": {
-    "@parcel/plugin": "2.0.0-beta.3.1",
-    "@parcel/utils": "2.0.0-beta.3.1",
+    "@parcel/diagnostic": "2.0.0-dev.1515+9d5643b9b",
+    "@parcel/plugin": "2.0.0-dev.1515+9d5643b9b",
+    "@parcel/rust": "2.12.1-dev.3138+9d5643b9b",
+    "@parcel/utils": "2.0.0-dev.1515+9d5643b9b",
     "clone": "^2.1.1",
-    "css-modules-loader-core": "^1.1.0",
     "nullthrows": "^1.1.1",
-    "postcss-modules": "^3.2.2",
-    "postcss-value-parser": "^4.1.0",
-    "semver": "^5.4.1"
+    "postcss-value-parser": "^4.2.0",
+    "semver": "^7.5.2"
   },
   "devDependencies": {
-    "postcss": "^8.2.1"
+    "postcss": "^8.4.5",
+    "postcss-modules": "^4.3.1"
   },
-  "gitHead": "daece49d003ba804bbdaa3a7ed3d6aaf446f166d"
+  "gitHead": "9d5643b9b5ba1a6ff638b4ae32024222e46b8133"
 }

package/src/PostCSSTransformer.js

@@ -1,21 +1,24 @@
 // @flow
 
-import type {FilePath, MutableAsset, PluginOptions} from '@parcel/types';
+import type {FilePath, Asset, MutableAsset, PluginOptions} from '@parcel/types';
 
-import {md5FromString} from '@parcel/utils';
+import {hashString} from '@parcel/rust';
+import {glob} from '@parcel/utils';
 import {Transformer} from '@parcel/plugin';
-import FileSystemLoader from 'css-modules-loader-core/lib/file-system-loader';
 import nullthrows from 'nullthrows';
 import path from 'path';
 import semver from 'semver';
 import valueParser from 'postcss-value-parser';
-import postcssModules from 'postcss-modules';
 import typeof * as Postcss from 'postcss';
 
 import {load} from './loadConfig';
+import {POSTCSS_RANGE} from './constants';
+import {md, generateJSONCodeHighlights} from '@parcel/diagnostic';
 
 const COMPOSES_RE = /composes:.+from\s*("|').*("|')\s*;?/;
 const FROM_IMPORT_RE = /.+from\s*(?:"|')(.*)(?:"|')\s*;?/;
+const LEGACY_MODULE_RE = /@value|:export|(:global|:local|:import)(?!\s*\()/i;
+const MODULE_BY_NAME_RE = /\.module\./;
 
 export default (new Transformer({
   loadConfig({config, options, logger}) {
@@ -23,11 +26,14 @@ export default (new Transformer({
   },
 
   canReuseAST({ast}) {
-    return ast.type === 'postcss' && semver.satisfies(ast.version, '^8.2.1');
+    return (
+      ast.type === 'postcss' && semver.satisfies(ast.version, POSTCSS_RANGE)
+    );
   },
 
   async parse({asset, config, options}) {
-    if (!config) {
+    let isLegacy = await isLegacyCssModule(asset);
+    if (!config && !isLegacy) {
       return;
     }
 
@@ -44,56 +50,158 @@ export default (new Transformer({
     };
   },
 
-  async transform({asset, config, options, resolve}) {
+  async transform({asset, config, options, resolve, logger}) {
     asset.type = 'css';
+    let isLegacy = await isLegacyCssModule(asset);
+    if (isLegacy && !config) {
+      config = {
+        raw: {},
+        filePath: '',
+        hydrated: {
+          plugins: [],
+          from: asset.filePath,
+          to: asset.filePath,
+          modules: {},
+        },
+      };
+
+      // TODO: warning?
+    }
+
     if (!config) {
       return [asset];
     }
 
     const postcss: Postcss = await loadPostcss(options, asset.filePath);
+    let ast = nullthrows(await asset.getAST());
+    let program = postcss.fromJSON(ast.program);
 
     let plugins = [...config.hydrated.plugins];
     let cssModules: ?{|[string]: string|} = null;
     if (config.hydrated.modules) {
+      asset.meta.cssModulesCompiled = 'postcss';
+
+      let code = asset.isASTDirty() ? null : await asset.getCode();
+      if (
+        Object.keys(config.hydrated.modules).length === 0 &&
+        code &&
+        !isLegacy &&
+        !LEGACY_MODULE_RE.test(code)
+      ) {
+        let filename = path.basename(config.filePath);
+        let message;
+        let configKey;
+        let hint;
+        if (config.raw.modules) {
+          message = md`The "modules" option in __${filename}__ can be replaced with configuration for @parcel/transformer-css to improve build performance.`;
+          configKey = '/modules';
+          hint = md`Remove the "modules" option from __${filename}__`;
+        } else {
+          message = md`The "postcss-modules" plugin in __${filename}__ can be replaced with configuration for @parcel/transformer-css to improve build performance.`;
+          configKey = '/plugins/postcss-modules';
+          hint = md`Remove the "postcss-modules" plugin from __${filename}__`;
+        }
+        if (filename === 'package.json') {
+          configKey = `/postcss${configKey}`;
+        }
+
+        let hints = [
+          'Enable the "cssModules" option for "@parcel/transformer-css" in your package.json',
+        ];
+        if (plugins.length === 0) {
+          message += md` Since there are no other plugins, __${filename}__ can be deleted safely.`;
+          hints.push(md`Delete __${filename}__`);
+        } else {
+          hints.push(hint);
+        }
+
+        let codeFrames;
+        if (path.extname(filename) !== '.js') {
+          let contents = await asset.fs.readFile(config.filePath, 'utf8');
+          codeFrames = [
+            {
+              language: 'json',
+              filePath: config.filePath,
+              code: contents,
+              codeHighlights: generateJSONCodeHighlights(contents, [
+                {
+                  key: configKey,
+                  type: 'key',
+                },
+              ]),
+            },
+          ];
+        } else {
+          codeFrames = [
+            {
+              filePath: config.filePath,
+              codeHighlights: [
+                {
+                  start: {line: 1, column: 1},
+                  end: {line: 1, column: 1},
+                },
+              ],
+            },
+          ];
+        }
+
+        logger.warn({
+          message,
+          hints,
+          documentationURL:
+            'https://parceljs.org/languages/css/#enabling-css-modules-globally',
+          codeFrames,
+        });
+      }
+
+      // TODO: should this be resolved from the project root?
+      let postcssModules = await options.packageManager.require(
+        'postcss-modules',
+        asset.filePath,
+        {
+          range: '^4.3.0',
+          saveDev: true,
+          shouldAutoInstall: options.shouldAutoInstall,
+        },
+      );
+
       plugins.push(
         postcssModules({
           getJSON: (filename, json) => (cssModules = json),
-          Loader: createLoader(asset, resolve),
+          Loader: await createLoader(asset, resolve, options),
           generateScopedName: (name, filename) =>
-            `_${name}_${md5FromString(
+            `${name}_${hashString(
               path.relative(options.projectRoot, filename),
             ).substr(0, 6)}`,
           ...config.hydrated.modules,
         }),
       );
-    }
 
-    let ast = nullthrows(await asset.getAST());
-    let program = postcss.fromJSON(ast.program);
-    let code = asset.isASTDirty() ? null : await asset.getCode();
-    if (code == null || COMPOSES_RE.test(code)) {
-      program.walkDecls(decl => {
-        let [, importPath] = FROM_IMPORT_RE.exec(decl.value) || [];
-        if (decl.prop === 'composes' && importPath != null) {
-          let parsed = valueParser(decl.value);
-
-          parsed.walk(node => {
-            if (node.type === 'string') {
-              asset.addDependency({
-                moduleSpecifier: importPath,
-                loc: {
-                  filePath: asset.filePath,
-                  start: decl.source.start,
-                  end: {
-                    line: decl.source.start.line,
-                    column: decl.source.start.column + importPath.length,
+      if (code == null || COMPOSES_RE.test(code)) {
+        program.walkDecls(decl => {
+          let [, importPath] = FROM_IMPORT_RE.exec(decl.value) || [];
+          if (decl.prop === 'composes' && importPath != null) {
+            let parsed = valueParser(decl.value);
+
+            parsed.walk(node => {
+              if (node.type === 'string') {
+                asset.addDependency({
+                  specifier: importPath,
+                  specifierType: 'url',
+                  loc: {
+                    filePath: asset.filePath,
+                    start: decl.source.start,
+                    end: {
+                      line: decl.source.start.line,
+                      column: decl.source.start.column + importPath.length,
+                    },
                   },
-                },
-              });
-            }
-          });
-        }
-      });
+                });
+              }
+            });
+          }
+        });
+      }
     }
 
     // $FlowFixMe Added in Flow 0.121.0 upgrade in #4381
@@ -108,7 +216,14 @@ export default (new Transformer({
     });
     for (let msg of messages) {
       if (msg.type === 'dependency') {
-        asset.addIncludedFile(msg.file);
+        asset.invalidateOnFileChange(msg.file);
+      } else if (msg.type === 'dir-dependency') {
+        let pattern = `${msg.dir}/${msg.glob ?? '**/*'}`;
+        let files = await glob(pattern, asset.fs, {onlyFiles: true});
+        for (let file of files) {
+          asset.invalidateOnFileChange(path.normalize(file));
+        }
+        asset.invalidateOnFileCreate({glob: pattern});
       }
     }
 
@@ -118,12 +233,12 @@ export default (new Transformer({
       let cssModulesList = (Object.entries(cssModules): Array<
         [string, string],
       >);
-      let deps = asset.getDependencies().filter(dep => !dep.isURL);
+      let deps = asset.getDependencies().filter(dep => dep.priority === 'sync');
       let code: string;
       if (deps.length > 0) {
         code = `
           module.exports = Object.assign({}, ${deps
-            .map(dep => `require(${JSON.stringify(dep.moduleSpecifier)})`)
+            .map(dep => `require(${JSON.stringify(dep.specifier)})`)
             .join(', ')}, ${JSON.stringify(cssModules, null, 2)});
         `;
       } else {
@@ -146,7 +261,6 @@ export default (new Transformer({
 
       assets.push({
         type: 'js',
-        filePath: asset.filePath + '.js',
         content: code,
       });
     }
@@ -167,10 +281,15 @@ export default (new Transformer({
   },
 }): Transformer);
 
-function createLoader(
+async function createLoader(
   asset: MutableAsset,
   resolve: (from: FilePath, to: string) => Promise<FilePath>,
+  options: PluginOptions,
 ) {
+  let {default: FileSystemLoader} = await options.packageManager.require(
+    'postcss-modules/build/css-loader-core/loader',
+    asset.filePath,
+  );
   return class ParcelFileSystemLoader extends FileSystemLoader {
     async fetch(composesPath, relativeTo) {
       let importPath = composesPath.replace(/^["']|["']$/g, '');
@@ -188,6 +307,7 @@ function createLoader(
         source,
         rootRelativePath,
         undefined,
+        // $FlowFixMe[method-unbinding]
         this.fetch.bind(this),
       );
       return exportTokens;
@@ -201,8 +321,17 @@ function createLoader(
 
 function loadPostcss(options: PluginOptions, from: FilePath): Promise<Postcss> {
   return options.packageManager.require('postcss', from, {
-    range: '^8.2.1',
+    range: POSTCSS_RANGE,
     saveDev: true,
     shouldAutoInstall: options.shouldAutoInstall,
   });
 }
+
+async function isLegacyCssModule(asset: Asset | MutableAsset) {
+  if (!MODULE_BY_NAME_RE.test(asset.filePath)) {
+    return false;
+  }
+
+  let code = await asset.getCode();
+  return LEGACY_MODULE_RE.test(code);
+}

package/src/constants.js

@@ -0,0 +1,3 @@
+// @flow
+
+export const POSTCSS_RANGE = '^8.2.1';

package/src/loadConfig.js

@@ -1,32 +1,36 @@
 // @flow
-import type {Config, FilePath, PluginOptions} from '@parcel/types';
-import type {PluginLogger} from '@parcel/logger';
+import type {
+  Config,
+  FilePath,
+  PluginOptions,
+  PluginLogger,
+} from '@parcel/types';
 import path from 'path';
-import {relativePath} from '@parcel/utils';
+import {md, generateJSONCodeHighlights} from '@parcel/diagnostic';
 import nullthrows from 'nullthrows';
 import clone from 'clone';
+import {POSTCSS_RANGE} from './constants';
 
 import loadExternalPlugins from './loadPlugins';
 
-const MODULE_BY_NAME_RE = /\.module\./;
+type ConfigResult = {|
+  raw: any,
+  filePath: string,
+  hydrated: {|
+    plugins: Array<any>,
+    from: FilePath,
+    to: FilePath,
+    modules: any,
+  |},
+|};
 
 async function configHydrator(
   configFile: any,
   config: Config,
-  resolveFrom: ?FilePath,
+  resolveFrom: FilePath,
   options: PluginOptions,
-) {
-  // Use a basic, modules-only PostCSS config if the file opts in by a name
-  // like foo.module.css
-  if (configFile == null && config.searchPath.match(MODULE_BY_NAME_RE)) {
-    configFile = {
-      plugins: {
-        'postcss-modules': {},
-      },
-    };
-    resolveFrom = __filename;
-  }
-
+  logger: PluginLogger,
+): Promise<?ConfigResult> {
   if (configFile == null) {
     return;
   }
@@ -63,21 +67,82 @@ async function configHydrator(
   for (let p of pluginArray) {
     if (typeof p === 'string') {
       config.addDevDependency({
-        moduleSpecifier: p,
+        specifier: p,
         resolveFrom: nullthrows(resolveFrom),
       });
     }
   }
 
-  config.setResult({
+  let redundantPlugins = pluginArray.filter(
+    p => p === 'autoprefixer' || p === 'postcss-preset-env',
+  );
+  if (redundantPlugins.length > 0) {
+    let filename = path.basename(resolveFrom);
+    let isPackageJson = filename === 'package.json';
+    let message;
+    let hints = [];
+    if (!isPackageJson && redundantPlugins.length === pluginArray.length) {
+      message = md`Parcel includes CSS transpilation and vendor prefixing by default. PostCSS config __${filename}__ contains only redundant plugins. Deleting it may significantly improve build performance.`;
+      hints.push(md`Delete __${filename}__`);
+    } else {
+      message = md`Parcel includes CSS transpilation and vendor prefixing by default. PostCSS config __${filename}__ contains the following redundant plugins: ${[
+        ...redundantPlugins,
+      ].map(p =>
+        md.underline(p),
+      )}. Removing these may improve build performance.`;
+      hints.push(md`Remove the above plugins from __${filename}__`);
+    }
+
+    let codeFrames;
+    if (path.extname(filename) !== '.js') {
+      let contents = await options.inputFS.readFile(resolveFrom, 'utf8');
+      let prefix = isPackageJson ? '/postcss' : '';
+      codeFrames = [
+        {
+          language: 'json',
+          filePath: resolveFrom,
+          code: contents,
+          codeHighlights: generateJSONCodeHighlights(
+            contents,
+            redundantPlugins.map(plugin => ({
+              key: `${prefix}/plugins/${plugin}`,
+              type: 'key',
+            })),
+          ),
+        },
+      ];
+    } else {
+      codeFrames = [
+        {
+          filePath: resolveFrom,
+          codeHighlights: [
+            {
+              start: {line: 1, column: 1},
+              end: {line: 1, column: 1},
+            },
+          ],
+        },
+      ];
+    }
+
+    logger.warn({
+      message,
+      hints,
+      documentationURL: 'https://parceljs.org/languages/css/#default-plugins',
+      codeFrames,
+    });
+  }
+
+  return {
     raw: configFile,
+    filePath: resolveFrom,
     hydrated: {
       plugins,
       from: config.searchPath,
       to: config.searchPath,
       modules: modulesConfig,
     },
-  });
+  };
 }
 
 export async function load({
@@ -88,21 +153,36 @@ export async function load({
   config: Config,
   options: PluginOptions,
   logger: PluginLogger,
-|}): Promise<void> {
+|}): Promise<?ConfigResult> {
+  if (!config.isSource) {
+    return;
+  }
+
   let configFile: any = await config.getConfig(
-    ['.postcssrc', '.postcssrc.json', '.postcssrc.js', 'postcss.config.js'],
+    [
+      '.postcssrc',
+      '.postcssrc.json',
+      '.postcssrc.js',
+      '.postcssrc.cjs',
+      '.postcssrc.mjs',
+      'postcss.config.js',
+      'postcss.config.cjs',
+      'postcss.config.mjs',
+    ],
     {packageKey: 'postcss'},
   );
 
   let contents = null;
   if (configFile) {
     config.addDevDependency({
-      moduleSpecifier: 'postcss',
+      specifier: 'postcss',
       resolveFrom: config.searchPath,
+      range: POSTCSS_RANGE,
     });
 
     contents = configFile.contents;
-    let isDynamic = configFile && path.extname(configFile.filePath) === '.js';
+    let isDynamic =
+      configFile && path.extname(configFile.filePath).endsWith('js');
     if (isDynamic) {
       // We have to invalidate on startup in case the config is non-deterministic,
       // e.g. using unknown environment variables, reading from the filesystem, etc.
@@ -110,17 +190,6 @@ export async function load({
         message:
           'WARNING: Using a JavaScript PostCSS config file means losing out on caching features of Parcel. Use a .postcssrc(.json) file whenever possible.',
       });
-
-      config.shouldInvalidateOnStartup();
-
-      // Also add the config as a dev dependency so we attempt to reload in watch mode.
-      config.addDevDependency({
-        moduleSpecifier: relativePath(
-          path.dirname(config.searchPath),
-          configFile.filePath,
-        ),
-        resolveFrom: config.searchPath,
-      });
     }
 
     if (typeof contents !== 'object') {
@@ -136,5 +205,11 @@ export async function load({
     }
   }
 
-  return configHydrator(contents, config, configFile?.filePath, options);
+  return configHydrator(
+    contents,
+    config,
+    configFile?.filePath,
+    options,
+    logger,
+  );
 }