@parcel/transformer-babel 2.0.0-rc.0 → 2.1.1

package/lib/config.js

@@ -5,6 +5,16 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.load = load;
 
+function _json() {
+  const data = _interopRequireDefault(require("json5"));
+
+  _json = function () {
+    return data;
+  };
+
+  return data;
+}
+
 function _path() {
   const data = _interopRequireDefault(require("path"));
 
@@ -35,6 +45,16 @@ function _utils() {
   return data;
 }
 
+function _diagnostic() {
+  const data = require("@parcel/diagnostic");
+
+  _diagnostic = function () {
+    return data;
+  };
+
+  return data;
+}
+
 var _jsx = _interopRequireDefault(require("./jsx"));
 
 var _flow = _interopRequireDefault(require("./flow"));
@@ -178,6 +198,7 @@ async function load(config, options, logger) {
       config.setCacheKey(JSON.stringify(Date.now()));
       config.invalidateOnStartup();
     } else {
+      await warnOnRedundantPlugins(options.inputFS, partialConfig, logger);
       definePluginDependencies(config, partialConfig.options, options);
       config.setCacheKey((0, _utils().hashObject)(partialConfig.options));
     }
@@ -257,4 +278,122 @@ function definePluginDependencies(config, babelConfig, options) {
       }]
     });
   }
+}
+
+const redundantPresets = new Set(['@babel/preset-env', '@babel/preset-react', '@babel/preset-typescript', '@parcel/babel-preset-env']);
+
+async function warnOnRedundantPlugins(fs, babelConfig, logger) {
+  var _babelConfig$config;
+
+  if (babelConfig == null) {
+    return;
+  }
+
+  let configPath = (_babelConfig$config = babelConfig.config) !== null && _babelConfig$config !== void 0 ? _babelConfig$config : babelConfig.babelrc;
+
+  if (!configPath) {
+    return;
+  }
+
+  let presets = babelConfig.options.presets || [];
+  let plugins = babelConfig.options.plugins || [];
+  let foundRedundantPresets = new Set();
+  let filteredPresets = presets.filter(preset => {
+    if (redundantPresets.has(preset.file.request)) {
+      foundRedundantPresets.add(preset.file.request);
+      return false;
+    }
+
+    return true;
+  });
+
+  let filePath = _path().default.relative(process.cwd(), configPath);
+
+  let diagnostics = [];
+
+  if (filteredPresets.length === 0 && foundRedundantPresets.size > 0 && plugins.length === 0) {
+    diagnostics.push({
+      message: (0, _diagnostic().md)`Parcel includes transpilation by default. Babel config __${filePath}__ contains only redundant presets. Deleting it may significantly improve build performance.`,
+      codeFrames: [{
+        filePath: configPath,
+        codeHighlights: await getCodeHighlights(fs, configPath, foundRedundantPresets)
+      }],
+      hints: [(0, _diagnostic().md)`Delete __${filePath}__`],
+      documentationURL: 'https://parceljs.org/languages/javascript/#default-presets'
+    });
+  } else if (foundRedundantPresets.size > 0) {
+    diagnostics.push({
+      message: (0, _diagnostic().md)`Parcel includes transpilation by default. Babel config __${filePath}__ includes the following redundant presets: ${[...foundRedundantPresets].map(p => _diagnostic().md.underline(p))}. Removing these may improve build performance.`,
+      codeFrames: [{
+        filePath: configPath,
+        codeHighlights: await getCodeHighlights(fs, configPath, foundRedundantPresets)
+      }],
+      hints: [(0, _diagnostic().md)`Remove the above presets from __${filePath}__`],
+      documentationURL: 'https://parceljs.org/languages/javascript/#default-presets'
+    });
+  }
+
+  if (foundRedundantPresets.has('@babel/preset-env')) {
+    var _babelConfig$config2, _babelConfig$config3;
+
+    diagnostics.push({
+      message: "@babel/preset-env does not support Parcel's targets, which will likely result in unnecessary transpilation and larger bundle sizes.",
+      codeFrames: [{
+        filePath: (_babelConfig$config2 = babelConfig.config) !== null && _babelConfig$config2 !== void 0 ? _babelConfig$config2 : babelConfig.babelrc,
+        codeHighlights: await getCodeHighlights(fs, (_babelConfig$config3 = babelConfig.config) !== null && _babelConfig$config3 !== void 0 ? _babelConfig$config3 : babelConfig.babelrc, new Set(['@babel/preset-env']))
+      }],
+      hints: [`Either remove __@babel/preset-env__ to use Parcel's builtin transpilation, or replace with __@parcel/babel-preset-env__`],
+      documentationURL: 'https://parceljs.org/languages/javascript/#custom-plugins'
+    });
+  }
+
+  if (diagnostics.length > 0) {
+    logger.warn(diagnostics);
+  }
+}
+
+async function getCodeHighlights(fs, filePath, redundantPresets) {
+  let ext = _path().default.extname(filePath);
+
+  if (ext !== '.js' && ext !== '.cjs' && ext !== '.mjs') {
+    let contents = await fs.readFile(filePath, 'utf8');
+
+    let json = _json().default.parse(contents);
+
+    let presets = json.presets || [];
+    let pointers = [];
+
+    for (let i = 0; i < presets.length; i++) {
+      if (Array.isArray(presets[i]) && redundantPresets.has(presets[i][0])) {
+        pointers.push({
+          type: 'value',
+          key: `/presets/${i}/0`
+        });
+      } else if (redundantPresets.has(presets[i])) {
+        pointers.push({
+          type: 'value',
+          key: `/presets/${i}`
+        });
+      }
+    }
+
+    if (pointers.length > 0) {
+      try {
+        return (0, _diagnostic().generateJSONCodeHighlights)(contents, pointers);
+      } catch {// TODO: support code highlights for json5 sources.
+        // Babel supports json5 syntax, but json-source-map does not.
+      }
+    }
+  }
+
+  return [{
+    start: {
+      line: 1,
+      column: 1
+    },
+    end: {
+      line: 1,
+      column: 1
+    }
+  }];
 }

package/lib/utils.js

@@ -4,7 +4,6 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.enginesToBabelTargets = enginesToBabelTargets;
-exports.getMinSemver = getMinSemver;
 
 function _assert() {
   const data = _interopRequireDefault(require("assert"));
@@ -56,9 +55,11 @@ function enginesToBabelTargets(env) {
     if (engineName === 'browsers') {
       targets[engineName] = engineValue;
     } else {
+      var _semver$minVersion;
+
       (0, _assert().default)(typeof engineValue === 'string');
       if (!_options().TargetNames.hasOwnProperty(engineName)) continue;
-      let minVersion = getMinSemver(engineValue);
+      let minVersion = (_semver$minVersion = _semver().default.minVersion(engineValue)) === null || _semver$minVersion === void 0 ? void 0 : _semver$minVersion.toString();
       targets[engineName] = minVersion !== null && minVersion !== void 0 ? minVersion : engineValue;
     }
   }
@@ -77,16 +78,4 @@ function enginesToBabelTargets(env) {
   }
 
   return targets;
-} // TODO: Replace with `minVersion` (https://github.com/npm/node-semver#ranges-1)
-//       once semver has been upgraded across Parcel.
-
-
-function getMinSemver(version) {
-  try {
-    let range = new (_semver().default.Range)(version);
-    let sorted = range.set.sort((a, b) => a[0].semver.compare(b[0].semver));
-    return sorted[0][0].semver.version;
-  } catch (err) {
-    return null;
-  }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parcel/transformer-babel",
-  "version": "2.0.0-rc.0",
+  "version": "2.1.1",
   "license": "MIT",
   "publishConfig": {
     "access": "public"
@@ -17,7 +17,7 @@
   "source": "src/BabelTransformer.js",
   "engines": {
     "node": ">= 12.0.0",
-    "parcel": "^2.0.0-beta.1"
+    "parcel": "^2.1.1"
   },
   "dependencies": {
     "@babel/core": "^7.12.0",
@@ -25,19 +25,21 @@
     "@babel/helper-compilation-targets": "^7.8.4",
     "@babel/plugin-transform-flow-strip-types": "^7.0.0",
     "@babel/traverse": "^7.0.0",
-    "@parcel/babel-ast-utils": "2.0.0-rc.0",
-    "@parcel/plugin": "2.0.0-rc.0",
-    "@parcel/source-map": "2.0.0-rc.6",
-    "@parcel/utils": "2.0.0-rc.0",
+    "@parcel/babel-ast-utils": "^2.1.1",
+    "@parcel/diagnostic": "^2.1.1",
+    "@parcel/plugin": "^2.1.1",
+    "@parcel/source-map": "^2.0.0",
+    "@parcel/utils": "^2.1.1",
     "browserslist": "^4.6.6",
     "core-js": "^3.2.1",
+    "json5": "^2.1.0",
     "nullthrows": "^1.1.1",
     "semver": "^5.7.0"
   },
   "devDependencies": {
     "@babel/core": "^7.12.0",
     "@babel/preset-env": "^7.0.0",
-    "@parcel/types": "2.0.0-rc.0"
+    "@parcel/types": "^2.1.1"
   },
-  "gitHead": "8fc248f1f8eeb4428f7abd768bd23111451b1903"
+  "gitHead": "f53ffe772a8259d94ca2937d02fde149454112f3"
 }

package/src/config.js

@@ -2,11 +2,14 @@
 
 import type {Config, PluginOptions, PluginLogger} from '@parcel/types';
 import typeof * as BabelCore from '@babel/core';
+import type {Diagnostic} from '@parcel/diagnostic';
 import type {BabelConfig} from './types';
 
+import json5 from 'json5';
 import path from 'path';
 import * as internalBabelCore from '@babel/core';
 import {hashObject, relativePath, resolveConfig} from '@parcel/utils';
+import {md, generateJSONCodeHighlights} from '@parcel/diagnostic';
 
 import isJSX from './jsx';
 import getFlowOptions from './flow';
@@ -107,10 +110,9 @@ export async function load(
       // We need to invalidate on startup in case the config is non-static,
       // e.g. uses unknown environment variables, reads from the filesystem, etc.
       logger.warn({
-        message: `It looks like you're using a JavaScript Babel config file. This means the config cannot be watched for changes, and Babel transformations cannot be cached. You'll need to restart Parcel for changes to this config to take effect. Try using a ${path.basename(
-          file,
-          path.extname(file),
-        ) + '.json'} file instead.`,
+        message: `It looks like you're using a JavaScript Babel config file. This means the config cannot be watched for changes, and Babel transformations cannot be cached. You'll need to restart Parcel for changes to this config to take effect. Try using a ${
+          path.basename(file, path.extname(file)) + '.json'
+        } file instead.`,
       });
       config.invalidateOnStartup();
 
@@ -195,6 +197,7 @@ export async function load(
       config.setCacheKey(JSON.stringify(Date.now()));
       config.invalidateOnStartup();
     } else {
+      await warnOnRedundantPlugins(options.inputFS, partialConfig, logger);
       definePluginDependencies(config, partialConfig.options, options);
       config.setCacheKey(hashObject(partialConfig.options));
     }
@@ -285,3 +288,147 @@ function definePluginDependencies(config, babelConfig: ?BabelConfig, options) {
     });
   }
 }
+
+const redundantPresets = new Set([
+  '@babel/preset-env',
+  '@babel/preset-react',
+  '@babel/preset-typescript',
+  '@parcel/babel-preset-env',
+]);
+
+async function warnOnRedundantPlugins(fs, babelConfig, logger) {
+  if (babelConfig == null) {
+    return;
+  }
+
+  let configPath = babelConfig.config ?? babelConfig.babelrc;
+  if (!configPath) {
+    return;
+  }
+
+  let presets = babelConfig.options.presets || [];
+  let plugins = babelConfig.options.plugins || [];
+  let foundRedundantPresets = new Set();
+
+  let filteredPresets = presets.filter(preset => {
+    if (redundantPresets.has(preset.file.request)) {
+      foundRedundantPresets.add(preset.file.request);
+      return false;
+    }
+
+    return true;
+  });
+
+  let filePath = path.relative(process.cwd(), configPath);
+  let diagnostics: Array<Diagnostic> = [];
+
+  if (
+    filteredPresets.length === 0 &&
+    foundRedundantPresets.size > 0 &&
+    plugins.length === 0
+  ) {
+    diagnostics.push({
+      message: md`Parcel includes transpilation by default. Babel config __${filePath}__ contains only redundant presets. Deleting it may significantly improve build performance.`,
+      codeFrames: [
+        {
+          filePath: configPath,
+          codeHighlights: await getCodeHighlights(
+            fs,
+            configPath,
+            foundRedundantPresets,
+          ),
+        },
+      ],
+      hints: [md`Delete __${filePath}__`],
+      documentationURL:
+        'https://parceljs.org/languages/javascript/#default-presets',
+    });
+  } else if (foundRedundantPresets.size > 0) {
+    diagnostics.push({
+      message: md`Parcel includes transpilation by default. Babel config __${filePath}__ includes the following redundant presets: ${[
+        ...foundRedundantPresets,
+      ].map(p =>
+        md.underline(p),
+      )}. Removing these may improve build performance.`,
+      codeFrames: [
+        {
+          filePath: configPath,
+          codeHighlights: await getCodeHighlights(
+            fs,
+            configPath,
+            foundRedundantPresets,
+          ),
+        },
+      ],
+      hints: [md`Remove the above presets from __${filePath}__`],
+      documentationURL:
+        'https://parceljs.org/languages/javascript/#default-presets',
+    });
+  }
+
+  if (foundRedundantPresets.has('@babel/preset-env')) {
+    diagnostics.push({
+      message:
+        "@babel/preset-env does not support Parcel's targets, which will likely result in unnecessary transpilation and larger bundle sizes.",
+      codeFrames: [
+        {
+          filePath: babelConfig.config ?? babelConfig.babelrc,
+          codeHighlights: await getCodeHighlights(
+            fs,
+            babelConfig.config ?? babelConfig.babelrc,
+            new Set(['@babel/preset-env']),
+          ),
+        },
+      ],
+      hints: [
+        `Either remove __@babel/preset-env__ to use Parcel's builtin transpilation, or replace with __@parcel/babel-preset-env__`,
+      ],
+      documentationURL:
+        'https://parceljs.org/languages/javascript/#custom-plugins',
+    });
+  }
+
+  if (diagnostics.length > 0) {
+    logger.warn(diagnostics);
+  }
+}
+
+async function getCodeHighlights(fs, filePath, redundantPresets) {
+  let ext = path.extname(filePath);
+  if (ext !== '.js' && ext !== '.cjs' && ext !== '.mjs') {
+    let contents = await fs.readFile(filePath, 'utf8');
+    let json = json5.parse(contents);
+
+    let presets = json.presets || [];
+    let pointers = [];
+    for (let i = 0; i < presets.length; i++) {
+      if (Array.isArray(presets[i]) && redundantPresets.has(presets[i][0])) {
+        pointers.push({type: 'value', key: `/presets/${i}/0`});
+      } else if (redundantPresets.has(presets[i])) {
+        pointers.push({type: 'value', key: `/presets/${i}`});
+      }
+    }
+
+    if (pointers.length > 0) {
+      try {
+        return generateJSONCodeHighlights(contents, pointers);
+      } catch {
+        // TODO: support code highlights for json5 sources.
+        // Babel supports json5 syntax, but json-source-map does not.
+      }
+    }
+  }
+
+  return [
+    {
+      start: {
+        line: 1,
+        column: 1,
+      },
+      end: {
+        line: 1,
+        column: 1,
+      },
+    },
+  ];
+}

package/src/utils.js

@@ -47,7 +47,7 @@ export function enginesToBabelTargets(env: Environment): BabelTargets {
     } else {
       invariant(typeof engineValue === 'string');
       if (!TargetNames.hasOwnProperty(engineName)) continue;
-      let minVersion = getMinSemver(engineValue);
+      let minVersion = semver.minVersion(engineValue)?.toString();
       targets[engineName] = minVersion ?? engineValue;
     }
   }
@@ -69,15 +69,3 @@ export function enginesToBabelTargets(env: Environment): BabelTargets {
 
   return targets;
 }
-
-// TODO: Replace with `minVersion` (https://github.com/npm/node-semver#ranges-1)
-//       once semver has been upgraded across Parcel.
-export function getMinSemver(version: string): ?string {
-  try {
-    let range = new semver.Range(version);
-    let sorted = range.set.sort((a, b) => a[0].semver.compare(b[0].semver));
-    return sorted[0][0].semver.version;
-  } catch (err) {
-    return null;
-  }
-}