@parcel/graph 2.7.1-nightly.2802 → 2.7.1-nightly.2808

package/lib/Graph.js

@@ -125,7 +125,7 @@ class Graph {
       type,
       from
     } of this.adjacencyList.getInboundEdgesByType(nodeId)) {
-      this.removeEdge(from, nodeId, type, // Do not allow orphans to be removed as this node could be one
+      this._removeEdge(from, nodeId, type, // Do not allow orphans to be removed as this node could be one
       // and is already being removed.
       false);
     }
@@ -134,7 +134,7 @@ class Graph {
       type,
       to
     } of this.adjacencyList.getOutboundEdgesByType(nodeId)) {
-      this.removeEdge(nodeId, to, type);
+      this._removeEdge(nodeId, to, type);
     }
 
     let wasRemoved = this.nodes.delete(nodeId);
@@ -147,12 +147,20 @@ class Graph {
     }
 
     for (let to of this.getNodeIdsConnectedFrom(nodeId, type)) {
-      this.removeEdge(nodeId, to, type);
+      this._removeEdge(nodeId, to, type);
     }
+  }
+
+  removeEdge(from, to, type = 1, removeOrphans = true) {
+    if (!this.adjacencyList.hasEdge(from, to, type)) {
+      throw new Error(`Edge from ${(0, _types.fromNodeId)(from)} to ${(0, _types.fromNodeId)(to)} not found!`);
+    }
+
+    this._removeEdge(from, to, type, removeOrphans);
   } // Removes edge and node the edge is to if the node is orphaned
 
 
-  removeEdge(from, to, type = 1, removeOrphans = true) {
+  _removeEdge(from, to, type = 1, removeOrphans = true) {
     if (!this.adjacencyList.hasEdge(from, to, type)) {
       return;
     }
@@ -215,7 +223,7 @@ class Graph {
     }
 
     for (let child of childrenToRemove) {
-      this.removeEdge(fromNodeId, child, type);
+      this._removeEdge(fromNodeId, child, type);
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parcel/graph",
-  "version": "2.7.1-nightly.2802+4ba031aa4",
+  "version": "2.7.1-nightly.2808+96d8f285b",
   "description": "Blazing fast, zero configuration web application bundler",
   "license": "MIT",
   "publishConfig": {
@@ -20,8 +20,8 @@
     "node": ">= 12.0.0"
   },
   "dependencies": {
-    "@parcel/utils": "2.0.0-nightly.1179+4ba031aa4",
+    "@parcel/utils": "2.0.0-nightly.1185+96d8f285b",
     "nullthrows": "^1.1.1"
   },
-  "gitHead": "4ba031aa44d14b48e97d8172daeae8c24a423294"
+  "gitHead": "96d8f285ba530fab67662ceaf06684d8da3e242a"
 }

package/src/Graph.js

@@ -142,7 +142,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
     }
 
     for (let {type, from} of this.adjacencyList.getInboundEdgesByType(nodeId)) {
-      this.removeEdge(
+      this._removeEdge(
         from,
         nodeId,
         type,
@@ -153,7 +153,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
     }
 
     for (let {type, to} of this.adjacencyList.getOutboundEdgesByType(nodeId)) {
-      this.removeEdge(nodeId, to, type);
+      this._removeEdge(nodeId, to, type);
     }
 
     let wasRemoved = this.nodes.delete(nodeId);
@@ -166,16 +166,31 @@ export default class Graph<TNode, TEdgeType: number = 1> {
     }
 
     for (let to of this.getNodeIdsConnectedFrom(nodeId, type)) {
-      this.removeEdge(nodeId, to, type);
+      this._removeEdge(nodeId, to, type);
     }
   }
 
-  // Removes edge and node the edge is to if the node is orphaned
   removeEdge(
     from: NodeId,
     to: NodeId,
     type: TEdgeType | NullEdgeType = 1,
     removeOrphans: boolean = true,
+  ) {
+    if (!this.adjacencyList.hasEdge(from, to, type)) {
+      throw new Error(
+        `Edge from ${fromNodeId(from)} to ${fromNodeId(to)} not found!`,
+      );
+    }
+
+    this._removeEdge(from, to, type, removeOrphans);
+  }
+
+  // Removes edge and node the edge is to if the node is orphaned
+  _removeEdge(
+    from: NodeId,
+    to: NodeId,
+    type: TEdgeType | NullEdgeType = 1,
+    removeOrphans: boolean = true,
   ) {
     if (!this.adjacencyList.hasEdge(from, to, type)) {
       return;
@@ -249,7 +264,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
     }
 
     for (let child of childrenToRemove) {
-      this.removeEdge(fromNodeId, child, type);
+      this._removeEdge(fromNodeId, child, type);
     }
   }
 

package/test/Graph.test.js

@@ -89,6 +89,16 @@ describe('Graph', () => {
     assert(!graph.isOrphanedNode(nodeC));
   });
 
+  it("removeEdge should throw if the edge doesn't exist", () => {
+    let graph = new Graph();
+    let nodeA = graph.addNode('a');
+    let nodeB = graph.addNode('b');
+
+    assert.throws(() => {
+      graph.removeEdge(nodeA, nodeB);
+    }, /Edge from 0 to 1 not found!/);
+  });
+
   it('removeEdge should prune the graph at that edge', () => {
     //         a
     //        / \