@parcel/graph 2.5.1-nightly.2705 → 2.5.1-nightly.2708

package/lib/AdjacencyList.js

@@ -214,7 +214,7 @@ class AdjacencyList {
 
 
   addEdge(from, to, type = 1) {
-    (0, _assert().default)(type > 0, `Unsupported edge type ${0}`);
+    (0, _assert().default)(type > 0, `Unsupported edge type ${type}`);
     let hash = this.#edges.hash(from, to, type);
     let edge = this.#edges.addressOf(hash, from, to, type); // The edge is already in the graph; do nothing.
 
@@ -378,6 +378,7 @@ class AdjacencyList {
     let matches = node => type === _Graph.ALL_EDGE_TYPES || (Array.isArray(type) ? type.includes(this.#nodes.typeOf(node)) : type === this.#nodes.typeOf(node));
 
     let nodes = [];
+    let seen = new Set();
     let node = this.#nodes.head(from);
 
     while (node !== null) {
@@ -385,7 +386,13 @@ class AdjacencyList {
         let edge = this.#nodes.firstOut(node);
 
         while (edge !== null) {
-          nodes.push(this.#edges.to(edge));
+          let to = this.#edges.to(edge);
+
+          if (!seen.has(to)) {
+            nodes.push(to);
+            seen.add(to);
+          }
+
           edge = this.#edges.nextOut(edge);
         }
       }
@@ -404,6 +411,7 @@ class AdjacencyList {
     let matches = node => type === _Graph.ALL_EDGE_TYPES || (Array.isArray(type) ? type.includes(this.#nodes.typeOf(node)) : type === this.#nodes.typeOf(node));
 
     let nodes = [];
+    let seen = new Set();
     let node = this.#nodes.head(to);
 
     while (node !== null) {
@@ -411,7 +419,13 @@ class AdjacencyList {
         let edge = this.#nodes.firstIn(node);
 
         while (edge !== null) {
-          nodes.push(this.#edges.from(edge));
+          let from = this.#edges.from(edge);
+
+          if (!seen.has(from)) {
+            nodes.push(from);
+            seen.add(from);
+          }
+
           edge = this.#edges.nextIn(edge);
         }
       }
@@ -539,7 +553,7 @@ class SharedTypeMap {
 
   get bufferSize() {
     return `${(this.data.byteLength / 1024 / 1024).toLocaleString(undefined, {
-      minmumFractionDigits: 2,
+      minimumFractionDigits: 2,
       maximumFractionDigits: 2
     })} mb`;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parcel/graph",
-  "version": "2.5.1-nightly.2705+9556a2291",
+  "version": "2.5.1-nightly.2708+504e54651",
   "description": "Blazing fast, zero configuration web application bundler",
   "license": "MIT",
   "publishConfig": {
@@ -20,8 +20,8 @@
     "node": ">= 12.0.0"
   },
   "dependencies": {
-    "@parcel/utils": "2.0.0-nightly.1082+9556a2291",
+    "@parcel/utils": "2.0.0-nightly.1085+504e54651",
     "nullthrows": "^1.1.1"
   },
-  "gitHead": "9556a229186b0120cf588d2205021094aa887c89"
+  "gitHead": "504e54651a06993707d230941d46c702be60edc4"
 }

package/src/AdjacencyList.js

@@ -246,7 +246,7 @@ export default class AdjacencyList<TEdgeType: number = 1> {
     to: NodeId,
     type: TEdgeType | NullEdgeType = 1,
   ): boolean {
-    assert(type > 0, `Unsupported edge type ${0}`);
+    assert(type > 0, `Unsupported edge type ${type}`);
 
     let hash = this.#edges.hash(from, to, type);
     let edge = this.#edges.addressOf(hash, from, to, type);
@@ -439,14 +439,18 @@ export default class AdjacencyList<TEdgeType: number = 1> {
       (Array.isArray(type)
         ? type.includes(this.#nodes.typeOf(node))
         : type === this.#nodes.typeOf(node));
-
     let nodes = [];
+    let seen = new Set<NodeId>();
     let node = this.#nodes.head(from);
     while (node !== null) {
       if (matches(node)) {
         let edge = this.#nodes.firstOut(node);
         while (edge !== null) {
-          nodes.push(this.#edges.to(edge));
+          let to = this.#edges.to(edge);
+          if (!seen.has(to)) {
+            nodes.push(to);
+            seen.add(to);
+          }
           edge = this.#edges.nextOut(edge);
         }
       }
@@ -473,12 +477,17 @@ export default class AdjacencyList<TEdgeType: number = 1> {
         : type === this.#nodes.typeOf(node));
 
     let nodes = [];
+    let seen = new Set<NodeId>();
     let node = this.#nodes.head(to);
     while (node !== null) {
       if (matches(node)) {
         let edge = this.#nodes.firstIn(node);
         while (edge !== null) {
-          nodes.push(this.#edges.from(edge));
+          let from = this.#edges.from(edge);
+          if (!seen.has(from)) {
+            nodes.push(from);
+            seen.add(from);
+          }
           edge = this.#edges.nextIn(edge);
         }
       }
@@ -600,7 +609,7 @@ export class SharedTypeMap<TItemType, THash, TAddress: number>
 
   get bufferSize(): string {
     return `${(this.data.byteLength / 1024 / 1024).toLocaleString(undefined, {
-      minmumFractionDigits: 2,
+      minimumFractionDigits: 2,
       maximumFractionDigits: 2,
     })} mb`;
   }

package/test/AdjacencyList.test.js

@@ -57,6 +57,18 @@ describe('AdjacencyList', () => {
     assert.deepEqual(graph.getNodeIdsConnectedTo(node1), [0, 2, 4, 5, 6]);
   });
 
+  it('getNodeIdsConnectedTo and getNodeIdsConnectedFrom should remove duplicate values', () => {
+    let graph = new AdjacencyList();
+    let a = graph.addNode();
+    let b = graph.addNode();
+    let c = graph.addNode();
+    graph.addEdge(a, b);
+    graph.addEdge(a, c);
+    graph.addEdge(a, b, 2);
+    assert.deepEqual(graph.getNodeIdsConnectedFrom(a, -1), [b, c]);
+    assert.deepEqual(graph.getNodeIdsConnectedTo(b, -1), [a]);
+  });
+
   it('removeEdge should remove an edge of a specific type from the graph', () => {
     let graph = new AdjacencyList();
     let a = graph.addNode();