@parcel/events 2.0.0-beta.3 → 2.0.0-dev.1510

package/lib/Disposable.js

@@ -4,84 +4,44 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
 function _assert() {
   const data = _interopRequireDefault(require("assert"));
-
   _assert = function () {
     return data;
   };
-
   return data;
 }
-
-function _errors() {
-  const data = require("./errors");
-
-  _errors = function () {
-    return data;
-  };
-
-  return data;
-}
-
+var _errors = require("./errors");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
-
-function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
-
-function _classPrivateFieldGet(receiver, privateMap) { var descriptor = _classExtractFieldDescriptor(receiver, privateMap, "get"); return _classApplyDescriptorGet(receiver, descriptor); }
-
-function _classApplyDescriptorGet(receiver, descriptor) { if (descriptor.get) { return descriptor.get.call(receiver); } return descriptor.value; }
-
-function _classPrivateFieldSet(receiver, privateMap, value) { var descriptor = _classExtractFieldDescriptor(receiver, privateMap, "set"); _classApplyDescriptorSet(receiver, descriptor, value); return value; }
-
-function _classExtractFieldDescriptor(receiver, privateMap, action) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to " + action + " private field on non-instance"); } return privateMap.get(receiver); }
-
-function _classApplyDescriptorSet(receiver, descriptor, value) { if (descriptor.set) { descriptor.set.call(receiver, value); } else { if (!descriptor.writable) { throw new TypeError("attempted to set read only private field"); } descriptor.value = value; } }
-
-var _disposables = new WeakMap();
-
 /*
  * A general-purpose disposable class. It can normalize disposable-like values
  * (such as single functions or IDisposables), as well as hold multiple
  * disposable-like values to be disposed of at once.
  */
 class Disposable {
-  constructor(...disposables) {
-    _defineProperty(this, "disposed", false);
-
-    _disposables.set(this, {
-      writable: true,
-      value: void 0
-    });
+  disposed = false;
+  #disposables /*: ?Set<DisposableLike> */;
 
-    _classPrivateFieldSet(this, _disposables, new Set(disposables));
+  constructor(...disposables) {
+    this.#disposables = new Set(disposables);
   }
-
   add(...disposables) {
     if (this.disposed) {
-      throw new (_errors().AlreadyDisposedError)('Cannot add new disposables after disposable has been disposed');
+      throw new _errors.AlreadyDisposedError('Cannot add new disposables after disposable has been disposed');
     }
-
-    (0, _assert().default)(_classPrivateFieldGet(this, _disposables) != null);
-
+    (0, _assert().default)(this.#disposables != null);
     for (let disposable of disposables) {
-      _classPrivateFieldGet(this, _disposables).add(disposable);
+      this.#disposables.add(disposable);
     }
   }
-
   async dispose() {
     if (this.disposed) {
       return;
     }
-
     this.disposed = true;
-    (0, _assert().default)(_classPrivateFieldGet(this, _disposables) != null);
-    await Promise.all([..._classPrivateFieldGet(this, _disposables)].map(disposable => typeof disposable === 'function' ? disposable() : disposable.dispose()));
-
-    _classPrivateFieldSet(this, _disposables, null);
+    (0, _assert().default)(this.#disposables != null);
+    await Promise.all([...this.#disposables].map(disposable => typeof disposable === 'function' ? disposable() : disposable.dispose()));
+    this.#disposables = null;
   }
-
 }
-
 exports.default = Disposable;

package/lib/ValueEmitter.js

@@ -4,93 +4,68 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
-
-function _errors() {
-  const data = require("./errors");
-
-  _errors = function () {
-    return data;
-  };
-
-  return data;
-}
-
-function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
-
+var _errors = require("./errors");
 // Like an EventEmitter, but for only a single "event". This provides type-safety
 // for the values emitted. Rather than passing predetermined strings (which can
 // be misspelled), create an instance of ValueEmitter for every logical "event"
 // to be dispatched, and type it according to the type of value emitted.
 class ValueEmitter {
-  constructor() {
-    _defineProperty(this, "_listeners", []);
-
-    _defineProperty(this, "_disposed", false);
-  }
-
+  // An array of listeners. One might think a Set would be better for O(1) removal,
+  // but splicing a JS array gets pretty close, and copying the array (as is done
+  // in emit) is far faster than a Set copy: https://github.com/atom/event-kit/pull/39
+  _listeners = [];
+  _disposed = false;
   addListener(listener) {
     if (this._disposed) {
-      throw new (_errors().AlreadyDisposedError)('Cannot add a listener since this ValueEmitter has been disposed');
+      throw new _errors.AlreadyDisposedError('Cannot add a listener since this ValueEmitter has been disposed');
     }
+    this._listeners.push(listener);
 
-    this._listeners.push(listener); // Close over a reference to this emitter in the disposable below, rather
+    // Close over a reference to this emitter in the disposable below, rather
     // than referencing `this` directly. This allows us to set it to null after
     // slicing out the listener.
     // This prevents anyone holding onto the disposable after disposal from
     // unintentionally retaining a reference to this emitter.
-
-
     let emitter = this;
     return {
       dispose() {
         if (emitter == null) {
           return;
         }
-
         if (emitter._disposed) {
           emitter = null;
           return;
         }
-
         let listeners = emitter._listeners;
         let listenerIndex = listeners.indexOf(listener);
-
         if (listenerIndex > -1) {
           listeners.splice(listenerIndex, 1);
         }
-
         emitter = null;
       }
-
     };
   }
-
   emit(value) {
     if (this._disposed) {
-      throw new (_errors().AlreadyDisposedError)('Cannot emit since this ValueEmitter has been disposed');
-    } // Iterate over a copy of listeners. This prevents the following cases:
+      throw new _errors.AlreadyDisposedError('Cannot emit since this ValueEmitter has been disposed');
+    }
+
+    // Iterate over a copy of listeners. This prevents the following cases:
     // * When a listener callback can itself register a new listener and be
     //   emitted as part of this iteration.
     // * When a listener callback disposes of this emitter mid-emit, preventing
     //   other listeners from receiving the event.
-
-
     let listeners = this._listeners.slice();
-
     for (let i = 0; i < listeners.length; i++) {
       listeners[i](value);
     }
   }
-
   dispose() {
     if (this._disposed) {
       return;
     }
-
     this._listeners = [];
     this._disposed = true;
   }
-
 }
-
 exports.default = ValueEmitter;

package/lib/errors.js

@@ -4,9 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.AlreadyDisposedError = void 0;
-
 class AlreadyDisposedError extends Error {}
-
 exports.AlreadyDisposedError = AlreadyDisposedError;
 Object.defineProperty(AlreadyDisposedError.prototype, 'name', {
   value: 'AlreadyDisposedError'

package/lib/index.js

@@ -3,53 +3,25 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-Object.defineProperty(exports, "Disposable", {
+Object.defineProperty(exports, "AlreadyDisposedError", {
   enumerable: true,
   get: function () {
-    return _Disposable().default;
+    return _errors.AlreadyDisposedError;
   }
 });
-Object.defineProperty(exports, "ValueEmitter", {
+Object.defineProperty(exports, "Disposable", {
   enumerable: true,
   get: function () {
-    return _ValueEmitter().default;
+    return _Disposable.default;
   }
 });
-Object.defineProperty(exports, "AlreadyDisposedError", {
+Object.defineProperty(exports, "ValueEmitter", {
   enumerable: true,
   get: function () {
-    return _errors().AlreadyDisposedError;
+    return _ValueEmitter.default;
   }
 });
-
-function _Disposable() {
-  const data = _interopRequireDefault(require("./Disposable"));
-
-  _Disposable = function () {
-    return data;
-  };
-
-  return data;
-}
-
-function _ValueEmitter() {
-  const data = _interopRequireDefault(require("./ValueEmitter"));
-
-  _ValueEmitter = function () {
-    return data;
-  };
-
-  return data;
-}
-
-function _errors() {
-  const data = require("./errors");
-
-  _errors = function () {
-    return data;
-  };
-
-  return data;
-}
-
+var _Disposable = _interopRequireDefault(require("./Disposable"));
+var _ValueEmitter = _interopRequireDefault(require("./ValueEmitter"));
+var _errors = require("./errors");
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parcel/events",
-  "version": "2.0.0-beta.3",
+  "version": "2.0.0-dev.1510+a9bb85adf",
   "license": "MIT",
   "publishConfig": {
     "access": "public"
@@ -18,5 +18,5 @@
   "engines": {
     "node": ">= 12.0.0"
   },
-  "gitHead": "bf03f018093f8c7ca4c3a544524e15065a637b3b"
+  "gitHead": "a9bb85adf8f3b38631e178b3aacaa30c78696e36"
 }

package/src/types.js

@@ -1,7 +1,8 @@
 // @flow strict-local
 
 export interface IDisposable {
-  // This can return a Promise, as dispose() of all inner disposables are
-  // awaited in Disposable#dispose()
+  /** This can return a Promise, as dispose() of all inner disposables are
+   * awaited in Disposable#dispose()
+   */
   dispose(): mixed;
 }