@parca/profile 0.16.343 → 0.16.344

package/CHANGELOG.md

@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.16.344](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.343...@parca/profile@0.16.344) (2024-02-21)
+
+**Note:** Version bump only for package @parca/profile
+
 ## [0.16.343](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.342...@parca/profile@0.16.343) (2024-02-20)
 
 **Note:** Version bump only for package @parca/profile

package/dist/MetricsGraph/index.d.ts

@@ -7,7 +7,7 @@ interface Props {
     from: number;
     to: number;
     profile: MergedProfileSelection | null;
-    onSampleClick: (timestamp: number, value: number, labels: Label[]) => void;
+    onSampleClick: (timestamp: number, value: number, labels: Label[], duration: number) => void;
     addLabelMatcher: (labels: {
         key: string;
         value: string;

package/dist/MetricsGraph/index.js

@@ -139,8 +139,8 @@ export const RawMetricsGraph = ({ data, from, to, profile, onSampleClick, addLab
     };
     const openClosestProfile = () => {
         if (highlighted != null) {
-            onSampleClick(Math.round(highlighted.timestamp), highlighted.value, sanitizeHighlightedValues(highlighted.labels) // When a user clicks on any sample in the graph, replace single `\` in the `labelValues` string with doubles `\\` if available.
-            );
+            onSampleClick(Math.round(highlighted.timestamp), highlighted.value, sanitizeHighlightedValues(highlighted.labels), // When a user clicks on any sample in the graph, replace single `\` in the `labelValues` string with doubles `\\` if available.
+            highlighted.duration);
         }
     };
     const onMouseUp = (e) => {

package/dist/ProfileMetricsGraph/index.d.ts

@@ -21,7 +21,7 @@ interface ProfileMetricsGraphProps {
         key: string;
         value: string;
     }>) => void;
-    onPointClick: (timestamp: number, labels: Label[], queryExpression: string) => void;
+    onPointClick: (timestamp: number, labels: Label[], queryExpression: string, duration: number) => void;
     comparing?: boolean;
 }
 export interface IQueryRangeState {

package/dist/ProfileMetricsGraph/index.js

@@ -88,8 +88,8 @@ const ProfileMetricsGraph = ({ queryClient, queryExpression, profile, from, to,
         return _jsx(ErrorContent, { errorMessage: capitalizeOnlyFirstLetter(error.message) });
     }
     if (dataAvailable) {
-        const handleSampleClick = (timestamp, _value, labels) => {
-            onPointClick(timestamp, labels, queryExpression);
+        const handleSampleClick = (timestamp, _value, labels, duration) => {
+            onPointClick(timestamp, labels, queryExpression, duration);
         };
         let sampleUnit = '';
         if (series.every((val, i, arr) => val?.sampleType?.unit === arr[0]?.sampleType?.unit)) {

package/dist/ProfileSelector/index.js

@@ -15,7 +15,6 @@ import { useEffect, useState } from 'react';
 import { Button, ButtonGroup, DateTimeRange, DateTimeRangePicker, IconButton, useGrpcMetadata, useParcaContext, } from '@parca/components';
 import { CloseIcon } from '@parca/icons';
 import { Query } from '@parca/parser';
-import { getStepDuration, getStepDurationInMilliseconds } from '@parca/utilities';
 import { MergedProfileSelection } from '..';
 import MatchersInput from '../MatchersInput/index';
 import { useMetricsGraphDimensions } from '../MetricsGraph/useMetricsGraphDimensions';
@@ -177,7 +176,7 @@ const ProfileSelector = ({ queryClient, querySelection, selectProfile, selectQue
                                     timeSelection: range.getRangeKey(),
                                     ...mergedProfileParams,
                                 });
-                            }, addLabelMatcher: addLabelMatcher, onPointClick: (timestamp, labels, queryExpression) => {
+                            }, addLabelMatcher: addLabelMatcher, onPointClick: (timestamp, labels, queryExpression, duration) => {
                                 // TODO: Pass the query object via click rather than queryExpression
                                 let query = Query.parse(queryExpression);
                                 labels.forEach(l => {
@@ -186,11 +185,10 @@ const ProfileSelector = ({ queryClient, querySelection, selectProfile, selectQue
                                         query = newQuery;
                                     }
                                 });
-                                const stepDuration = getStepDuration(querySelection.from, querySelection.to);
-                                const stepDurationInMilliseconds = getStepDurationInMilliseconds(stepDuration);
+                                const durationInMilliseconds = duration / 1000000; // duration is in nanoseconds
                                 const mergeFrom = timestamp;
                                 const mergeTo = query.profileType().delta
-                                    ? mergeFrom + stepDurationInMilliseconds
+                                    ? mergeFrom + durationInMilliseconds
                                     : mergeFrom;
                                 selectProfile(new MergedProfileSelection(mergeFrom, mergeTo, query));
                             } }) })) : (_jsx(_Fragment, { children: profileSelection == null ? (_jsx("div", { className: "p-2", children: _jsx(ProfileMetricsEmptyState, { message: `Please select a profile type and click "Search" to begin.` }) })) : null })) }) })] }));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parca/profile",
-  "version": "0.16.343",
+  "version": "0.16.344",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@parca/client": "^0.16.103",
@@ -51,5 +51,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "c5b8204dc83fb3f120c2536fa15de23171cb04b9"
+  "gitHead": "419fad9b80e702bafd775521f69a812bc5e81124"
 }

package/src/MetricsGraph/index.tsx

@@ -40,7 +40,7 @@ interface Props {
   from: number;
   to: number;
   profile: MergedProfileSelection | null;
-  onSampleClick: (timestamp: number, value: number, labels: Label[]) => void;
+  onSampleClick: (timestamp: number, value: number, labels: Label[], duration: number) => void;
   addLabelMatcher: (
     labels: {key: string; value: string} | Array<{key: string; value: string}>
   ) => void;
@@ -260,7 +260,8 @@ export const RawMetricsGraph = ({
       onSampleClick(
         Math.round(highlighted.timestamp),
         highlighted.value,
-        sanitizeHighlightedValues(highlighted.labels) // When a user clicks on any sample in the graph, replace single `\` in the `labelValues` string with doubles `\\` if available.
+        sanitizeHighlightedValues(highlighted.labels), // When a user clicks on any sample in the graph, replace single `\` in the `labelValues` string with doubles `\\` if available.
+        highlighted.duration
       );
     }
   };

package/src/ProfileMetricsGraph/index.tsx

@@ -64,7 +64,12 @@ interface ProfileMetricsGraphProps {
   addLabelMatcher: (
     labels: {key: string; value: string} | Array<{key: string; value: string}>
   ) => void;
-  onPointClick: (timestamp: number, labels: Label[], queryExpression: string) => void;
+  onPointClick: (
+    timestamp: number,
+    labels: Label[],
+    queryExpression: string,
+    duration: number
+  ) => void;
   comparing?: boolean;
 }
 
@@ -168,8 +173,13 @@ const ProfileMetricsGraph = ({
   }
 
   if (dataAvailable) {
-    const handleSampleClick = (timestamp: number, _value: number, labels: Label[]): void => {
-      onPointClick(timestamp, labels, queryExpression);
+    const handleSampleClick = (
+      timestamp: number,
+      _value: number,
+      labels: Label[],
+      duration: number
+    ): void => {
+      onPointClick(timestamp, labels, queryExpression, duration);
     };
 
     let sampleUnit = '';

package/src/ProfileSelector/index.tsx

@@ -15,7 +15,7 @@ import React, {useEffect, useState} from 'react';
 
 import {RpcError} from '@protobuf-ts/runtime-rpc';
 
-import {ProfileTypesResponse, QueryServiceClient} from '@parca/client';
+import {Label, ProfileTypesResponse, QueryServiceClient} from '@parca/client';
 import {
   Button,
   ButtonGroup,
@@ -27,7 +27,6 @@ import {
 } from '@parca/components';
 import {CloseIcon} from '@parca/icons';
 import {Query} from '@parca/parser';
-import {getStepDuration, getStepDurationInMilliseconds} from '@parca/utilities';
 
 import {MergedProfileSelection, ProfileSelection} from '..';
 import MatchersInput from '../MatchersInput/index';
@@ -327,7 +326,12 @@ const ProfileSelector = ({
                   });
                 }}
                 addLabelMatcher={addLabelMatcher}
-                onPointClick={(timestamp, labels, queryExpression) => {
+                onPointClick={(
+                  timestamp: number,
+                  labels: Label[],
+                  queryExpression: string,
+                  duration: number
+                ) => {
                   // TODO: Pass the query object via click rather than queryExpression
                   let query = Query.parse(queryExpression);
                   labels.forEach(l => {
@@ -337,11 +341,10 @@ const ProfileSelector = ({
                     }
                   });
 
-                  const stepDuration = getStepDuration(querySelection.from, querySelection.to);
-                  const stepDurationInMilliseconds = getStepDurationInMilliseconds(stepDuration);
+                  const durationInMilliseconds = duration / 1000000; // duration is in nanoseconds
                   const mergeFrom = timestamp;
                   const mergeTo = query.profileType().delta
-                    ? mergeFrom + stepDurationInMilliseconds
+                    ? mergeFrom + durationInMilliseconds
                     : mergeFrom;
                   selectProfile(new MergedProfileSelection(mergeFrom, mergeTo, query));
                 }}