@parca/profile 0.16.304 → 0.16.305

package/CHANGELOG.md

@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## 0.16.305 (2023-11-15)
+
+**Note:** Version bump only for package @parca/profile
+
 ## [0.16.304](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.303...@parca/profile@0.16.304) (2023-11-09)
 
 **Note:** Version bump only for package @parca/profile

package/dist/GraphTooltipArrow/useGraphTooltip/index.js

@@ -14,7 +14,7 @@ import { divide, valueFormatter } from '@parca/utilities';
 import { FIELD_CUMULATIVE, FIELD_DIFF, FIELD_LOCATION_ADDRESS, } from '../../ProfileIcicleGraph/IcicleGraphArrow';
 import { getTextForCumulative, nodeLabel } from '../../ProfileIcicleGraph/IcicleGraphArrow/utils';
 export const useGraphTooltip = ({ table, unit, total, totalUnfiltered, row, level, }) => {
-    if (row === null) {
+    if (row === null || row === 0) {
         return null;
     }
     const locationAddress = table.getChild(FIELD_LOCATION_ADDRESS)?.get(row) ?? 0n;

package/dist/ProfileIcicleGraph/IcicleGraphArrow/IcicleGraphNodes.js

@@ -57,8 +57,8 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({ table, row, map
     // get the actual values from the columns
     const mappingFile = arrowToString(mappingColumn?.get(row));
     const functionName = arrowToString(functionNameColumn?.get(row));
-    const cumulative = BigInt(cumulativeColumn?.get(row));
-    const diff = BigInt(diffColumn?.get(row));
+    const cumulative = cumulativeColumn?.get(row) !== null ? BigInt(cumulativeColumn?.get(row)) : 0n;
+    const diff = diffColumn?.get(row) !== null ? BigInt(diffColumn?.get(row)) : null;
     const childRows = Array.from(table.getChild(FIELD_CHILDREN)?.get(row) ?? []);
     // TODO: Maybe it's better to pass down the sorter function as prop instead of figuring this out here.
     switch (sortBy) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parca/profile",
-  "version": "0.16.304",
+  "version": "0.16.305",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@parca/client": "^0.16.98",
@@ -50,5 +50,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "a342b32b3ed89bee6659d1f4fd073c6bcd52cb16"
+  "gitHead": "42d5b5da9506741c6fa60aa756e7b8279861a8a7"
 }

package/src/GraphTooltipArrow/useGraphTooltip/index.ts

@@ -48,7 +48,7 @@ export const useGraphTooltip = ({
   row,
   level,
 }: Props): GraphTooltipData | null => {
-  if (row === null) {
+  if (row === null || row === 0) {
     return null;
   }
 

package/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleGraphNodes.tsx

@@ -194,8 +194,8 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({
   // get the actual values from the columns
   const mappingFile: string | null = arrowToString(mappingColumn?.get(row));
   const functionName: string | null = arrowToString(functionNameColumn?.get(row));
-  const cumulative = BigInt(cumulativeColumn?.get(row));
-  const diff: bigint | null = BigInt(diffColumn?.get(row));
+  const cumulative = cumulativeColumn?.get(row) !== null ? BigInt(cumulativeColumn?.get(row)) : 0n;
+  const diff: bigint | null = diffColumn?.get(row) !== null ? BigInt(diffColumn?.get(row)) : null;
   const childRows: number[] = Array.from(table.getChild(FIELD_CHILDREN)?.get(row) ?? []);
 
   // TODO: Maybe it's better to pass down the sorter function as prop instead of figuring this out here.