@parca/profile 0.16.248 → 0.16.250

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.16.250](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.249...@parca/profile@0.16.250) (2023-09-07)
+
+**Note:** Version bump only for package @parca/profile
+
+## [0.16.249](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.248...@parca/profile@0.16.249) (2023-09-06)
+
+**Note:** Version bump only for package @parca/profile
+
 ## [0.16.248](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.247...@parca/profile@0.16.248) (2023-09-05)
 
 **Note:** Version bump only for package @parca/profile

package/dist/GraphTooltipArrow/Content.js

@@ -34,8 +34,8 @@ const GraphTooltipArrowContent = ({ table, unit, total, totalUnfiltered, row, le
         return _jsx(_Fragment, {});
     }
     const locationAddress = table.getChild(FIELD_LOCATION_ADDRESS)?.get(row) ?? 0n;
-    const cumulative = table.getChild(FIELD_CUMULATIVE)?.get(row) ?? 0n;
-    const diff = table.getChild(FIELD_DIFF)?.get(row) ?? 0n;
+    const cumulative = BigInt(table.getChild(FIELD_CUMULATIVE)?.get(row)) ?? 0n;
+    const diff = BigInt(table.getChild(FIELD_DIFF)?.get(row)) ?? 0n;
     const onCopy = () => {
         setIsCopied(true);
         if (timeoutHandle !== null) {

package/dist/ProfileIcicleGraph/IcicleGraphArrow/IcicleGraphNodes.js

@@ -32,8 +32,8 @@ export const IcicleGraphNodes = React.memo(function IcicleGraphNodesNoMemo({ tab
     let childrenCumulative = BigInt(0);
     const childrenElements = [];
     childRows.forEach((child, i) => {
-        const xStart = Math.floor(xScale(childrenCumulative));
-        const c = cumulatives?.get(child);
+        const xStart = Math.floor(xScale(BigInt(childrenCumulative)));
+        const c = BigInt(cumulatives?.get(child));
         childrenCumulative += c;
         childrenElements.push(_jsx(IcicleNode, { table: table, row: child, mappingColors: mappingColors, x: xStart, y: 0, totalWidth: totalWidth, height: RowHeight, path: path, setCurPath: setCurPath, setHoveringRow: setHoveringRow, setHoveringLevel: setHoveringLevel, level: level, curPath: curPath, total: total, xScale: xScale, sortBy: sortBy, searchString: searchString, darkMode: darkMode, compareMode: compareMode }, `node-${level}-${i}`));
     });
@@ -58,8 +58,8 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({ table, row, map
     // get the actual values from the columns
     const mappingFile = arrowToString(mappingColumn?.get(row));
     const functionName = arrowToString(functionNameColumn?.get(row));
-    const cumulative = cumulativeColumn?.get(row);
-    const diff = diffColumn?.get(row);
+    const cumulative = BigInt(cumulativeColumn?.get(row));
+    const diff = BigInt(diffColumn?.get(row));
     const childRows = Array.from(table.getChild(FIELD_CHILDREN)?.get(row) ?? []);
     // TODO: Maybe it's better to pass down the sorter function as prop instead of figuring this out here.
     switch (sortBy) {
@@ -125,11 +125,11 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({ table, row, map
     const nextLevel = level + 1;
     const nextCurPath = curPath.length === 0 ? [] : curPath.slice(1);
     const newXScale = nextCurPath.length === 0 && curPath.length === 1
-        ? scaleLinear([0n, cumulative], [0, totalWidth])
+        ? scaleLinear([0n, BigInt(cumulative)], [0, totalWidth])
         : xScale;
     const width = nextCurPath.length > 0 || (nextCurPath.length === 0 && curPath.length === 1)
         ? totalWidth
-        : xScale(cumulative);
+        : xScale(BigInt(cumulative));
     const { isHighlightEnabled = false, isHighlighted = false } = useMemo(() => {
         if (searchString === undefined || searchString === '') {
             return { isHighlightEnabled: false };

package/dist/Table/index.js

@@ -17,6 +17,13 @@ import { tableFromIPC } from 'apache-arrow';
 import { Button, Table as TableComponent, useURLState } from '@parca/components';
 import { getLastItem, isSearchMatch, parseParams, valueFormatter, } from '@parca/utilities';
 import { hexifyAddress } from '../utils';
+const FIELD_MAPPING_FILE = 'mapping_file';
+const FIELD_LOCATION_ADDRESS = 'location_address';
+const FIELD_FUNCTION_NAME = 'function_name';
+const FIELD_FLAT = 'flat';
+const FIELD_FLAT_DIFF = 'flat_diff';
+const FIELD_CUMULATIVE = 'cumulative';
+const FIELD_CUMULATIVE_DIFF = 'cumulative_diff';
 const columnHelper = createColumnHelper();
 export const Table = React.memo(function Table({ data, sampleUnit: unit, navigateTo, loading, currentSearchString, setActionButtons, }) {
     const router = parseParams(window?.location.search);
@@ -134,10 +141,10 @@ export const Table = React.memo(function Table({ data, sampleUnit: unit, navigat
     if (data === undefined)
         return _jsx("div", { className: "mx-auto text-center", children: "Profile has no samples" });
     const table = tableFromIPC(data);
-    const flatColumn = table.getChild('flat');
-    const flatDiffColumn = table.getChild('flat_diff');
-    const cumulativeColumn = table.getChild('cumulative');
-    const cumulativeDiffColumn = table.getChild('cumulative_diff');
+    const flatColumn = table.getChild(FIELD_FLAT);
+    const flatDiffColumn = table.getChild(FIELD_FLAT_DIFF);
+    const cumulativeColumn = table.getChild(FIELD_CUMULATIVE);
+    const cumulativeDiffColumn = table.getChild(FIELD_CUMULATIVE_DIFF);
     if (table.numRows === 0)
         return _jsx("div", { className: "mx-auto text-center", children: "Profile has no samples" });
     const rows = [];
@@ -164,7 +171,7 @@ const addPlusSign = (num) => {
     return `+${num}`;
 };
 export const RowName = (table, row) => {
-    const mappingFileColumn = table.getChild('mapping_file');
+    const mappingFileColumn = table.getChild(FIELD_MAPPING_FILE);
     if (mappingFileColumn === null) {
         console.error('mapping_file column not found');
         return '';
@@ -175,11 +182,11 @@ export const RowName = (table, row) => {
     if (mappingFile != null && mappingFileColumn.data.length > 1) {
         mapping = `[${getLastItem(mappingFile) ?? ''}]`;
     }
-    const functionName = table.getChild('function_name')?.get(row) ?? '';
+    const functionName = table.getChild(FIELD_FUNCTION_NAME)?.get(row) ?? '';
     if (functionName !== null && functionName !== '') {
         return `${mapping} ${functionName}`;
     }
-    const address = table.getChild('location_address')?.get(row) ?? 0;
+    const address = table.getChild(FIELD_LOCATION_ADDRESS)?.get(row) ?? 0;
     return hexifyAddress(address);
 };
 export default Table;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parca/profile",
-  "version": "0.16.248",
+  "version": "0.16.250",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@parca/client": "^0.16.86",
@@ -49,5 +49,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "4e814a1223712dee92ea404b87363eac778fa499"
+  "gitHead": "b13f14408040abd2230c059e8944fcbea6391704"
 }

package/src/GraphTooltipArrow/Content.tsx

@@ -74,8 +74,8 @@ const GraphTooltipArrowContent = ({
   }
 
   const locationAddress: bigint = table.getChild(FIELD_LOCATION_ADDRESS)?.get(row) ?? 0n;
-  const cumulative: bigint = table.getChild(FIELD_CUMULATIVE)?.get(row) ?? 0n;
-  const diff: bigint = table.getChild(FIELD_DIFF)?.get(row) ?? 0n;
+  const cumulative: bigint = BigInt(table.getChild(FIELD_CUMULATIVE)?.get(row)) ?? 0n;
+  const diff: bigint = BigInt(table.getChild(FIELD_DIFF)?.get(row)) ?? 0n;
 
   const onCopy = (): void => {
     setIsCopied(true);

package/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleGraphNodes.tsx

@@ -88,8 +88,8 @@ export const IcicleGraphNodes = React.memo(function IcicleGraphNodesNoMemo({
   let childrenCumulative = BigInt(0);
   const childrenElements: ReactNode[] = [];
   childRows.forEach((child, i) => {
-    const xStart = Math.floor(xScale(childrenCumulative));
-    const c: bigint = cumulatives?.get(child);
+    const xStart = Math.floor(xScale(BigInt(childrenCumulative)));
+    const c = BigInt(cumulatives?.get(child));
     childrenCumulative += c;
 
     childrenElements.push(
@@ -190,8 +190,8 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({
   // get the actual values from the columns
   const mappingFile: string | null = arrowToString(mappingColumn?.get(row));
   const functionName: string | null = arrowToString(functionNameColumn?.get(row));
-  const cumulative: bigint = cumulativeColumn?.get(row);
-  const diff: bigint | null = diffColumn?.get(row);
+  const cumulative = BigInt(cumulativeColumn?.get(row));
+  const diff: bigint | null = BigInt(diffColumn?.get(row));
   const childRows: number[] = Array.from(table.getChild(FIELD_CHILDREN)?.get(row) ?? []);
 
   // TODO: Maybe it's better to pass down the sorter function as prop instead of figuring this out here.
@@ -260,13 +260,13 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({
   const nextCurPath = curPath.length === 0 ? [] : curPath.slice(1);
   const newXScale =
     nextCurPath.length === 0 && curPath.length === 1
-      ? scaleLinear([0n, cumulative], [0, totalWidth])
+      ? scaleLinear([0n, BigInt(cumulative)], [0, totalWidth])
       : xScale;
 
   const width: number =
     nextCurPath.length > 0 || (nextCurPath.length === 0 && curPath.length === 1)
       ? totalWidth
-      : xScale(cumulative);
+      : xScale(BigInt(cumulative));
 
   const {isHighlightEnabled = false, isHighlighted = false} = useMemo(() => {
     if (searchString === undefined || searchString === '') {

package/src/Table/index.tsx

@@ -27,6 +27,14 @@ import {
 
 import {hexifyAddress} from '../utils';
 
+const FIELD_MAPPING_FILE = 'mapping_file';
+const FIELD_LOCATION_ADDRESS = 'location_address';
+const FIELD_FUNCTION_NAME = 'function_name';
+const FIELD_FLAT = 'flat';
+const FIELD_FLAT_DIFF = 'flat_diff';
+const FIELD_CUMULATIVE = 'cumulative';
+const FIELD_CUMULATIVE_DIFF = 'cumulative_diff';
+
 const columnHelper = createColumnHelper<row>();
 
 interface row {
@@ -211,10 +219,10 @@ export const Table = React.memo(function Table({
   if (data === undefined) return <div className="mx-auto text-center">Profile has no samples</div>;
 
   const table = tableFromIPC(data);
-  const flatColumn = table.getChild('flat');
-  const flatDiffColumn = table.getChild('flat_diff');
-  const cumulativeColumn = table.getChild('cumulative');
-  const cumulativeDiffColumn = table.getChild('cumulative_diff');
+  const flatColumn = table.getChild(FIELD_FLAT);
+  const flatDiffColumn = table.getChild(FIELD_FLAT_DIFF);
+  const cumulativeColumn = table.getChild(FIELD_CUMULATIVE);
+  const cumulativeDiffColumn = table.getChild(FIELD_CUMULATIVE_DIFF);
 
   if (table.numRows === 0) return <div className="mx-auto text-center">Profile has no samples</div>;
 
@@ -261,7 +269,7 @@ const addPlusSign = (num: string): string => {
 };
 
 export const RowName = (table: ArrowTable, row: number): string => {
-  const mappingFileColumn = table.getChild('mapping_file');
+  const mappingFileColumn = table.getChild(FIELD_MAPPING_FILE);
   if (mappingFileColumn === null) {
     console.error('mapping_file column not found');
     return '';
@@ -273,12 +281,12 @@ export const RowName = (table: ArrowTable, row: number): string => {
   if (mappingFile != null && mappingFileColumn.data.length > 1) {
     mapping = `[${getLastItem(mappingFile) ?? ''}]`;
   }
-  const functionName: string | null = table.getChild('function_name')?.get(row) ?? '';
+  const functionName: string | null = table.getChild(FIELD_FUNCTION_NAME)?.get(row) ?? '';
   if (functionName !== null && functionName !== '') {
     return `${mapping} ${functionName}`;
   }
 
-  const address: bigint = table.getChild('location_address')?.get(row) ?? 0;
+  const address: bigint = table.getChild(FIELD_LOCATION_ADDRESS)?.get(row) ?? 0;
 
   return hexifyAddress(address);
 };