@parca/profile 0.16.246 → 0.16.248

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.16.248](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.247...@parca/profile@0.16.248) (2023-09-05)
+
+**Note:** Version bump only for package @parca/profile
+
+## 0.16.247 (2023-09-05)
+
+**Note:** Version bump only for package @parca/profile
+
 ## [0.16.246](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.245...@parca/profile@0.16.246) (2023-09-04)
 
 ### Bug Fixes

package/dist/ProfileIcicleGraph/IcicleGraphArrow/utils.js

@@ -26,7 +26,7 @@ export function nodeLabel(table, row, level, showBinaryName) {
         return labelColumnNames
             .map((field, i) => [
             labelColumnNames[i].name.slice(pprofLabelPrefix.length),
-            table.getChild(field.name)?.get(row) ?? '',
+            arrowToString(table.getChild(field.name)?.get(row)) ?? '',
         ])
             .filter(value => value[1] !== '')
             .map(([k, v]) => `${k}="${v}"`)

package/dist/ProfileViewWithData.js

@@ -14,7 +14,6 @@ import { jsx as _jsx } from "react/jsx-runtime";
 import { useEffect, useMemo, useState } from 'react';
 import { QueryRequest_ReportType } from '@parca/client';
 import { useGrpcMetadata, useParcaContext, useURLState } from '@parca/components';
-import { USER_PREFERENCES, useUIFeatureFlag, useUserPreference } from '@parca/hooks';
 import { saveAsBlob } from '@parca/utilities';
 import { FIELD_FUNCTION_NAME } from './ProfileIcicleGraph/IcicleGraphArrow';
 import { ProfileView } from './ProfileView';
@@ -26,26 +25,18 @@ export const ProfileViewWithData = ({ queryClient, profileSource, navigateTo, })
     const [sourceBuildID] = useURLState({ param: 'source_buildid', navigateTo });
     const [sourceFilename] = useURLState({ param: 'source_filename', navigateTo });
     const [groupBy = [FIELD_FUNCTION_NAME]] = useURLState({ param: 'group_by', navigateTo });
-    const [enableTrimming] = useUserPreference(USER_PREFERENCES.ENABLE_GRAPH_TRIMMING.key);
-    const [arrowFlamegraphEnabled] = useUIFeatureFlag('flamegraph-arrow');
     const [pprofDownloading, setPprofDownloading] = useState(false);
     const nodeTrimThreshold = useMemo(() => {
-        if (!enableTrimming) {
-            return 0;
-        }
         let width = 
         // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
         window.innerWidth || document.documentElement.clientWidth || document.body.clientWidth;
         // subtract the padding
         width = width - 12 - 16 - 12;
         return (1 / width) * 100;
-    }, [enableTrimming]);
-    const reportType = arrowFlamegraphEnabled
-        ? QueryRequest_ReportType.FLAMEGRAPH_ARROW
-        : QueryRequest_ReportType.FLAMEGRAPH_TABLE;
+    }, []);
     // make sure we get a string[]
     const groupByParam = typeof groupBy === 'string' ? [groupBy] : groupBy;
-    const { isLoading: flamegraphLoading, response: flamegraphResponse, error: flamegraphError, } = useQuery(queryClient, profileSource, reportType, {
+    const { isLoading: flamegraphLoading, response: flamegraphResponse, error: flamegraphError, } = useQuery(queryClient, profileSource, QueryRequest_ReportType.FLAMEGRAPH_ARROW, {
         skip: !dashboardItems.includes('icicle'),
         nodeTrimThreshold,
         groupBy: groupByParam,

package/package.json

@@ -1,10 +1,10 @@
 {
   "name": "@parca/profile",
-  "version": "0.16.246",
+  "version": "0.16.248",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@parca/client": "^0.16.86",
-    "@parca/components": "^0.16.188",
+    "@parca/components": "^0.16.189",
     "@parca/dynamicsize": "^0.16.54",
     "@parca/hooks": "^0.0.21",
     "@parca/parser": "^0.16.55",
@@ -49,5 +49,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "0cb4c70d5506b3a61a3f088015698f485fcaaa9f"
+  "gitHead": "4e814a1223712dee92ea404b87363eac778fa499"
 }

package/src/ProfileIcicleGraph/IcicleGraphArrow/utils.ts

@@ -45,10 +45,10 @@ export function nodeLabel(
     return labelColumnNames
       .map((field, i) => [
         labelColumnNames[i].name.slice(pprofLabelPrefix.length),
-        table.getChild(field.name)?.get(row) ?? '',
+        arrowToString(table.getChild(field.name)?.get(row)) ?? '',
       ])
       .filter(value => value[1] !== '')
-      .map(([k, v]) => `${k as string}="${v as string}"`)
+      .map(([k, v]) => `${k}="${v}"`)
       .join(', ');
   }
 

package/src/ProfileViewWithData.tsx

@@ -15,7 +15,6 @@ import {useEffect, useMemo, useState} from 'react';
 
 import {QueryRequest_ReportType, QueryServiceClient} from '@parca/client';
 import {useGrpcMetadata, useParcaContext, useURLState} from '@parca/components';
-import {USER_PREFERENCES, useUIFeatureFlag, useUserPreference} from '@parca/hooks';
 import {saveAsBlob, type NavigateFunction} from '@parca/utilities';
 
 import {FIELD_FUNCTION_NAME} from './ProfileIcicleGraph/IcicleGraphArrow';
@@ -44,26 +43,16 @@ export const ProfileViewWithData = ({
   ];
   const [groupBy = [FIELD_FUNCTION_NAME]] = useURLState({param: 'group_by', navigateTo});
 
-  const [enableTrimming] = useUserPreference<boolean>(USER_PREFERENCES.ENABLE_GRAPH_TRIMMING.key);
-  const [arrowFlamegraphEnabled] = useUIFeatureFlag('flamegraph-arrow');
   const [pprofDownloading, setPprofDownloading] = useState<boolean>(false);
 
   const nodeTrimThreshold = useMemo(() => {
-    if (!enableTrimming) {
-      return 0;
-    }
-
     let width =
       // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
       window.innerWidth || document.documentElement.clientWidth || document.body.clientWidth;
     // subtract the padding
     width = width - 12 - 16 - 12;
     return (1 / width) * 100;
-  }, [enableTrimming]);
-
-  const reportType = arrowFlamegraphEnabled
-    ? QueryRequest_ReportType.FLAMEGRAPH_ARROW
-    : QueryRequest_ReportType.FLAMEGRAPH_TABLE;
+  }, []);
 
   // make sure we get a string[]
   const groupByParam: string[] = typeof groupBy === 'string' ? [groupBy] : groupBy;
@@ -72,7 +61,7 @@ export const ProfileViewWithData = ({
     isLoading: flamegraphLoading,
     response: flamegraphResponse,
     error: flamegraphError,
-  } = useQuery(queryClient, profileSource, reportType, {
+  } = useQuery(queryClient, profileSource, QueryRequest_ReportType.FLAMEGRAPH_ARROW, {
     skip: !dashboardItems.includes('icicle'),
     nodeTrimThreshold,
     groupBy: groupByParam,