@parca/profile 0.16.229 → 0.16.230

package/CHANGELOG.md

@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.16.230](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.229...@parca/profile@0.16.230) (2023-08-24)
+
+**Note:** Version bump only for package @parca/profile
+
 ## [0.16.229](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.228...@parca/profile@0.16.229) (2023-08-23)
 
 **Note:** Version bump only for package @parca/profile

package/dist/GraphTooltipArrow/Content.js

@@ -12,6 +12,7 @@ import { jsx as _jsx, Fragment as _Fragment, jsxs as _jsxs } from "react/jsx-run
 // See the License for the specific language governing permissions and
 // limitations under the License.
 import { useState } from 'react';
+import cx from 'classnames';
 import { CopyToClipboard } from 'react-copy-to-clipboard';
 import { Tooltip } from 'react-tooltip';
 import { QueryRequest_ReportType } from '@parca/client';
@@ -70,10 +71,10 @@ onCopy, row, navigateTo, }) => {
     const functionStartLine = table.getChild(FIELD_FUNCTION_START_LINE)?.get(row) ?? 0n;
     const pprofLabelPrefix = 'pprof_labels.';
     const labelColumnNames = table.schema.fields.filter(field => field.name.startsWith(pprofLabelPrefix));
-    const { queryServiceClient } = useParcaContext();
+    const { queryServiceClient, enableSourcesView } = useParcaContext();
     const { profileSource } = useProfileViewContext();
     const { isLoading: sourceLoading, response: sourceResponse } = useQuery(queryServiceClient, profileSource, QueryRequest_ReportType.SOURCE, {
-        skip: profileSource === undefined,
+        skip: enableSourcesView === false || profileSource === undefined,
         sourceBuildID: mappingBuildID,
         sourceFilename: functionFilename,
         sourceOnly: true,
@@ -119,6 +120,6 @@ onCopy, row, navigateTo, }) => {
         setSourceFilename(functionFilename);
         setSourceLine(locationLine.toString());
     };
-    return (_jsxs(_Fragment, { children: [_jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "File" }), _jsx("td", { className: "w-3/4 break-all", children: functionFilename === '' ? (_jsx(NoData, {})) : (_jsxs("div", { className: "flex gap-4", children: [_jsx(CopyToClipboard, { onCopy: onCopy, text: file, children: _jsx("button", { className: "cursor-pointer whitespace-nowrap text-left", children: _jsx(ExpandOnHover, { value: file, displayValue: truncateStringReverse(file, 30) }) }) }), _jsxs("div", { className: "flex gap-2", children: [_jsx("div", { "data-tooltip-id": "open-source-button-help", "data-tooltip-content": "There is no source code uploaded for this build", children: _jsx(Button, { variant: 'neutral', onClick: () => openFile(), className: "shrink-0", disabled: !isSourceAvailable, children: "open" }) }), !isSourceAvailable ? _jsx(Tooltip, { id: "open-source-button-help" }) : null] })] })) })] }), _jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "Address" }), _jsx("td", { className: "w-3/4 break-all", children: locationAddress === 0n ? (_jsx(NoData, {})) : (_jsx(CopyToClipboard, { onCopy: onCopy, text: hexifyAddress(locationAddress), children: _jsx("button", { className: "cursor-pointer", children: hexifyAddress(locationAddress) }) })) })] }), _jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "Binary" }), _jsx("td", { className: "w-3/4 break-all", children: mappingFile === '' ? (_jsx(NoData, {})) : (_jsx(CopyToClipboard, { onCopy: onCopy, text: mappingFile, children: _jsx("button", { className: "cursor-pointer", children: getLastItem(mappingFile) }) })) })] }), _jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "Build Id" }), _jsx("td", { className: "w-3/4 break-all", children: mappingBuildID === '' ? (_jsx(NoData, {})) : (_jsx(CopyToClipboard, { onCopy: onCopy, text: mappingBuildID, children: _jsx("button", { className: "cursor-pointer", children: truncateString(getLastItem(mappingBuildID), 28) }) })) })] }), labelPairs.length > 0 && (_jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "Labels" }), _jsx("td", { className: "w-3/4 break-all", children: labels })] }))] }));
+    return (_jsxs(_Fragment, { children: [_jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "File" }), _jsx("td", { className: "w-3/4 break-all", children: functionFilename === '' ? (_jsx(NoData, {})) : (_jsxs("div", { className: "flex gap-4", children: [_jsx(CopyToClipboard, { onCopy: onCopy, text: file, children: _jsx("button", { className: "cursor-pointer whitespace-nowrap text-left", children: _jsx(ExpandOnHover, { value: file, displayValue: truncateStringReverse(file, 30) }) }) }), _jsxs("div", { className: cx('flex gap-2', { hidden: enableSourcesView === false }), children: [_jsx("div", { "data-tooltip-id": "open-source-button-help", "data-tooltip-content": "There is no source code uploaded for this build", children: _jsx(Button, { variant: 'neutral', onClick: () => openFile(), className: "shrink-0", disabled: !isSourceAvailable, children: "open" }) }), !isSourceAvailable ? _jsx(Tooltip, { id: "open-source-button-help" }) : null] })] })) })] }), _jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "Address" }), _jsx("td", { className: "w-3/4 break-all", children: locationAddress === 0n ? (_jsx(NoData, {})) : (_jsx(CopyToClipboard, { onCopy: onCopy, text: hexifyAddress(locationAddress), children: _jsx("button", { className: "cursor-pointer", children: hexifyAddress(locationAddress) }) })) })] }), _jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "Binary" }), _jsx("td", { className: "w-3/4 break-all", children: mappingFile === '' ? (_jsx(NoData, {})) : (_jsx(CopyToClipboard, { onCopy: onCopy, text: mappingFile, children: _jsx("button", { className: "cursor-pointer", children: getLastItem(mappingFile) }) })) })] }), _jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "Build Id" }), _jsx("td", { className: "w-3/4 break-all", children: mappingBuildID === '' ? (_jsx(NoData, {})) : (_jsx(CopyToClipboard, { onCopy: onCopy, text: mappingBuildID, children: _jsx("button", { className: "cursor-pointer", children: truncateString(getLastItem(mappingBuildID), 28) }) })) })] }), labelPairs.length > 0 && (_jsxs("tr", { children: [_jsx("td", { className: "w-1/4", children: "Labels" }), _jsx("td", { className: "w-3/4 break-all", children: labels })] }))] }));
 };
 export default GraphTooltipArrowContent;

package/dist/ProfileView/ViewSelector.js

@@ -11,7 +11,7 @@ import { Fragment as _Fragment, jsx as _jsx, jsxs as _jsxs } from "react/jsx-run
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-import { Select, useURLState } from '@parca/components';
+import { Select, useParcaContext, useURLState } from '@parca/components';
 import { useUIFeatureFlag } from '@parca/hooks';
 const ViewSelector = ({ defaultValue, navigateTo, position, placeholderText, primary = false, addView = false, disabled = false, }) => {
     const [callgraphEnabled] = useUIFeatureFlag('callgraph');
@@ -19,11 +19,14 @@ const ViewSelector = ({ defaultValue, navigateTo, position, placeholderText, pri
         param: 'dashboard_items',
         navigateTo,
     });
+    const { enableSourcesView } = useParcaContext();
     const allItems = [
         { key: 'table', canBeSelected: !dashboardItems.includes('table') },
         { key: 'icicle', canBeSelected: !dashboardItems.includes('icicle') },
-        { key: 'source', canBeSelected: false },
     ];
+    if (enableSourcesView === true) {
+        allItems.push({ key: 'source', canBeSelected: false });
+    }
     if (callgraphEnabled) {
         allItems.push({
             key: 'callgraph',

package/package.json

@@ -1,10 +1,10 @@
 {
   "name": "@parca/profile",
-  "version": "0.16.229",
+  "version": "0.16.230",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@parca/client": "^0.16.86",
-    "@parca/components": "^0.16.182",
+    "@parca/components": "^0.16.183",
     "@parca/dynamicsize": "^0.16.54",
     "@parca/hooks": "^0.0.21",
     "@parca/parser": "^0.16.55",
@@ -49,5 +49,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "6cc8241e1dba86446268b2c427330e46fe815fb0"
+  "gitHead": "79fbf41f87bbd157c49568591abe9bcea3a38afa"
 }

package/src/GraphTooltipArrow/Content.tsx

@@ -14,6 +14,7 @@
 import React, {useState} from 'react';
 
 import {Table} from 'apache-arrow';
+import cx from 'classnames';
 import {CopyToClipboard} from 'react-copy-to-clipboard';
 import {Tooltip} from 'react-tooltip';
 
@@ -200,7 +201,7 @@ const TooltipMetaInfo = ({
     field.name.startsWith(pprofLabelPrefix)
   );
 
-  const {queryServiceClient} = useParcaContext();
+  const {queryServiceClient, enableSourcesView} = useParcaContext();
   const {profileSource} = useProfileViewContext();
 
   const {isLoading: sourceLoading, response: sourceResponse} = useQuery(
@@ -208,7 +209,7 @@ const TooltipMetaInfo = ({
     profileSource as ProfileSource,
     QueryRequest_ReportType.SOURCE,
     {
-      skip: profileSource === undefined,
+      skip: enableSourcesView === false || profileSource === undefined,
       sourceBuildID: mappingBuildID,
       sourceFilename: functionFilename,
       sourceOnly: true,
@@ -289,7 +290,7 @@ const TooltipMetaInfo = ({
                   <ExpandOnHover value={file} displayValue={truncateStringReverse(file, 30)} />
                 </button>
               </CopyToClipboard>
-              <div className="flex gap-2">
+              <div className={cx('flex gap-2', {hidden: enableSourcesView === false})}>
                 <div
                   data-tooltip-id="open-source-button-help"
                   data-tooltip-content="There is no source code uploaded for this build"

package/src/ProfileView/ViewSelector.tsx

@@ -11,7 +11,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import {Select, useURLState, type SelectElement} from '@parca/components';
+import {Select, useParcaContext, useURLState, type SelectElement} from '@parca/components';
 import {useUIFeatureFlag} from '@parca/hooks';
 import type {NavigateFunction} from '@parca/utilities';
 
@@ -39,12 +39,15 @@ const ViewSelector = ({
     param: 'dashboard_items',
     navigateTo,
   });
+  const {enableSourcesView} = useParcaContext();
 
   const allItems: Array<{key: string; canBeSelected: boolean; supportingText?: string}> = [
     {key: 'table', canBeSelected: !dashboardItems.includes('table')},
     {key: 'icicle', canBeSelected: !dashboardItems.includes('icicle')},
-    {key: 'source', canBeSelected: false},
   ];
+  if (enableSourcesView === true) {
+    allItems.push({key: 'source', canBeSelected: false});
+  }
   if (callgraphEnabled) {
     allItems.push({
       key: 'callgraph',