@parca/profile 0.16.206 → 0.16.208

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.16.208](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.207...@parca/profile@0.16.208) (2023-07-14)
+
+**Note:** Version bump only for package @parca/profile
+
+## [0.16.207](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.206...@parca/profile@0.16.207) (2023-07-12)
+
+**Note:** Version bump only for package @parca/profile
+
 ## 0.16.206 (2023-07-12)
 
 **Note:** Version bump only for package @parca/profile

package/dist/ProfileIcicleGraph/IcicleGraphArrow/IcicleGraphNodes.js

@@ -69,7 +69,17 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({ table, row, map
                 // TODO: Support fallthrough to comparing addresses or something
                 const afn = functionNameColumn?.get(a);
                 const bfn = functionNameColumn?.get(b);
-                return afn.localeCompare(bfn);
+                if (afn !== null && bfn !== null) {
+                    return afn.localeCompare(bfn);
+                }
+                if (afn === null && bfn !== null) {
+                    return -1;
+                }
+                if (afn !== null && bfn === null) {
+                    return 1;
+                }
+                // both are null
+                return 0;
             });
             break;
         case FIELD_CUMULATIVE:
@@ -87,10 +97,10 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({ table, row, map
                     return Number(bDiff - aDiff);
                 }
                 if (aDiff === null && bDiff !== null) {
-                    return 1;
+                    return -1;
                 }
                 if (aDiff !== null && bDiff === null) {
-                    return -1;
+                    return 1;
                 }
                 // both are null
                 return 0;

package/package.json

@@ -1,15 +1,15 @@
 {
   "name": "@parca/profile",
-  "version": "0.16.206",
+  "version": "0.16.208",
   "description": "Profile viewing libraries",
   "dependencies": {
-    "@parca/client": "^0.16.79",
-    "@parca/components": "^0.16.166",
+    "@parca/client": "^0.16.80",
+    "@parca/components": "^0.16.167",
     "@parca/dynamicsize": "^0.16.54",
-    "@parca/hooks": "^0.0.14",
+    "@parca/hooks": "^0.0.15",
     "@parca/parser": "^0.16.55",
-    "@parca/store": "^0.16.90",
-    "@parca/utilities": "^0.0.19",
+    "@parca/store": "^0.16.91",
+    "@parca/utilities": "^0.0.20",
     "@tanstack/react-query": "^4.0.5",
     "@types/react-beautiful-dnd": "^13.1.3",
     "apache-arrow": "^12.0.0",
@@ -47,5 +47,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "396c0fc844658d3b699f8991efb6e8b9b3a97e19"
+  "gitHead": "6598149618b644783f5d638b6a913026cb8adc25"
 }

package/src/ProfileIcicleGraph/IcicleGraphArrow/IcicleGraphNodes.tsx

@@ -190,9 +190,19 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({
     case FIELD_FUNCTION_NAME:
       childRows.sort((a, b) => {
         // TODO: Support fallthrough to comparing addresses or something
-        const afn: string = functionNameColumn?.get(a);
-        const bfn: string = functionNameColumn?.get(b);
-        return afn.localeCompare(bfn);
+        const afn: string | null = functionNameColumn?.get(a);
+        const bfn: string | null = functionNameColumn?.get(b);
+        if (afn !== null && bfn !== null) {
+          return afn.localeCompare(bfn);
+        }
+        if (afn === null && bfn !== null) {
+          return -1;
+        }
+        if (afn !== null && bfn === null) {
+          return 1;
+        }
+        // both are null
+        return 0;
       });
       break;
     case FIELD_CUMULATIVE:
@@ -210,10 +220,10 @@ export const IcicleNode = React.memo(function IcicleNodeNoMemo({
           return Number(bDiff - aDiff);
         }
         if (aDiff === null && bDiff !== null) {
-          return 1;
+          return -1;
         }
         if (aDiff !== null && bDiff === null) {
-          return -1;
+          return 1;
         }
         // both are null
         return 0;