@parca/profile 0.16.149 → 0.16.151

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## 0.16.151 (2023-03-27)
+
+**Note:** Version bump only for package @parca/profile
+
+## [0.16.150](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.149...@parca/profile@0.16.150) (2023-03-23)
+
+**Note:** Version bump only for package @parca/profile
+
 ## 0.16.149 (2023-03-23)
 
 **Note:** Version bump only for package @parca/profile

package/dist/Callgraph/index.js

@@ -74,7 +74,6 @@ var Callgraph = function (_a) {
                 nodes.each(function () {
                     var _this = this;
                     var nodeData = data.nodes.find(function (n) {
-                        // @ts-expect-error
                         return n.id === _this.id;
                     });
                     var defaultColor = colorScale(Number(nodeData === null || nodeData === void 0 ? void 0 : nodeData.cumulative));

package/dist/ProfileIcicleGraph/IcicleGraph/utils.js

@@ -18,6 +18,9 @@ export var getBinaryName = function (node, mappings, locations, strings) {
     if (((_a = node.meta) === null || _a === void 0 ? void 0 : _a.locationIndex) === undefined || ((_b = node.meta) === null || _b === void 0 ? void 0 : _b.locationIndex) === 0) {
         return undefined;
     }
+    if (node.meta.locationIndex > locations.length) {
+        return undefined;
+    }
     var location = locations[node.meta.locationIndex - 1];
     if (location.mappingIndex === undefined || location.mappingIndex === 0) {
         return undefined;
@@ -35,7 +38,13 @@ export function nodeLabel(node, strings, mappings, locations, functions, showBin
         return '<unknown>';
     if (((_b = node.meta) === null || _b === void 0 ? void 0 : _b.locationIndex) === 0)
         return '<unknown>';
+    if (node.meta.locationIndex > locations.length) {
+        console.info('location index out of bounds', node.meta.locationIndex, locations.length);
+        return '<unknown>';
+    }
     var location = locations[node.meta.locationIndex - 1];
+    if (location === undefined)
+        return '<unknown>';
     var mappingString = '';
     if (showBinaryName) {
         var binary = getBinaryName(node, mappings, locations, strings);

package/package.json

@@ -1,14 +1,14 @@
 {
   "name": "@parca/profile",
-  "version": "0.16.149",
+  "version": "0.16.151",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@parca/client": "^0.16.69",
-    "@parca/components": "^0.16.121",
+    "@parca/components": "^0.16.122",
     "@parca/dynamicsize": "^0.16.54",
     "@parca/hooks": "^0.0.2",
     "@parca/parser": "^0.16.55",
-    "@parca/store": "^0.16.70",
+    "@parca/store": "^0.16.71",
     "@parca/utilities": "^0.0.3",
     "@types/react-beautiful-dnd": "^13.1.3",
     "d3": "7.8.2",
@@ -46,5 +46,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "ac30ab34fee416cb627972a15013e56b31320a8b"
+  "gitHead": "b4d9d693e72cfb0cfd2454041f9b480b2802a57c"
 }

package/src/Callgraph/index.tsx

@@ -83,8 +83,7 @@ const Callgraph = ({data, svgString, sampleUnit, width}: Props): JSX.Element =>
 
         nodes.each(function () {
           const nodeData = data.nodes.find((n): boolean => {
-            // @ts-expect-error
-            return n.id === this.id;
+            return n.id === (this as Element).id;
           });
           const defaultColor = colorScale(Number(nodeData?.cumulative));
           const node = d3.select(this);

package/src/ProfileIcicleGraph/IcicleGraph/utils.ts

@@ -31,6 +31,9 @@ export const getBinaryName = (
   if (node.meta?.locationIndex === undefined || node.meta?.locationIndex === 0) {
     return undefined;
   }
+  if (node.meta.locationIndex > locations.length) {
+    return undefined;
+  }
 
   const location = locations[node.meta.locationIndex - 1];
 
@@ -57,7 +60,13 @@ export function nodeLabel(
   if (node.meta?.locationIndex === undefined) return '<unknown>';
   if (node.meta?.locationIndex === 0) return '<unknown>';
 
+  if (node.meta.locationIndex > locations.length) {
+    console.info('location index out of bounds', node.meta.locationIndex, locations.length);
+    return '<unknown>';
+  }
+
   const location = locations[node.meta.locationIndex - 1];
+  if (location === undefined) return '<unknown>';
 
   let mappingString = '';