@parca/profile 0.16.129 → 0.16.131

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.16.131](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.130...@parca/profile@0.16.131) (2023-03-06)
+
+**Note:** Version bump only for package @parca/profile
+
+## 0.16.130 (2023-03-06)
+
+**Note:** Version bump only for package @parca/profile
+
 ## [0.16.129](https://github.com/parca-dev/parca/compare/@parca/profile@0.16.128...@parca/profile@0.16.129) (2023-03-02)
 
 ## 0.16.1 (2023-03-02)

package/dist/Callgraph/index.js

@@ -111,7 +111,7 @@ var Callgraph = function (_a) {
     var currentSearchString = (_b = selectQueryParam('search_string')) !== null && _b !== void 0 ? _b : '';
     var isSearchEmpty = currentSearchString === undefined || currentSearchString === '';
     var rawDashboardItems = useURLState({ param: 'dashboard_items' })[0];
-    var dashboardItems = rawDashboardItems;
+    var dashboardItems = rawDashboardItems !== undefined ? rawDashboardItems : ['icicle'];
     useEffect(function () {
         var getDataWithPositions = function () { return __awaiter(void 0, void 0, void 0, function () {
             var dataAsDot, jsonGraph;

package/dist/ProfileSource.js

@@ -45,12 +45,17 @@ export function ProfileSelectionFromParams(expression, from, to, mergeFrom, merg
         expression !== undefined) {
         // TODO: Refactor parsing the query and adding matchers
         var query_1 = Query.parse(expression);
-        ParseLabels(labels !== null && labels !== void 0 ? labels : ['']).forEach(function (l) {
-            var _a = query_1.setMatcher(l.name, l.value), newQuery = _a[0], changed = _a[1];
-            if (changed) {
-                query_1 = newQuery;
-            }
-        });
+        if (labels !== undefined) {
+            ParseLabels(labels !== null && labels !== void 0 ? labels : ['']).forEach(function (l) {
+                var hasLabels = labels.length > 0 && labels.filter(function (val) { return val !== ''; }).length > 0;
+                if (hasLabels) {
+                    var _a = query_1.setMatcher(l.name, l.value), newQuery = _a[0], changed = _a[1];
+                    if (changed) {
+                        query_1 = newQuery;
+                    }
+                }
+            });
+        }
         return new MergedProfileSelection(parseInt(mergeFrom), parseInt(mergeTo), query_1, filterQuery);
     }
     return null;

package/dist/ProfileView/ViewSelector.js

@@ -30,7 +30,7 @@ var ViewSelector = function (_a) {
     var _e = useURLState({
         param: 'dashboard_items',
         navigateTo: navigateTo,
-    }), dashboardItems = _e[0], setDashboardItems = _e[1];
+    }), _f = _e[0], dashboardItems = _f === void 0 ? ['icicle'] : _f, setDashboardItems = _e[1];
     var allItems = [
         { key: 'table', canBeSelected: !dashboardItems.includes('table') },
         { key: 'icicle', canBeSelected: !dashboardItems.includes('icicle') },

package/dist/ProfileView/index.js

@@ -63,7 +63,12 @@ export var ProfileView = function (_a) {
         navigateTo: navigateTo,
     }), rawDashboardItems = _d[0], setDashboardItems = _d[1];
     var currentSearchString = useURLState({ param: 'search_string' })[0];
-    var dashboardItems = rawDashboardItems;
+    var dashboardItems = useMemo(function () {
+        if (rawDashboardItems !== undefined) {
+            return rawDashboardItems;
+        }
+        return ['icicle'];
+    }, [rawDashboardItems]);
     var isDarkMode = useAppSelector(selectDarkMode);
     var isMultiPanelView = dashboardItems.length > 1;
     var _e = useParcaContext(), loader = _e.loader, perf = _e.perf;

package/dist/TopTable/index.js

@@ -54,7 +54,12 @@ export var TopTable = React.memo(function TopTable(_a) {
     var rawDashboardItems = useURLState({ param: 'dashboard_items' })[0];
     var rawcompareMode = useURLState({ param: 'compare_a' })[0];
     var compareMode = rawcompareMode === undefined ? false : rawcompareMode === 'true';
-    var dashboardItems = rawDashboardItems;
+    var dashboardItems = useMemo(function () {
+        if (rawDashboardItems !== undefined) {
+            return rawDashboardItems;
+        }
+        return ['icicle'];
+    }, [rawDashboardItems]);
     var columns = useMemo(function () {
         var cols = [
             columnHelper.accessor('meta', {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parca/profile",
-  "version": "0.16.129",
+  "version": "0.16.131",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@parca/client": "^0.16.65",
@@ -45,5 +45,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "ec6a751d5e3058e3a537e93b867b59cfadb050b1"
+  "gitHead": "d60fe1c35d044d0ab89c15b6717fd6615cc4bd3a"
 }

package/src/Callgraph/index.tsx

@@ -186,7 +186,8 @@ const Callgraph = ({graph, sampleUnit, width, colorRange}: Props): JSX.Element =
   const isSearchEmpty = currentSearchString === undefined || currentSearchString === '';
   const [rawDashboardItems] = useURLState({param: 'dashboard_items'});
 
-  const dashboardItems = rawDashboardItems as string[];
+  const dashboardItems =
+    rawDashboardItems !== undefined ? (rawDashboardItems as string[]) : ['icicle'];
 
   useEffect(() => {
     const getDataWithPositions = async (): Promise<void> => {

package/src/ProfileSource.tsx

@@ -82,12 +82,17 @@ export function ProfileSelectionFromParams(
   ) {
     // TODO: Refactor parsing the query and adding matchers
     let query = Query.parse(expression);
-    ParseLabels(labels ?? ['']).forEach(l => {
-      const [newQuery, changed] = query.setMatcher(l.name, l.value);
-      if (changed) {
-        query = newQuery;
-      }
-    });
+    if (labels !== undefined) {
+      ParseLabels(labels ?? ['']).forEach(l => {
+        const hasLabels = labels.length > 0 && labels.filter(val => val !== '').length > 0;
+        if (hasLabels) {
+          const [newQuery, changed] = query.setMatcher(l.name, l.value);
+          if (changed) {
+            query = newQuery;
+          }
+        }
+      });
+    }
 
     return new MergedProfileSelection(parseInt(mergeFrom), parseInt(mergeTo), query, filterQuery);
   }

package/src/ProfileView/ViewSelector.tsx

@@ -35,7 +35,7 @@ const ViewSelector = ({
   disabled = false,
 }: Props): JSX.Element => {
   const [callgraphEnabled] = useUIFeatureFlag('callgraph');
-  const [dashboardItems, setDashboardItems] = useURLState({
+  const [dashboardItems = ['icicle'], setDashboardItems] = useURLState({
     param: 'dashboard_items',
     navigateTo,
   });

package/src/ProfileView/index.tsx

@@ -106,7 +106,14 @@ export const ProfileView = ({
     navigateTo,
   });
   const [currentSearchString] = useURLState({param: 'search_string'});
-  const dashboardItems = rawDashboardItems as string[];
+
+  const dashboardItems = useMemo(() => {
+    if (rawDashboardItems !== undefined) {
+      return rawDashboardItems as string[];
+    }
+    return ['icicle'];
+  }, [rawDashboardItems]);
+
   const isDarkMode = useAppSelector(selectDarkMode);
   const isMultiPanelView = dashboardItems.length > 1;
 

package/src/TopTable/index.tsx

@@ -76,7 +76,12 @@ export const TopTable = React.memo(function TopTable({
 
   const compareMode: boolean = rawcompareMode === undefined ? false : rawcompareMode === 'true';
 
-  const dashboardItems = rawDashboardItems as string[];
+  const dashboardItems = useMemo(() => {
+    if (rawDashboardItems !== undefined) {
+      return rawDashboardItems as string[];
+    }
+    return ['icicle'];
+  }, [rawDashboardItems]);
 
   const columns = useMemo(() => {
     const cols: Array<ColumnDef<TopNode, any>> = [