@parca/profile 0.15.19 → 0.16.0

package/CHANGELOG.md

@@ -3,6 +3,45 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [0.16.0](https://github.com/parca-dev/parca/compare/ui-v0.15.26...ui-v0.16.0) (2022-09-13)
+
+**Note:** Version bump only for package @parca/profile
+
+
+
+
+
+## [0.15.25](https://github.com/parca-dev/parca/compare/ui-v0.15.24...ui-v0.15.25) (2022-09-13)
+
+**Note:** Version bump only for package @parca/profile
+
+
+
+
+
+## [0.15.24](https://github.com/parca-dev/parca/compare/ui-v0.15.23...ui-v0.15.24) (2022-09-13)
+
+
+
+## [0.15.19](https://github.com/parca-dev/parca/compare/ui-v0.15.17...ui-v0.15.19) (2022-09-08)
+
+
+
+## [0.15.17](https://github.com/parca-dev/parca/compare/ui-v0.15.10...ui-v0.15.17) (2022-09-07)
+
+
+### Bug Fixes
+
+* **ui:** type all the things (string mode) ([e91ac9d](https://github.com/parca-dev/parca/commit/e91ac9deb8a200ed3c9a9c5d81ae71e13d49466e))
+
+
+
+## 0.15.10 (2022-08-30)
+
+
+
+
+
 ## [0.15.19](https://github.com/parca-dev/parca/compare/ui-v0.15.18...ui-v0.15.19) (2022-09-08)
 
 

package/package.json

@@ -1,17 +1,20 @@
 {
   "name": "@parca/profile",
-  "version": "0.15.19",
+  "version": "0.16.0",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@iconify/react": "^3.2.2",
-    "@parca/client": "^0.15.11",
-    "@parca/dynamicsize": "^0.15.17",
-    "@parca/functions": "^0.15.17",
-    "@parca/parser": "^0.15.17",
+    "@parca/client": "^0.16.0",
+    "@parca/dynamicsize": "^0.16.0",
+    "@parca/functions": "^0.16.0",
+    "@parca/parser": "^0.16.0",
     "d3-scale": "^4.0.2",
     "d3-selection": "3.0.0",
     "react-copy-to-clipboard": "^5.1.0"
   },
+  "devDependencies": {
+    "@types/react-copy-to-clipboard": "5.0.4"
+  },
   "main": "src/index.tsx",
   "scripts": {
     "test": "jest --coverage --config ../../../jest.config.js ./src/*"
@@ -23,5 +26,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "bd028ff3e017cfeda0b743b2426f8d30f92b72f9"
+  "gitHead": "63fa76520f8a8b4c51b645f23117dde72bf0504d"
 }

package/src/IcicleGraph.tsx

@@ -261,7 +261,7 @@ export function IcicleGraphRootNode({
   const onClick = (): void => setCurPath([]);
   const onMouseEnter = (): void => setHoveringNode(node);
   const onMouseLeave = (): void => setHoveringNode(undefined);
-  const path = [];
+  const path: string[] = [];
 
   return (
     <g transform={'translate(0, 0)'}>

package/src/TopTable.tsx

@@ -15,7 +15,7 @@ import React from 'react';
 
 import {getLastItem, valueFormatter, isSearchMatch} from '@parca/functions';
 import {useAppSelector, selectCompareMode, selectSearchNodeString} from '@parca/store';
-import {TopNodeMeta, Top} from '@parca/client';
+import {TopNode, TopNodeMeta, Top} from '@parca/client';
 
 import {hexifyAddress} from './utils';
 
@@ -43,7 +43,10 @@ const Arrow = ({direction}: {direction: string | undefined}): JSX.Element => {
 
 const useSortableData = (
   top?: Top,
-  config = {key: 'cumulative', direction: 'desc'}
+  config: {key: keyof TopNode | 'name'; direction: 'asc' | 'desc'} = {
+    key: 'cumulative',
+    direction: 'desc',
+  }
 ): {
   items:
     | Array<{
@@ -54,17 +57,20 @@ const useSortableData = (
         meta?: TopNodeMeta | undefined;
       }>
     | undefined;
-  requestSort: (key: string) => void;
-  sortConfig: {key: string; direction: string} | null;
+  requestSort: (key: keyof TopNode | 'name') => void;
+  sortConfig: {key: keyof TopNode | 'name'; direction: string} | null;
 } => {
-  const [sortConfig, setSortConfig] = React.useState<{key: string; direction: string} | null>(
-    config
-  );
+  const [sortConfig, setSortConfig] = React.useState<{
+    key: keyof TopNode | 'name';
+    direction: string;
+  } | null>(config);
 
   const rawTableReport = top != null ? top.list : [];
 
   const items = rawTableReport.map(node => ({
     ...node,
+    // Warning: string to number can overflow
+    // https://github.com/timostamm/protobuf-ts/blob/master/MANUAL.md#bigint-support
     diff: Number(node.diff),
     cumulative: Number(node.cumulative),
     flat: Number(node.flat),
@@ -77,10 +83,21 @@ const useSortableData = (
     const sortableItems = [...items];
     if (sortConfig !== null) {
       sortableItems.sort((a, b) => {
-        if (a[sortConfig.key] < b[sortConfig.key]) {
+        const itemA = a[sortConfig.key];
+        const itemB = b[sortConfig.key];
+        if (itemA === undefined && itemB === undefined) {
+          return 0;
+        }
+        if (itemA === undefined) {
+          return sortConfig.direction === 'asc' ? -1 : 1;
+        }
+        if (itemB === undefined) {
+          return sortConfig.direction === 'asc' ? 1 : -1;
+        }
+        if (itemA < itemB) {
           return sortConfig.direction === 'asc' ? -1 : 1;
         }
-        if (a[sortConfig.key] > b[sortConfig.key]) {
+        if (itemA > itemB) {
           return sortConfig.direction === 'asc' ? 1 : -1;
         }
         return 0;
@@ -89,7 +106,7 @@ const useSortableData = (
     return sortableItems;
   }, [items, sortConfig]);
 
-  const requestSort = (key: string): void => {
+  const requestSort = (key: keyof TopNode | 'name'): void => {
     let direction = 'desc';
     if (sortConfig != null && sortConfig.key === key && sortConfig.direction === 'desc') {
       direction = 'asc';

package/src/components/ProfileShareButton/index.tsx

@@ -54,9 +54,13 @@ const ProfileShareModal = ({
       setLoading(false);
       setIsShared(true);
     } catch (err) {
-      console.error(err);
-      setLoading(false);
-      setError(err.toString());
+      if (err instanceof Error) {
+        console.error(err);
+        setLoading(false);
+        // https://github.com/microsoft/TypeScript/issues/38347
+        // eslint-disable-next-line @typescript-eslint/no-base-to-string
+        setError(err.toString());
+      }
     }
   };
 

package/src/useDelayedLoader.ts

@@ -27,7 +27,7 @@ const useDelayedLoader = (isLoading = false, options?: DelayedLoaderOptions): bo
       showLoaderTimeout = setTimeout(() => {
         setIsLoaderVisible(true);
       }, delay);
-    } else {
+    } else if (!isLoading && isLoaderVisible) {
       setIsLoaderVisible(false);
     }
     return () => clearTimeout(showLoaderTimeout);