@parca/profile 0.14.30 → 0.14.31

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.14.31](https://github.com/parca-dev/parca/compare/ui-v0.14.30...ui-v0.14.31) (2022-08-18)
+
+
+### Bug Fixes
+
+* **ui:** address all problems reported by ESLint ([7f9c921](https://github.com/parca-dev/parca/commit/7f9c9217af49f2661a4363b9b17a9a06f1c7539b))
+
+
+
+
+
 ## [0.14.30](https://github.com/parca-dev/parca/compare/ui-v0.14.29...ui-v0.14.30) (2022-08-17)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parca/profile",
-  "version": "0.14.30",
+  "version": "0.14.31",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@iconify/react": "^3.2.2",
@@ -22,5 +22,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "9c8d0ec834d23db619a26b999d543c6bc40f7e16"
+  "gitHead": "ad5f13b18fb7c5dd70df3dc6b40477e44f839381"
 }

package/src/IcicleGraph.tsx

@@ -111,7 +111,11 @@ function IcicleRect({
         height={height - 1}
         style={{
           opacity:
-            Boolean(currentSearchString) && !isSearchMatch(currentSearchString, name) ? 0.5 : 1,
+            currentSearchString !== undefined &&
+            currentSearchString !== '' &&
+            !isSearchMatch(currentSearchString, name)
+              ? 0.5
+              : 1,
           fill: color,
         }}
       />
@@ -130,7 +134,7 @@ export function nodeLabel(node: FlamegraphNode): string {
   if (node.meta === undefined) return '<unknown>';
   const mapping = `${
     node.meta?.mapping?.file !== undefined && node.meta?.mapping?.file !== ''
-      ? '[' + getLastItem(node.meta.mapping.file) + '] '
+      ? '[' + (getLastItem(node.meta.mapping.file) ?? '') + '] '
       : ''
   }`;
   if (node.meta.function?.name !== undefined && node.meta.function?.name !== '')

package/src/ProfileView.tsx

@@ -70,7 +70,7 @@ export const useProfileVisState = (): ProfileVisState => {
   const router = parseParams(window.location.search);
   const currentViewFromURL = router.currentProfileView as string;
   const [currentView, setCurrentView] = useState<VisualizationType>(
-    (currentViewFromURL as VisualizationType) || 'icicle'
+    (currentViewFromURL as VisualizationType) ?? 'icicle'
   );
 
   return {currentView, setCurrentView};
@@ -98,13 +98,13 @@ export const ProfileView = ({
 
   const isLoading = useMemo(() => {
     if (currentView === 'icicle') {
-      return !!flamegraphData?.loading;
+      return Boolean(flamegraphData?.loading);
     }
     if (currentView === 'table') {
-      return !!topTableData?.loading;
+      return Boolean(topTableData?.loading);
     }
     if (currentView === 'both') {
-      return !!flamegraphData?.loading || !!topTableData?.loading;
+      return Boolean(flamegraphData?.loading) || Boolean(topTableData?.loading);
     }
     return false;
   }, [currentView, flamegraphData?.loading, topTableData?.loading]);
@@ -176,7 +176,7 @@ export const ProfileView = ({
                     />
                   ) : null}
 
-                  <Button color="neutral" onClick={downloadPProf}>
+                  <Button color="neutral" onClick={void downloadPProf}>
                     Download pprof
                   </Button>
                 </div>

package/src/ProfileViewWithData.tsx

@@ -38,7 +38,7 @@ export const ProfileViewWithData = ({
     response: flamegraphResponse,
     error: flamegraphError,
   } = useQuery(queryClient, profileSource, QueryRequest_ReportType.FLAMEGRAPH_UNSPECIFIED, {
-    skip: currentView != 'icicle' && currentView != 'both',
+    skip: currentView !== 'icicle' && currentView !== 'both',
   });
 
   const {
@@ -46,7 +46,7 @@ export const ProfileViewWithData = ({
     response: topTableResponse,
     error: topTableError,
   } = useQuery(queryClient, profileSource, QueryRequest_ReportType.TOP, {
-    skip: currentView != 'table' && currentView != 'both',
+    skip: currentView !== 'table' && currentView !== 'both',
   });
 
   const sampleUnit = profileSource.ProfileType().sampleUnit;

package/src/TopTable.tsx

@@ -57,7 +57,7 @@ const useSortableData = (top?: Top, config = {key: 'cumulative', direction: 'des
   }));
 
   const sortedItems = React.useMemo(() => {
-    if (!items) return;
+    if (items.length === 0) return;
 
     const sortableItems = [...items];
     if (sortConfig !== null) {
@@ -74,7 +74,7 @@ const useSortableData = (top?: Top, config = {key: 'cumulative', direction: 'des
     return sortableItems;
   }, [items, sortConfig]);
 
-  const requestSort = key => {
+  const requestSort = (key: string) => {
     let direction = 'desc';
     if (sortConfig != null && sortConfig.key === key && sortConfig.direction === 'desc') {
       direction = 'asc';
@@ -89,7 +89,7 @@ export const RowLabel = (meta: TopNodeMeta | undefined): string => {
   if (meta === undefined) return '<unknown>';
   const mapping = `${
     meta?.mapping?.file !== undefined && meta?.mapping?.file !== ''
-      ? `[${getLastItem(meta.mapping.file)}]`
+      ? `[${getLastItem(meta.mapping.file) ?? ''}]`
       : ''
   }`;
   if (meta.function?.name !== undefined && meta.function?.name !== '')
@@ -112,7 +112,7 @@ export const TopTable = ({data: top, sampleUnit}: TopTableProps): JSX.Element =>
   const total = top != null ? top.list.length : 0;
   if (total === 0) return <>Profile has no samples</>;
 
-  const getClassNamesFor = name => {
+  const getClassNamesFor = (name: string) => {
     if (sortConfig == null) {
       return;
     }
@@ -138,7 +138,9 @@ export const TopTable = ({data: top, sampleUnit}: TopTableProps): JSX.Element =>
                 onClick={() => requestSort('name')}
               >
                 Name
-                <span className={`inline-block align-middle ml-2 ${getClassNamesFor('name')}`}>
+                <span
+                  className={`inline-block align-middle ml-2 ${getClassNamesFor('name') ?? ''}`}
+                >
                   <Arrow direction={getClassNamesFor('name')} />
                 </span>
               </th>
@@ -147,7 +149,9 @@ export const TopTable = ({data: top, sampleUnit}: TopTableProps): JSX.Element =>
                 onClick={() => requestSort('flat')}
               >
                 Flat
-                <span className={`inline-block align-middle ml-2 ${getClassNamesFor('flat')}`}>
+                <span
+                  className={`inline-block align-middle ml-2 ${getClassNamesFor('flat') ?? ''}`}
+                >
                   <Arrow direction={getClassNamesFor('flat')} />
                 </span>
               </th>
@@ -157,7 +161,9 @@ export const TopTable = ({data: top, sampleUnit}: TopTableProps): JSX.Element =>
               >
                 Cumulative
                 <span
-                  className={`inline-block align-middle ml-2 ${getClassNamesFor('cumulative')}`}
+                  className={`inline-block align-middle ml-2 ${
+                    getClassNamesFor('cumulative') ?? ''
+                  }`}
                 >
                   <Arrow direction={getClassNamesFor('cumulative')} />
                 </span>
@@ -168,7 +174,9 @@ export const TopTable = ({data: top, sampleUnit}: TopTableProps): JSX.Element =>
                   onClick={() => requestSort('diff')}
                 >
                   Diff
-                  <span className={`inline-block align-middle ml-2 ${getClassNamesFor('diff')}`}>
+                  <span
+                    className={`inline-block align-middle ml-2 ${getClassNamesFor('diff') ?? ''}`}
+                  >
                     <Arrow direction={getClassNamesFor('diff')} />
                   </span>
                 </th>

package/src/components/DiffLegend.tsx

@@ -59,7 +59,7 @@ const DiffLegend = () => {
   const [popperElement, setPopperElement] = useState<HTMLDivElement | null>(null);
   const [referenceElement, setReferenceElement] = useState<HTMLDivElement | null>(null);
 
-  const {styles, attributes, ...popperProps} = usePopper(referenceElement, popperElement, {
+  const {styles, attributes} = usePopper(referenceElement, popperElement, {
     placement: 'auto-start',
     strategy: 'absolute',
   });

package/src/components/ProfileShareButton/index.tsx

@@ -43,7 +43,7 @@ const ProfileShareModal = ({
   const metadata = useGrpcMetadata();
   const isFormDataValid = () => true;
 
-  const handleSubmit: () => void = async () => {
+  const handleSubmit: () => Promise<void> = async () => {
     try {
       setLoading(true);
       const {response} = await queryClient.shareProfile(
@@ -89,7 +89,7 @@ const ProfileShareModal = ({
               className="w-fit mt-4"
               onClick={e => {
                 e.preventDefault();
-                handleSubmit();
+                void handleSubmit();
               }}
               disabled={loading || !isFormDataValid()}
               type="submit"

package/src/useDelayedLoader.ts

@@ -18,10 +18,10 @@ interface DelayedLoaderOptions {
 }
 
 const useDelayedLoader = (isLoading = false, options?: DelayedLoaderOptions) => {
-  const {delay = 500} = options != null || {};
+  const {delay = 500} = options ?? {};
   const [isLoaderVisible, setIsLoaderVisible] = useState<boolean>(false);
   useEffect(() => {
-    let showLoaderTimeout;
+    let showLoaderTimeout: ReturnType<typeof setTimeout>;
     if (isLoading && !isLoaderVisible) {
       // if the request takes longer than half a second, show the loading icon
       showLoaderTimeout = setTimeout(() => {
@@ -31,7 +31,7 @@ const useDelayedLoader = (isLoading = false, options?: DelayedLoaderOptions) =>
       setIsLoaderVisible(false);
     }
     return () => clearTimeout(showLoaderTimeout);
-  }, [isLoading]);
+  }, [isLoading, isLoaderVisible, delay]);
 
   return isLoaderVisible;
 };

package/src/useQuery.tsx

@@ -35,7 +35,7 @@ export const useQuery = (
   reportType: QueryRequest_ReportType,
   options?: UseQueryOptions
 ): IQueryResult => {
-  const {skip = false} = options != null || {};
+  const {skip = false} = options ?? {};
   const [result, setResult] = useState<IQueryResult>({
     response: null,
     error: null,
@@ -60,7 +60,7 @@ export const useQuery = (
     call.response
       .then(response => setResult({response, error: null, isLoading: false}))
       .catch(error => setResult({error, response: null, isLoading: false}));
-  }, [client, profileSource, metadata, reportType]);
+  }, [skip, client, profileSource, metadata, reportType]);
 
   return result;
 };