@parca/profile 0.12.20 → 0.12.23

package/CHANGELOG.md

@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.12.23](https://github.com/parca-dev/parca/compare/ui-v0.12.22...ui-v0.12.23) (2022-04-25)
+
+**Note:** Version bump only for package @parca/profile
+
 ## [0.12.20](https://github.com/parca-dev/parca/compare/ui-v0.12.19...ui-v0.12.20) (2022-04-12)
 
 **Note:** Version bump only for package @parca/profile

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@parca/profile",
-  "version": "0.12.20",
+  "version": "0.12.23",
   "description": "Profile viewing libraries",
   "dependencies": {
     "@parca/client": "^0.12.20",
@@ -19,5 +19,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "72da90d95cc53eda749dbb5dd6b2ea24fe2e6ca2"
+  "gitHead": "adfe17cad5627ceb7e3ba6ffa0a3806bf8b7b8b4"
 }

package/src/IcicleGraph.tsx

@@ -5,8 +5,9 @@ import {scaleLinear} from 'd3-scale';
 import {Flamegraph, FlamegraphNode, FlamegraphRootNode} from '@parca/client';
 import {usePopper} from 'react-popper';
 import {getLastItem, valueFormatter} from '@parca/functions';
+import {useAppSelector, selectDarkMode} from '@parca/store';
 
-const RowHeight = 20;
+const RowHeight = 26;
 
 const icicleRectStyles = {
   cursor: 'pointer',
@@ -65,7 +66,7 @@ function IcicleRect({
       />
       {width > 5 && (
         <svg width={width - 5} height={height}>
-          <text x={5} y={13} style={{fontSize: '12px'}}>
+          <text x={5} y={15} style={{fontSize: '12px'}}>
             {name}
           </text>
         </svg>
@@ -90,22 +91,6 @@ interface IcicleGraphNodesProps {
   xScale: (value: number) => number;
 }
 
-function diffColor(diff: number, cumulative: number): string {
-  const prevValue = cumulative - diff;
-  const diffRatio = prevValue > 0 ? (Math.abs(diff) > 0 ? diff / prevValue : 0) : 1.0;
-
-  const diffTransparency =
-    Math.abs(diff) > 0 ? Math.min((Math.abs(diffRatio) / 2 + 0.5) * 0.8, 0.8) : 0;
-  const color =
-    diff === 0
-      ? '#90c7e0'
-      : diff > 0
-      ? `rgba(221, 46, 69, ${diffTransparency})`
-      : `rgba(59, 165, 93, ${diffTransparency})`;
-
-  return color;
-}
-
 export function nodeLabel(node: FlamegraphNode.AsObject): string {
   if (node.meta === undefined) return '<unknown>';
   const mapping = `${
@@ -126,6 +111,26 @@ export function nodeLabel(node: FlamegraphNode.AsObject): string {
   return fallback === '' ? '<unknown>' : fallback;
 }
 
+function diffColor(diff: number, cumulative: number, isDarkMode: boolean): string {
+  const prevValue = cumulative - diff;
+  const diffRatio = prevValue > 0 ? (Math.abs(diff) > 0 ? diff / prevValue : 0) : 1.0;
+
+  const diffTransparency =
+    Math.abs(diff) > 0 ? Math.min((Math.abs(diffRatio) / 2 + 0.5) * 0.8, 0.8) : 0;
+
+  const newSpanColor = isDarkMode ? '#B3BAE1' : '#929FEB';
+  const increasedSpanColor = isDarkMode
+    ? `rgba(255, 177, 204, ${diffTransparency})`
+    : `rgba(254, 153, 187, ${diffTransparency})`;
+  const reducedSpanColor = isDarkMode
+    ? `rgba(103, 158, 92, ${diffTransparency})`
+    : `rgba(164, 214, 153, ${diffTransparency})`;
+
+  const color = diff === 0 ? newSpanColor : diff > 0 ? increasedSpanColor : reducedSpanColor;
+
+  return color;
+}
+
 export function IcicleGraphNodes({
   data,
   x,
@@ -139,6 +144,8 @@ export function IcicleGraphNodes({
   setCurPath,
   curPath,
 }: IcicleGraphNodesProps) {
+  const isDarkMode = useAppSelector(selectDarkMode);
+
   const nodes =
     curPath.length === 0 ? data : data.filter(d => d != null && curPath[0] === nodeLabel(d));
 
@@ -163,7 +170,7 @@ export function IcicleGraphNodes({
         const name = nodeLabel(d);
         const nextPath = path.concat([name]);
 
-        const color = diffColor(d.diff === undefined ? 0 : d.diff, d.cumulative);
+        const color = diffColor(d.diff === undefined ? 0 : d.diff, d.cumulative, isDarkMode);
 
         const onClick = () => {
           setCurPath(nextPath);
@@ -437,7 +444,9 @@ export function IcicleGraphRootNode({
   setCurPath,
   curPath,
 }: IcicleGraphRootNodeProps) {
-  const color = diffColor(node.diff === undefined ? 0 : node.diff, node.cumulative);
+  const isDarkMode = useAppSelector(selectDarkMode);
+
+  const color = diffColor(node.diff === undefined ? 0 : node.diff, node.cumulative, isDarkMode);
 
   const onClick = () => setCurPath([]);
   const onMouseEnter = () => setHoveringNode(node);
@@ -521,7 +530,13 @@ export default function IcicleGraph({graph, width, setCurPath, curPath}: IcicleG
         hoveringNode={hoveringNode}
         contextElement={svg.current}
       />
-      <svg width={width} height={height} onMouseMove={onMouseMove} ref={svg}>
+      <svg
+        className="font-robotoMono"
+        width={width}
+        height={height}
+        onMouseMove={onMouseMove}
+        ref={svg}
+      >
         <g ref={ref}>
           <MemoizedIcicleGraphRootNode
             node={graph.root}

package/src/TopTable.tsx

@@ -167,7 +167,7 @@ export const TopTable = ({queryClient, profileSource}: ProfileViewProps): JSX.El
 
   return (
     <>
-      <div className="w-full">
+      <div className="w-full font-robotoMono">
         <table className="iciclegraph-table table-fixed text-left w-full divide-y divide-gray-200 dark:divide-gray-700">
           <thead className="bg-gray-50 dark:bg-gray-800">
             <tr>