@parca/profile 0.12.13 → 0.12.23

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.12.23](https://github.com/parca-dev/parca/compare/ui-v0.12.22...ui-v0.12.23) (2022-04-25)
+
+**Note:** Version bump only for package @parca/profile
+
+## [0.12.20](https://github.com/parca-dev/parca/compare/ui-v0.12.19...ui-v0.12.20) (2022-04-12)
+
+**Note:** Version bump only for package @parca/profile
+
+## [0.12.14](https://github.com/parca-dev/parca/compare/ui-v0.12.13...ui-v0.12.14) (2022-04-06)
+
+**Note:** Version bump only for package @parca/profile
+
 ## [0.12.13](https://github.com/parca-dev/parca/compare/ui-v0.12.12...ui-v0.12.13) (2022-04-05)
 
 **Note:** Version bump only for package @parca/profile

package/package.json

@@ -1,9 +1,9 @@
 {
   "name": "@parca/profile",
-  "version": "0.12.13",
+  "version": "0.12.23",
   "description": "Profile viewing libraries",
   "dependencies": {
-    "@parca/client": "^0.12.12",
+    "@parca/client": "^0.12.20",
     "@parca/dynamicsize": "^0.12.0",
     "@parca/parser": "^0.12.3",
     "d3-scale": "^4.0.2"
@@ -19,5 +19,5 @@
     "access": "public",
     "registry": "https://registry.npmjs.org/"
   },
-  "gitHead": "d75d40dee66420f703879f7b572d5f14ec09cce8"
+  "gitHead": "adfe17cad5627ceb7e3ba6ffa0a3806bf8b7b8b4"
 }

package/src/IcicleGraph.tsx

@@ -5,8 +5,9 @@ import {scaleLinear} from 'd3-scale';
 import {Flamegraph, FlamegraphNode, FlamegraphRootNode} from '@parca/client';
 import {usePopper} from 'react-popper';
 import {getLastItem, valueFormatter} from '@parca/functions';
+import {useAppSelector, selectDarkMode} from '@parca/store';
 
-const RowHeight = 20;
+const RowHeight = 26;
 
 const icicleRectStyles = {
   cursor: 'pointer',
@@ -65,7 +66,7 @@ function IcicleRect({
       />
       {width > 5 && (
         <svg width={width - 5} height={height}>
-          <text x={5} y={13} style={{fontSize: '12px'}}>
+          <text x={5} y={15} style={{fontSize: '12px'}}>
             {name}
           </text>
         </svg>
@@ -90,22 +91,6 @@ interface IcicleGraphNodesProps {
   xScale: (value: number) => number;
 }
 
-function diffColor(diff: number, cumulative: number): string {
-  const prevValue = cumulative - diff;
-  const diffRatio = prevValue > 0 ? (Math.abs(diff) > 0 ? diff / prevValue : 0) : 1.0;
-
-  const diffTransparency =
-    Math.abs(diff) > 0 ? Math.min((Math.abs(diffRatio) / 2 + 0.5) * 0.8, 0.8) : 0;
-  const color =
-    diff === 0
-      ? '#90c7e0'
-      : diff > 0
-      ? `rgba(221, 46, 69, ${diffTransparency})`
-      : `rgba(59, 165, 93, ${diffTransparency})`;
-
-  return color;
-}
-
 export function nodeLabel(node: FlamegraphNode.AsObject): string {
   if (node.meta === undefined) return '<unknown>';
   const mapping = `${
@@ -126,6 +111,26 @@ export function nodeLabel(node: FlamegraphNode.AsObject): string {
   return fallback === '' ? '<unknown>' : fallback;
 }
 
+function diffColor(diff: number, cumulative: number, isDarkMode: boolean): string {
+  const prevValue = cumulative - diff;
+  const diffRatio = prevValue > 0 ? (Math.abs(diff) > 0 ? diff / prevValue : 0) : 1.0;
+
+  const diffTransparency =
+    Math.abs(diff) > 0 ? Math.min((Math.abs(diffRatio) / 2 + 0.5) * 0.8, 0.8) : 0;
+
+  const newSpanColor = isDarkMode ? '#B3BAE1' : '#929FEB';
+  const increasedSpanColor = isDarkMode
+    ? `rgba(255, 177, 204, ${diffTransparency})`
+    : `rgba(254, 153, 187, ${diffTransparency})`;
+  const reducedSpanColor = isDarkMode
+    ? `rgba(103, 158, 92, ${diffTransparency})`
+    : `rgba(164, 214, 153, ${diffTransparency})`;
+
+  const color = diff === 0 ? newSpanColor : diff > 0 ? increasedSpanColor : reducedSpanColor;
+
+  return color;
+}
+
 export function IcicleGraphNodes({
   data,
   x,
@@ -139,6 +144,8 @@ export function IcicleGraphNodes({
   setCurPath,
   curPath,
 }: IcicleGraphNodesProps) {
+  const isDarkMode = useAppSelector(selectDarkMode);
+
   const nodes =
     curPath.length === 0 ? data : data.filter(d => d != null && curPath[0] === nodeLabel(d));
 
@@ -163,7 +170,7 @@ export function IcicleGraphNodes({
         const name = nodeLabel(d);
         const nextPath = path.concat([name]);
 
-        const color = diffColor(d.diff === undefined ? 0 : d.diff, d.cumulative);
+        const color = diffColor(d.diff === undefined ? 0 : d.diff, d.cumulative, isDarkMode);
 
         const onClick = () => {
           setCurPath(nextPath);
@@ -437,7 +444,9 @@ export function IcicleGraphRootNode({
   setCurPath,
   curPath,
 }: IcicleGraphRootNodeProps) {
-  const color = diffColor(node.diff === undefined ? 0 : node.diff, node.cumulative);
+  const isDarkMode = useAppSelector(selectDarkMode);
+
+  const color = diffColor(node.diff === undefined ? 0 : node.diff, node.cumulative, isDarkMode);
 
   const onClick = () => setCurPath([]);
   const onMouseEnter = () => setHoveringNode(node);
@@ -521,7 +530,13 @@ export default function IcicleGraph({graph, width, setCurPath, curPath}: IcicleG
         hoveringNode={hoveringNode}
         contextElement={svg.current}
       />
-      <svg width={width} height={height} onMouseMove={onMouseMove} ref={svg}>
+      <svg
+        className="font-robotoMono"
+        width={width}
+        height={height}
+        onMouseMove={onMouseMove}
+        ref={svg}
+      >
         <g ref={ref}>
           <MemoizedIcicleGraphRootNode
             node={graph.root}

package/src/ProfileView.tsx

@@ -236,7 +236,7 @@ export const ProfileView = ({
               </div>
             </div>
 
-            <div className="flex space-x-4">
+            <div className="flex space-x-4 justify-between">
               {currentView === 'icicle' && (
                 <div className="w-full">
                   <CalcWidth throttle={300} delay={2000}>

package/src/TopTable.tsx

@@ -9,6 +9,7 @@ import {
 import * as parca_query_v1alpha1_query_pb from '@parca/client/src/parca/query/v1alpha1/query_pb';
 import {getLastItem, valueFormatter} from '@parca/functions';
 import {useGrpcMetadata} from '@parca/components';
+import {useAppSelector, selectCompareMode} from '@parca/store';
 
 import {ProfileSource} from './ProfileSource';
 import './TopTable.styles.css';
@@ -138,6 +139,8 @@ export const TopTable = ({queryClient, profileSource}: ProfileViewProps): JSX.El
   const {response, error} = useQuery(queryClient, profileSource);
   const {items, requestSort, sortConfig} = useSortableData(response);
 
+  const compareMode = useAppSelector(selectCompareMode);
+
   const unit = response?.toObject().top?.unit as string;
 
   if (error != null) {
@@ -154,10 +157,18 @@ export const TopTable = ({queryClient, profileSource}: ProfileViewProps): JSX.El
     return sortConfig.key === name ? sortConfig.direction : undefined;
   };
 
+  const addPlusSign = (num: string) => {
+    if (num.charAt(0) === '0' || num.charAt(0) === '-') {
+      return num;
+    }
+
+    return `+${num}`;
+  };
+
   return (
     <>
-      <div className="w-full">
-        <table className="iciclegraph-table table-auto text-left w-full divide-y divide-gray-200 dark:divide-gray-700">
+      <div className="w-full font-robotoMono">
+        <table className="iciclegraph-table table-fixed text-left w-full divide-y divide-gray-200 dark:divide-gray-700">
           <thead className="bg-gray-50 dark:bg-gray-800">
             <tr>
               <th
@@ -170,7 +181,7 @@ export const TopTable = ({queryClient, profileSource}: ProfileViewProps): JSX.El
                 </span>
               </th>
               <th
-                className="text-left text-sm cursor-pointer pt-2 pb-2"
+                className="text-right text-sm cursor-pointer pt-2 pb-2 w-[150px]"
                 onClick={() => requestSort('flat')}
               >
                 Flat
@@ -179,7 +190,7 @@ export const TopTable = ({queryClient, profileSource}: ProfileViewProps): JSX.El
                 </span>
               </th>
               <th
-                className="text-right text-sm cursor-pointer pt-2 pb-2 pr-2"
+                className="text-right text-sm cursor-pointer pt-2 pb-2 pr-2 w-[150px]"
                 onClick={() => requestSort('cumulative')}
               >
                 Cumulative
@@ -189,32 +200,34 @@ export const TopTable = ({queryClient, profileSource}: ProfileViewProps): JSX.El
                   <Arrow direction={getClassNamesFor('cumulative')} />
                 </span>
               </th>
-              <th
-                className="text-right text-sm cursor-pointer pt-2 pb-2 pr-2"
-                onClick={() => requestSort('diff')}
-              >
-                Diff
-                <span className={`inline-block align-middle ml-2 ${getClassNamesFor('diff')}`}>
-                  <Arrow direction={getClassNamesFor('diff')} />
-                </span>
-              </th>
+              {compareMode && (
+                <th
+                  className="text-right text-sm cursor-pointer pt-2 pb-2 pr-2 w-[150px]"
+                  onClick={() => requestSort('diff')}
+                >
+                  Diff
+                  <span className={`inline-block align-middle ml-2 ${getClassNamesFor('diff')}`}>
+                    <Arrow direction={getClassNamesFor('diff')} />
+                  </span>
+                </th>
+              )}
             </tr>
           </thead>
           <tbody className="bg-white divide-y divide-gray-200 dark:bg-gray-900 dark:divide-gray-700">
             {items?.map((report, index) => (
               <tr key={index} className="hover:bg-[#62626212] dark:hover:bg-[#ffffff12]">
-                <td className="text-xs py-1.5 pl-2 min-w-[150px] max-w-[450px]">
-                  {RowLabel(report.meta)}
-                </td>
-                <td className="text-xs min-w-[150px] max-w-[150px] py-1.5 text-right">
+                <td className="text-xs py-1.5 pl-2">{RowLabel(report.meta)}</td>
+                <td className="text-xs py-1.5 text-right">
                   {valueFormatter(report.flat, unit, 2)}
                 </td>
-                <td className="text-xs min-w-[150px] max-w-[150px] py-1.5 text-right pr-2">
+                <td className="text-xs py-1.5 text-right pr-2">
                   {valueFormatter(report.cumulative, unit, 2)}
                 </td>
-                <td className="text-xs min-w-[150px] max-w-[150px] py-1.5 text-right pr-2">
-                  {valueFormatter(report.diff, unit, 2)}
-                </td>
+                {compareMode && (
+                  <td className="text-xs py-1.5 text-right pr-2">
+                    {addPlusSign(valueFormatter(report.diff, unit, 2))}
+                  </td>
+                )}
               </tr>
             ))}
           </tbody>