@parall/codex-agent 1.30.0 → 1.32.0

package/src/event-mapping.ts

@@ -1,4 +1,4 @@
-import type { RuntimeEvent } from "@parall/agent-core";
+import type { RuntimeEvent } from '@parall/agent-core';
 
 /**
  * Translation layer between `codex app-server` JSON-RPC notifications and
@@ -31,39 +31,39 @@ export class EventMapper {
 
     switch (method) {
       // Streaming deltas are intentionally dropped — see the class comment.
-      case "item/agentMessage/delta":
-      case "item/reasoning/textDelta":
-      case "item/reasoning/summaryTextDelta":
+      case 'item/agentMessage/delta':
+      case 'item/reasoning/textDelta':
+      case 'item/reasoning/summaryTextDelta':
         break;
 
-      case "item/started": {
+      case 'item/started': {
         const item = p.item as Record<string, unknown> | undefined;
-        if (!item || typeof item.type !== "string") break;
-        events.push(...this.mapItem(item, "started"));
+        if (!item || typeof item.type !== 'string') break;
+        events.push(...this.mapItem(item, 'started'));
         break;
       }
 
-      case "item/completed": {
+      case 'item/completed': {
         const item = p.item as Record<string, unknown> | undefined;
-        if (!item || typeof item.type !== "string") break;
-        events.push(...this.mapItem(item, "completed"));
+        if (!item || typeof item.type !== 'string') break;
+        events.push(...this.mapItem(item, 'completed'));
         break;
       }
 
-      case "turn/completed": {
+      case 'turn/completed': {
         const turn = p.turn as Record<string, unknown> | undefined;
         const status = turn ? asString(turn.status) : undefined;
         const error = turn?.error as Record<string, unknown> | undefined;
-        if (status === "failed") {
-          const message = asString(error?.message) ?? "Codex turn failed";
-          events.push({ type: "error", message });
+        if (status === 'failed') {
+          const message = asString(error?.message) ?? 'Codex turn failed';
+          events.push({ type: 'error', message });
         }
         break;
       }
 
-      case "error": {
-        const message = asString(p.message) ?? "Codex error";
-        events.push({ type: "error", message });
+      case 'error': {
+        const message = asString(p.message) ?? 'Codex error';
+        events.push({ type: 'error', message });
         break;
       }
     }
@@ -71,75 +71,82 @@ export class EventMapper {
     return events;
   }
 
-  private mapItem(item: Record<string, unknown>, phase: "started" | "completed"): RuntimeEvent[] {
+  private mapItem(item: Record<string, unknown>, phase: 'started' | 'completed'): RuntimeEvent[] {
     const type = asString(item.type);
     const id = asString(item.id);
     const now = Date.now();
 
-    if (type === "agentMessage") {
-      if (phase !== "completed") return [];
+    if (type === 'agentMessage') {
+      if (phase !== 'completed') return [];
       const text = asString(item.text);
       if (!text) return [];
       // Layer 0 symmetric output contract: plain text is never auto-projected;
       // agents must explicitly call `@parall/cli messages send` / `dm` to reach
       // the chat. The text is still recorded as a session step for audit.
-      return [{ type: "text", text, project: false }];
+      return [{ type: 'text', text, project: false }];
     }
 
-    if (type === "reasoning") {
-      if (phase !== "completed") return [];
+    if (type === 'reasoning') {
+      if (phase !== 'completed') return [];
       const text = joinReasoningText(item);
       if (!text) return [];
-      return [{ type: "thinking", text }];
+      return [{ type: 'thinking', text }];
     }
 
-    if (type === "commandExecution") {
+    if (type === 'commandExecution') {
       const command = formatCommand(item.command);
       const callId = id ?? `shell-${now}`;
-      if (phase === "started") {
+      if (phase === 'started') {
         this.toolCallStart.set(callId, now);
-        return [{
-          type: "tool_call",
-          callId,
-          toolName: "shell",
-          input: { command, cwd: asString(item.cwd) },
-          startedAt: new Date(now).toISOString(),
-        }];
+        return [
+          {
+            type: 'tool_call',
+            callId,
+            toolName: 'shell',
+            input: { command, cwd: asString(item.cwd) },
+            startedAt: new Date(now).toISOString(),
+          },
+        ];
       }
       // Codex app-server uses camelCase: aggregatedOutput / exitCode / durationMs
       // (see openai/codex codex-rs/app-server-protocol). Earlier snake_case
       // probing dropped exit codes and split outputs that arrive as one string.
       const durationMs = this.resolveDuration(callId, now, item.durationMs);
       const output = asString(item.aggregatedOutput) ?? joinStreams(item.stdout, item.stderr);
-      const exitCode = typeof item.exitCode === "number" ? item.exitCode : undefined;
+      const exitCode = typeof item.exitCode === 'number' ? item.exitCode : undefined;
       const status = asString(item.status);
-      const failed = (exitCode !== undefined && exitCode !== 0)
-        || status === "failed"
-        || status === "declined";
-      return [{
-        type: "tool_result",
-        callId,
-        toolName: "shell",
-        output,
-        ...(failed ? { error: output || `shell ${status ?? "exited"} (code=${exitCode ?? "?"})` } : {}),
-        ...(durationMs !== undefined ? { durationMs } : {}),
-      }];
+      const failed =
+        (exitCode !== undefined && exitCode !== 0) || status === 'failed' || status === 'declined';
+      return [
+        {
+          type: 'tool_result',
+          callId,
+          toolName: 'shell',
+          output,
+          ...(failed
+            ? { error: output || `shell ${status ?? 'exited'} (code=${exitCode ?? '?'})` }
+            : {}),
+          ...(durationMs !== undefined ? { durationMs } : {}),
+        },
+      ];
     }
 
-    if (type === "mcpToolCall") {
+    if (type === 'mcpToolCall') {
       const server = asString(item.server);
       const tool = asString(item.tool);
-      const toolName = server && tool ? `${server}:${tool}` : tool ?? server ?? "mcp";
+      const toolName = server && tool ? `${server}:${tool}` : (tool ?? server ?? 'mcp');
       const callId = id ?? `mcp-${now}`;
-      if (phase === "started") {
+      if (phase === 'started') {
         this.toolCallStart.set(callId, now);
-        return [{
-          type: "tool_call",
-          callId,
-          toolName,
-          input: item.arguments ?? {},
-          startedAt: new Date(now).toISOString(),
-        }];
+        return [
+          {
+            type: 'tool_call',
+            callId,
+            toolName,
+            input: item.arguments ?? {},
+            startedAt: new Date(now).toISOString(),
+          },
+        ];
       }
       const durationMs = this.resolveDuration(callId, now, item.durationMs);
       const result = item.result;
@@ -148,64 +155,73 @@ export class EventMapper {
       // success path renders an empty-quoted output and the failure path's
       // `output || "MCP tool call failed"` fallback gets eaten because the
       // literal `'""'` is truthy.
-      const output = result == null
-        ? ""
-        : typeof result === "string" ? result : JSON.stringify(result);
+      const output =
+        result == null ? '' : typeof result === 'string' ? result : JSON.stringify(result);
       const success = item.isSuccess !== false;
-      return [{
-        type: "tool_result",
-        callId,
-        toolName,
-        output,
-        ...(success ? {} : { error: output || "MCP tool call failed" }),
-        ...(durationMs !== undefined ? { durationMs } : {}),
-      }];
+      return [
+        {
+          type: 'tool_result',
+          callId,
+          toolName,
+          output,
+          ...(success ? {} : { error: output || 'MCP tool call failed' }),
+          ...(durationMs !== undefined ? { durationMs } : {}),
+        },
+      ];
     }
 
-    if (type === "fileChange") {
+    if (type === 'fileChange') {
       const callId = id ?? `patch-${now}`;
-      if (phase === "started") {
+      if (phase === 'started') {
         this.toolCallStart.set(callId, now);
-        return [{
-          type: "tool_call",
-          callId,
-          toolName: "patch",
-          input: { changes: item.changes ?? [] },
-          startedAt: new Date(now).toISOString(),
-        }];
+        return [
+          {
+            type: 'tool_call',
+            callId,
+            toolName: 'patch',
+            input: { changes: item.changes ?? [] },
+            startedAt: new Date(now).toISOString(),
+          },
+        ];
       }
       const durationMs = this.resolveDuration(callId, now, undefined);
-      return [{
-        type: "tool_result",
-        callId,
-        toolName: "patch",
-        output: "",
-        ...(durationMs !== undefined ? { durationMs } : {}),
-      }];
+      return [
+        {
+          type: 'tool_result',
+          callId,
+          toolName: 'patch',
+          output: '',
+          ...(durationMs !== undefined ? { durationMs } : {}),
+        },
+      ];
     }
 
-    if (type === "webSearch") {
+    if (type === 'webSearch') {
       const callId = id ?? `search-${now}`;
-      if (phase === "started") {
+      if (phase === 'started') {
         this.toolCallStart.set(callId, now);
-        return [{
-          type: "tool_call",
-          callId,
-          toolName: "web_search",
-          input: { query: asString(item.query) ?? "" },
-          startedAt: new Date(now).toISOString(),
-        }];
+        return [
+          {
+            type: 'tool_call',
+            callId,
+            toolName: 'web_search',
+            input: { query: asString(item.query) ?? '' },
+            startedAt: new Date(now).toISOString(),
+          },
+        ];
       }
       const durationMs = this.resolveDuration(callId, now, item.durationMs);
       const results = Array.isArray(item.results) ? item.results : [];
-      const output = results.length > 0 ? JSON.stringify(results) : "";
-      return [{
-        type: "tool_result",
-        callId,
-        toolName: "web_search",
-        output,
-        ...(durationMs !== undefined ? { durationMs } : {}),
-      }];
+      const output = results.length > 0 ? JSON.stringify(results) : '';
+      return [
+        {
+          type: 'tool_result',
+          callId,
+          toolName: 'web_search',
+          output,
+          ...(durationMs !== undefined ? { durationMs } : {}),
+        },
+      ];
     }
 
     return [];
@@ -217,10 +233,14 @@ export class EventMapper {
    * tracked start timestamp so long-lived bridges don't accumulate stale
    * entries when the server routinely supplies durationMs.
    */
-  private resolveDuration(callId: string, now: number, serverDurationMs: unknown): number | undefined {
+  private resolveDuration(
+    callId: string,
+    now: number,
+    serverDurationMs: unknown,
+  ): number | undefined {
     const start = this.toolCallStart.get(callId);
     this.toolCallStart.delete(callId);
-    if (typeof serverDurationMs === "number" && Number.isFinite(serverDurationMs)) {
+    if (typeof serverDurationMs === 'number' && Number.isFinite(serverDurationMs)) {
       return Math.max(0, serverDurationMs);
     }
     if (start === undefined) return undefined;
@@ -229,30 +249,36 @@ export class EventMapper {
 }
 
 function asString(value: unknown): string | undefined {
-  if (typeof value !== "string") return undefined;
+  if (typeof value !== 'string') return undefined;
   const trimmed = value.trim();
   return trimmed.length > 0 ? trimmed : undefined;
 }
 
 function joinReasoningText(item: Record<string, unknown>): string {
-  const summary = Array.isArray(item.summary) ? item.summary.filter((x) => typeof x === "string") : [];
-  const content = Array.isArray(item.content) ? item.content.filter((x) => typeof x === "string") : [];
+  const summary = Array.isArray(item.summary)
+    ? item.summary.filter((x) => typeof x === 'string')
+    : [];
+  const content = Array.isArray(item.content)
+    ? item.content.filter((x) => typeof x === 'string')
+    : [];
   const parts = [...summary, ...content, asString(item.text)].filter(Boolean) as string[];
-  return parts.join("\n").trim();
+  return parts.join('\n').trim();
 }
 
 function joinStreams(stdout: unknown, stderr: unknown): string {
   const out = asString(stdout);
   const err = asString(stderr);
   if (out && err) return `${out}\n${err}`;
-  return out ?? err ?? "";
+  return out ?? err ?? '';
 }
 
 /** Codex sends `command` either as a plain string or as an argv array (e.g. ["sh", "-c", "ls"]). */
 function formatCommand(command: unknown): string {
-  if (typeof command === "string") return command;
+  if (typeof command === 'string') return command;
   if (Array.isArray(command)) {
-    return command.map((part) => (typeof part === "string" ? part : JSON.stringify(part))).join(" ");
+    return command
+      .map((part) => (typeof part === 'string' ? part : JSON.stringify(part)))
+      .join(' ');
   }
-  return "";
+  return '';
 }