@papi-ai/server 0.7.13 → 0.7.14

package/dist/index.js

@@ -10,7 +10,12 @@ var __export = (target, all) => {
 };
 
 // ../shared/dist/index.js
-var VALID_TRANSITIONS;
+function isLiveDecision(d) {
+  if (d.superseded === true) return false;
+  if (d.outcome != null && RETIRED_DECISION_OUTCOMES.includes(d.outcome)) return false;
+  return true;
+}
+var VALID_TRANSITIONS, RETIRED_DECISION_OUTCOMES;
 var init_dist = __esm({
   "../shared/dist/index.js"() {
     "use strict";
@@ -25,6 +30,7 @@ var init_dist = __esm({
       "Cancelled": [],
       "Deferred": ["Backlog", "Cancelled"]
     };
+    RETIRED_DECISION_OUTCOMES = ["resolved", "abandoned", "superseded"];
   }
 });
 
@@ -1441,12 +1447,13 @@ async function detectReviewPatterns(reviews, currentCycle, window = 5, clusterer
 function hasReviewPatterns(patterns) {
   return patterns.recurringFeedback.length > 0 || patterns.requestChangesRate >= 50;
 }
-var VALID_TRANSITIONS2, TASK_TYPE_TIERS, VALID_EFFORT_SIZES, SECTION_HEADERS, YAML_MARKER, YAML_START, YAML_END, VALID_EFFORT_SIZES2, HEADER_SENTINEL, TABLE_HEADER, TABLE_SEPARATOR, PREV_TABLE_HEADER, LEGACY_TABLE_HEADER, SECTION_HEADING, FILE_TEMPLATE, COST_SECTION_HEADING, COST_TABLE_SEPARATOR, FILE_HEADING, ACCURACY_HEADER, ACCURACY_SEPARATOR, VELOCITY_HEADER, VELOCITY_SEPARATOR, EFFORT_SCALE, NONE_PATTERN, HEADER_SENTINEL2, VALID_STAGES, VALID_VERDICTS, STAGE_DISPLAY, VALID_STATUSES, PHASES_START, PHASES_END, YAML_MARKER2, YAML_START2, YAML_END2, VALID_STATUSES2, YAML_MARKER3, YAML_START3, YAML_END3, MdFileAdapter, NONE_PATTERN2;
+var VALID_TRANSITIONS2, isLiveDecision2, TASK_TYPE_TIERS, VALID_EFFORT_SIZES, SECTION_HEADERS, YAML_MARKER, YAML_START, YAML_END, VALID_EFFORT_SIZES2, HEADER_SENTINEL, TABLE_HEADER, TABLE_SEPARATOR, PREV_TABLE_HEADER, LEGACY_TABLE_HEADER, SECTION_HEADING, FILE_TEMPLATE, COST_SECTION_HEADING, COST_TABLE_SEPARATOR, FILE_HEADING, ACCURACY_HEADER, ACCURACY_SEPARATOR, VELOCITY_HEADER, VELOCITY_SEPARATOR, EFFORT_SCALE, NONE_PATTERN, HEADER_SENTINEL2, VALID_STAGES, VALID_VERDICTS, STAGE_DISPLAY, VALID_STATUSES, PHASES_START, PHASES_END, YAML_MARKER2, YAML_START2, YAML_END2, VALID_STATUSES2, YAML_MARKER3, YAML_START3, YAML_END3, MdFileAdapter, NONE_PATTERN2;
 var init_dist2 = __esm({
   "../adapter-md/dist/index.js"() {
     "use strict";
     init_dist();
     VALID_TRANSITIONS2 = VALID_TRANSITIONS;
+    isLiveDecision2 = isLiveDecision;
     TASK_TYPE_TIERS = {
       bug: 1,
       task: 1,
@@ -1557,11 +1564,18 @@ ${TABLE_SEPARATOR}
       async getCycleHealth() {
         return parseCycleHealth(await this.read("PLANNING_LOG.md"));
       }
-      /** Read all Active Decisions from ACTIVE_DECISIONS.md. */
-      async getActiveDecisions() {
+      /**
+       * Read Active Decisions from ACTIVE_DECISIONS.md.
+       *
+       * Default filters out retired ADs (outcome ∈ abandoned/superseded/resolved or superseded=true).
+       * Pass { includeRetired: true } for management/triage surfaces. See PapiAdapter docstring.
+       */
+      async getActiveDecisions(options) {
         const content = await this.readOptional("ACTIVE_DECISIONS.md");
         if (!content) return [];
-        return parseActiveDecisions(content);
+        const all = parseActiveDecisions(content);
+        if (options?.includeRetired) return all;
+        return all.filter(isLiveDecision2);
       }
       /** Read cycle log entries (newest first), optionally limited to {@link limit} entries. */
       async getCycleLog(limit) {
@@ -6352,11 +6366,31 @@ EXCEPTION WHEN duplicate_object THEN NULL; END $$;
           lastFullMode: 0
         };
       }
-      async getActiveDecisions() {
+      /**
+       * Read Active Decisions for this project.
+       *
+       * Default filters out retired ADs (outcome ∈ abandoned/superseded/resolved or superseded=true).
+       * Pass { includeRetired: true } for management/triage surfaces. See PapiAdapter docstring.
+       *
+       * task-1546 (C242 hot-fix): closes the bug where retired ADs leaked into context surfaces.
+       */
+      async getActiveDecisions(options) {
+        if (options?.includeRetired) {
+          const rows2 = await this.sql`
+        SELECT id, display_id, title, confidence, superseded, superseded_by, created_cycle, modified_cycle, body, outcome, revision_count
+        FROM active_decisions
+        WHERE project_id = ${this.projectId}
+        ORDER BY display_id
+        LIMIT 200
+      `;
+          return rows2.map(rowToActiveDecision);
+        }
         const rows = await this.sql`
       SELECT id, display_id, title, confidence, superseded, superseded_by, created_cycle, modified_cycle, body, outcome, revision_count
       FROM active_decisions
       WHERE project_id = ${this.projectId}
+        AND superseded = false
+        AND (outcome IS NULL OR outcome NOT IN ('abandoned', 'superseded', 'resolved'))
       ORDER BY display_id
       LIMIT 200 -- bounded: ADs are bounded by project lifecycle, 200 is a safe ceiling
     `;
@@ -8575,8 +8609,8 @@ Check PAPI_PROJECT_ID in your .mcp.json config. Find your project ID in the PAPI
       getCycleHealth() {
         return this.invoke("getCycleHealth");
       }
-      getActiveDecisions() {
-        return this.invoke("getActiveDecisions");
+      getActiveDecisions(options) {
+        return this.invoke("getActiveDecisions", [options ?? {}]);
       }
       getCycleLog(limit) {
         return this.invoke("getCycleLog", [limit]);
@@ -10535,6 +10569,20 @@ async function sendSlackWebhook(webhookUrl, summary, header = "PAPI Strategy Rev
 }
 
 // src/prompts.ts
+var AD_REJECTION_RULES = `**AD Minting Guard \u2014 REJECT observations dressed as decisions.**
+
+An Active Decision expresses a *stance* the project is taking \u2014 a choice between alternatives that constrains future work. Reject any candidate AD whose body asserts:
+(a) the existence, identity, or status of a person, user, or external entity (e.g. "User X is building Y", "Customer Z is active");
+(b) a metric or measurement (e.g. "Signups grew 3x last cycle", "Latency dropped to 200ms");
+(c) a fact about the current state of the world that could be confirmed or denied by a query rather than challenged by argument (e.g. "External user feedback is now flowing", "The /admin route exists").
+
+If a candidate AD body could be invalidated by running a SQL query, refreshing a dashboard, or checking a log \u2014 it is an observation, not a decision. Capture it as a build report finding, a dogfood observation, a cycle log note, or a registered doc instead. Do NOT mint it as an AD.
+
+**Positive example (valid AD):** "Pricing tier strategy: free engine + paid intelligence. Decision: keep cycles free, charge for strategy reviews and analytics. Why: telemetry shows engagement clusters around intelligence surfaces, not engine surfaces." \u2014 this is a stance with alternatives.
+
+**Negative example (reject):** "External user feedback is now flowing. Stonebridge Systems is actively building." \u2014 this is a fact about the current state of the world. Capture as dogfood/signal observation; do not mint.
+
+This rule applies to: new ADs proposed during planning (Step 9), strategy review AD updates (section 5), and strategy_change AD updates. If you find an existing AD that violates this rule during housekeeping, propose deleting it (action: "delete") with a one-line rationale.`;
 var PLAN_SYSTEM = `You are the PAPI Cycle Planner \u2014 an autonomous planning engine for software projects.
 You receive project context and produce a planning cycle output with a BUILD HANDOFF.
 
@@ -10760,6 +10808,9 @@ Standard planning cycle with full board review.
 
 9. **Active Decisions** \u2014 If any AD needs updating: Type A (confidence change), Type B (modification), or Type C (reversal/supersede).
    **AD Quality Bar:** ADs are for product and architecture choices that constrain future work \u2014 technology selections, data model designs, UX principles, strategic positioning. They are NOT for: process preferences (commit style, PR size), configuration choices (linter rules, tab width), or temporary workarounds. If a decision doesn't affect what gets built or how it's architected, it's not an AD. Apply this bar when proposing new ADs and when triaging existing ones.
+
+${AD_REJECTION_RULES}
+
    **\u2192 PERSIST:** EVERY AD you created, updated, or confirmed with changes MUST appear in \`activeDecisions\` array in Part 2. Include the full replacement body with ### heading.
 
 ### Operational Quality Rules
@@ -10997,6 +11048,9 @@ Standard planning cycle with full board review.
 
 9. **Active Decisions** \u2014 If any AD needs updating: Type A (confidence change), Type B (modification), or Type C (reversal/supersede).
    **AD Quality Bar:** ADs are for product and architecture choices that constrain future work \u2014 technology selections, data model designs, UX principles, strategic positioning. They are NOT for: process preferences (commit style, PR size), configuration choices (linter rules, tab width), or temporary workarounds. If a decision doesn't affect what gets built or how it's architected, it's not an AD. Apply this bar when proposing new ADs and when triaging existing ones.
+
+${AD_REJECTION_RULES}
+
    **\u2192 PERSIST:** EVERY AD you created, updated, or confirmed with changes MUST appear in \`activeDecisions\` array in Part 2. Include the full replacement body with ### heading.
 
 ### Operational Quality Rules
@@ -11369,6 +11423,8 @@ You MUST cover these 5 sections. Each is mandatory.
    - Note any hierarchy/phase issues worth correcting (1-2 bullets max)
    - Delete ADs that are legacy, process-level, or redundant without discussion
 
+${AD_REJECTION_RULES}
+
 **Registered Documents:** If a "### Registered Documents" section is present in context, scan it for: (a) research findings that contradict current ADs or strategy, (b) unactioned research that should influence the next plan. Reference relevant docs by title in your review. If unregistered docs are listed, flag 1-2 that look strategically relevant and suggest registering them.
 
 ## CONDITIONAL SECTIONS (include only when genuinely useful \u2014 most reviews should have 0-2 of these)
@@ -11678,6 +11734,8 @@ The JSON must be valid. Only include ADs that need changes \u2014 omit unchanged
 For new ADs, use the next available AD number.
 The body field must be the COMPLETE replacement text for the AD block (including the ### heading line).
 
+${AD_REJECTION_RULES}
+
 ## PHASE UPDATES
 
 If the strategic change affects the project's phase structure, include a phaseUpdates array.
@@ -14140,7 +14198,8 @@ async function assembleContext2(adapter2, cycleNumber, cyclesSinceLastReview, pr
     docsWithPendingActions
   ] = await Promise.all([
     adapter2.readProductBrief(),
-    adapter2.getActiveDecisions(),
+    // Strategy review needs to see retired ADs to triage/restore them as needed.
+    adapter2.getActiveDecisions({ includeRetired: true }),
     adapter2.getBuildReportsSince(lastReviewCycleNum),
     adapter2.getCycleLogSince(lastReviewCycleNum),
     adapter2.queryBoard({
@@ -14642,7 +14701,7 @@ ${cleanContent}`;
   try {
     const recs = extractRecommendations(data, cycleNumber);
     if (recs.length > 0) {
-      const existingAds = await adapter2.getActiveDecisions().catch(() => []);
+      const existingAds = await adapter2.getActiveDecisions({ includeRetired: true }).catch(() => []);
       const existingAdIds = new Set(existingAds.map((ad) => ad.id));
       const filteredRecs = recs.filter((rec) => {
         if (rec.target && /^AD-\d+$/.test(rec.target)) {
@@ -15176,7 +15235,8 @@ async function prepareStrategyChange(adapter2, text) {
   try {
     const [brief, decisions, readPhases, boardTasks, reports, previousReviews] = await Promise.all([
       adapter2.readProductBrief(),
-      adapter2.getActiveDecisions(),
+      // Strategy review needs ALL ADs (live + retired) for housekeeping.
+      adapter2.getActiveDecisions({ includeRetired: true }),
       adapter2.readPhases(),
       adapter2.queryBoard().catch(() => []),
       adapter2.getRecentBuildReports(15).catch(() => []),
@@ -15221,7 +15281,7 @@ async function captureDecision(adapter2, input) {
     adId = input.adId;
     adAction = "updated";
   } else {
-    const existingAds = await adapter2.getActiveDecisions();
+    const existingAds = await adapter2.getActiveDecisions({ includeRetired: true });
     const maxNum = existingAds.reduce((max, ad) => {
       const match = ad.id.match(/^AD-(\d+)$/);
       return match ? Math.max(max, parseInt(match[1], 10)) : max;
@@ -17638,6 +17698,23 @@ function isNoHandoffError(err) {
 function isBlockedError(err) {
   return err instanceof Error && err.code === "BLOCKED";
 }
+function computeScopeDriftSignal(predicted, changed) {
+  if (!predicted || predicted.length === 0) return null;
+  if (changed.length === 0) return null;
+  const basename2 = (p) => {
+    const parts = p.split(/[\\/]/);
+    return parts[parts.length - 1] ?? p;
+  };
+  const predictedNames = new Set(predicted.map(basename2).filter(Boolean));
+  const unexpected = changed.filter((c) => !predictedNames.has(basename2(c)));
+  const fraction = unexpected.length / changed.length;
+  const triggered = fraction > 0.5 || unexpected.length > 5;
+  if (!triggered) return null;
+  const sample = unexpected.slice(0, 5).join(", ");
+  const more = unexpected.length > 5 ? ` (+${unexpected.length - 5} more)` : "";
+  const pct = Math.round(fraction * 100);
+  return `${unexpected.length}/${changed.length} changed files (${pct}%) outside FILES LIKELY TOUCHED: ${sample}${more}`;
+}
 function getUnresolvedDeps(task, allTasks) {
   if (!task.dependsOn) return [];
   const deps = task.dependsOn.split(",").map((d) => d.trim()).filter(Boolean);
@@ -17699,6 +17776,11 @@ async function startBuild(adapter2, config2, taskId, options = {}) {
   if (task.status === "Done" || task.status === "Archived") {
     throw new Error(`Task "${taskId}" (${task.title}) is already ${task.status}. Cannot execute a completed task.`);
   }
+  if (task.status === "In Review") {
+    throw new Error(
+      `Task "${taskId}" (${task.title}) is already In Review \u2014 it has been built and is awaiting sign-off. Run \`review_submit\` instead of re-building. If the build genuinely needs rework, use \`review_submit\` with verdict \`request-changes\` first.`
+    );
+  }
   if (!task.buildHandoff) {
     const err = new Error(`Task "${taskId}" (${task.title}) has no BUILD HANDOFF.`);
     err.code = "NO_HANDOFF";
@@ -18099,6 +18181,8 @@ async function completeBuild(adapter2, config2, taskId, input, options = {}) {
     const baseBranch = resolveBaseBranch(config2.projectRoot, config2.baseBranch);
     const changed = getFilesChangedFromBase(config2.projectRoot, baseBranch);
     if (changed.length > 0) report.filesChanged = changed;
+    const drift = computeScopeDriftSignal(task.buildHandoff?.filesLikelyTouched, changed);
+    if (drift) report.scopeDriftSignal = drift;
   }
   let prLines = [];
   if (options.light) {
@@ -18669,6 +18753,7 @@ function formatCompleteResult(result) {
     `**Discovered Issues:** ${result.report.discoveredIssues}`,
     `**Architecture Notes:** ${result.report.architectureNotes}`,
     ...result.report.deadEnds ? [`**Dead Ends:** ${result.report.deadEnds}`] : [],
+    ...result.report.scopeDriftSignal ? [`**Scope drift signal:** ${result.report.scopeDriftSignal}`] : [],
     `**Scope Accuracy:** ${result.scopeAccuracy}`,
     "",
     "---",
@@ -21365,7 +21450,7 @@ ${lines.join("\n")}`;
   }
   let decisionLifecycleSection = "";
   try {
-    const decisions = await adapter2.getActiveDecisions();
+    const decisions = await adapter2.getActiveDecisions({ includeRetired: true });
     const lifecycleSummary = formatDecisionLifecycleSummary(decisions);
     if (lifecycleSummary) {
       decisionLifecycleSection = `**Lifecycle:** ${lifecycleSummary}`;
@@ -22131,7 +22216,19 @@ ${versionDrift}` : "";
       const learnings = await adapter2.getCycleLearnings?.({ category: "issue", limit: 30 });
       if (learnings) {
         const byRecency = (a, b2) => (b2.createdAt ?? "").localeCompare(a.createdAt ?? "");
-        const unactionedAll = learnings.filter((l) => !l.actionTaken).map((l) => ({ ...l, severity: l.severity ?? "P3" }));
+        const candidateLearnings = learnings.filter((l) => !l.actionTaken);
+        const referencedTaskIds = Array.from(new Set(candidateLearnings.map((l) => l.taskId).filter(Boolean)));
+        let closedTaskIds = /* @__PURE__ */ new Set();
+        if (referencedTaskIds.length > 0) {
+          try {
+            const tasks = await adapter2.getTasks(referencedTaskIds);
+            closedTaskIds = new Set(
+              tasks.filter((t) => t.status === "Done" || t.status === "Cancelled").map((t) => t.id)
+            );
+          } catch {
+          }
+        }
+        const unactionedAll = candidateLearnings.filter((l) => !closedTaskIds.has(l.taskId)).map((l) => ({ ...l, severity: l.severity ?? "P3" }));
         const allAlerts = unactionedAll.filter((l) => l.severity === "P0" || l.severity === "P1").sort(byRecency);
         const allLowSev = unactionedAll.filter((l) => l.severity === "P2" || l.severity === "P3").sort(byRecency);
         const totalP2 = allLowSev.filter((l) => l.severity === "P2").length;

package/dist/prompts.js

@@ -1,4 +1,18 @@
 // src/prompts.ts
+var AD_REJECTION_RULES = `**AD Minting Guard \u2014 REJECT observations dressed as decisions.**
+
+An Active Decision expresses a *stance* the project is taking \u2014 a choice between alternatives that constrains future work. Reject any candidate AD whose body asserts:
+(a) the existence, identity, or status of a person, user, or external entity (e.g. "User X is building Y", "Customer Z is active");
+(b) a metric or measurement (e.g. "Signups grew 3x last cycle", "Latency dropped to 200ms");
+(c) a fact about the current state of the world that could be confirmed or denied by a query rather than challenged by argument (e.g. "External user feedback is now flowing", "The /admin route exists").
+
+If a candidate AD body could be invalidated by running a SQL query, refreshing a dashboard, or checking a log \u2014 it is an observation, not a decision. Capture it as a build report finding, a dogfood observation, a cycle log note, or a registered doc instead. Do NOT mint it as an AD.
+
+**Positive example (valid AD):** "Pricing tier strategy: free engine + paid intelligence. Decision: keep cycles free, charge for strategy reviews and analytics. Why: telemetry shows engagement clusters around intelligence surfaces, not engine surfaces." \u2014 this is a stance with alternatives.
+
+**Negative example (reject):** "External user feedback is now flowing. Stonebridge Systems is actively building." \u2014 this is a fact about the current state of the world. Capture as dogfood/signal observation; do not mint.
+
+This rule applies to: new ADs proposed during planning (Step 9), strategy review AD updates (section 5), and strategy_change AD updates. If you find an existing AD that violates this rule during housekeeping, propose deleting it (action: "delete") with a one-line rationale.`;
 var PLAN_SYSTEM = `You are the PAPI Cycle Planner \u2014 an autonomous planning engine for software projects.
 You receive project context and produce a planning cycle output with a BUILD HANDOFF.
 
@@ -224,6 +238,9 @@ Standard planning cycle with full board review.
 
 9. **Active Decisions** \u2014 If any AD needs updating: Type A (confidence change), Type B (modification), or Type C (reversal/supersede).
    **AD Quality Bar:** ADs are for product and architecture choices that constrain future work \u2014 technology selections, data model designs, UX principles, strategic positioning. They are NOT for: process preferences (commit style, PR size), configuration choices (linter rules, tab width), or temporary workarounds. If a decision doesn't affect what gets built or how it's architected, it's not an AD. Apply this bar when proposing new ADs and when triaging existing ones.
+
+${AD_REJECTION_RULES}
+
    **\u2192 PERSIST:** EVERY AD you created, updated, or confirmed with changes MUST appear in \`activeDecisions\` array in Part 2. Include the full replacement body with ### heading.
 
 ### Operational Quality Rules
@@ -461,6 +478,9 @@ Standard planning cycle with full board review.
 
 9. **Active Decisions** \u2014 If any AD needs updating: Type A (confidence change), Type B (modification), or Type C (reversal/supersede).
    **AD Quality Bar:** ADs are for product and architecture choices that constrain future work \u2014 technology selections, data model designs, UX principles, strategic positioning. They are NOT for: process preferences (commit style, PR size), configuration choices (linter rules, tab width), or temporary workarounds. If a decision doesn't affect what gets built or how it's architected, it's not an AD. Apply this bar when proposing new ADs and when triaging existing ones.
+
+${AD_REJECTION_RULES}
+
    **\u2192 PERSIST:** EVERY AD you created, updated, or confirmed with changes MUST appear in \`activeDecisions\` array in Part 2. Include the full replacement body with ### heading.
 
 ### Operational Quality Rules
@@ -833,6 +853,8 @@ You MUST cover these 5 sections. Each is mandatory.
    - Note any hierarchy/phase issues worth correcting (1-2 bullets max)
    - Delete ADs that are legacy, process-level, or redundant without discussion
 
+${AD_REJECTION_RULES}
+
 **Registered Documents:** If a "### Registered Documents" section is present in context, scan it for: (a) research findings that contradict current ADs or strategy, (b) unactioned research that should influence the next plan. Reference relevant docs by title in your review. If unregistered docs are listed, flag 1-2 that look strategically relevant and suggest registering them.
 
 ## CONDITIONAL SECTIONS (include only when genuinely useful \u2014 most reviews should have 0-2 of these)
@@ -1142,6 +1164,8 @@ The JSON must be valid. Only include ADs that need changes \u2014 omit unchanged
 For new ADs, use the next available AD number.
 The body field must be the COMPLETE replacement text for the AD block (including the ### heading line).
 
+${AD_REJECTION_RULES}
+
 ## PHASE UPDATES
 
 If the strategic change affects the project's phase structure, include a phaseUpdates array.
@@ -1438,6 +1462,7 @@ ${inputs.codebaseContext}
 Return a JSON array of 3-10 tasks based on gaps, improvements, and next steps visible from the codebase analysis above.`;
 }
 export {
+  AD_REJECTION_RULES,
   AD_SEED_SYSTEM,
   CONVENTIONS_SYSTEM,
   HANDOFF_REGEN_SYSTEM,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@papi-ai/server",
-  "version": "0.7.13",
+  "version": "0.7.14",
   "description": "PAPI MCP server — AI-powered sprint planning, build execution, and strategy review for software projects",
   "license": "Elastic-2.0",
   "type": "module",