@palmetto/pubsub 2.2.7 → 3.0.0

package/README.md

@@ -19,7 +19,7 @@ It is up to the pub/sub implementations what to do with rejected messages. Optio
 ## Installation
 
 ```sh
-yarn add @palmetto/pubsub zod
+yarn add @palmetto/pubsub zod @palmetto/trace dd-trace
 ```
 
 ## Usage
@@ -120,9 +120,9 @@ yarn add @palmetto/pubsub zod
 
    ```ts
    import tracer from "dd-trace";
-   import { registerDdTrace } from "@palmetto/pubsub";
+   import { registerDdTracer } from "@palmetto/trace";
 
-   registerDdTrace(tracer);
+   registerDdTracer(tracer);
    ```
 
 ### Message logging

package/dist/bullmq/subscriber.js

@@ -10,11 +10,11 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.BullMqSubscriber = exports.MessageRetryError = exports.MessageFailError = void 0;
+const trace_1 = require("@palmetto/trace");
 const interfaces_js_1 = require("../interfaces.js");
 const connection_js_1 = require("./connection.js");
 const lazy_load_js_1 = require("../lazy-load.js");
 const create_log_error_payload_js_1 = require("../create-log-error-payload.js");
-const dd_trace_api_1 = require("dd-trace-api");
 class SubscribedMessage {
     constructor(owner, worker, logger) {
         this.owner = owner;
@@ -65,7 +65,7 @@ class BullMqSubscriber {
                 context: "BullMqSubscriber",
             });
             const worker = new BullMqPackage.Worker(config.name, (job) => __awaiter(this, void 0, void 0, function* () {
-                return yield dd_trace_api_1.tracer.trace("pubsub.bullmq.handle", {
+                return yield (0, trace_1.getTracer)().trace("pubsub.bullmq.handle", {
                     resource: `handle ${config.name}`,
                 }, () => __awaiter(this, void 0, void 0, function* () {
                     const context = {

package/dist/publisher.js

@@ -13,9 +13,9 @@ exports.Publisher = void 0;
 const zod_1 = require("zod");
 const uuid_1 = require("uuid");
 const crypto_1 = require("crypto");
+const trace_1 = require("@palmetto/trace");
 const errors_js_1 = require("./errors.js");
 const message_logger_js_1 = require("./message-logger.js");
-const dd_trace_api_1 = require("dd-trace-api");
 class Publisher {
     constructor(logger, providers) {
         var _a, _b;
@@ -57,7 +57,7 @@ class Publisher {
         if (messages.length === 0) {
             return Promise.resolve();
         }
-        return dd_trace_api_1.tracer.trace("pubsub.publish", {
+        return (0, trace_1.getTracer)().trace("pubsub.publish", {
             resource: `publish ${config.transport} ${config.name}`,
         }, (span) => {
             return this.publishImpl(config, messages, span);

package/dist/rabbitmq/publisher.js

@@ -117,10 +117,10 @@ class RabbitMqPublisher {
                 timestamp: Date.now(),
                 persistent: true,
             };
-            const oks = yield Promise.all(messages.map((message) => sender(Buffer.from(message, "utf8"), options)));
+            const oks = yield Promise.allSettled(messages.map((message) => sender(Buffer.from(message, "utf8"), options)));
             const failedMessages = oks
                 .map((ok, index) => ({ ok, index }))
-                .filter(({ ok }) => !ok)
+                .filter(({ ok }) => ok.status === "rejected")
                 .map(({ index }) => messages[index]);
             if (failedMessages.length > 0) {
                 const allOrSome = failedMessages.length === messages.length ? "all" : "some";

package/dist/rabbitmq/subscriber.d.ts

@@ -6,12 +6,13 @@ import { RabbitMqConnection } from "./connection.js";
 declare class SubscribedMessage {
     private readonly owner;
     private readonly logger;
+    private readonly queueName;
     readonly config: RabbitQueueExchangeConfiguration;
     readonly onMessage: (s: string, context: RabbitMqMessageContext) => Promise<MessageResult> | MessageResult;
     stop?: StopSubscribe | undefined;
     channel?: ChannelWrapper;
     busy: number;
-    constructor(owner: RabbitMqSubscriber, logger: Logger, config: RabbitQueueExchangeConfiguration, onMessage: (s: string, context: RabbitMqMessageContext) => Promise<MessageResult> | MessageResult, stop?: StopSubscribe | undefined);
+    constructor(owner: RabbitMqSubscriber, logger: Logger, queueName: string, config: RabbitQueueExchangeConfiguration, onMessage: (s: string, context: RabbitMqMessageContext) => Promise<MessageResult> | MessageResult, stop?: StopSubscribe | undefined);
     stopSubscribe(): Promise<void>;
 }
 export declare class RabbitMqSubscriber implements SubscriberProvider {

package/dist/rabbitmq/subscriber.js

@@ -10,16 +10,17 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.RabbitMqSubscriber = void 0;
+const trace_1 = require("@palmetto/trace");
 const interfaces_js_1 = require("../interfaces.js");
 const errors_js_1 = require("../errors.js");
 const config_js_1 = require("./config.js");
 const connection_js_1 = require("./connection.js");
 const create_log_error_payload_js_1 = require("../create-log-error-payload.js");
-const dd_trace_api_1 = require("dd-trace-api");
 class SubscribedMessage {
-    constructor(owner, logger, config, onMessage, stop) {
+    constructor(owner, logger, queueName, config, onMessage, stop) {
         this.owner = owner;
         this.logger = logger;
+        this.queueName = queueName;
         this.config = config;
         this.onMessage = onMessage;
         this.stop = stop;
@@ -34,16 +35,16 @@ class SubscribedMessage {
                 this.stop = undefined;
                 this.owner.removeSubscriber(this);
                 if (this.busy) {
-                    (_b = (_a = this.logger).debug) === null || _b === void 0 ? void 0 : _b.call(_a, "RabbitMq subscriber waiting for handler to finish");
-                    const start = new Date().valueOf();
+                    (_b = (_a = this.logger).debug) === null || _b === void 0 ? void 0 : _b.call(_a, `RabbitMq subscriber waiting for ${this.queueName} handler to finish`);
+                    const start = Date.now();
                     const waitDelay = 5;
-                    let busyCheck = 1000 / waitDelay; // wait up to a second or so
+                    let busyCheck = 5000 / waitDelay; // wait a few seconds before shutdown
                     while (this.busy && busyCheck > 0) {
                         yield new Promise((resolve) => setTimeout(resolve, waitDelay));
                         busyCheck -= waitDelay;
                     }
-                    const delay = new Date().valueOf() - start;
-                    (_d = (_c = this.logger).debug) === null || _d === void 0 ? void 0 : _d.call(_c, `RabbitMq subscriber waited ${delay}ms for handler to finish`);
+                    const delay = Date.now() - start;
+                    (_d = (_c = this.logger).debug) === null || _d === void 0 ? void 0 : _d.call(_c, `RabbitMq subscriber waited ${delay}ms for ${this.queueName} handler to finish`);
                 }
                 yield s();
             }
@@ -73,7 +74,7 @@ class RabbitMqSubscriber {
         if (subscribedMessage) {
             throw new errors_js_1.AlreadySubscribingError(queueName);
         }
-        subscribedMessage = new SubscribedMessage(this, this.logger, config, onMessage);
+        subscribedMessage = new SubscribedMessage(this, this.logger, queueName, config, onMessage);
         this.subscribers.set(queueName, subscribedMessage);
         subscribedMessage.channel = this.connection.connection.createChannel({
             setup: (channel) => __awaiter(this, void 0, void 0, function* () {
@@ -84,9 +85,9 @@ class RabbitMqSubscriber {
     }
     close() {
         return __awaiter(this, void 0, void 0, function* () {
-            for (const subscribedMessage of this.subscribers.values()) {
-                yield subscribedMessage.stopSubscribe();
-            }
+            yield Promise.all(this.subscribers
+                .values()
+                .map((subscribedMessage) => subscribedMessage.stopSubscribe()));
             this.subscribers.clear();
         });
     }
@@ -123,7 +124,7 @@ class RabbitMqSubscriber {
                 ? setupResult.dlQueueName
                 : setupResult.queueName;
             const onRabbitMessage = (msg) => __awaiter(this, void 0, void 0, function* () {
-                yield dd_trace_api_1.tracer.trace("pubsub.rabbit.consume", {
+                yield (0, trace_1.getTracer)().trace("pubsub.rabbit.consume", {
                     resource: `consume ${config.transport} ${queueName}`,
                 }, (span) => __awaiter(this, void 0, void 0, function* () {
                     try {
@@ -135,7 +136,7 @@ class RabbitMqSubscriber {
                             message: "Unexpected error handling RabbitMq message",
                             error: (0, create_log_error_payload_js_1.createLogErrorPayload)(err),
                         });
-                        span === null || span === void 0 ? void 0 : span.setTag("error", err);
+                        span.setTag("error", err);
                         try {
                             channel.nack(msg, undefined, true);
                         }
@@ -163,9 +164,10 @@ class RabbitMqSubscriber {
             this.logger.log(`RabbitMQ consumer started for ${queueName}`);
             // stop will cancel the subscriber
             subscribedMessage.stop = () => __awaiter(this, void 0, void 0, function* () {
-                var _a, _b;
+                var _a, _b, _c, _d;
+                (_b = (_a = this.logger).debug) === null || _b === void 0 ? void 0 : _b.call(_a, `RabbitMQ consumer stopping for ${queueName}`);
                 yield channel.close();
-                (_b = (_a = this.logger).debug) === null || _b === void 0 ? void 0 : _b.call(_a, `RabbitMQ consumer stopped for ${queueName}`);
+                (_d = (_c = this.logger).debug) === null || _d === void 0 ? void 0 : _d.call(_c, `RabbitMQ consumer stopped for ${queueName}`);
             });
         });
     }
@@ -207,7 +209,7 @@ class RabbitMqSubscriber {
                 timestamp: (_d = sentDates.firstSent) === null || _d === void 0 ? void 0 : _d.valueOf(),
                 headers: {
                     [RETRIES_HEADER]: retries + 1,
-                    [RETRYSENT_HEADER]: new Date().valueOf(),
+                    [RETRYSENT_HEADER]: Date.now(),
                 },
             }));
             if (ok) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@palmetto/pubsub",
-  "version": "2.2.7",
+  "version": "3.0.0",
   "main": "./dist/main.js",
   "scripts": {
     "lint": "yarn run -T eslint --fix ./src",
@@ -20,12 +20,12 @@
     "test:watch": "yarn run test-runner vitest watch"
   },
   "devDependencies": {
+    "@palmetto/trace": "^0.0.1",
     "@types/amqplib": "^0",
     "@types/node": "^24.2.1",
     "amqp-connection-manager": "^4.1.14",
     "amqplib": "^0.10.8",
     "bullmq": "^5.58.0",
-    "opentracing": "^0.14.7",
     "ts-node": "^10.9.2",
     "typescript": "^5.8.3",
     "vitest": "^3.2.4",
@@ -42,10 +42,10 @@
     "access": "public"
   },
   "dependencies": {
-    "dd-trace-api": "^1.0.0",
     "uuid": "^11.1.0"
   },
   "peerDependencies": {
+    "@palmetto/trace": "^0.0.1",
     "amqp-connection-manager": "^4.1.14",
     "amqplib": "^0.10.8",
     "bullmq": "^5.58.0",