@pagopa/io-react-native-iso18013 0.6.0 → 0.7.0

package/IoReactNativeIso18013.podspec

@@ -17,7 +17,7 @@ Pod::Spec.new do |s|
 
   # Module dependencies
   s.dependency "IOWalletCBOR", "0.2.1"
-  s.dependency "IOWalletProximity", "1.3.0"
+  s.dependency "IOWalletProximity", "1.3.2"
 
   # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
   # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.

package/android/src/main/java/com/ioreactnativeiso18013/IoReactNativeIso18013Module.kt

@@ -386,7 +386,8 @@ class IoReactNativeIso18013Module(reactContext: ReactApplicationContext) :
      *   },
      *   {...}
      * }
-     * @throw IllegalArgumentException if the ReadableMap is not consistent or contains an invalid value
+     * @throw IllegalArgumentException if the value provided is not a ReadableMap which contains
+     * at least a credential type. If a namespace doesn't contain at least one value.
      * @returns String representation of [acceptedFields]
      */
     fun parseAcceptedFields(acceptedFields: ReadableMap): String {
@@ -399,10 +400,7 @@ class IoReactNativeIso18013Module(reactContext: ReactApplicationContext) :
             throw IllegalArgumentException("Credential '$credentialName' must be a map")
           }
 
-          // If no namespace is found then throw
-          if(!credentialValue.entryIterator.hasNext()){
-            throw IllegalArgumentException("Credential '$credentialName' must define at least one namespace")
-          }
+          // We don't check for a namespace, if there's none that's a valid structure and thus should pass the validation
 
           // Loop for each namespace in credential and throw if something different than map is found
           credentialValue.entryIterator.forEach { namespaceEntry ->

package/android/src/test/java/com/ioreactnativeiso18013/IoReactNativeIso18013Test.kt

@@ -414,6 +414,17 @@ class IoReactNativeIso18013Test {
     assert(result == "{}")
   }
 
+  @Test
+  fun `should parse a map with a credential type but without any namespace nor values`() {
+    val nativeMap = JavaOnlyMap.of(
+      "org.iso.18013.5.1.mDL",
+      JavaOnlyMap()
+    )
+    val result = IoReactNativeIso18013Module.parseAcceptedFields(nativeMap)
+    print(result)
+    assert(result == "{org.iso.18013.5.1.mDL={}}")
+  }
+
   @Test
   fun `should throw an IllegalArgumentException if the credential type is not a map`() {
     val nativeMap = JavaOnlyMap.of(
@@ -450,19 +461,6 @@ class IoReactNativeIso18013Test {
     }
   }
 
-  @Test
-  fun `should throw an IllegalArgumentException if no namespace are provided for the credential`() {
-    val nativeMap = JavaOnlyMap.of(
-      "org.iso.18013.5.1.mDL",
-      JavaOnlyMap()
-    )
-    assertThrows(
-      IllegalArgumentException::class.java
-    ) {
-      IoReactNativeIso18013Module.parseAcceptedFields(nativeMap)
-    }
-  }
-
   @Test
   fun `should throw an IllegalArgumentException if no fields are provided for the namespace`() {
     val nativeMap = JavaOnlyMap.of(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pagopa/io-react-native-iso18013",
-  "version": "0.6.0",
+  "version": "0.7.0",
   "description": "React Native bridge for iso18013 methods",
   "source": "./src/index.tsx",
   "main": "./lib/module/index.js",