@pagopa/io-app-design-system 4.2.1 → 4.4.0

package/src/components/buttons/ButtonLink.tsx

@@ -1,23 +1,18 @@
-import React, { useCallback, useMemo } from "react";
+import React, { forwardRef, useMemo } from "react";
 import { GestureResponderEvent, Pressable, View } from "react-native";
 import Animated, {
-  Extrapolate,
-  interpolate,
   interpolateColor,
-  useAnimatedProps,
   useAnimatedStyle,
-  useDerivedValue,
-  useSharedValue,
-  withSpring
+  useReducedMotion
 } from "react-native-reanimated";
 import {
   IOButtonStyles,
   IOColors,
-  IOScaleValues,
-  IOSpringValues,
+  IOSpacingScale,
   hexToRgba,
   useIOExperimentalDesign
 } from "../../core";
+import { useScaleAnimation } from "../../hooks";
 import { WithTestID } from "../../utils/types";
 import {
   AnimatedIcon,
@@ -25,7 +20,6 @@ import {
   IOIcons,
   IconClassComponent
 } from "../icons";
-import { HSpacer } from "../spacer/Spacer";
 import { IOText, buttonTextFontSize } from "../typography";
 
 export type ColorButtonLink = "primary" | "contrast";
@@ -96,8 +90,9 @@ const mapLegacyColorStates: Record<
 };
 
 const DISABLED_OPACITY = 0.5;
+const ICON_MARGIN = 8;
 
-export const ButtonLink = React.forwardRef<View, ButtonLinkProps>(
+export const ButtonLink = forwardRef<View, ButtonLinkProps>(
   (
     {
       color = "primary",
@@ -112,8 +107,10 @@ export const ButtonLink = React.forwardRef<View, ButtonLinkProps>(
     },
     ref
   ) => {
-    const isPressed = useSharedValue(0);
     const { isExperimental } = useIOExperimentalDesign();
+    const { progress, onPressIn, onPressOut, scaleAnimatedStyle } =
+      useScaleAnimation();
+    const reducedMotion = useReducedMotion();
 
     const colorMap = useMemo(
       () => (isExperimental ? mapColorStates : mapLegacyColorStates),
@@ -122,70 +119,20 @@ export const ButtonLink = React.forwardRef<View, ButtonLinkProps>(
 
     const AnimatedIOText = Animated.createAnimatedComponent(IOText);
 
-    // Scaling transformation applied when the button is pressed
-    const animationScaleValue = IOScaleValues?.basicButton?.pressedState;
-
-    // Using a spring-based animation for our interpolations
-    const progressPressed = useDerivedValue(() =>
-      withSpring(isPressed.value, IOSpringValues.button)
-    );
-
-    // Interpolate animation values from `isPressed` values
-    const pressedAnimationStyle = useAnimatedStyle(() => {
-      // Link color states to the pressed states
-
-      // Scale down button slightly when pressed
-      const scale = interpolate(
-        progressPressed.value,
-        [0, 1],
-        [1, animationScaleValue],
-        Extrapolate.CLAMP
-      );
-
-      return {
-        transform: [{ scale }]
-      };
-    });
-
-    const pressedColorLabelAnimationStyle = useAnimatedStyle(() => {
-      // Link color states to the pressed states
-
-      const labelColor = interpolateColor(
-        progressPressed.value,
+    const pressedColorAnimationStyle = useAnimatedStyle(() => ({
+      color: interpolateColor(
+        progress.value,
         [0, 1],
         [colorMap[color].label.default, colorMap[color].label.pressed]
-      );
-
-      return {
-        color: labelColor
-      };
-    });
-
-    // Animate the <Icon> color prop
-    const pressedColorIconAnimationStyle = useAnimatedProps(() => {
-      const iconColor = interpolateColor(
-        progressPressed.value,
-        [0, 1],
-        [colorMap[color].label.default, colorMap[color].label.pressed]
-      );
-
-      return { color: iconColor };
-    });
+      )
+    }));
 
     const AnimatedIconClassComponent =
       Animated.createAnimatedComponent(IconClassComponent);
 
-    const onPressIn = useCallback(() => {
-      // eslint-disable-next-line functional/immutable-data
-      isPressed.value = 1;
-    }, [isPressed]);
-    const onPressOut = useCallback(() => {
-      // eslint-disable-next-line functional/immutable-data
-      isPressed.value = 0;
-    }, [isPressed]);
-
     // Icon size
     const iconSize: IOIconSizeScale = 24;
+    const iconMargin: IOSpacingScale = 8;
 
     return (
       <Pressable
@@ -208,31 +155,31 @@ export const ButtonLink = React.forwardRef<View, ButtonLinkProps>(
           style={[
             IOButtonStyles.buttonLink,
             iconPosition === "end" && { flexDirection: "row-reverse" },
+            { columnGap: iconMargin },
             disabled ? { opacity: DISABLED_OPACITY } : {},
+            { columnGap: ICON_MARGIN },
             /* Prevent Reanimated from overriding background colors
                     if button is disabled */
-            !disabled && pressedAnimationStyle
+            !disabled && !reducedMotion && scaleAnimatedStyle
           ]}
         >
-          {icon && (
-            <>
-              {!disabled ? (
-                <AnimatedIconClassComponent
-                  name={icon}
-                  animatedProps={pressedColorIconAnimationStyle}
-                  color={colorMap[color]?.label?.default}
-                  size={iconSize}
-                />
-              ) : (
-                <AnimatedIcon
-                  name={icon}
-                  color={colorMap[color]?.label?.disabled}
-                  size={iconSize}
-                />
-              )}
-              <HSpacer size={8} />
-            </>
-          )}
+          {icon &&
+            (!disabled ? (
+              <AnimatedIconClassComponent
+                allowFontScaling
+                name={icon}
+                animatedProps={pressedColorAnimationStyle}
+                color={colorMap[color]?.label?.default}
+                size={iconSize}
+              />
+            ) : (
+              <AnimatedIcon
+                allowFontScaling
+                name={icon}
+                color={colorMap[color]?.label?.disabled}
+                size={iconSize}
+              />
+            ))}
           <AnimatedIOText
             accessible={false}
             accessibilityElementsHidden
@@ -243,7 +190,7 @@ export const ButtonLink = React.forwardRef<View, ButtonLinkProps>(
             style={
               disabled
                 ? { color: colorMap[color]?.label?.disabled }
-                : { ...pressedColorLabelAnimationStyle }
+                : { ...pressedColorAnimationStyle }
             }
             numberOfLines={1}
             ellipsizeMode="tail"

package/src/components/buttons/ButtonOutline.tsx

@@ -1,4 +1,4 @@
-import React, { ComponentProps, useCallback } from "react";
+import React, { ComponentProps, forwardRef } from "react";
 import {
   GestureResponderEvent,
   Pressable,
@@ -6,24 +6,19 @@ import {
   View
 } from "react-native";
 import Animated, {
-  Extrapolate,
-  interpolate,
   interpolateColor,
   useAnimatedProps,
   useAnimatedStyle,
-  useDerivedValue,
-  useSharedValue,
-  withSpring
+  useReducedMotion
 } from "react-native-reanimated";
 import {
   IOButtonLegacyStyles,
   IOButtonStyles,
   IOColors,
-  IOScaleValues,
-  IOSpringValues,
   hexToRgba,
   useIOExperimentalDesign
 } from "../../core/";
+import { useScaleAnimation } from "../../hooks";
 import { WithTestID } from "../../utils/types";
 import {
   AnimatedIcon,
@@ -31,7 +26,6 @@ import {
   IOIcons,
   IconClassComponent
 } from "../icons";
-import { HSpacer } from "../spacer/Spacer";
 import { IOText, buttonTextFontSize } from "../typography";
 
 type ColorButtonOutline = "primary" | "contrast" | "danger";
@@ -201,6 +195,7 @@ const IOButtonLegacyStylesLocal = StyleSheet.create({
 const iconSize: IOIconSizeScale = 20;
 
 const DISABLED_OPACITY = 0.5;
+const ICON_MARGIN = 8;
 
 const IOButtonStylesLocal = StyleSheet.create({
   buttonWithBorder: {
@@ -208,7 +203,7 @@ const IOButtonStylesLocal = StyleSheet.create({
   }
 });
 
-export const ButtonOutline = React.forwardRef<View, ButtonOutline>(
+export const ButtonOutline = forwardRef<View, ButtonOutline>(
   (
     {
       color = "primary",
@@ -225,7 +220,9 @@ export const ButtonOutline = React.forwardRef<View, ButtonOutline>(
     ref
   ) => {
     const { isExperimental } = useIOExperimentalDesign();
-    const isPressed: Animated.SharedValue<number> = useSharedValue(0);
+    const { progress, onPressIn, onPressOut, scaleAnimatedStyle } =
+      useScaleAnimation();
+    const reducedMotion = useReducedMotion();
 
     const AnimatedIOText = Animated.createAnimatedComponent(IOText);
 
@@ -243,80 +240,48 @@ export const ButtonOutline = React.forwardRef<View, ButtonOutline>(
       () => (isExperimental ? IOButtonStylesLocal : IOButtonLegacyStylesLocal),
       [isExperimental]
     );
-    // Scaling transformation applied when the button is pressed
-    const animationScaleValue = IOScaleValues?.basicButton?.pressedState;
-
-    // Using a spring-based animation for our interpolations
-    const progressPressed = useDerivedValue(() =>
-      withSpring(isPressed.value, IOSpringValues.button)
-    );
 
     // Interpolate animation values from `isPressed` values
     const pressedAnimationStyle = useAnimatedStyle(() => {
       // Link color states to the pressed states
       const backgroundColor = interpolateColor(
-        progressPressed.value,
+        progress.value,
         [0, 1],
         [colorMap[color].background.default, colorMap[color].background.pressed]
       );
 
       const borderColor = interpolateColor(
-        progressPressed.value,
+        progress.value,
         [0, 1],
         [colorMap[color].border.default, colorMap[color].border.pressed]
       );
 
-      // Scale down button slightly when pressed
-      const scale = interpolate(
-        progressPressed.value,
-        [0, 1],
-        [1, animationScaleValue],
-        Extrapolate.CLAMP
-      );
-
       return {
         borderColor,
-        backgroundColor,
-        transform: [{ scale }]
+        backgroundColor
       };
     });
 
-    const pressedColorLabelAnimationStyle = useAnimatedStyle(() => {
-      // Link color states to the pressed states
-
-      const labelColor = interpolateColor(
-        progressPressed.value,
+    const pressedColorLabelAnimationStyle = useAnimatedStyle(() => ({
+      color: interpolateColor(
+        progress.value,
         [0, 1],
         [colorMap[color].border.default, colorMap[color].border.pressed]
-      );
-
-      return {
-        color: labelColor
-      };
-    });
+      )
+    }));
 
     // Animate the <Icon> color prop
-    const pressedColorIconAnimationStyle = useAnimatedProps(() => {
-      const iconColor = interpolateColor(
-        progressPressed.value,
+    const pressedColorIconAnimationStyle = useAnimatedProps(() => ({
+      color: interpolateColor(
+        progress.value,
         [0, 1],
         [colorMap[color].label.default, colorMap[color].label.pressed]
-      );
-      return { color: iconColor };
-    });
+      )
+    }));
 
     const AnimatedIconClassComponent =
       Animated.createAnimatedComponent(IconClassComponent);
 
-    const onPressIn = useCallback(() => {
-      // eslint-disable-next-line functional/immutable-data
-      isPressed.value = 1;
-    }, [isPressed]);
-    const onPressOut = useCallback(() => {
-      // eslint-disable-next-line functional/immutable-data
-      isPressed.value = 0;
-    }, [isPressed]);
-
     return (
       <Pressable
         ref={ref}
@@ -338,6 +303,7 @@ export const ButtonOutline = React.forwardRef<View, ButtonOutline>(
             isExperimental && fullWidth && { paddingHorizontal: 16 },
             buttonStylesLocal.buttonWithBorder,
             buttonStyles.buttonSizeDefault,
+            { columnGap: ICON_MARGIN },
             iconPosition === "end" && { flexDirection: "row-reverse" },
             disabled
               ? {
@@ -351,28 +317,27 @@ export const ButtonOutline = React.forwardRef<View, ButtonOutline>(
                 },
             /* Prevent Reanimated from overriding background colors
                     if button is disabled */
+            !reducedMotion && !disabled && scaleAnimatedStyle,
             !disabled && pressedAnimationStyle
           ]}
         >
-          {icon && (
-            <>
-              {!disabled ? (
-                <AnimatedIconClassComponent
-                  name={icon}
-                  animatedProps={pressedColorIconAnimationStyle}
-                  color={colorMap[color]?.label?.default}
-                  size={iconSize}
-                />
-              ) : (
-                <AnimatedIcon
-                  name={icon}
-                  color={colorMap[color]?.label?.disabled}
-                  size={iconSize}
-                />
-              )}
-              <HSpacer size={8} />
-            </>
-          )}
+          {icon &&
+            (!disabled ? (
+              <AnimatedIconClassComponent
+                allowFontScaling
+                name={icon}
+                animatedProps={pressedColorIconAnimationStyle}
+                color={colorMap[color]?.label?.default}
+                size={iconSize}
+              />
+            ) : (
+              <AnimatedIcon
+                allowFontScaling
+                name={icon}
+                color={colorMap[color]?.label?.disabled}
+                size={iconSize}
+              />
+            ))}
           <AnimatedIOText
             font={isExperimental ? "Titillio" : "TitilliumSansPro"}
             weight={"Semibold"}

package/src/components/buttons/ButtonSolid.tsx

@@ -1,4 +1,4 @@
-import React, { ComponentProps, useCallback, useEffect, useRef } from "react";
+import React, { ComponentProps, useCallback } from "react";
 import {
   GestureResponderEvent,
   Pressable,
@@ -7,29 +7,23 @@ import {
 } from "react-native";
 import ReactNativeHapticFeedback from "react-native-haptic-feedback";
 import Animated, {
-  Extrapolate,
-  interpolate,
   interpolateColor,
   useAnimatedStyle,
-  useDerivedValue,
-  useSharedValue,
-  withSpring
+  useReducedMotion
 } from "react-native-reanimated";
 import {
   IOButtonLegacyStyles,
   IOButtonStyles,
   IOColors,
-  IOScaleValues,
-  IOSpringValues,
   enterTransitionInnerContent,
   enterTransitionInnerContentSmall,
   exitTransitionInnerContent,
   useIOExperimentalDesign
 } from "../../core";
+import { useScaleAnimation } from "../../hooks";
 import { WithTestID } from "../../utils/types";
 import { IOIconSizeScale, IOIcons, Icon } from "../icons";
 import { LoadingSpinner } from "../loadingSpinner";
-import { HSpacer } from "../spacer/Spacer";
 import { ButtonText } from "../typography/ButtonText";
 
 export type ButtonSolidColor = "primary" | "danger" | "contrast";
@@ -53,6 +47,7 @@ const legacyStyles = StyleSheet.create({
 });
 
 const colorPrimaryButtonDisabled: IOColors = "grey-200";
+const ICON_MARGIN = 8;
 const DISABLED_OPACITY = 0.5;
 
 // Icon size
@@ -176,21 +171,10 @@ export const ButtonSolid = React.forwardRef<View, ButtonSolidProps>(
     },
     ref
   ) => {
-    const isPressed = useSharedValue(0);
     const { isExperimental } = useIOExperimentalDesign();
-    // Scaling transformation applied when the button is pressed
-    const animationScaleValue = IOScaleValues?.basicButton?.pressedState;
-
-    /* Prevent the component from triggering the `isEntering' transition
-       on the on the first render. Solution from this discussion:
-       https://github.com/software-mansion/react-native-reanimated/discussions/2513
-    */
-    const isMounted = useRef(false);
-
-    useEffect(() => {
-      // eslint-disable-next-line functional/immutable-data
-      isMounted.current = true;
-    }, []);
+    const { progress, onPressIn, onPressOut, scaleAnimatedStyle } =
+      useScaleAnimation();
+    const reducedMotion = useReducedMotion();
 
     const colorMap = React.useMemo(
       () => (isExperimental ? mapColorStates : mapLegacyColorStates),
@@ -202,43 +186,18 @@ export const ButtonSolid = React.forwardRef<View, ButtonSolidProps>(
       [isExperimental]
     );
 
-    // Using a spring-based animation for our interpolations
-    const progressPressed = useDerivedValue(() =>
-      withSpring(isPressed.value, IOSpringValues.button)
-    );
-
     // Interpolate animation values from `isPressed` values
     const pressedAnimationStyle = useAnimatedStyle(() => {
       // Link color states to the pressed states
       const backgroundColor = interpolateColor(
-        progressPressed.value,
+        progress.value,
         [0, 1],
         [colorMap[color].default, colorMap[color].pressed]
       );
 
-      // Scale down button slightly when pressed
-      const scale = interpolate(
-        progressPressed.value,
-        [0, 1],
-        [1, animationScaleValue],
-        Extrapolate.CLAMP
-      );
-
-      return {
-        backgroundColor,
-        transform: [{ scale }]
-      };
+      return { backgroundColor };
     });
 
-    const onPressIn = useCallback(() => {
-      // eslint-disable-next-line functional/immutable-data
-      isPressed.value = 1;
-    }, [isPressed]);
-    const onPressOut = useCallback(() => {
-      // eslint-disable-next-line functional/immutable-data
-      isPressed.value = 0;
-    }, [isPressed]);
-
     const handleOnPress = useCallback(
       (event: GestureResponderEvent) => {
         /* Don't call `onPress` if the button is
@@ -289,15 +248,14 @@ export const ButtonSolid = React.forwardRef<View, ButtonSolidProps>(
               : { backgroundColor: colorMap[color]?.default },
             /* Prevent Reanimated from overriding background colors
               if button is disabled */
+            !disabled && !reducedMotion && scaleAnimatedStyle,
             !disabled && pressedAnimationStyle
           ]}
         >
           {loading && (
             <Animated.View
               style={buttonStyles.buttonInner}
-              entering={
-                isMounted.current ? enterTransitionInnerContentSmall : undefined
-              }
+              entering={enterTransitionInnerContentSmall}
               exiting={exitTransitionInnerContent}
             >
               <LoadingSpinner color={foregroundColor} />
@@ -308,24 +266,20 @@ export const ButtonSolid = React.forwardRef<View, ButtonSolidProps>(
             <Animated.View
               style={[
                 buttonStyles.buttonInner,
+                { columnGap: ICON_MARGIN },
+                /* If 'iconPosition' is set to 'end', we use 
+                   reverse flex property to invert the position */
                 iconPosition === "end" && { flexDirection: "row-reverse" }
               ]}
-              entering={
-                isMounted.current ? enterTransitionInnerContent : undefined
-              }
-              /* Temporarily disable the exiting transition because it caused
-              a weird glitch on page exit */
-              // exiting={exitTransitionInnerContent}
+              entering={enterTransitionInnerContent}
             >
               {icon && (
-                <>
-                  {/* If 'iconPosition' is set to 'end', we use 
-            reverse flex property to invert the position */}
-                  <Icon name={icon} size={iconSize} color={foregroundColor} />
-                  {/* Once we have support for 'gap' property,
-            we can get rid of that spacer */}
-                  <HSpacer size={8} />
-                </>
+                <Icon
+                  allowFontScaling
+                  name={icon}
+                  size={iconSize}
+                  color={foregroundColor}
+                />
               )}
               <ButtonText
                 color={foregroundColor}