@pagopa/dx-savemoney 0.6.1 → 0.6.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pagopa/dx-savemoney",
-  "version": "0.6.1",
+  "version": "0.6.3",
   "type": "module",
   "description": "Azure resource analyzer for finding unused or cost-inefficient resources.",
   "repository": {
@@ -51,12 +51,5 @@
     "typescript": "~5.9.3",
     "vitest": "^4.1.10",
     "@pagopa/eslint-config": "^6.2.2"
-  },
-  "scripts": {
-    "build": "rm -rf dist && tsc",
-    "dev": "tsc --watch",
-    "format": "prettier --write .",
-    "format:check": "prettier --check .",
-    "test:coverage": "vitest run --coverage"
   }
 }

package/src/__tests__/savemoney-command-telemetry.test.ts

@@ -0,0 +1,117 @@
+import { describe, expect, it } from "vitest";
+
+import type { Finding } from "../finding.js";
+
+import {
+  buildSavemoneyInvocationTelemetryAttributes,
+  buildSavemoneyOutcomeTelemetryAttributes,
+} from "../telemetry/savemoney-command-telemetry.js";
+
+const BASE_FINDING: Finding = {
+  category: "cost",
+  code: "vm.low-cpu",
+  reason: "Low CPU usage.",
+  resourceId:
+    "/subscriptions/sub/resourceGroups/rg/providers/Microsoft.Compute/virtualMachines/vm",
+  severity: "low",
+  source: "custom",
+};
+
+describe("buildSavemoneyInvocationTelemetryAttributes", () => {
+  it("sets azqr_report_source to cli when --azqr-report is provided", () => {
+    const attributes = buildSavemoneyInvocationTelemetryAttributes({
+      azqrReportPathOption: "./azqr.json",
+      format: "table",
+      resolvedConfig: {
+        azqrReportPath: "./from-config.json",
+        pricing: { enabled: true },
+        sources: ["advisor", "custom"],
+        subscriptionIds: ["sub-a"],
+      },
+    });
+
+    expect(attributes["savemoney.azqr_report_source"]).toBe("cli");
+  });
+
+  it("sets azqr_report_source to config when only config path is present", () => {
+    const attributes = buildSavemoneyInvocationTelemetryAttributes({
+      format: "table",
+      resolvedConfig: {
+        azqrReportPath: "./from-config.json",
+        pricing: { enabled: true },
+        sources: ["advisor", "custom"],
+        subscriptionIds: ["sub-a"],
+      },
+    });
+
+    expect(attributes["savemoney.azqr_report_source"]).toBe("config");
+  });
+
+  it("sets azqr_report_source to none when azqr is absent", () => {
+    const attributes = buildSavemoneyInvocationTelemetryAttributes({
+      format: "table",
+      resolvedConfig: {
+        pricing: { enabled: true },
+        sources: ["advisor", "custom"],
+        subscriptionIds: ["sub-a"],
+      },
+    });
+
+    expect(attributes["savemoney.azqr_report_source"]).toBe("none");
+  });
+
+  it("derives subscriptions_source as config, env, or prompt", () => {
+    const fromConfig = buildSavemoneyInvocationTelemetryAttributes({
+      configPathOption: "./config.yaml",
+      format: "table",
+      resolvedConfig: {
+        pricing: { enabled: true },
+        sources: ["advisor", "custom"],
+        subscriptionIds: ["sub-a"],
+      },
+      subscriptionIdsEnv: "sub-env",
+    });
+    const fromEnv = buildSavemoneyInvocationTelemetryAttributes({
+      format: "table",
+      resolvedConfig: {
+        pricing: { enabled: true },
+        sources: ["advisor", "custom"],
+        subscriptionIds: ["sub-a"],
+      },
+      subscriptionIdsEnv: "sub-env",
+    });
+    const fromPrompt = buildSavemoneyInvocationTelemetryAttributes({
+      format: "table",
+      resolvedConfig: {
+        pricing: { enabled: true },
+        sources: ["advisor", "custom"],
+        subscriptionIds: ["sub-a"],
+      },
+    });
+
+    expect(fromConfig["savemoney.subscriptions_source"]).toBe("config");
+    expect(fromEnv["savemoney.subscriptions_source"]).toBe("env");
+    expect(fromPrompt["savemoney.subscriptions_source"]).toBe("prompt");
+  });
+});
+
+describe("buildSavemoneyOutcomeTelemetryAttributes", () => {
+  it("counts findings and analyzed resources", () => {
+    const attributes = buildSavemoneyOutcomeTelemetryAttributes([
+      {
+        findings: [BASE_FINDING, { ...BASE_FINDING, code: "disk.unattached" }],
+      },
+      {
+        findings: [
+          { ...BASE_FINDING, code: "advisor.right-size", source: "advisor" },
+        ],
+      },
+      {},
+    ]);
+
+    expect(attributes).toEqual({
+      "savemoney.findings_count": 3,
+      "savemoney.resources_analyzed": 3,
+    });
+  });
+});

package/src/azure/pricing/__tests__/schema.test.ts

@@ -0,0 +1,30 @@
+/**
+ * Tests for the Retail Prices API zod schemas, focused on the API's real
+ * (and easy to overlook) quirks rather than the happy path already covered
+ * indirectly by client.test.ts.
+ */
+
+import { describe, expect, it } from "vitest";
+
+import { PriceItemSchema } from "../schema.js";
+
+describe("PriceItemSchema", () => {
+  it("accepts empty strings for optional metadata fields", () => {
+    // The Retail Prices API returns "" (not the field omitted) for meters
+    // that don't have a given attribute, e.g. `armSkuName` on
+    // Bandwidth/Support meters. Resolvers already treat "" and `undefined`
+    // the same way (`?.toLowerCase() ?? ""`), so the schema must tolerate it.
+    const item = {
+      armSkuName: "",
+      currencyCode: "EUR",
+      retailPrice: 1,
+      type: "Consumption",
+      unitOfMeasure: "1 Hour",
+      unitPrice: 1,
+    };
+
+    const result = PriceItemSchema.parse(item);
+
+    expect(result.armSkuName).toBe("");
+  });
+});

package/src/azure/pricing/pricing-service.ts

@@ -116,9 +116,12 @@ export class PricingService {
     try {
       return await factory();
     } catch (error) {
-      logger.warn(
-        `Pricing lookup failed: ${error instanceof Error ? error.message : String(error)}`,
-      );
+      // Passed as a template property, not string-interpolated: logtape parses
+      // `{...}` in the message itself as placeholders (e.g. a ZodError's
+      // JSON-formatted issues would otherwise get swallowed as `undefined`).
+      logger.warn("Pricing lookup failed: {message}", {
+        message: error instanceof Error ? error.message : String(error),
+      });
       return undefined;
     }
   }

package/src/azure/pricing/schema.ts

@@ -12,6 +12,14 @@
 import { z } from "zod";
 
 const NonEmptyStringSchema = z.string().min(1);
+/**
+ * Optional metadata fields. The Retail Prices API returns `""` (not the
+ * field omitted) for meters where a given attribute doesn't apply (e.g.
+ * `armSkuName` for Bandwidth/Support meters), so these must tolerate empty
+ * strings — resolvers already treat empty and missing values the same way
+ * (`?.toLowerCase() ?? ""`).
+ */
+const OptionalStringSchema = z.string().optional();
 const PriceTypeSchema = z.enum([
   "Consumption",
   "DevTestConsumption",
@@ -31,23 +39,23 @@ const PriceValueSchema = z.number().finite().nonnegative();
  *   want on-demand pricing must filter by `type === "Consumption"`.
  */
 export const PriceItemSchema = z.object({
-  armRegionName: NonEmptyStringSchema.optional(),
-  armSkuName: NonEmptyStringSchema.optional(),
+  armRegionName: OptionalStringSchema,
+  armSkuName: OptionalStringSchema,
   currencyCode: z.string().length(3),
-  effectiveStartDate: NonEmptyStringSchema.optional(),
+  effectiveStartDate: OptionalStringSchema,
   isPrimaryMeterRegion: z.boolean().optional(),
-  location: NonEmptyStringSchema.optional(),
-  meterId: NonEmptyStringSchema.optional(),
-  meterName: NonEmptyStringSchema.optional(),
-  productId: NonEmptyStringSchema.optional(),
-  productName: NonEmptyStringSchema.optional(),
-  reservationTerm: NonEmptyStringSchema.optional(),
+  location: OptionalStringSchema,
+  meterId: OptionalStringSchema,
+  meterName: OptionalStringSchema,
+  productId: OptionalStringSchema,
+  productName: OptionalStringSchema,
+  reservationTerm: OptionalStringSchema,
   retailPrice: PriceValueSchema,
-  serviceFamily: NonEmptyStringSchema.optional(),
-  serviceId: NonEmptyStringSchema.optional(),
-  serviceName: NonEmptyStringSchema.optional(),
-  skuId: NonEmptyStringSchema.optional(),
-  skuName: NonEmptyStringSchema.optional(),
+  serviceFamily: OptionalStringSchema,
+  serviceId: OptionalStringSchema,
+  serviceName: OptionalStringSchema,
+  skuId: OptionalStringSchema,
+  skuName: OptionalStringSchema,
   tierMinimumUnits: PriceValueSchema.optional(),
   /** "Consumption" | "Reservation" | "DevTestConsumption". */
   type: PriceTypeSchema,

package/src/azure/resources/app-service.ts

@@ -139,7 +139,8 @@ export async function analyzeAppServicePlan(
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
     logger.warn(
-      `Failed to get App Service Plan details for ${planName}: ${error instanceof Error ? error.message : error}`,
+      `Failed to get App Service Plan details for ${planName}: {message}`,
+      { message: error instanceof Error ? error.message : error },
     );
     reason += "Could not retrieve detailed App Service Plan information. ";
   }
@@ -184,7 +185,8 @@ async function enrichWithPricing(
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
     logger.warn(
-      `Failed to enrich App Service Plan ${resource.name ?? "unknown"} with pricing: ${error instanceof Error ? error.message : error}`,
+      `Failed to enrich App Service Plan ${resource.name ?? "unknown"} with pricing: {message}`,
+      { message: error instanceof Error ? error.message : error },
     );
     return result;
   }

package/src/azure/resources/container-app.ts

@@ -100,7 +100,8 @@ export async function analyzeContainerApp(
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
     logger.warn(
-      `Failed to get Container App details for ${containerAppName}: ${error instanceof Error ? error.message : error}`,
+      `Failed to get Container App details for ${containerAppName}: {message}`,
+      { message: error instanceof Error ? error.message : error },
     );
     reason += "Could not retrieve detailed Container App information. ";
   }

package/src/azure/resources/disk.ts

@@ -81,9 +81,9 @@ export async function analyzeDisk(
     }
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
-    logger.warn(
-      `Failed to get disk details for ${diskName}: ${error instanceof Error ? error.message : error}`,
-    );
+    logger.warn(`Failed to get disk details for ${diskName}: {message}`, {
+      message: error instanceof Error ? error.message : error,
+    });
     // Fallback to checking properties if API call fails
     // Note: GenericResource doesn't have diskState property
     // Without API access, we can't determine if disk is unattached

package/src/azure/resources/nic.ts

@@ -77,9 +77,9 @@ export async function analyzeNic(
     // The primary checks (attachment to VM and public IP assignment) are sufficient
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
-    logger.warn(
-      `Failed to get NIC details for ${nicName}: ${error instanceof Error ? error.message : error}`,
-    );
+    logger.warn(`Failed to get NIC details for ${nicName}: {message}`, {
+      message: error instanceof Error ? error.message : error,
+    });
     reason += "Could not retrieve detailed NIC information. ";
   }
 

package/src/azure/resources/private-endpoint.ts

@@ -100,7 +100,8 @@ export async function analyzePrivateEndpoint(
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
     logger.warn(
-      `Failed to get Private Endpoint details for ${privateEndpointName}: ${error instanceof Error ? error.message : error}`,
+      `Failed to get Private Endpoint details for ${privateEndpointName}: {message}`,
+      { message: error instanceof Error ? error.message : error },
     );
     reason += "Could not retrieve detailed Private Endpoint information. ";
   }

package/src/azure/resources/public-ip.ts

@@ -106,7 +106,8 @@ export async function analyzePublicIp(
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
     logger.warn(
-      `Failed to get Public IP details for ${publicIpName}: ${error instanceof Error ? error.message : error}`,
+      `Failed to get Public IP details for ${publicIpName}: {message}`,
+      { message: error instanceof Error ? error.message : error },
     );
     reason += "Could not retrieve detailed Public IP information. ";
   }
@@ -160,9 +161,9 @@ async function enrichWithPricing(
     return { ...result, estimatedMonthlySavings };
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
-    logger.warn(
-      `Failed to enrich Public IP with pricing: ${error instanceof Error ? error.message : error}`,
-    );
+    logger.warn("Failed to enrich Public IP with pricing: {message}", {
+      message: error instanceof Error ? error.message : error,
+    });
     return result;
   }
 }

package/src/azure/resources/static-web-app.ts

@@ -101,7 +101,8 @@ export async function analyzeStaticSite(
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
     logger.warn(
-      `Failed to get metrics for Static Web App ${resource.name}: ${error instanceof Error ? error.message : error}`,
+      `Failed to get metrics for Static Web App ${resource.name}: {message}`,
+      { message: error instanceof Error ? error.message : error },
     );
   }
 

package/src/azure/resources/vm.ts

@@ -114,9 +114,9 @@ export async function analyzeVM(
     }
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
-    logger.warn(
-      `Failed to get VM instance view for ${vmName}: ${error instanceof Error ? error.message : error}`,
-    );
+    logger.warn(`Failed to get VM instance view for ${vmName}: {message}`, {
+      message: error instanceof Error ? error.message : error,
+    });
     // Continue with metric analysis if instance view fails
   }
 
@@ -203,9 +203,9 @@ async function enrichWithPricing(
     return { ...result, estimatedMonthlySavings };
   } catch (error) {
     const logger = getLogger(["savemoney", "azure"]);
-    logger.warn(
-      `Failed to enrich VM ${vmName} with pricing: ${error instanceof Error ? error.message : error}`,
-    );
+    logger.warn(`Failed to enrich VM ${vmName} with pricing: {message}`, {
+      message: error instanceof Error ? error.message : error,
+    });
     return result;
   }
 }

package/src/azure/utils.ts

@@ -219,7 +219,11 @@ export function verboseLog(
   if (verbose) {
     const logger = getLogger(["savemoney", "azure", "verbose"]);
     if (object !== undefined) {
-      logger.debug(`${message} ${JSON.stringify(object, null, 2)}`);
+      // Passed as a template property (see pricing-service.ts for why: avoids
+      // logtape misparsing literal `{`/`}` in the JSON as placeholders).
+      logger.debug(`${message} {object}`, {
+        object: JSON.stringify(object, null, 2),
+      });
     } else {
       logger.debug(message);
     }
@@ -308,8 +312,10 @@ async function fetchMetric(
     return aggregatedValue;
   } catch (error) {
     const logger = getLogger(["savemoney", "azure", "metrics"]);
+    // Passed as a template property (see pricing-service.ts for why).
     logger.error(
-      `Failed to fetch metric ${metricName} for resource ${resourceId}: ${error instanceof Error ? error.message : String(error)}`,
+      `Failed to fetch metric ${metricName} for resource ${resourceId}: {message}`,
+      { message: error instanceof Error ? error.message : String(error) },
     );
     return null;
   }

package/src/index.ts

@@ -38,6 +38,13 @@ export {
   type ResourceReport,
 } from "./finding.js";
 export { AZURE_SOURCE_VALUES } from "./schema.js";
+export {
+  buildSavemoneyInvocationTelemetryAttributes,
+  buildSavemoneyOutcomeTelemetryAttributes,
+  type SavemoneyAzqrReportSource,
+  type SavemoneyCommandInput,
+  type SavemoneySubscriptionsSource,
+} from "./telemetry/savemoney-command-telemetry.js";
 
 export * from "./types.js";
 

package/src/telemetry/savemoney-command-telemetry.ts

@@ -0,0 +1,83 @@
+/**
+ * SaveMoney command telemetry helpers.
+ *
+ * Keeps telemetry attribute derivation close to the SaveMoney domain so the
+ * same mapping can be reused by both the DX CLI adapter and a future standalone
+ * SaveMoney CLI entrypoint.
+ */
+
+import type {
+  AzureConfig,
+  AzureDetailedResourceReport,
+} from "../azure/types.js";
+
+export type SavemoneyAzqrReportSource = "cli" | "config" | "none";
+
+export type SavemoneyCommandInput = {
+  azqrReportPathOption?: string;
+  configPathOption?: string;
+  format: string;
+  resolvedConfig: Pick<
+    AzureConfig,
+    "azqrReportPath" | "pricing" | "sources" | "subscriptionIds"
+  >;
+  subscriptionIdsEnv?: string;
+};
+
+export type SavemoneySubscriptionsSource = "config" | "env" | "prompt";
+
+export function buildSavemoneyInvocationTelemetryAttributes(
+  input: SavemoneyCommandInput,
+): Record<string, boolean | number | string> {
+  const azqrReportSource = resolveAzqrReportSource(
+    input.azqrReportPathOption,
+    input.resolvedConfig.azqrReportPath,
+  );
+  const subscriptionsSource = resolveSubscriptionsSource(
+    input.configPathOption,
+    input.subscriptionIdsEnv,
+  );
+
+  return {
+    "savemoney.azqr_report_source": azqrReportSource,
+    "savemoney.format": input.format,
+    "savemoney.has_config": Boolean(input.configPathOption),
+    "savemoney.pricing_enabled":
+      input.resolvedConfig.pricing?.enabled !== false,
+    "savemoney.sources": input.resolvedConfig.sources.join(","),
+    "savemoney.subscriptions_count":
+      input.resolvedConfig.subscriptionIds.length,
+    "savemoney.subscriptions_source": subscriptionsSource,
+  };
+}
+
+export function buildSavemoneyOutcomeTelemetryAttributes(
+  reports: readonly Pick<AzureDetailedResourceReport, "findings">[],
+): Record<string, number> {
+  return {
+    "savemoney.findings_count": reports.reduce(
+      (sum, report) => sum + (report.findings?.length ?? 0),
+      0,
+    ),
+    "savemoney.resources_analyzed": reports.length,
+  };
+}
+
+function resolveAzqrReportSource(
+  azqrReportPathOption: string | undefined,
+  azqrReportPathResolved: string | undefined,
+): SavemoneyAzqrReportSource {
+  if (azqrReportPathOption) return "cli";
+  if (azqrReportPathResolved) return "config";
+  return "none";
+}
+
+function resolveSubscriptionsSource(
+  configPathOption: string | undefined,
+  subscriptionIdsEnv: string | undefined,
+): SavemoneySubscriptionsSource {
+  // Mirrors loadAzureConfig() priority: config file > ARM_SUBSCRIPTION_ID > prompt.
+  if (configPathOption) return "config";
+  if (subscriptionIdsEnv) return "env";
+  return "prompt";
+}

package/dist/__tests__/finding.test.d.ts

@@ -1,17 +0,0 @@
-/**
- * Tests for findingsFromAnalysisResult — verifies the adapter that converts
- * a legacy `AnalysisResult.reason` string into a structured `Finding[]`.
- *
- * Behaviours covered:
- * 1. Empty / whitespace-only reason → empty array.
- * 2. Single sentence (with or without trailing period) → one finding.
- * 3. Multi-sentence reason (". " separator) → one finding per sentence.
- * 4. Trailing period on the whole string → not duplicated.
- * 5. Custom `code` → propagated to every finding.
- * 6. Omitted `code` → defaults to "custom.unknown".
- * 7. Custom `source` → propagated.
- * 8. Omitted `source` → defaults to "custom".
- * 9. Every finding carries the correct `resourceId`, `severity`, `category`.
- */
-export {};
-//# sourceMappingURL=finding.test.d.ts.map

package/dist/__tests__/finding.test.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"finding.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/finding.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG"}

package/dist/__tests__/finding.test.js

@@ -1,146 +0,0 @@
-/**
- * Tests for findingsFromAnalysisResult — verifies the adapter that converts
- * a legacy `AnalysisResult.reason` string into a structured `Finding[]`.
- *
- * Behaviours covered:
- * 1. Empty / whitespace-only reason → empty array.
- * 2. Single sentence (with or without trailing period) → one finding.
- * 3. Multi-sentence reason (". " separator) → one finding per sentence.
- * 4. Trailing period on the whole string → not duplicated.
- * 5. Custom `code` → propagated to every finding.
- * 6. Omitted `code` → defaults to "custom.unknown".
- * 7. Custom `source` → propagated.
- * 8. Omitted `source` → defaults to "custom".
- * 9. Every finding carries the correct `resourceId`, `severity`, `category`.
- */
-import { describe, expect, it } from "vitest";
-import { findingsFromAnalysisResult } from "../finding.js";
-const BASE_ARGS = {
-    reason: "Low CPU usage.",
-    resourceId: "/subscriptions/sub1/resourceGroups/rg/providers/Microsoft.Compute/virtualMachines/vm",
-    severity: "high",
-};
-describe("findingsFromAnalysisResult", () => {
-    describe("empty / whitespace input", () => {
-        it("returns [] for an empty string", () => {
-            expect(findingsFromAnalysisResult({ ...BASE_ARGS, reason: "" })).toEqual([]);
-        });
-        it("returns [] for a whitespace-only string", () => {
-            expect(findingsFromAnalysisResult({ ...BASE_ARGS, reason: "   " })).toEqual([]);
-        });
-        it("returns [] for a bare period", () => {
-            expect(findingsFromAnalysisResult({ ...BASE_ARGS, reason: "." })).toEqual([]);
-        });
-    });
-    describe("single sentence", () => {
-        it("returns one finding with a trailing period", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                reason: "VM is deallocated.",
-            });
-            expect(result).toHaveLength(1);
-            expect(result[0].reason).toBe("VM is deallocated.");
-        });
-        it("appends a trailing period when missing", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                reason: "VM is deallocated",
-            });
-            expect(result).toHaveLength(1);
-            expect(result[0].reason).toBe("VM is deallocated.");
-        });
-    });
-    describe("multi-sentence reason", () => {
-        it("splits on '. ' into separate findings", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                reason: "VM is deallocated. No tags found. Low CPU usage.",
-            });
-            expect(result).toHaveLength(3);
-            expect(result[0].reason).toBe("VM is deallocated.");
-            expect(result[1].reason).toBe("No tags found.");
-            expect(result[2].reason).toBe("Low CPU usage.");
-        });
-        it("does not create an extra empty finding for a trailing period", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                reason: "Sentence one. Sentence two.",
-            });
-            expect(result).toHaveLength(2);
-        });
-    });
-    describe("code field", () => {
-        it("uses the provided code for every finding", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                code: "vm.deallocated",
-                reason: "A. B.",
-            });
-            expect(result.every((f) => f.code === "vm.deallocated")).toBe(true);
-        });
-        it("defaults code to 'custom.unknown' when omitted", () => {
-            const result = findingsFromAnalysisResult(BASE_ARGS);
-            expect(result[0].code).toBe("custom.unknown");
-        });
-    });
-    describe("source field", () => {
-        it("uses the provided source for every finding", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                source: "advisor",
-            });
-            expect(result.every((f) => f.source === "advisor")).toBe(true);
-        });
-        it("defaults source to 'custom' when omitted", () => {
-            const result = findingsFromAnalysisResult(BASE_ARGS);
-            expect(result[0].source).toBe("custom");
-        });
-    });
-    describe("static fields on every finding", () => {
-        it("propagates resourceId to every finding", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                reason: "A. B.",
-            });
-            expect(result.every((f) => f.resourceId === BASE_ARGS.resourceId)).toBe(true);
-        });
-        it("propagates severity to every finding", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                reason: "A. B.",
-                severity: "medium",
-            });
-            expect(result.every((f) => f.severity === "medium")).toBe(true);
-        });
-        it("sets category to 'cost' on every finding", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                reason: "A. B.",
-            });
-            expect(result.every((f) => f.category === "cost")).toBe(true);
-        });
-        it("never attaches estimatedMonthlySavings to custom findings", () => {
-            // Custom analyzers carry the resource's monthly cost on
-            // `AnalysisResult.estimatedMonthlySavings` and the report layer
-            // renders it at the resource level. Propagating it down to a
-            // single finding sentence (e.g. "No tags found") would falsely
-            // suggest that fixing that sentence yields the full saving.
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                reason: "Low CPU. Low network. Idle.",
-            });
-            expect(result).toHaveLength(3);
-            for (const f of result) {
-                expect(f.estimatedMonthlySavings).toBeUndefined();
-            }
-        });
-        it("omits estimatedMonthlySavings entirely", () => {
-            const result = findingsFromAnalysisResult({
-                ...BASE_ARGS,
-                reason: "Low CPU.",
-            });
-            expect(result[0].estimatedMonthlySavings).toBeUndefined();
-        });
-    });
-});
-//# sourceMappingURL=finding.test.js.map