@pagermon/ingest-core 1.0.5 → 1.2.0

package/.lefthook.yml

@@ -0,0 +1,15 @@
+# Lefthook configuration for PagerMon Ingest Core
+# @see https://github.com/evilmartians/lefthook
+
+pre-commit:
+  commands:
+    lint-and-format:
+      run: npx lint-staged
+      skip:
+        - merge
+        - rebase
+
+commit-msg:
+  commands:
+    commitlint:
+      run: npx commitlint --edit $GIT_PARAMS

package/.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "1.0.5"
+  ".": "1.2.0"
 }

package/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## [1.2.0](https://github.com/eopo/pagermon-ingest-core/compare/v1.1.0...v1.2.0) (2026-03-10)
+
+
+### Features
+
+* update ApiClient integration and unit tests to simplify response handling ([bc0d0ed](https://github.com/eopo/pagermon-ingest-core/commit/bc0d0ed22c28419080e9d6cbfdb892dec83c2225))
+
+
+### Bug Fixes
+
+* skip lefthook install in production builds ([1ace8ac](https://github.com/eopo/pagermon-ingest-core/commit/1ace8ac6883d32bc7a2f067d67eede7c4544a9d2))
+
+## [1.1.0](https://github.com/eopo/pagermon-ingest-core/compare/v1.0.5...v1.1.0) (2026-03-10)
+
+
+### Features
+
+* add adapter rebuild trigger to release workflow ([b916bfe](https://github.com/eopo/pagermon-ingest-core/commit/b916bfe491208144f07b5b033e2e910b6d61bf67))
+
+
+### Bug Fixes
+
+* enhance 'no-unused-vars' rule configuration in ESLint ([f6f1a69](https://github.com/eopo/pagermon-ingest-core/commit/f6f1a69feaf785e164d90d61b0171c70e1dd496f))
+
 ## [1.0.5](https://github.com/eopo/pagermon-ingest-core/compare/v1.0.4...v1.0.5) (2026-03-10)
 
 

package/commitlint.config.js

@@ -0,0 +1,35 @@
+/**
+ * Commitlint configuration for Conventional Commits
+ * Used by Release-Please for automatic changelog generation
+ *
+ * @see https://commitlint.js.org/
+ * @see https://www.conventionalcommits.org/
+ */
+export default {
+  extends: ['@commitlint/config-conventional'],
+  rules: {
+    'type-enum': [
+      2,
+      'always',
+      [
+        'feat', // New features
+        'fix', // Bug fixes
+        'docs', // Documentation changes
+        'style', // Code style changes (formatting, etc.)
+        'refactor', // Code refactoring
+        'perf', // Performance improvements
+        'test', // Test changes
+        'build', // Build system changes
+        'ci', // CI/CD changes
+        'chore', // Maintenance tasks
+        'revert', // Revert previous commit
+      ],
+    ],
+    'subject-case': [2, 'never', ['upper-case']], // No UPPERCASE subjects
+    'subject-full-stop': [2, 'never', '.'], // No period at end
+    'subject-empty': [2, 'never'], // Subject required
+    'type-empty': [2, 'never'], // Type required
+    'body-leading-blank': [2, 'always'], // Blank line before body
+    'footer-leading-blank': [2, 'always'], // Blank line before footer
+  },
+};

package/eslint.config.mjs

@@ -25,7 +25,15 @@ export default [
       camelcase: ['warn', { properties: 'never', ignoreDestructuring: true }],
 
       // Code quality
-      'no-unused-vars': ['error', { argsIgnorePattern: '^_', varsIgnorePattern: '^_' }],
+      'no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_|^err$',
+          caughtErrors: 'all',
+          caughtErrorsIgnorePattern: '^_|^err$',
+        },
+      ],
       'no-unused-expressions': 'off',
       'no-use-before-define': ['error', { functions: false, classes: true, variables: true }],
 

package/lib/core/ApiClient.js

@@ -1,49 +1,33 @@
-/**
- * API Client - PagerMon API communication
- *
- * Handles HTTP communication with the PagerMon API.
- */
-
 import http from 'http';
 import https from 'https';
 
-// Error classes
-class TimeoutError extends Error {
-  constructor(message) {
+class ApiError extends Error {
+  constructor(statusCode, message) {
     super(message);
-    this.name = 'TimeoutError';
+    this.name = 'ApiError';
+    this.statusCode = statusCode;
+    this.retryable = statusCode >= 500;
   }
 }
 
-class AuthError extends Error {
+class TimeoutError extends Error {
   constructor(message) {
     super(message);
-    this.name = 'AuthError';
-    this.isAuth = true;
+    this.name = 'TimeoutError';
+    this.retryable = true;
   }
 }
 
-class ClientError extends Error {
-  constructor(message) {
+class NetworkError extends Error {
+  constructor(message, originalError) {
     super(message);
-    this.name = 'ClientError';
-  }
-}
-
-class ServerError extends Error {
-  constructor(message) {
-    super(message);
-    this.name = 'ServerError';
+    this.name = 'NetworkError';
+    this.retryable = true;
+    this.originalError = originalError;
   }
 }
 
 class ApiClient {
-  /**
-   * @param {Object} config
-   * @param {string} config.url - API Base URL
-   * @param {string} config.apiKey - API key for authentication
-   * @param {Object} [options] - Additional options
-   */
   constructor(config, options = {}) {
     if (!config.url) throw new Error('ApiClient requires config.url');
     if (!config.apiKey) throw new Error('ApiClient requires config.apiKey');
@@ -51,80 +35,27 @@ class ApiClient {
     this.url = config.url;
     this.apiKey = config.apiKey;
     this.timeout = options.timeout || 10000;
-    this.retries = options.retries || 3;
-    this.retryDelay = options.retryDelay || 1000;
   }
 
-  /**
-   * Submit a message to the API
-   * @param {Message|Object} message - Message with address, message, format, etc.
-   * @returns {Promise<Object>} API response
-   */
   async submitMessage(message) {
     const payload = message.toPayload ? message.toPayload() : message;
-
-    try {
-      const result = await this._request('POST', '/api/messages', payload);
-      return { success: true, data: result };
-    } catch (err) {
-      return { success: false, error: err.message };
-    }
+    return await this._request('POST', '/api/messages', payload);
   }
 
-  /**
-   * Check API health
-   * @returns {Promise<boolean>}
-   */
   async checkHealth() {
     try {
-      const result = await this._request('GET', '/api/health', null, {
-        timeout: 5000,
-        retries: 1,
-      });
+      const result = await this._request('GET', '/api/health', null, { timeout: 5000 });
       return result && result.status === 'ok';
     } catch {
       return false;
     }
   }
 
-  /**
-   * Make HTTP request with retry logic
-   * @private
-   */
   async _request(method, path, body = null, options = {}) {
     const timeout = options.timeout || this.timeout;
-    const maxRetries = options.retries !== undefined ? options.retries : this.retries;
-
-    let lastErr;
-
-    // Sequential retry with exponential backoff is intentional here.
-    /* eslint-disable no-await-in-loop */
-    for (let attempt = 0; attempt <= maxRetries; attempt++) {
-      try {
-        return await this._makeRequest(method, path, body, timeout);
-      } catch (err) {
-        lastErr = err;
-
-        // Only retry on transient errors
-        if (!this._isTransientError(err)) {
-          throw err;
-        }
-
-        if (attempt < maxRetries) {
-          const delay = this.retryDelay * Math.pow(2, attempt); // Exponential backoff
-          await new Promise((resolve) => setTimeout(resolve, delay));
-        }
-      }
-    }
-    /* eslint-enable no-await-in-loop */
-
-    throw lastErr;
+    return await this._makeRequest(method, path, body, timeout);
   }
 
-  /**
-   * Actually execute the HTTP request
-   * @private
-   */
   _makeRequest(method, path, body, timeout) {
     return new Promise((resolve, reject) => {
       const url = new URL(path, this.url);
@@ -158,12 +89,8 @@ class ApiClient {
             if (res.statusCode >= 200 && res.statusCode < 300) {
               const parsed = data ? JSON.parse(data) : {};
               resolve(parsed);
-            } else if (res.statusCode === 401) {
-              reject(new AuthError('Unauthorized'));
-            } else if (res.statusCode >= 400 && res.statusCode < 500) {
-              reject(new ClientError(`${res.statusCode}: ${data}`));
             } else {
-              reject(new ServerError(`${res.statusCode}: ${data}`));
+              reject(new ApiError(res.statusCode, `${res.statusCode}: ${data}`));
             }
           } catch (err) {
             reject(err);
@@ -177,7 +104,7 @@ class ApiClient {
       });
 
       req.on('error', (err) => {
-        reject(err);
+        reject(new NetworkError(`Network error: ${err.message}`, err));
       });
 
       if (bodyStr) {
@@ -187,21 +114,6 @@ class ApiClient {
       req.end();
     });
   }
-
-  /**
-   * Determine if an error is transient (retryable)
-   * @private
-   */
-  _isTransientError(err) {
-    if (err instanceof TimeoutError) return true;
-    if (err instanceof ServerError) return true;
-    if (err instanceof ClientError) return false; // 4xx errors don't retry
-    if (err instanceof AuthError) return false; // 401 doesn't retry
-    if (err.code === 'ECONNREFUSED') return true;
-    if (err.code === 'ETIMEDOUT') return true;
-    if (err.code === 'EHOSTUNREACH') return true;
-    return false;
-  }
 }
 
 export default ApiClient;

package/lib/core/Worker.js

@@ -60,47 +60,48 @@ class Worker {
   async _processMessage(job) {
     const messageData = job.data;
 
-    const result = await this.apiClient.submitMessage(messageData);
+    try {
+      const result = await this.apiClient.submitMessage(messageData);
 
-    if (result.success) {
       console.debug(`[WORKER] Message sent: ${messageData.address}`);
 
       if (this.callbacks.onMessageProcessed) {
         this.callbacks.onMessageProcessed({
           jobId: job.id,
           message: messageData,
+          response: result,
         });
       }
 
       return result;
-    }
-    console.warn(`[WORKER] Message failed: ${messageData.address} - ${result.error}`);
+    } catch (error) {
+      console.warn(`[WORKER] Message failed: ${messageData.address} - ${error.message}`);
 
-    // If API is unhealthy, throw to trigger queue retry
-    if (!this.health.isHealthy) {
-      throw new Error(`API unhealthy: ${result.error}`);
-    }
+      // Emit failure callback with retry information
+      if (this.callbacks.onMessageFailed) {
+        this.callbacks.onMessageFailed({
+          jobId: job.id,
+          message: messageData,
+          error: error.message,
+          statusCode: error.statusCode,
+          retryable: error.retryable ?? true, // Default to retryable for unknown errors
+        });
+      }
 
-    // For other failures, throw only for retryable classes
-    if (result.error && result.error.includes('401')) {
-      throw new Error('API Authentication failed - will not retry');
-    }
+      // Check if API is unhealthy - always retry regardless of error type
+      if (!this.health.isHealthy) {
+        throw new Error(`API unhealthy: ${error.message}`);
+      }
 
-    if (result.error && !result.error.includes('4')) {
-      // Server-side errors should be retried
-      throw new Error(result.error);
-    }
+      // Use error.retryable property to decide if BullMQ should retry
+      if (error.retryable === false) {
+        // Non-retryable error (auth, client errors) - complete without retry
+        return;
+      }
 
-    if (this.callbacks.onMessageFailed) {
-      this.callbacks.onMessageFailed({
-        jobId: job.id,
-        message: messageData,
-        error: result.error,
-      });
+      // Retryable error - throw so BullMQ handles exponential backoff
+      throw error;
     }
-
-    // Return a soft-failure payload without throwing
-    return { failed: true, error: result.error };
   }
 
   /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pagermon/ingest-core",
-  "version": "1.0.5",
+  "version": "1.2.0",
   "description": "PagerMon ingest core runtime",
   "type": "module",
   "main": "index.js",
@@ -17,7 +17,16 @@
     "format": "prettier --write \"**/*.{js,mjs,json,md}\"",
     "format:check": "prettier --check \"**/*.{js,mjs,json,md}\"",
     "check": "npm run format:check && npm run lint",
-    "prepare": "husky"
+    "postinstall": "[ -z \"$CI\" ] && lefthook install || true"
+  },
+  "lint-staged": {
+    "*.{js,mjs}": [
+      "eslint --fix",
+      "prettier --write"
+    ],
+    "*.{json,md}": [
+      "prettier --write"
+    ]
   },
   "keywords": [
     "pagermon",
@@ -46,12 +55,15 @@
     "ioredis": "^5.8.2"
   },
   "devDependencies": {
+    "@commitlint/cli": "^20.4.3",
+    "@commitlint/config-conventional": "^20.4.3",
+    "@evilmartians/lefthook": "^2.1.3",
     "@vitest/coverage-v8": "^2.1.8",
     "eslint": "^9.16.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-prettier": "^5.2.1",
     "globals": "^15.14.0",
-    "husky": "^9.1.7",
+    "lint-staged": "^16.3.2",
     "prettier": "^3.4.2",
     "vitest": "^2.1.8"
   }