@pagefront/lint-commerce 0.8.0 → 0.9.0

package/dist/rules/pdp-w-032.js

@@ -4,8 +4,9 @@ import { asObject, isComplete, missingModifierProblems, resolveConfigurator, } f
  * Transcribed from commerce/spec/rules.md (normative).
  *
  * Applies to a resolving pricing block whose `pricing` is absent or
- * `complete`. One finding per priced option with no modifier, and one
- * per priced dimension that enumerates no options, all at the block.
+ * `complete`. One finding per priced option with no modifier, one per
+ * priced text dimension with no `*` modifier, and one per priced select
+ * dimension that enumerates no options, all at the block.
  */
 export const pdpW032 = {
     id: "PDP-W-032",
@@ -19,24 +20,31 @@ export const pdpW032 = {
         const configurator = resolveConfigurator(block, ctx.sheet);
         if (configurator === null)
             return null;
-        const hits = missingModifierProblems(configurator, block).map((p) => p.kind === "no-options"
+        const hits = missingModifierProblems(configurator, block).map((p) => p.kind === "no-text-modifier"
             ? {
                 values: {
                     dimension: p.dimension,
-                    problem: `cannot state modifiers for \`${p.dimension}\`, a priced dimension that enumerates no options`,
+                    problem: `states no \`*\` modifier for text dimension \`${p.dimension}\``,
                 },
             }
-            : {
-                values: {
-                    dimension: p.dimension,
-                    option: p.option,
-                    problem: `states no modifier for option \`${p.option}\` of \`${p.dimension}\``,
-                },
-            });
+            : p.kind === "no-options"
+                ? {
+                    values: {
+                        dimension: p.dimension,
+                        problem: `cannot state modifiers for \`${p.dimension}\`, a priced dimension that enumerates no options`,
+                    },
+                }
+                : {
+                    values: {
+                        dimension: p.dimension,
+                        option: p.option,
+                        problem: `states no modifier for option \`${p.option}\` of \`${p.dimension}\``,
+                    },
+                });
         return hits.length > 0 ? hits : null;
     },
     messageTemplate: "Pricing block at `{path}` {problem}, and `pricing` is not `partial`.",
-    remediation: "State the modifier, `\"0\"` included. If the dimension never changes the price, declare `affectsPrice: false` on it. If the price is not known, declare `pricing: \"partial\"`.",
+    remediation: "State the modifier, zero included; for a text dimension, state it under the key `\"*\"`. If the dimension never changes the price, declare `affectsPrice: false` on it. If the price is not known, declare `pricing: \"partial\"`.",
     introduced: "v0.9 (2026-10-01 revision)",
     specReference: "product.md#configurator-pricing-and-price-bands",
 };

package/dist/rules/pdp-w-036.d.ts

@@ -0,0 +1,2 @@
+import { type Rule } from "@pagefront/lint-core";
+export declare const pdpW036: Rule;

package/dist/rules/pdp-w-036.js

@@ -0,0 +1,31 @@
+import { valueAtPath } from "@pagefront/lint-core";
+import { asObject } from "./configurator-pricing.js";
+/**
+ * PDP-W-036 — Option value looks like a display label.
+ * Transcribed from commerce/spec/rules.md (normative).
+ *
+ * Heuristic on string option values: whitespace, an uppercase letter,
+ * or a decimal number followed by letters to the end (a unit suffix).
+ * Options of a sizing dimension (one declaring `system`) are exempt;
+ * PDP-W-037 checks those.
+ */
+const UNIT_SUFFIX = /^-?\d+(\.\d+)?\p{L}+$/u;
+export const pdpW036 = {
+    id: "PDP-W-036",
+    title: "Option value looks like a display label",
+    severity: "warning",
+    target: "$.data['pagefront:configurator'].dimensions[*].options[*]",
+    check: (match, ctx) => {
+        const value = asObject(match.value)?.["value"];
+        if (typeof value !== "string")
+            return null;
+        const dimension = asObject(valueAtPath(ctx.sheet, match.path.replace(/\['options'\]\[\d+\]$/, "")));
+        if (typeof dimension?.["system"] === "string")
+            return null;
+        return /\s/.test(value) || /\p{Lu}/u.test(value) || UNIT_SUFFIX.test(value) ? {} : null;
+    },
+    messageTemplate: "Option value should be a stable identifier; put the label in description.",
+    remediation: "Replace the value with a lowercase identifier without spaces (`yellow_gold`, `0.5`) and move the label to `description`. Put a unit in the dimension's `note`. Update the pricing block's keys, `baseConfiguration`, `when` and `exclusions` to the new value.",
+    introduced: "v0.9 (2026-10-01 revision)",
+    specReference: "product.md#configurator-pricing-and-price-bands",
+};

package/dist/rules/pdp-w-037.d.ts

@@ -0,0 +1,2 @@
+import { type Rule } from "@pagefront/lint-core";
+export declare const pdpW037: Rule;

package/dist/rules/pdp-w-037.js

@@ -0,0 +1,37 @@
+import { valueAtPath } from "@pagefront/lint-core";
+import { asObject } from "./configurator-pricing.js";
+/**
+ * PDP-W-037 — Option in a sizing dimension is not a size.
+ * Transcribed from commerce/spec/rules.md (normative).
+ *
+ * Heuristic on string option values of a dimension whose `system` is
+ * `UK`, `EU`, `US` or `JP`: the value is written as that system writes
+ * a size. Other systems are out of scope.
+ */
+const NUMERIC_SIZE = /^\d+(\.\d+|½)?$/;
+const SIZE_IN_SYSTEM = {
+    UK: /^[A-Z]\s*½?$/,
+    EU: NUMERIC_SIZE,
+    US: NUMERIC_SIZE,
+    JP: NUMERIC_SIZE,
+};
+export const pdpW037 = {
+    id: "PDP-W-037",
+    title: "Option in a sizing dimension is not a size",
+    severity: "warning",
+    target: "$.data['pagefront:configurator'].dimensions[*].options[*]",
+    check: (match, ctx) => {
+        const value = asObject(match.value)?.["value"];
+        if (typeof value !== "string")
+            return null;
+        const dimension = asObject(valueAtPath(ctx.sheet, match.path.replace(/\['options'\]\[\d+\]$/, "")));
+        const system = dimension?.["system"];
+        if (typeof system !== "string" || !Object.hasOwn(SIZE_IN_SYSTEM, system))
+            return null;
+        return SIZE_IN_SYSTEM[system].test(value) ? null : {};
+    },
+    messageTemplate: "Option does not look like a size in the declared system.",
+    remediation: "Remove the entry if it is a service, and describe the service in the dimension's `note` or in `pagefront:madeToOrderTerms.aftermarketServices`. If it is a size, write it as the system writes it, without the system's name.",
+    introduced: "v0.9 (2026-10-01 revision)",
+    specReference: "product.md#configurator-pricing-and-price-bands",
+};

package/dist/rules/pdp-w-038.d.ts

@@ -0,0 +1,2 @@
+import type { Rule } from "@pagefront/lint-core";
+export declare const pdpW038: Rule;

package/dist/rules/pdp-w-038.js

@@ -0,0 +1,30 @@
+import { asObject } from "./configurator-pricing.js";
+/**
+ * PDP-W-038 — Configurator note reads as page copy.
+ * Transcribed from commerce/spec/rules.md (normative).
+ *
+ * Heuristic on English Sheets (`inLanguage` `en` or `en-…`): the
+ * dimension's `note` contains `you`, `your`, `select`, `order` or
+ * `contact` as a whole word, delimited by non-letters.
+ */
+const PAGE_COPY_WORD = /(?<!\p{L})(you|your|select|order|contact)(?!\p{L})/iu;
+export const pdpW038 = {
+    id: "PDP-W-038",
+    title: "Configurator note reads as page copy",
+    severity: "warning",
+    target: "$.data['pagefront:configurator'].dimensions[*]",
+    check: (match, ctx) => {
+        const inLanguage = asObject(ctx.sheet.data)?.["inLanguage"];
+        if (typeof inLanguage !== "string" || !/^en(-|$)/i.test(inLanguage))
+            return null;
+        const note = asObject(match.value)?.["note"];
+        if (typeof note !== "string")
+            return null;
+        const found = PAGE_COPY_WORD.exec(note);
+        return found === null ? null : { values: { word: found[1].toLowerCase() } };
+    },
+    messageTemplate: "Note reads as page copy; state the fact.",
+    remediation: "Restate the note as a fact in the third person: what the merchant offers or recommends, with no \"you\" and no instruction.",
+    introduced: "v0.9 (2026-10-01 revision)",
+    specReference: "product.md#configurator-pricing-and-price-bands",
+};

package/dist/rules/pdp-w-039.d.ts

@@ -0,0 +1,10 @@
+import type { Rule } from "@pagefront/lint-core";
+/**
+ * PDP-W-039 — Size advice carried as prose only.
+ * Transcribed from commerce/spec/rules.md (normative).
+ *
+ * Fires when `pagefront:sizeRecommendation` carries a non-empty
+ * `description` and no `sizeAdjustment`, and the configurator has a
+ * sizing dimension. `{system}` is the first sizing dimension's system.
+ */
+export declare const pdpW039: Rule;

package/dist/rules/pdp-w-039.js

@@ -0,0 +1,29 @@
+import { asObject, readConfigurator } from "./configurator-pricing.js";
+/**
+ * PDP-W-039 — Size advice carried as prose only.
+ * Transcribed from commerce/spec/rules.md (normative).
+ *
+ * Fires when `pagefront:sizeRecommendation` carries a non-empty
+ * `description` and no `sizeAdjustment`, and the configurator has a
+ * sizing dimension. `{system}` is the first sizing dimension's system.
+ */
+export const pdpW039 = {
+    id: "PDP-W-039",
+    title: "Size advice carried as prose only",
+    severity: "warning",
+    target: "$.data['pagefront:sizeRecommendation']",
+    check: (match, ctx) => {
+        const recommendation = asObject(match.value);
+        if (recommendation === null || recommendation["sizeAdjustment"] !== undefined)
+            return null;
+        const description = recommendation["description"];
+        if (typeof description !== "string" || description.trim() === "")
+            return null;
+        const sizing = (readConfigurator(ctx.sheet)?.dimensions ?? []).find((d) => d.system !== undefined);
+        return sizing?.system === undefined ? null : { values: { system: sizing.system } };
+    },
+    messageTemplate: "Size advice at `{path}` could not be stated in the Sheet's sizing system (`{system}`); it is carried as prose only.",
+    remediation: "If the merchant states the advice in the sizing dimension's system, add a `sizeAdjustment` in that system. If it does not, no action: do not convert between systems.",
+    introduced: "v0.9 (2026-10-01 revision)",
+    specReference: "product.md#size-guidance-pagefrontsizechart-and-pagefrontsizerecommendation",
+};