@pagefront/lint-commerce 0.12.0 → 0.12.1

package/README.md

@@ -26,7 +26,7 @@ lint with their own catalogue, dispatched by sheet type.
 
 ## Catalogue
 
-Catalogue 0.16.0, supporting commerce releases 0.4.0 (Product Sheet spec
+Catalogue 0.16.1, supporting commerce releases 0.4.0 (Product Sheet spec
 0.10.0, Organization Sheet spec 0.4.0) and 0.3.0, and the legacy draft line
 (format 0.9): 58 product rules (`PDP-E-001` to `PDP-E-018`, `PDP-W-001` to
 `PDP-W-039`, `PDP-I-001`) and 10 organization rules (`ORG-E-001` to
@@ -175,6 +175,14 @@ Added in 0.12.0 (catalogue 0.16.0), with commerce release 0.4.0. Requires
 - `PDP-E-018` and `ORG-E-004` — the sheet declares a `release` the release
   manifest does not list. At Layer 1 this is a single error at `/release`.
 
+Changed in 0.12.1 (catalogue 0.16.1):
+
+- `PDP-E-017` adds a type hint. When a reference matches no option but a
+  declared option has the same text under another JSON type, the message
+  names both types, and the finding's `values` carry `reference_type`,
+  `declared_option` and `declared_type`. Comparison is unchanged and the
+  finding stays an error.
+
 ## API
 
 The public surface — everything importable from the package root, and

package/dist/catalogue.js

@@ -67,6 +67,6 @@ import { pdpI001 } from "./rules/pdp-i-001.js";
 export const commerceCatalogue = {
     vertical: "commerce",
     releases: KNOWN_RELEASES,
-    catalogueVersion: "0.16.0",
+    catalogueVersion: "0.16.1",
     rules: [pdpE001, pdpE002, pdpE003, pdpE004, pdpE005, pdpE006, pdpE007, pdpE008, pdpE009, pdpE010, pdpE011, pdpE012, pdpE013, pdpE014, pdpE015, pdpE016, pdpE017, pdpE018, pdpW001, pdpW002, pdpW003, pdpW004, pdpW005, pdpW006, pdpW007, pdpW008, pdpW009, pdpW010, pdpW011, pdpW012, pdpW013, pdpW014, pdpW015, pdpW016, pdpW017, pdpW018, pdpW019, pdpW020, pdpW021, pdpW022, pdpW023, pdpW024, pdpW025, pdpW026, pdpW027, pdpW028, pdpW029, pdpW030, pdpW031, pdpW032, pdpW033, pdpW034, pdpW035, pdpW036, pdpW037, pdpW038, pdpW039, pdpI001],
 };

package/dist/organization-catalogue.js

@@ -21,6 +21,6 @@ import { orgW006 } from "./rules/org-w-006.js";
 export const organizationCatalogue = {
     vertical: "commerce",
     releases: KNOWN_RELEASES,
-    catalogueVersion: "0.16.0",
+    catalogueVersion: "0.16.1",
     rules: [orgE001, orgE002, orgE003, orgE004, orgW001, orgW002, orgW003, orgW004, orgW005, orgW006],
 };

package/dist/rules/pdp-e-017.js

@@ -1,4 +1,13 @@
 import { asObject, own, pricedConfiguratorId, pricingBlock, seg } from "./configurator-pricing.js";
+function isScalar(value) {
+    return typeof value === "string" || typeof value === "number" || typeof value === "boolean";
+}
+/** The declared option that equals `value` after string conversion, if any. */
+function sameTextOption(value, declared) {
+    if (!isScalar(value))
+        return undefined;
+    return declared.find((v) => isScalar(v) && String(v) === String(value));
+}
 function declaredDimensions(configurator) {
     const out = new Map();
     const dimensions = configurator["dimensions"];
@@ -22,15 +31,34 @@ function unresolved(pairs, path, dimensions) {
     for (const [dimension, value] of Object.entries(asObject(pairs) ?? {})) {
         const option = JSON.stringify(value);
         const declared = dimensions.get(dimension);
-        let problem = null;
+        const at = `${path}${seg(dimension)}`;
         if (declared === undefined) {
-            problem = `the configurator declares no dimension \`${dimension}\``;
+            const problem = `the configurator declares no dimension \`${dimension}\``;
+            hits.push({ path: at, values: { dimension, option, problem } });
         }
         else if (declared.values !== null && !declared.values.some((v) => v === value)) {
-            problem = `\`${dimension}\` lists no option \`${option}\``;
-        }
-        if (problem !== null) {
-            hits.push({ path: `${path}${seg(dimension)}`, values: { dimension, option, problem } });
+            const near = sameTextOption(value, declared.values);
+            if (near === undefined) {
+                const problem = `\`${dimension}\` lists no option \`${option}\``;
+                hits.push({ path: at, values: { dimension, option, problem } });
+            }
+            else {
+                const declaredOption = JSON.stringify(near);
+                const referenceType = typeof value;
+                const declaredType = typeof near;
+                const problem = `it references \`${option}\` (${referenceType}); dimension \`${dimension}\` declares \`${declaredOption}\` (${declaredType})`;
+                hits.push({
+                    path: at,
+                    values: {
+                        dimension,
+                        option,
+                        problem,
+                        reference_type: referenceType,
+                        declared_option: declaredOption,
+                        declared_type: declaredType,
+                    },
+                });
+            }
         }
     }
     return hits;

package/dist/version.d.ts

@@ -5,4 +5,4 @@
  * (test/linter-version.test.mjs) fails when they diverge. Regenerate
  * on version bump.
  */
-export declare const PACKAGE_VERSION = "0.12.0";
+export declare const PACKAGE_VERSION = "0.12.1";

package/dist/version.js

@@ -5,4 +5,4 @@
  * (test/linter-version.test.mjs) fails when they diverge. Regenerate
  * on version bump.
  */
-export const PACKAGE_VERSION = "0.12.0";
+export const PACKAGE_VERSION = "0.12.1";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pagefront/lint-commerce",
-  "version": "0.12.0",
+  "version": "0.12.1",
   "description": "Pagefront commerce linter: the commerce rule catalogue and CLI, on the @pagefront/lint-core engine.",
   "license": "Apache-2.0",
   "repository": {