@pagamio/frontend-commons-lib 0.8.344 → 0.8.345

package/lib/pagamio-drawer/components/DrawerContent.js

@@ -8,32 +8,38 @@ import { useFormPersistence } from '../../form-engine/hooks/useFormPersistence';
 const DrawerContent = ({ fields, onSubmit, isOpen, initialValues, submitButtonText = 'Submit', cancelButtonText = 'Cancel', showForm = true, showDrawerButtons = true, handleCloseDrawer, onFieldUpdate, onFieldChange, children, updateFieldOptions, updateFieldLabel, setFieldHidden, addField, updateFieldValidation, processInitialFieldUpdates, processingDependencyRef, pendingUpdatesRef, persistenceKey, clearOnClose = false, isDirtyRef, cancelRef, }) => {
     const { saveFormData, restoreFormData, clearPersistedData, hasPersistedData } = useFormPersistence(persistenceKey);
     const { addToast } = useToast();
-    // Build a `{ fieldName: '' }` baseline so every registered input starts
-    // controlled (with a defined string value). Without this, RHF defaults
-    // unspecified fields to `undefined`, which React flags as a "controlled
-    // → uncontrolled" transition the moment we reset, and Radix Select keeps
-    // showing its previously-selected display value.
+    // For clearOnClose drawers, seed an `{ fieldName: '' }` baseline so every
+    // registered input starts controlled with a defined string value. Without
+    // this, RHF leaves unspecified fields as `undefined`, and Radix Select
+    // refuses to update its visual state when we reset on close — the
+    // controlled→uncontrolled transition is the bug we're fixing.
+    // We intentionally only seed empties when clearOnClose is true: legacy
+    // drawers that relied on `undefined`-vs-`""` distinctions in their submit
+    // payload (e.g. "field omitted means don't update") keep their exact
+    // previous behaviour.
     const emptyFieldValues = useMemo(() => {
+        if (!clearOnClose)
+            return undefined;
         const acc = {};
         for (const f of fields) {
             acc[f.name] = '';
         }
         return acc;
-    }, [fields]);
+    }, [clearOnClose, fields]);
     // Determine initial values: initialValues take precedence over persisted data.
     // For clearOnClose drawers we always start from the empty baseline so a
     // stale persistence entry from a previous lifetime can't leak in.
     const getEffectiveInitialValues = () => {
         if (initialValues && Object.keys(initialValues).length > 0) {
-            return { ...emptyFieldValues, ...initialValues };
+            return emptyFieldValues ? { ...emptyFieldValues, ...initialValues } : initialValues;
         }
         if (!clearOnClose && persistenceKey && hasPersistedData()) {
             const persistedData = restoreFormData();
             if (persistedData) {
-                return { ...emptyFieldValues, ...persistedData };
+                return persistedData;
             }
         }
-        return emptyFieldValues;
+        return emptyFieldValues ?? initialValues ?? {};
     };
     const { control, handleSubmit, watch, setValue, clearErrors, formState: { errors, isSubmitting }, reset, getValues, } = useForm({ mode: 'onBlur', defaultValues: getEffectiveInitialValues() });
     const [pendingUpdateCount, setPendingUpdateCount] = useState(0);
@@ -68,7 +74,7 @@ const DrawerContent = ({ fields, onSubmit, isOpen, initialValues, submitButtonTe
         previousIsOpenRef.current = !!isOpen;
         if (wasOpen && !isOpen && clearOnCloseRef.current) {
             clearPersistedDataRef.current();
-            resetRef.current(emptyFieldValuesRef.current);
+            resetRef.current(emptyFieldValuesRef.current ?? {});
         }
     }, [isOpen]);
     const password = watch('password');

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@pagamio/frontend-commons-lib",
   "description": "Pagamio library for Frontend reusable components like the form engine and table container",
-  "version": "0.8.344",
+  "version": "0.8.345",
   "publishConfig": {
     "access": "public",
     "provenance": false