@oxyhq/services 30.0.0 → 30.1.0

package/lib/typescript/types/expo-image-picker.d.ts

@@ -0,0 +1,35 @@
+declare module 'expo-image-picker' {
+    export interface ImagePickerAsset {
+        uri: string;
+        width: number;
+        height: number;
+    }
+
+    export interface ImagePickerSuccessResult {
+        canceled: false;
+        assets: ImagePickerAsset[];
+    }
+
+    export interface ImagePickerCanceledResult {
+        canceled: true;
+        assets: null;
+    }
+
+    export type ImagePickerResult = ImagePickerSuccessResult | ImagePickerCanceledResult;
+
+    export interface ImagePickerPermission {
+        granted: boolean;
+        canAskAgain: boolean;
+    }
+
+    export interface ImagePickerOptions {
+        mediaTypes?: 'images'[];
+        allowsMultipleSelection?: boolean;
+        quality?: number;
+    }
+
+    export function launchImageLibraryAsync(options?: ImagePickerOptions): Promise<ImagePickerResult>;
+    export function launchCameraAsync(options?: ImagePickerOptions): Promise<ImagePickerResult>;
+    export function requestMediaLibraryPermissionsAsync(): Promise<ImagePickerPermission>;
+    export function requestCameraPermissionsAsync(): Promise<ImagePickerPermission>;
+}

package/lib/typescript/types/expo-secure-store.d.ts

@@ -0,0 +1,22 @@
+declare module 'expo-secure-store' {
+  export interface SecureStoreOptions {
+    keychainAccessible?: 'WHEN_UNLOCKED' | 'AFTER_FIRST_UNLOCK' | 'WHEN_UNLOCKED_THIS_DEVICE_ONLY' | 'AFTER_FIRST_UNLOCK_THIS_DEVICE_ONLY' | 'WHEN_PASSCODE_SET_THIS_DEVICE_ONLY';
+    requireAuthentication?: boolean;
+    authenticationPrompt?: string;
+    showModal?: boolean;
+    keychainService?: string;
+  }
+
+  export const WHEN_UNLOCKED: 'WHEN_UNLOCKED';
+  export const AFTER_FIRST_UNLOCK: 'AFTER_FIRST_UNLOCK';
+  export const WHEN_UNLOCKED_THIS_DEVICE_ONLY: 'WHEN_UNLOCKED_THIS_DEVICE_ONLY';
+  export const AFTER_FIRST_UNLOCK_THIS_DEVICE_ONLY: 'AFTER_FIRST_UNLOCK_THIS_DEVICE_ONLY';
+  export const WHEN_PASSCODE_SET_THIS_DEVICE_ONLY: 'WHEN_PASSCODE_SET_THIS_DEVICE_ONLY';
+
+  export function setItemAsync(key: string, value: string, options?: SecureStoreOptions): Promise<void>;
+  export function getItemAsync(key: string, options?: SecureStoreOptions): Promise<string | null>;
+  export function deleteItemAsync(key: string, options?: SecureStoreOptions): Promise<void>;
+  export function isAvailableAsync(): Promise<boolean>;
+}
+
+

package/lib/typescript/types/express.d.ts

@@ -0,0 +1,24 @@
+declare module 'express' {
+  export function Router(): {
+    get: (path: string, ...handlers: Array<(req: Request, res: Response, next: () => void) => void>) => void;
+    post: (path: string, ...handlers: Array<(req: Request, res: Response, next: () => void) => void>) => void;
+    put: (path: string, ...handlers: Array<(req: Request, res: Response, next: () => void) => void>) => void;
+    delete: (path: string, ...handlers: Array<(req: Request, res: Response, next: () => void) => void>) => void;
+    use: (path: string | (() => void), ...handlers: Array<(req: Request, res: Response, next: () => void) => void>) => void;
+  };
+  export interface Request { 
+    body?: Record<string, unknown>;
+    params: Record<string, string>;
+    query: Record<string, string | string[]>;
+    headers: Record<string, string>;
+    user?: Record<string, unknown>;
+    [key: string]: unknown;
+  }
+  export interface Response { 
+    status: (code: number) => Response;
+    json: (data: unknown) => Response;
+    send: (data: unknown) => Response;
+    redirect: (url: string) => Response;
+    [key: string]: unknown;
+  }
+}

package/lib/typescript/types/react-native-classname.d.ts

@@ -0,0 +1,39 @@
+// Robust NativeWind className typings for React Native's `ScrollView` & `FlatList`.
+//
+// NativeWind 5's engine (`react-native-css`) augments `ScrollViewProps` and
+// `FlatListProps` with className props, but its declarations carry heritage
+// clauses (`interface ScrollViewProps extends ViewProps, ScrollViewPropsIOS, …`)
+// and route `FlatList`'s `contentContainerClassName` through a deep
+// `@react-native/virtualized-lists` → `ScrollViewProps` augmentation. Under
+// React Native 0.85 that heritage no longer matches, and the nested
+// `@react-native/virtualized-lists` copy does not resolve from a CONSUMER's
+// `node_modules` — so when this package's source is type-checked through the
+// `react-native` export condition (which resolves `@oxyhq/services` to raw
+// `src/`), those className members silently drop and consumer `tsc` fails with
+// TS2769 on screens that use `contentContainerClassName` (e.g.
+// ManageAccountScreen, ConnectedAppsScreen).
+//
+// These heritage-free augmentations add the className props directly to the two
+// interfaces, so resolution never depends on the deep virtualized-lists copy or
+// on react-native-css's heritage clauses. The plain `import 'react-native'`
+// makes this a module so the `declare module` is treated as an augmentation
+// (merge) rather than a redeclaration. Consumers load it via the
+// `/// <reference path>` directives in `src/index.ts` and `src/ui/index.ts`.
+
+import 'react-native';
+
+declare module 'react-native' {
+  interface ScrollViewProps {
+    className?: string;
+    contentContainerClassName?: string;
+    indicatorClassName?: string;
+  }
+
+  interface FlatListProps<ItemT> {
+    className?: string;
+    contentContainerClassName?: string;
+    columnWrapperClassName?: string;
+    ListHeaderComponentClassName?: string;
+    ListFooterComponentClassName?: string;
+  }
+}

package/lib/typescript/types/react-native-web-style.d.ts

@@ -0,0 +1,27 @@
+// Web-only CSS transition/transform typings for React Native's `ViewStyle`.
+//
+// On web, React Native for Web forwards these CSS properties straight through to
+// the underlying DOM element, so an inline `style={{ transitionProperty: … }}`
+// works at runtime — but RN's `ViewStyle` type (which targets native) does not
+// declare them, so `tsc` rejects the object literal (TS2322 "Object literal may
+// only specify known properties"). Components that reproduce web animations with
+// inline transition styles (e.g. `ProfileButton`'s Bluesky-style hover reveal)
+// need these keys typed without resorting to `as any`.
+//
+// This augmentation adds ONLY the standard CSS animation/transition properties
+// as optional `string`s. It is guarded at the call site behind `Platform.OS ===
+// 'web'`, so native code paths never emit them. The plain `import 'react-native'`
+// makes this a module augmentation (merge) rather than a redeclaration. Consumers
+// load it via the `/// <reference path>` directives in `src/index.ts` and
+// `src/ui/index.ts`, alongside `react-native-classname.d.ts`.
+
+import 'react-native';
+
+declare module 'react-native' {
+  interface ViewStyle {
+    transitionProperty?: string;
+    transitionDuration?: string;
+    transitionDelay?: string;
+    transitionTimingFunction?: string;
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oxyhq/services",
-  "version": "30.0.0",
+  "version": "30.1.0",
   "description": "OxyHQ Expo/React Native SDK — UI components, screens, and native features",
   "main": "lib/commonjs/index.js",
   "module": "lib/module/index.js",
@@ -112,6 +112,8 @@
     "typescript": "tsc --skipLibCheck --noEmit",
     "lint": "biome lint --error-on-warnings ./src",
     "build": "bun x react-native-builder-bob build --target commonjs && bun x react-native-builder-bob build --target module && bun x react-native-builder-bob build --target typescript && bun run copy-assets && bun run copy-dts && bun run delete-dts.js && bun run delete-debug-view",
+    "postbuild": "node scripts/verify-package.mjs",
+    "verify:package": "node scripts/verify-package.mjs",
     "build:js": "bun x react-native-builder-bob build --target commonjs && bun x react-native-builder-bob build --target module && bun run copy-assets",
     "test": "jest --passWithNoTests",
     "test:watch": "jest --watch",
@@ -138,7 +140,7 @@
     }
   },
   "dependencies": {
-    "@oxyhq/contracts": "0.29.0",
+    "@oxyhq/contracts": "0.33.0",
     "@simplewebauthn/browser": "^13.3.0",
     "color": "^4.2.3"
   },
@@ -147,7 +149,7 @@
     "@commitlint/cli": "^21.2.1",
     "@commitlint/config-conventional": "^21.2.0",
     "@expo/vector-icons": "^15.0.3",
-    "@oxyhq/core": "21.0.0",
+    "@oxyhq/core": "22.0.0",
     "@react-native-async-storage/async-storage": "^2.0.0",
     "@react-native-community/netinfo": "^11.4.1",
     "@react-native/babel-preset": "^0.86.2",
@@ -191,7 +193,7 @@
   "peerDependencies": {
     "@expo/vector-icons": "^15.0.3",
     "@oxyhq/bloom": "^1.0.0",
-    "@oxyhq/core": "^21.0.0",
+    "@oxyhq/core": "^21.0.0 || ^22.0.0",
     "@react-native-async-storage/async-storage": "^2.0.0",
     "@react-native-community/netinfo": ">=11.4.1",
     "@tanstack/query-async-storage-persister": "^5.101",

package/src/ui/components/OxySignInButton.tsx

@@ -303,10 +303,11 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
     );
 
     // Resolve the Application once, then route: third-party → OAuth; first-party
-    // / official / unresolved → the in-app dialog. Resolution failure NEVER
-    // breaks an official app's sign-in — it falls back to the dialog. Every path
-    // that does NOT reach the OAuth lane closes the pre-opened popup, so a
-    // mis-routed press can never leave an empty window on screen.
+    // / official → the in-app dialog. An unresolved client must fail closed:
+    // opening the privileged device-session dialog without a known first-party
+    // classification could downgrade a third-party OAuth + PKCE flow. Every path
+    // that does NOT reach the OAuth lane closes the pre-opened popup, so an
+    // aborted press can never leave an empty window on screen.
     const routeSignIn = useCallback(
         async (popup: OAuthPopupHandle | null): Promise<void> => {
             if (routingRef.current) {
@@ -327,11 +328,11 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
                 } catch (error) {
                     closeOAuthPopup(popup);
                     logger.warn(
-                        'OxySignInButton: could not resolve the application; opening the sign-in dialog',
+                        'OxySignInButton: could not resolve the application; sign-in aborted',
                         { component: 'OxySignInButton', clientId },
                         error,
                     );
-                    startOfficialSignIn();
+                    notifyFailed();
                     return;
                 }
                 if (app.type === 'third_party' && !app.isOfficial) {

package/src/ui/oauth/oauthPopupMessages.ts

@@ -103,6 +103,15 @@ export function readOAuthPopupMessage(
   event: MessageEvent,
   context: OAuthPopupMessageContext,
 ): OAuthPopupMessageVerdict {
+  // These two are a PAIR, and the source check is load-bearing rather than
+  // belt-and-braces. `expectedOrigin` is `new URL(authorizeUrl).origin`, and
+  // `authorizeBaseUrl` is app-configurable — a non-http(s) value makes that
+  // expression the literal string `"null"`, the opaque origin, which is also
+  // what a browser reports as `event.origin` for EVERY sandboxed iframe,
+  // `data:` document and `file:` page. The origin check stops discriminating at
+  // that point and the source check is the only thing still refusing them.
+  // Do not collapse them into one, and do not drop the source check as
+  // redundant with the origin check: it is not, in the one case that matters.
   if (event.origin !== context.expectedOrigin) return { kind: 'ignore' };
   if (!isSameWindowReference(event.source, context.popup)) return { kind: 'ignore' };
 

package/src/ui/screens/CreateAccountScreen.tsx

@@ -4,6 +4,13 @@ import { View, ActivityIndicator } from 'react-native';
 import Ionicons from '@expo/vector-icons/Ionicons';
 import type { AccountCategoryId, AccountKind, CreateAccountInput } from '@oxyhq/core';
 import { accountCategoryLabel, DISPLAY_NAME_INVALID_MESSAGE, isValidDisplayName, MAX_ACCOUNT_CATEGORIES, MAX_DISPLAY_NAME_LENGTH, SELECTABLE_ACCOUNT_CATEGORY_IDS } from '@oxyhq/core';
+import {
+  isValidUsername,
+  stripDisallowedUsernameCharacters,
+  USERNAME_INVALID_MESSAGE,
+  USERNAME_MAX_LENGTH,
+  USERNAME_MIN_LENGTH,
+} from '@oxyhq/contracts';
 import type { BaseScreenProps } from '../types/navigation';
 import { useI18n } from '../hooks/useI18n';
 import { useSurfaceHeader } from '../hooks/useSurfaceHeader';
@@ -36,9 +43,7 @@ type UsernameStatus = 'idle' | 'checking' | 'available' | 'taken' | 'invalid';
  */
 type CreatableAccountKind = Extract<AccountKind, 'organization' | 'project' | 'bot'>;
 
-const USERNAME_REGEX = /^[a-zA-Z0-9_-]{3,30}$/;
 const DEBOUNCE_MS = 400;
-const USERNAME_MAX = 30;
 const DISPLAY_NAME_MAX = MAX_DISPLAY_NAME_LENGTH;
 const BIO_MAX = 160;
 
@@ -144,21 +149,24 @@ const CreateAccountScreen: React.FC<BaseScreenProps> = ({
       clearTimeout(debounceTimerRef.current);
     }
 
-    if (!value || value.length < 3) {
+    if (!value || value.length < USERNAME_MIN_LENGTH) {
       setUsernameStatus(value.length > 0 ? 'invalid' : 'idle');
       setUsernameMessage(
         value.length > 0
-          ? (t('accounts.create.username.tooShort') || 'Username must be at least 3 characters')
+          ? (t('accounts.create.username.tooShort')
+            || `Username must be at least ${USERNAME_MIN_LENGTH} characters`)
           : '',
       );
       return;
     }
 
-    if (!USERNAME_REGEX.test(value)) {
+    // The ONE policy, from `@oxyhq/contracts`. This screen used to carry a
+    // private copy of the rule, and the server it talks to enforced a LOOSER one
+    // — so a name this field refused was a name `POST /accounts` would happily
+    // have stored.
+    if (!isValidUsername(value)) {
       setUsernameStatus('invalid');
-      setUsernameMessage(
-        t('accounts.create.username.invalidChars') || 'Only letters, numbers, hyphens, and underscores',
-      );
+      setUsernameMessage(t('accounts.create.username.invalidChars') || USERNAME_INVALID_MESSAGE);
       return;
     }
 
@@ -186,7 +194,11 @@ const CreateAccountScreen: React.FC<BaseScreenProps> = ({
   }, [oxyServices, t]);
 
   const handleUsernameChange = useCallback((value: string) => {
-    const cleaned = value.toLowerCase().replace(/[^a-z0-9_-]/g, '');
+    // Filters characters the policy forbids, and nothing else. It no longer
+    // lower-cases: `MyBot` is stored as `MyBot`, and uniqueness is decided
+    // case-insensitively by the database index rather than by rewriting what
+    // somebody typed.
+    const cleaned = stripDisallowedUsernameCharacters(value);
     setUsername(cleaned);
     checkUsername(cleaned);
   }, [checkUsername]);
@@ -360,7 +372,7 @@ const CreateAccountScreen: React.FC<BaseScreenProps> = ({
                 autoCapitalize="none"
                 autoCorrect={false}
                 autoComplete="off"
-                maxLength={USERNAME_MAX}
+                maxLength={USERNAME_MAX_LENGTH}
               />
             </TextField>
             {(usernameStatus === 'checking' || usernameMessage) ? (