@oxyhq/services 26.0.4 → 26.1.0

package/src/ui/components/OxySignInButton.tsx

@@ -12,6 +12,7 @@ import { useAuthStore } from '../stores/authStore';
 import { useShallow } from 'zustand/react/shallow';
 import { useTheme } from '@oxyhq/bloom/theme';
 import { Button, type ButtonVariant } from '@oxyhq/bloom/button';
+import { toast } from '@oxyhq/bloom/toast';
 import { useOxy } from '../context/OxyContext';
 import { useI18n } from '../hooks/useI18n';
 import { LogoIcon } from './logo/LogoIcon';
@@ -201,6 +202,24 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
         return promise;
     }, [clientId, oxyServices]);
 
+    // A press that cannot reach a sign-in surface must SAY so. Without this the
+    // only trace of an aborted sign-in was a console line, so the button read as
+    // simply dead — the SDK owns this so no relying party has to wire it up.
+    // `ToastOutlet` is already mounted by `OxyProvider`.
+    const notifyNotConfigured = useCallback(
+        (appName: string) => {
+            toast.error(t('signin.errors.notConfigured'), {
+                description: t('signin.errors.notConfiguredDescription', { app: appName }),
+            });
+        },
+        [t],
+    );
+    const notifyFailed = useCallback(() => {
+        toast.error(t('signin.errors.failed'), {
+            description: t('signin.errors.failedDescription'),
+        });
+    }, [t]);
+
     // Official / first-party surface: the in-app account + sign-in dialog.
     const startOfficialSignIn = useCallback(() => {
         openAccountDialog('signin');
@@ -227,6 +246,7 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
                     undefined,
                     { component: 'OxySignInButton', clientId, application: app.name },
                 );
+                notifyNotConfigured(app.name);
                 return;
             }
 
@@ -245,6 +265,7 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
                         { component: 'OxySignInButton', application: app.name },
                         result.description,
                     );
+                    notifyFailed();
                 }
                 return;
             }
@@ -267,6 +288,7 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
                 'OxySignInButton: native third-party sign-in cannot complete without an `onOAuthResult` handler; the code exchange is the RP\'s responsibility (state + code_verifier were not surfaced)',
                 { component: 'OxySignInButton', application: app.name },
             );
+            notifyNotConfigured(app.name);
         },
         [
             clientId,
@@ -275,6 +297,8 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
             startOfficialSignIn,
             startWebOAuthSignIn,
             shouldPreOpenPopup,
+            notifyNotConfigured,
+            notifyFailed,
         ],
     );
 
@@ -316,11 +340,29 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
                 }
                 closeOAuthPopup(popup);
                 startOfficialSignIn();
+            } catch (error) {
+                // `handlePress` fires this without awaiting, so an unexpected
+                // throw (a rejected native auth session, a crypto failure) would
+                // otherwise vanish into an unhandled rejection with the button
+                // left looking inert.
+                closeOAuthPopup(popup);
+                logger.error(
+                    'OxySignInButton: sign-in routing threw; sign-in aborted',
+                    error instanceof Error ? error : new Error(String(error)),
+                    { component: 'OxySignInButton', clientId },
+                );
+                notifyFailed();
             } finally {
                 routingRef.current = false;
             }
         },
-        [resolvePublicApplication, startOfficialSignIn, startThirdPartyOAuth, clientId],
+        [
+            resolvePublicApplication,
+            startOfficialSignIn,
+            startThirdPartyOAuth,
+            clientId,
+            notifyFailed,
+        ],
     );
 
     // Defer to a caller-supplied handler, otherwise route by application type.

package/src/ui/components/ProfileButton.tsx

@@ -134,7 +134,7 @@ const ProfileButton: React.FC<ProfileButtonProps> = ({
     }, [openAccountDialog]);
 
     useEffect(() => {
-        if (!onNavigateManage && !onAddAccount && !onNavigateProfile) {
+        if (!onNavigateManage && !onAddAccount && !onNavigateProfile && !menuItems?.length) {
             return undefined;
         }
         return registerAccountDialogConsumerHooks({

package/src/ui/navigation/accountDialogManager.ts

@@ -45,6 +45,13 @@ export interface AccountDialogConsumerHooks {
 let controls: AccountDialogControls | null = null;
 let consumerHooks: AccountDialogConsumerHooks | null = null;
 const visibilityListeners = new Set<(visible: boolean) => void>();
+const consumerHookListeners = new Set<() => void>();
+
+function notifyConsumerHookListeners(): void {
+  for (const listener of consumerHookListeners) {
+    listener();
+  }
+}
 
 export function registerAccountDialogControls(next: AccountDialogControls): () => void {
   controls = next;
@@ -60,9 +67,11 @@ export function registerAccountDialogConsumerHooks(
   next: AccountDialogConsumerHooks | null,
 ): () => void {
   consumerHooks = next;
+  notifyConsumerHookListeners();
   return () => {
     if (consumerHooks === next) {
       consumerHooks = null;
+      notifyConsumerHookListeners();
     }
   };
 }
@@ -71,6 +80,14 @@ export function getAccountDialogConsumerHooks(): AccountDialogConsumerHooks | nu
   return consumerHooks;
 }
 
+/** Subscribe to consumer-hook registration changes (menu items, manage/add overrides). */
+export function subscribeToAccountDialogConsumerHooks(listener: () => void): () => void {
+  consumerHookListeners.add(listener);
+  return () => {
+    consumerHookListeners.delete(listener);
+  };
+}
+
 /** Open the account dialog on `view` (default `accounts`). No-op before mount. */
 export function openAccountDialog(view?: AccountDialogView): void {
   controls?.open(view);

package/src/ui/screens/AccountSettingsScreen.tsx

@@ -143,11 +143,10 @@ const AccountSettingsScreen: React.FC<BaseScreenProps> = ({ onClose, goBack, nav
   const handleSave = useCallback(() => {
     const trimmed = displayName.trim();
     if (!trimmed || displayNameError) return;
-    const nameParts = trimmed.split(/\s+/).filter(Boolean);
-    const first = nameParts[0] || '';
-    const last = nameParts.length > 1 ? nameParts.slice(1).join(' ') : undefined;
+    // Managed accounts (org / project / bot / channel) have a title, not a
+    // given-and-family name — persist the explicit displayName column.
     updateMutation.mutate({
-      name: { first, last },
+      name: { displayName: trimmed },
       bio: bio.trim() ? bio.trim() : null,
     });
   }, [displayName, displayNameError, bio, updateMutation]);