@oxyhq/services 22.4.0 → 22.4.2

package/src/ui/hooks/queries/useAccountQueries.ts

@@ -145,7 +145,20 @@ function parseUpdatedAt(value: unknown): number | null {
 }
 
 /**
- * Get user by ID
+ * Get user by ID (identity-by-id).
+ *
+ * Keyed on the viewer-INDEPENDENT `queryKeys.users.detail(id)`: this hook is
+ * the card-identity workhorse (name, avatar, username, verified) and does NOT
+ * read the viewer-relative `relationship` field. Keeping the key
+ * viewer-independent lets external by-id identity seeders / precache layers
+ * (e.g. Mention's card enrichment) that all write `queryKeys.users.detail(id)`
+ * share a single cache entry — a viewer-scoped key would dead-end every seed
+ * and cause avatar/name flashes plus N+1 fetches.
+ *
+ * A viewer-scoped, relationship-aware by-id PROFILE fetch is intentionally NOT
+ * this hook — it would be a separate future `useUserProfileById` keyed on
+ * `queryKeys.users.detailForViewer(id, viewerId)`. No current consumer reads
+ * `relationship` from a by-id fetch (only the username path does).
  */
 export const useUserById = (userId: string | null, options?: { enabled?: boolean }) => {
   const { oxyServices } = useOxy();
@@ -168,10 +181,21 @@ export const useUserById = (userId: string | null, options?: { enabled?: boolean
  * Get user profile by username
  */
 export const useUserByUsername = (username: string | null, options?: { enabled?: boolean }) => {
-  const { oxyServices } = useOxy();
+  const { oxyServices, user } = useOxy();
+  // Viewer-scope the cache. Authenticated single-profile fetches embed a
+  // viewer-relative `relationship` ({ isFollowing, followsYou }); anonymous
+  // fetches omit it and different viewers get different values. Without the
+  // active viewer in the key, react-query freezes the first (often anonymous
+  // cold-boot) copy and never refetches when the session lands ~5-25s later,
+  // so the "Follows you" tag flashes then vanishes forever. Adding the viewer
+  // makes anon vs authed distinct entries AND forces a refetch when the
+  // session resolves or the account switches. (The SDK's GET response cache is
+  // already identity-scoped by the access-token user id via `computeIdentityTag`,
+  // so it never cross-poisons `relationship` — the only gap was this key.)
+  const viewerId = user?.id ?? '';
 
   return useQuery({
-    queryKey: [...queryKeys.users.details(), 'username', username || ''],
+    queryKey: queryKeys.users.byUsername(username || '', viewerId),
     queryFn: async () => {
       if (!username) {
         throw new Error('Username is required');

package/src/ui/screens/ConnectedAppsScreen.tsx

@@ -120,7 +120,6 @@ const ConnectedAppsScreen: React.FC<BaseScreenProps> = ({ onClose, goBack }) =>
                             t('connectedApps.item.granted', {
                                 relative: formatRelative(item.firstGrantedAt),
                             })
-                            || `Granted ${formatRelative(item.firstGrantedAt)}`
                         }
                         onPress={isRevoking ? undefined : () => confirmRevoke(item)}
                         disabled={isRevoking}

package/src/ui/screens/CreateAccountScreen.tsx

@@ -79,13 +79,13 @@ const organizationCategoryLabel = (
 ): string => {
   switch (category) {
     case 'agency':
-      return t('accounts.organizationCategory.agency') || 'Real estate agency';
+      return t('accounts.organizationCategory.agency');
     case 'cooperative':
-      return t('accounts.organizationCategory.cooperative') || 'Housing cooperative';
+      return t('accounts.organizationCategory.cooperative');
     case 'landlord':
-      return t('accounts.organizationCategory.landlord') || 'Landlord / property manager';
+      return t('accounts.organizationCategory.landlord');
     default:
-      return t('accounts.organizationCategory.other') || 'Other organization';
+      return t('accounts.organizationCategory.other');
   }
 };
 
@@ -309,7 +309,7 @@ const CreateAccountScreen: React.FC<BaseScreenProps> = ({
           {kind === 'organization' ? (
             <View className="gap-space-8">
               <Text className="text-body font-bodyBold text-text">
-                {t('accounts.create.organizationCategory.label') || 'Organization type'}
+                {t('accounts.create.organizationCategory.label')}
               </Text>
               <View className="flex-row flex-wrap gap-space-8">
                 {ORGANIZATION_CATEGORY_OPTIONS.map((option) => {