@oxyhq/core 3.4.15 → 3.4.16

package/dist/types/models/interfaces.d.ts

@@ -80,6 +80,8 @@ export interface User {
     id: string;
     publicKey: string;
     username: string;
+    /** Canonical display name resolved by the API. */
+    displayName: string;
     email?: string;
     avatar?: string;
     color?: string;

package/dist/types/utils/accountUtils.d.ts

@@ -32,13 +32,7 @@ export interface DisplayNameUserShape {
         full?: string;
         [key: string]: unknown;
     };
-    /**
-     * Pre-resolved display name as emitted by the server's `displayName` virtual
-     * (raw `/users/me` responses). NOTE: the server virtual resolves to
-     * `username || truncatedPublicKey || 'Anonymous'` — it does NOT compose the
-     * structured `name`. It is therefore preferred only AFTER a real structured
-     * name, so a first-name-only account never collapses to its username/key.
-     */
+    /** Canonical display name resolved by the API. */
     displayName?: string;
     username?: string;
     publicKey?: string;
@@ -52,13 +46,9 @@ export declare const formatPublicKeyHandle: (publicKey: string) => string;
  * Resolve a friendly display name for a user.
  *
  * Order of preference:
- *  1. `name.full`, or composed `name.first name.last` (FIRST-NAME-ONLY SAFE —
- *     a user with only a first name resolves to that first name, never to the
- *     lowercase username; this is the exact drift bug the auth app hit).
- *  2. `name` (when stored as a plain string)
- *  3. `displayName` (server `displayName` virtual — `username || truncatedKey`).
- *     Placed AFTER the structured name on purpose: the server virtual ignores
- *     `name`, so preferring it first would re-introduce the first-only bug.
+ *  1. `displayName` from the API contract.
+ *  2. `name.full`, or composed `name.first name.last` for local unsaved shapes.
+ *  3. `name` when stored as a plain string.
  *  4. `username`
  *  5. `Account 0x12345678…` (derived from publicKey, when present)
  *  6. Translated fallback (e.g. "Unnamed")

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oxyhq/core",
-  "version": "3.4.15",
+  "version": "3.4.16",
   "description": "OxyHQ SDK Foundation — API client, authentication, cryptographic identity, and shared utilities",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",

package/src/models/interfaces.ts

@@ -87,6 +87,8 @@ export interface User {
   id: string;
   publicKey: string;
   username: string;
+  /** Canonical display name resolved by the API. */
+  displayName: string;
   email?: string;
   // Avatar file id (asset id)
   avatar?: string;

package/src/utils/__tests__/accountUtils.test.ts

@@ -4,16 +4,17 @@ import {
     formatPublicKeyHandle,
 } from '../accountUtils';
 
-/**
- * Regression coverage for the auth-app display-name drift (Phase 1 of the
- * contract-centralisation refactor).
- *
- * The auth app previously required BOTH `name.first` AND `name.last` to compose
- * a display name, falling back to the lowercase `username` for first-name-only
- * accounts. The canonical resolver in core MUST be first-name-only safe: a user
- * with only a first name resolves to that first name, never to the username.
- */
 describe('getAccountDisplayName', () => {
+    it('prefers the API displayName when present', () => {
+        expect(
+            getAccountDisplayName({
+                name: { first: 'Nate' },
+                displayName: 'Nate Isern',
+                username: 'nateus',
+            }),
+        ).toBe('Nate Isern');
+    });
+
     it('returns first name for first-name-only accounts (NOT the username)', () => {
         const result = getAccountDisplayName({
             name: { first: 'Nate' },
@@ -50,19 +51,6 @@ describe('getAccountDisplayName', () => {
         ).toBe('Nathaniel Isern');
     });
 
-    it('uses the structured name over a server displayName virtual', () => {
-        // Server `displayName` virtual = `username || truncatedKey`; it ignores
-        // the structured name. A real name must win so a first-only account is
-        // never collapsed to its username.
-        expect(
-            getAccountDisplayName({
-                name: { first: 'Nate' },
-                displayName: 'nateus',
-                username: 'nateus',
-            }),
-        ).toBe('Nate');
-    });
-
     it('uses displayName when there is no structured name', () => {
         expect(
             getAccountDisplayName({

package/src/utils/accountUtils.ts

@@ -31,13 +31,7 @@ export interface QuickAccount {
 /** Minimal user shape accepted by display-name helpers. Avoids importing the full User type. */
 export interface DisplayNameUserShape {
     name?: string | { first?: string; last?: string; full?: string; [key: string]: unknown };
-    /**
-     * Pre-resolved display name as emitted by the server's `displayName` virtual
-     * (raw `/users/me` responses). NOTE: the server virtual resolves to
-     * `username || truncatedPublicKey || 'Anonymous'` — it does NOT compose the
-     * structured `name`. It is therefore preferred only AFTER a real structured
-     * name, so a first-name-only account never collapses to its username/key.
-     */
+    /** Canonical display name resolved by the API. */
     displayName?: string;
     username?: string;
     publicKey?: string;
@@ -57,13 +51,9 @@ export const formatPublicKeyHandle = (publicKey: string): string => {
  * Resolve a friendly display name for a user.
  *
  * Order of preference:
- *  1. `name.full`, or composed `name.first name.last` (FIRST-NAME-ONLY SAFE —
- *     a user with only a first name resolves to that first name, never to the
- *     lowercase username; this is the exact drift bug the auth app hit).
- *  2. `name` (when stored as a plain string)
- *  3. `displayName` (server `displayName` virtual — `username || truncatedKey`).
- *     Placed AFTER the structured name on purpose: the server virtual ignores
- *     `name`, so preferring it first would re-introduce the first-only bug.
+ *  1. `displayName` from the API contract.
+ *  2. `name.full`, or composed `name.first name.last` for local unsaved shapes.
+ *  3. `name` when stored as a plain string.
  *  4. `username`
  *  5. `Account 0x12345678…` (derived from publicKey, when present)
  *  6. Translated fallback (e.g. "Unnamed")
@@ -79,6 +69,8 @@ export const getAccountDisplayName = (
 
     const { name, displayName, username, publicKey } = user;
 
+    if (typeof displayName === 'string' && displayName.trim()) return displayName.trim();
+
     if (name && typeof name === 'object') {
         if (typeof name.full === 'string' && name.full.trim()) return name.full.trim();
         const first = typeof name.first === 'string' ? name.first.trim() : '';
@@ -89,8 +81,6 @@ export const getAccountDisplayName = (
         return name.trim();
     }
 
-    if (typeof displayName === 'string' && displayName.trim()) return displayName.trim();
-
     if (typeof username === 'string' && username.trim()) return username.trim();
 
     if (typeof publicKey === 'string' && publicKey.length > 0) {

package/src/utils/asyncUtils.ts

@@ -277,4 +277,4 @@ export async function retryOnError<T>(
     const errorCode = error?.code || error?.status || error?.message;
     return retryableErrors.includes(errorCode);
   });
-} 
+}