@oxyhq/core 3.17.0 → 3.18.0

package/dist/types/mixins/OxyServices.links.d.ts

@@ -37,11 +37,15 @@ export declare function OxyServicesLinksMixin<T extends typeof OxyServicesBase>(
          * Resolve multiple link previews via `POST /links/previews` (body `{ urls }`).
          *
          * Inputs are de-duplicated and split into chunks of {@link LINK_PREVIEWS_CHUNK_SIZE}
-         * (the server-side cap). Chunks run concurrently and their `data` maps are
+         * (the server-side cap). Chunks run concurrently and their result maps are
          * merged into a single result keyed by the REQUESTED url (the exact string
          * passed in `urls`) — matching the batch contract — so a caller can always
          * look its own input back up.
          *
+         * `makeRequest` unwraps the API's top-level `{ data }` envelope (same as
+         * `getUsersByIds`'s `makeServiceRequest<User[]>`), so each chunk response is
+         * already the `Record<url, LinkPreview>` map — merge it directly.
+         *
          * An empty / whitespace-only input resolves immediately with `{}` and
          * performs no network call. A failure in any chunk surfaces (via
          * `handleError`) rather than being swallowed.

package/dist/types/models/interfaces.d.ts

@@ -98,8 +98,10 @@ export interface User {
     privacySettings?: PrivacySettings;
     /**
      * Structured human name. `name.displayName` is the canonical display string
-     * resolved by the API; consumers render it directly instead of recomposing
-     * names from `first` / `last` / `full` / `username`.
+     * resolved by the API when present; consumers render it directly instead of
+     * recomposing names from `first` / `last` / `full` / `username`. It is now
+     * OPTIONAL (see `UserNameResponse`) — when absent, fall back to a handle
+     * (e.g. `getNormalizedUserHandle`) rather than recomposing a name locally.
      */
     name: UserNameResponse;
     bio?: string;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oxyhq/core",
-  "version": "3.17.0",
+  "version": "3.18.0",
   "description": "OxyHQ SDK Foundation — API client, authentication, cryptographic identity, and shared utilities",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",

package/src/mixins/OxyServices.auth.ts

@@ -1026,7 +1026,9 @@ export function OxyServicesAuthMixin<T extends typeof OxyServicesBase>(Base: T)
           continue;
         }
         const userId = e.user.id ?? e.user._id;
-        if (!userId || !e.user.username || !e.user.name?.displayName) {
+        // `name.displayName` is optional on the contract — do NOT drop no-name
+        // accounts. Only an absent userId or username makes the entry unusable.
+        if (!userId || !e.user.username) {
           continue;
         }
         if (typeof e.authuser !== 'number') {
@@ -1040,7 +1042,9 @@ export function OxyServicesAuthMixin<T extends typeof OxyServicesBase>(Base: T)
           user: {
             id: userId,
             username: e.user.username,
-            name: e.user.name,
+            // `name.displayName` is optional; carry whatever structured name the
+            // server sent (possibly an empty object) and let consumers fall back.
+            name: e.user.name ?? {},
             avatar: e.user.avatar ?? null,
             email: e.user.email,
             color: e.user.color ?? null,

package/src/mixins/OxyServices.links.ts

@@ -15,7 +15,7 @@
  * later read, so an SDK GET cache would pin the stale `'pending'` snapshot.
  * App-side caching (React Query / stores) owns this responsibility.
  */
-import type { LinkPreview, LinkPreviewBatchResponse } from '@oxyhq/contracts';
+import type { LinkPreview } from '@oxyhq/contracts';
 import type { OxyServicesBase } from '../OxyServices.base';
 import { buildUrl } from '../utils/apiUtils';
 
@@ -57,11 +57,15 @@ export function OxyServicesLinksMixin<T extends typeof OxyServicesBase>(Base: T)
      * Resolve multiple link previews via `POST /links/previews` (body `{ urls }`).
      *
      * Inputs are de-duplicated and split into chunks of {@link LINK_PREVIEWS_CHUNK_SIZE}
-     * (the server-side cap). Chunks run concurrently and their `data` maps are
+     * (the server-side cap). Chunks run concurrently and their result maps are
      * merged into a single result keyed by the REQUESTED url (the exact string
      * passed in `urls`) — matching the batch contract — so a caller can always
      * look its own input back up.
      *
+     * `makeRequest` unwraps the API's top-level `{ data }` envelope (same as
+     * `getUsersByIds`'s `makeServiceRequest<User[]>`), so each chunk response is
+     * already the `Record<url, LinkPreview>` map — merge it directly.
+     *
      * An empty / whitespace-only input resolves immediately with `{}` and
      * performs no network call. A failure in any chunk surfaces (via
      * `handleError`) rather than being swallowed.
@@ -82,7 +86,7 @@ export function OxyServicesLinksMixin<T extends typeof OxyServicesBase>(Base: T)
       try {
         const responses = await Promise.all(
           chunks.map((chunk) =>
-            this.makeRequest<LinkPreviewBatchResponse>(
+            this.makeRequest<Record<string, LinkPreview>>(
               'POST',
               '/links/previews',
               { urls: chunk },
@@ -92,7 +96,7 @@ export function OxyServicesLinksMixin<T extends typeof OxyServicesBase>(Base: T)
         );
 
         return responses.reduce<Record<string, LinkPreview>>(
-          (merged, response) => Object.assign(merged, response?.data ?? {}),
+          (merged, response) => Object.assign(merged, response ?? {}),
           {},
         );
       } catch (error) {

package/src/mixins/OxyServices.sso.ts

@@ -171,14 +171,17 @@ export function OxyServicesSsoMixin<T extends typeof OxyServicesBase>(Base: T) {
       }
 
       const userId = payload.user?.id ?? payload.user?._id;
-      if (!userId || typeof payload.user?.username !== 'string' || typeof payload.user.name?.displayName !== 'string') {
+      if (!userId || typeof payload.user?.username !== 'string') {
         throw this.handleError(new Error('SSO exchange returned an invalid user'));
       }
 
       const user: MinimalUserData = {
         id: userId,
         username: payload.user.username,
-        name: payload.user.name,
+        // `name.displayName` is optional on the contract. A no-name user is
+        // valid; carry whatever structured name the server sent (possibly an
+        // empty object) and let consumers fall back to a handle.
+        name: payload.user.name ?? {},
         avatar: payload.user.avatar,
       };
 

package/src/mixins/__tests__/OxyServices.links.test.ts

@@ -11,7 +11,7 @@
  *    `data` map keyed by the requested url, and surfaces a chunk failure.
  */
 
-import type { LinkPreview, LinkPreviewBatchResponse } from '@oxyhq/contracts';
+import type { LinkPreview } from '@oxyhq/contracts';
 import { OxyServices } from '../../OxyServices';
 
 const sampleResolved: LinkPreview = {
@@ -82,10 +82,10 @@ describe('OxyServices.links', () => {
     });
 
     it('de-duplicates and sends a single chunk for <= 50 unique URLs', async () => {
-      const response: LinkPreviewBatchResponse = {
-        data: { 'https://a.test/': sampleResolved },
-      };
-      makeRequestSpy.mockResolvedValueOnce(response);
+      // makeRequest unwraps the API's `{ data }` envelope, so the resolved value
+      // is the bare record (NOT `{ data: {...} }`) — mirror that real shape here.
+      const record: Record<string, LinkPreview> = { 'https://a.test/': sampleResolved };
+      makeRequestSpy.mockResolvedValueOnce(record);
 
       const result = await oxy.getLinkPreviews([
         'https://a.test/',
@@ -93,7 +93,7 @@ describe('OxyServices.links', () => {
         '   ', // dropped
       ]);
 
-      expect(result).toEqual(response.data);
+      expect(result).toEqual(record);
       expect(makeRequestSpy).toHaveBeenCalledTimes(1);
       expect(makeRequestSpy).toHaveBeenCalledWith(
         'POST',
@@ -111,13 +111,13 @@ describe('OxyServices.links', () => {
           _method: 'GET' | 'POST' | 'PUT' | 'PATCH' | 'DELETE',
           _url: string,
           data?: { urls: string[] },
-        ): Promise<LinkPreviewBatchResponse> => {
+        ): Promise<Record<string, LinkPreview>> => {
           const chunkUrls = data?.urls ?? [];
           const dataMap: Record<string, LinkPreview> = {};
           for (const u of chunkUrls) {
             dataMap[u] = { url: u, status: 'resolved', title: `t-${u}` };
           }
-          return { data: dataMap };
+          return dataMap;
         },
       );
 

package/src/models/interfaces.ts

@@ -108,8 +108,10 @@ export interface User {
   privacySettings?: PrivacySettings;
   /**
    * Structured human name. `name.displayName` is the canonical display string
-   * resolved by the API; consumers render it directly instead of recomposing
-   * names from `first` / `last` / `full` / `username`.
+   * resolved by the API when present; consumers render it directly instead of
+   * recomposing names from `first` / `last` / `full` / `username`. It is now
+   * OPTIONAL (see `UserNameResponse`) — when absent, fall back to a handle
+   * (e.g. `getNormalizedUserHandle`) rather than recomposing a name locally.
    */
   name: UserNameResponse;
   bio?: string;