@oxyhq/core 10.1.1 → 10.1.3

package/dist/types/models/interfaces.d.ts

@@ -551,7 +551,6 @@ export interface SecurityActivity {
     eventType: SecurityEventType;
     eventDescription: string;
     metadata?: Record<string, any>;
-    ipAddress?: string;
     userAgent?: string;
     deviceId?: string;
     timestamp: string;

package/dist/types/utils/textNormalization.d.ts

@@ -78,20 +78,23 @@ export declare function normalizeInlineText(value: string): string;
  *   2. Unify every line-break form (CRLF, lone CR, U+2028, U+2029) to `\n`.
  *   3. Collapse runs of HORIZONTAL whitespace (spaces, tabs, NBSP and friends)
  *      to a single space. Line breaks are untouched.
- *   4. Strip the horizontal whitespace at the END of each line.
+ *   4. Strip the horizontal whitespace at BOTH ends of every line.
  *   5. Collapse three or more line breaks to exactly one blank line (`\n\n`).
- *   6. Trim both ends.
+ *   6. Trim both ends of the value.
  *
  * STEP 4 MUST PRECEDE STEP 5 — this is the whole point of the function. A
  * "blank" line that actually contains spaces (`"a\n   \n   \nb"`) breaks the
  * run of `\n` characters, so a bare `\n{3,}` collapse (step 5 alone) never sees
  * it and the extra blank lines survive into the UI. That is exactly the bug in
- * federated post bodies. Removing the trailing horizontal whitespace first
- * turns those lines into real, empty lines, which step 5 then collapses.
- *
- * A single space at the START of a line is preserved: only RUNS of horizontal
- * whitespace collapse, and an indent is not trailing whitespace, so a one-space
- * indent is treated as the author's and left alone.
+ * federated post bodies. Trimming each line first turns those lines into real,
+ * empty lines, which step 5 then collapses.
+ *
+ * Every line is trimmed on BOTH sides, so a leading indent is removed outright
+ * rather than reduced to one space. Step 3 has already destroyed whatever indent
+ * the author wrote (`"      Mundo"` → `" Mundo"`), so a surviving space would not
+ * be the author's intent — it would be an arbitrary remnant of exactly the
+ * source-markup indentation this function exists to erase, and `pre-wrap` renders
+ * it. Indentation is invisible in HTML by spec; it must be invisible here too.
  *
  * A value that is empty or whitespace-only returns `''`.
  *

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oxyhq/core",
-  "version": "10.1.1",
+  "version": "10.1.3",
   "description": "OxyHQ SDK Foundation — API client, authentication, cryptographic identity, and shared utilities",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",

package/src/models/interfaces.ts

@@ -648,7 +648,6 @@ export interface SecurityActivity {
   eventType: SecurityEventType;
   eventDescription: string;
   metadata?: Record<string, any>;
-  ipAddress?: string;
   userAgent?: string;
   deviceId?: string;
   timestamp: string;

package/src/session/__tests__/accountDialogController.test.ts

@@ -4,6 +4,7 @@ import type { User } from '../../models/interfaces';
 import type { SessionLoginResponse, MinimalUserData } from '../../models/session';
 import type { AccountNode } from '../../mixins/OxyServices.accounts';
 import { SessionClient, type SessionClientHost } from '../SessionClient';
+import { logger } from '../../utils/loggerUtils';
 import {
   AccountDialogController,
   createAccountDialogController,
@@ -206,6 +207,7 @@ describe('AccountDialogController — account list', () => {
   });
 
   it('keeps device rows and surfaces the error when listAccounts fails', async () => {
+    const warnSpy = jest.spyOn(logger, 'warn').mockImplementation(() => undefined);
     const { controller, oxy, sc } = makeHarness();
     sc.set(state([{ accountId: 'a1', sessionId: 's1' }], 'a1'));
     oxy.getUsersByIds.mockResolvedValue([user('a1')]);
@@ -216,6 +218,40 @@ describe('AccountDialogController — account list', () => {
     const snap = controller.getSnapshot();
     expect(snap.error).toBe('graph boom');
     expect(snap.accounts.map((r) => r.accountId)).toEqual(['a1']);
+    // A genuine (non-401) failure STILL warns.
+    expect(warnSpy).toHaveBeenCalledWith(
+      '[AccountDialogController] listAccounts failed',
+      { component: 'AccountDialogController' },
+      expect.any(Error),
+    );
+    warnSpy.mockRestore();
+  });
+
+  it('treats a 401 from listAccounts as the signed-out edge — debug, no surfaced error, no warn', async () => {
+    const warnSpy = jest.spyOn(logger, 'warn').mockImplementation(() => undefined);
+    const debugSpy = jest.spyOn(logger, 'debug').mockImplementation(() => undefined);
+    const { controller, oxy, sc } = makeHarness();
+    sc.set(state([{ accountId: 'a1', sessionId: 's1' }], 'a1'));
+    oxy.getUsersByIds.mockResolvedValue([user('a1')]);
+    // A stale/revoked bearer 401s: an EXPECTED signed-out outcome, not a failure.
+    oxy.listAccounts.mockRejectedValue(
+      Object.assign(new Error('Invalid or missing authorization header'), { status: 401 }),
+    );
+
+    await controller.refresh();
+
+    const snap = controller.getSnapshot();
+    // Never surface an error for a normal signed-out state; device rows still render.
+    expect(snap.error).toBeNull();
+    expect(snap.accounts.map((r) => r.accountId)).toEqual(['a1']);
+    expect(warnSpy).not.toHaveBeenCalled();
+    expect(debugSpy).toHaveBeenCalledWith(
+      '[AccountDialogController] listAccounts unauthorized (signed out)',
+      { component: 'AccountDialogController' },
+      expect.objectContaining({ status: 401 }),
+    );
+    warnSpy.mockRestore();
+    debugSpy.mockRestore();
   });
 });
 

package/src/session/accountDialogController.ts

@@ -30,6 +30,7 @@ import type { OxyServices } from '../OxyServices';
 import type { SessionLoginResponse, MinimalUserData } from '../models/session';
 import type { User } from '../models/interfaces';
 import { logger } from '../utils/loggerUtils';
+import { extractErrorStatus } from '../utils/errorUtils';
 import { CENTRAL_IDP_APEX } from '../utils/authWebUrl';
 import {
   generateOAuthState,
@@ -392,10 +393,19 @@ export class AccountDialogController {
     try {
       graph = await this.oxyServices.listAccounts();
     } catch (error) {
-      // A graph-load failure is non-fatal: device rows still render. Surface the
-      // message but keep going with whatever graph we already had.
-      this.error = errorMessage(error);
-      logger.warn('[AccountDialogController] listAccounts failed', { component: 'AccountDialogController' }, error);
+      // A 401 here is the EXPECTED signed-out edge, not a failure: the bearer was
+      // stale/revoked, so `HttpService` already cleared it and emitted
+      // `onTokensChanged(null)`, which drops the graph via `reconcileAuth`. Log at
+      // debug and leave the dialog error-free — a signed-out device with zero
+      // accounts is a normal state, not a warning. Any other error (network, 5xx,
+      // malformed) IS unexpected: surface it and warn while keeping the prior graph
+      // so device rows still render.
+      if (extractErrorStatus(error) === 401) {
+        logger.debug('[AccountDialogController] listAccounts unauthorized (signed out)', { component: 'AccountDialogController' }, error);
+      } else {
+        this.error = errorMessage(error);
+        logger.warn('[AccountDialogController] listAccounts failed', { component: 'AccountDialogController' }, error);
+      }
     }
     if (seq !== this.refreshSeq) return; // superseded by a newer refresh
 
@@ -432,9 +442,15 @@ export class AccountDialogController {
     try {
       profiles = await this.oxyServices.getUsersByIds(ids);
     } catch (error) {
-      // `getUsersByIds` already swallows per-chunk failures and returns `[]`;
-      // this guards the unexpected total failure. Non-fatal — keep prior map.
-      logger.warn('[AccountDialogController] getUsersByIds failed', { component: 'AccountDialogController' }, error);
+      // A 401 is the EXPECTED signed-out edge (stale/cleared bearer) — log at debug.
+      // `getUsersByIds` already swallows per-chunk failures and returns `[]`, so any
+      // OTHER error here is an unexpected total failure worth a warn. Either way keep
+      // the prior profile map.
+      if (extractErrorStatus(error) === 401) {
+        logger.debug('[AccountDialogController] getUsersByIds unauthorized (signed out)', { component: 'AccountDialogController' }, error);
+      } else {
+        logger.warn('[AccountDialogController] getUsersByIds failed', { component: 'AccountDialogController' }, error);
+      }
       return;
     }
     if (seq !== this.refreshSeq) return; // superseded

package/src/utils/__tests__/textNormalization.test.ts

@@ -124,8 +124,16 @@ describe('normalizeMultilineText', () => {
     );
   });
 
-  it('preserves a single-space indent (it is the author\'s, not markup noise)', () => {
-    expect(normalizeMultilineText('a\n b')).toBe('a\n b');
+  it('strips leading horizontal whitespace from every line', () => {
+    expect(normalizeMultilineText('a\n b')).toBe('a\nb');
+    expect(normalizeMultilineText('one\n\ttwo\n      three')).toBe('one\ntwo\nthree');
+  });
+
+  it('leaves no indent residue after a space-filled blank line', () => {
+    // The blank line collapses AND the six-space indent goes away entirely —
+    // collapsing it to a single space would leave a visible artifact under
+    // `white-space: pre-wrap`.
+    expect(normalizeMultilineText('Hola\n    \n\n      Mundo')).toBe('Hola\n\nMundo');
   });
 
   it('normalizes CRLF and lone CR to \\n', () => {
@@ -176,6 +184,7 @@ describe('normalizeMultilineText', () => {
       'First paragraph.\n\nSecond paragraph.',
       `a${NBSP}b`,
       'a\n b',
+      'Hola\n    \n\n      Mundo',
       '',
       '   ',
       `Caf${DECOMPOSED_E_ACUTE}`,

package/src/utils/textNormalization.ts

@@ -61,12 +61,11 @@ const INLINE_NEEDS_NORMALIZATION = /[^\x20-\x7E]|^ | $| {2}/;
 /**
  * Same idea as {@link INLINE_NEEDS_NORMALIZATION}, for MULTILINE values: `\n`
  * joins the printable-ASCII fast-path alphabet, and the additional shapes a
- * normalized body can never contain are a space before a line break (trailing
- * horizontal whitespace) and a run of three line breaks (more than one blank
- * line). A single space AFTER a line break is legal — a one-space indent is
- * the author's, and normalization deliberately preserves it.
+ * normalized body can never contain are a space adjacent to a line break — on
+ * either side, since every line is trimmed — and a run of three line breaks
+ * (more than one blank line).
  */
-const MULTILINE_NEEDS_NORMALIZATION = /[^\x20-\x7E\n]|^[ \n]|[ \n]$| {2}| \n|\n{3}/;
+const MULTILINE_NEEDS_NORMALIZATION = /[^\x20-\x7E\n]|^[ \n]|[ \n]$| {2}| \n|\n |\n{3}/;
 
 /** Any run of whitespace, including tabs, line breaks and Unicode spaces. */
 const ANY_WHITESPACE_RUN = /\s+/g;
@@ -92,9 +91,20 @@ const LINE_BREAK_FORMS = /\r\n|\r|\p{Zl}|\p{Zp}/gu;
  */
 const HORIZONTAL_WHITESPACE_RUN = /[^\S\n]+/g;
 
-/** Horizontal whitespace at the end of a line — the blank-line spoiler. */
+/**
+ * Horizontal whitespace at the END of a line — the blank-line spoiler: it is
+ * what makes an "empty" line non-empty and hides it from {@link EXCESS_BLANK_LINES}.
+ */
 const TRAILING_HORIZONTAL_WHITESPACE = / +\n/g;
 
+/**
+ * Horizontal whitespace at the START of a line: source-markup indentation. HTML
+ * collapses it by spec, so it is invisible where the text came from and carries
+ * no meaning — it only becomes visible once a client renders the value with
+ * `white-space: pre-wrap`.
+ */
+const LEADING_HORIZONTAL_WHITESPACE = /\n +/g;
+
 /** Three or more line breaks: more than one blank line between paragraphs. */
 const EXCESS_BLANK_LINES = /\n{3,}/g;
 
@@ -140,20 +150,23 @@ export function normalizeInlineText(value: string): string {
  *   2. Unify every line-break form (CRLF, lone CR, U+2028, U+2029) to `\n`.
  *   3. Collapse runs of HORIZONTAL whitespace (spaces, tabs, NBSP and friends)
  *      to a single space. Line breaks are untouched.
- *   4. Strip the horizontal whitespace at the END of each line.
+ *   4. Strip the horizontal whitespace at BOTH ends of every line.
  *   5. Collapse three or more line breaks to exactly one blank line (`\n\n`).
- *   6. Trim both ends.
+ *   6. Trim both ends of the value.
  *
  * STEP 4 MUST PRECEDE STEP 5 — this is the whole point of the function. A
  * "blank" line that actually contains spaces (`"a\n   \n   \nb"`) breaks the
  * run of `\n` characters, so a bare `\n{3,}` collapse (step 5 alone) never sees
  * it and the extra blank lines survive into the UI. That is exactly the bug in
- * federated post bodies. Removing the trailing horizontal whitespace first
- * turns those lines into real, empty lines, which step 5 then collapses.
+ * federated post bodies. Trimming each line first turns those lines into real,
+ * empty lines, which step 5 then collapses.
  *
- * A single space at the START of a line is preserved: only RUNS of horizontal
- * whitespace collapse, and an indent is not trailing whitespace, so a one-space
- * indent is treated as the author's and left alone.
+ * Every line is trimmed on BOTH sides, so a leading indent is removed outright
+ * rather than reduced to one space. Step 3 has already destroyed whatever indent
+ * the author wrote (`"      Mundo"` → `" Mundo"`), so a surviving space would not
+ * be the author's intent — it would be an arbitrary remnant of exactly the
+ * source-markup indentation this function exists to erase, and `pre-wrap` renders
+ * it. Indentation is invisible in HTML by spec; it must be invisible here too.
  *
  * A value that is empty or whitespace-only returns `''`.
  *
@@ -168,6 +181,7 @@ export function normalizeMultilineText(value: string): string {
     .replace(LINE_BREAK_FORMS, '\n')
     .replace(HORIZONTAL_WHITESPACE_RUN, ' ')
     .replace(TRAILING_HORIZONTAL_WHITESPACE, '\n')
+    .replace(LEADING_HORIZONTAL_WHITESPACE, '\n')
     .replace(EXCESS_BLANK_LINES, '\n\n')
     .trim();
 }