@oxyhq/core 1.11.21 → 1.11.22

package/dist/types/mixins/OxyServices.fedcm.d.ts

@@ -29,14 +29,6 @@ interface FedCMTokenResult {
     token: string;
     isAutoSelected: boolean;
 }
-/**
- * Test-only reset of the page-load silent-SSO memo. The memo is module-scoped
- * and never cleared at runtime (a fresh page load resets it naturally), but
- * tests sharing one module instance need to start from a clean slate.
- *
- * @internal
- */
-export declare function __resetSilentSSOMemoForTests(): void;
 /**
  * Federated Credential Management (FedCM) Authentication Mixin
  *
@@ -121,22 +113,6 @@ export declare function OxyServicesFedCMMixin<T extends typeof OxyServicesBase>(
          * ```
          */
         silentSignInWithFedCM(): Promise<SessionLoginResponse | null>;
-        /**
-         * Build the page-load silent-SSO memo key from the current origin and the
-         * configured API base URL. Two providers pointed at the same API from the
-         * same origin share a single silent attempt per page load.
-         *
-         * @internal
-         */
-        silentSSOMemoKey(): string;
-        /**
-         * Perform the actual silent FedCM sign-in. Always wrapped by
-         * {@link silentSignInWithFedCM}'s page-load memo — never call this directly
-         * (doing so bypasses the run-once guard).
-         *
-         * @internal
-         */
-        _performSilentSignInWithFedCM(): Promise<SessionLoginResponse | null>;
         /**
          * Request identity credential from browser using FedCM API
          *

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oxyhq/core",
-  "version": "1.11.21",
+  "version": "1.11.22",
   "description": "OxyHQ SDK Foundation — API client, authentication, cryptographic identity, and shared utilities",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",

package/src/mixins/OxyServices.fedcm.ts

@@ -130,46 +130,6 @@ let fedCMRequestInProgress = false;
 let fedCMRequestPromise: Promise<FedCMTokenResult | null> | null = null;
 let currentMediationMode: string | null = null;
 
-/**
- * Page-load-persistent memo for SILENT FedCM sign-in.
- *
- * Silent SSO (`mediation: 'silent'`) is the one FedCM flow that runs WITHOUT a
- * user gesture — on app startup / provider mount. Multiple consumers
- * (`@oxyhq/auth`'s `WebOxyProvider` / `useWebSSO`, `@oxyhq/services`'
- * `useWebSSO`) can each mount and trigger it, and a remount storm (route churn,
- * React StrictMode double-invoke, error-boundary recovery) previously turned
- * into a `navigator.credentials.get` storm. This memo collapses every silent
- * attempt for a given `origin + baseURL` into AT MOST ONE browser credential
- * request per page load:
- *
- *   - the FIRST silent call runs the real flow and stores its in-flight promise;
- *   - concurrent silent calls share that same in-flight promise;
- *   - once it settles, the memo retains the resolved value (a session OR `null`)
- *     and every subsequent silent call returns it WITHOUT re-invoking the
- *     browser.
- *
- * Keyed on `origin + baseURL` (not the OxyServices instance) so it survives
- * instance churn across remounts. Intentionally never cleared: only a fresh
- * page load — which starts a fresh module scope — can change the IdP session
- * state that silent mediation observes.
- *
- * This guard is SILENT-ONLY. Interactive flows (`signInWithFedCM`,
- * `mediation: 'optional'|'required'`, `mode: 'active'|'passive'`) must always
- * be able to re-prompt and are never memoized here.
- */
-const silentSSOMemo = new Map<string, Promise<SessionLoginResponse | null>>();
-
-/**
- * Test-only reset of the page-load silent-SSO memo. The memo is module-scoped
- * and never cleared at runtime (a fresh page load resets it naturally), but
- * tests sharing one module instance need to start from a clean slate.
- *
- * @internal
- */
-export function __resetSilentSSOMemoForTests(): void {
-  silentSSOMemo.clear();
-}
-
 /**
  * Federated Credential Management (FedCM) Authentication Mixin
  *
@@ -362,49 +322,6 @@ export function OxyServicesFedCMMixin<T extends typeof OxyServicesBase>(Base: T)
       return null;
     }
 
-    // Page-load run-once guard. The first silent attempt for this
-    // origin + API runs; concurrent callers share the in-flight promise; once
-    // it settles, every later caller gets the memoized result (session OR
-    // null) WITHOUT re-invoking `navigator.credentials.get`. This is the single
-    // chokepoint for silent SSO across all consumers and remounts.
-    const memoKey = this.silentSSOMemoKey();
-    const existing = silentSSOMemo.get(memoKey);
-    if (existing) {
-      debug.log('Silent SSO: Returning memoized page-load result (no re-invocation)');
-      return existing;
-    }
-
-    const attempt = this._performSilentSignInWithFedCM();
-    silentSSOMemo.set(memoKey, attempt);
-    return attempt;
-  }
-
-  /**
-   * Build the page-load silent-SSO memo key from the current origin and the
-   * configured API base URL. Two providers pointed at the same API from the
-   * same origin share a single silent attempt per page load.
-   *
-   * @internal
-   */
-  public silentSSOMemoKey(): string {
-    const origin = typeof window !== 'undefined' ? window.location.origin : 'no-origin';
-    let baseURL = '';
-    try {
-      baseURL = this.getBaseURL();
-    } catch {
-      baseURL = '';
-    }
-    return `${origin}|${baseURL}`;
-  }
-
-  /**
-   * Perform the actual silent FedCM sign-in. Always wrapped by
-   * {@link silentSignInWithFedCM}'s page-load memo — never call this directly
-   * (doing so bypasses the run-once guard).
-   *
-   * @internal
-   */
-  public async _performSilentSignInWithFedCM(): Promise<SessionLoginResponse | null> {
     const clientId = this.getClientId();
     debug.log('Silent SSO: Starting for', clientId);
 

package/src/mixins/__tests__/fedcm.test.ts

@@ -19,7 +19,6 @@
  */
 
 import { OxyServices } from '../../OxyServices';
-import { __resetSilentSSOMemoForTests } from '../OxyServices.fedcm';
 
 interface CredentialGetCall {
   identity: {
@@ -70,11 +69,6 @@ describe('OxyServices FedCM nonce binding', () => {
   afterEach(() => {
     clearBrowserGlobals();
     jest.restoreAllMocks();
-    // The silent-SSO memo is module-scoped and survives between `it` blocks.
-    // Each test that calls `silentSignInWithFedCM` expects a fresh browser
-    // invocation, so reset the memo (a real page load would do the same by
-    // starting a fresh module scope).
-    __resetSilentSSOMemoForTests();
   });
 
   it('silent SSO mints a server nonce and forwards it to the browser', async () => {
@@ -231,7 +225,6 @@ describe('OxyServices FedCM mode enum (active/passive)', () => {
   afterEach(() => {
     clearBrowserGlobals();
     jest.restoreAllMocks();
-    __resetSilentSSOMemoForTests();
   });
 
   it('interactive sign-in requests the modern mode: "active"', async () => {
@@ -328,178 +321,3 @@ describe('OxyServices FedCM mode enum (active/passive)', () => {
     expect(call.identity.mode).toBeUndefined();
   });
 });
-
-/**
- * Page-load silent-SSO run-once guard.
- *
- * Silent SSO must invoke `navigator.credentials.get` AT MOST ONCE per page
- * load, even when multiple consumers / remounts / StrictMode call
- * `silentSignInWithFedCM()` repeatedly. The guard lives at the chokepoint in
- * core: the first silent attempt for an `origin + baseURL` runs; concurrent
- * callers share the in-flight promise; later callers get the memoized result
- * (session OR null) without re-invoking the browser.
- *
- * Interactive sign-in (`signInWithFedCM`) is NOT memoized — a user clicking the
- * sign-in button must always be able to re-prompt. That is asserted too.
- */
-describe('OxyServices FedCM silent-SSO page-load guard', () => {
-  afterEach(() => {
-    clearBrowserGlobals();
-    jest.restoreAllMocks();
-    __resetSilentSSOMemoForTests();
-  });
-
-  it('invokes the browser at most once across repeated silent calls and returns the memoized result', async () => {
-    let getCallCount = 0;
-    installBrowserGlobals({
-      credentialsGet: async () => {
-        getCallCount += 1;
-        return { type: 'identity', token: 'idp-token', isAutoSelected: true };
-      },
-    });
-
-    const oxy = new OxyServices({ baseURL: 'https://api.oxy.so' });
-    let exchangeCount = 0;
-    jest.spyOn(oxy, 'makeRequest').mockImplementation(async (_method: string, url: string) => {
-      if (url === '/fedcm/nonce') {
-        return { nonce: 'n', expiresAt: new Date(Date.now() + 60000).toISOString() } as never;
-      }
-      if (url === '/fedcm/exchange') {
-        exchangeCount += 1;
-        return {
-          sessionId: 'sess_guard',
-          deviceId: 'dev_guard',
-          expiresAt: new Date(Date.now() + 60000).toISOString(),
-          accessToken: 'access_guard',
-          user: { id: 'user_guard', username: 'tester' },
-        } as never;
-      }
-      throw new Error(`unexpected request to ${url}`);
-    });
-
-    const first = await oxy.silentSignInWithFedCM();
-    const second = await oxy.silentSignInWithFedCM();
-    const third = await oxy.silentSignInWithFedCM();
-
-    // The browser credential request fired exactly once.
-    expect(getCallCount).toBe(1);
-    // The token exchange ran exactly once too (the whole flow is memoized).
-    expect(exchangeCount).toBe(1);
-    // Every caller received the same memoized session.
-    expect(first?.sessionId).toBe('sess_guard');
-    expect(second).toBe(first);
-    expect(third).toBe(first);
-  });
-
-  it('shares a single in-flight browser call across concurrent silent callers', async () => {
-    let getCallCount = 0;
-    let resolveGet: ((value: unknown) => void) | null = null;
-    installBrowserGlobals({
-      credentialsGet: () =>
-        new Promise((resolve) => {
-          getCallCount += 1;
-          resolveGet = resolve;
-        }),
-    });
-
-    const oxy = new OxyServices({ baseURL: 'https://api.oxy.so' });
-    jest.spyOn(oxy, 'makeRequest').mockImplementation(async (_method: string, url: string) => {
-      if (url === '/fedcm/nonce') {
-        return { nonce: 'n', expiresAt: new Date(Date.now() + 60000).toISOString() } as never;
-      }
-      if (url === '/fedcm/exchange') {
-        return {
-          sessionId: 'sess_concurrent',
-          deviceId: 'dev_concurrent',
-          expiresAt: new Date(Date.now() + 60000).toISOString(),
-          accessToken: 'access_concurrent',
-          user: { id: 'user_concurrent', username: 'tester' },
-        } as never;
-      }
-      throw new Error(`unexpected request to ${url}`);
-    });
-
-    // Fire three silent calls before the first browser request resolves.
-    const p1 = oxy.silentSignInWithFedCM();
-    const p2 = oxy.silentSignInWithFedCM();
-    const p3 = oxy.silentSignInWithFedCM();
-
-    // Let the in-flight nonce/get chain start, then release the browser call.
-    await Promise.resolve();
-    await new Promise((r) => setTimeout(r, 0));
-    expect(getCallCount).toBe(1);
-    expect(resolveGet).not.toBeNull();
-    (resolveGet as unknown as (value: unknown) => void)({
-      type: 'identity',
-      token: 'idp-token',
-      isAutoSelected: true,
-    });
-
-    const [r1, r2, r3] = await Promise.all([p1, p2, p3]);
-
-    // Only one browser invocation despite three concurrent callers.
-    expect(getCallCount).toBe(1);
-    expect(r1?.sessionId).toBe('sess_concurrent');
-    expect(r2).toBe(r1);
-    expect(r3).toBe(r1);
-  });
-
-  it('memoizes a null result (user not signed in) without re-invoking the browser', async () => {
-    let getCallCount = 0;
-    installBrowserGlobals({
-      credentialsGet: async () => {
-        getCallCount += 1;
-        return null; // user not logged in at IdP
-      },
-    });
-
-    const oxy = new OxyServices({ baseURL: 'https://api.oxy.so' });
-    jest.spyOn(oxy, 'makeRequest').mockImplementation(async (_method: string, url: string) => {
-      if (url === '/fedcm/nonce') {
-        return { nonce: 'n', expiresAt: new Date(Date.now() + 60000).toISOString() } as never;
-      }
-      throw new Error(`unexpected request to ${url}`);
-    });
-
-    const first = await oxy.silentSignInWithFedCM();
-    const second = await oxy.silentSignInWithFedCM();
-
-    expect(first).toBeNull();
-    expect(second).toBeNull();
-    // The null verdict is memoized — the browser is not asked again.
-    expect(getCallCount).toBe(1);
-  });
-
-  it('does NOT memoize interactive sign-in (each click can re-prompt the browser)', async () => {
-    let getCallCount = 0;
-    installBrowserGlobals({
-      credentialsGet: async () => {
-        getCallCount += 1;
-        return { type: 'identity', token: `idp-token-${getCallCount}`, isAutoSelected: false };
-      },
-    });
-
-    const oxy = new OxyServices({ baseURL: 'https://api.oxy.so' });
-    jest.spyOn(oxy, 'makeRequest').mockImplementation(async (_method: string, url: string) => {
-      if (url === '/fedcm/nonce') {
-        return { nonce: 'n', expiresAt: new Date(Date.now() + 60000).toISOString() } as never;
-      }
-      if (url === '/fedcm/exchange') {
-        return {
-          sessionId: 'sess_interactive',
-          deviceId: 'dev_interactive',
-          expiresAt: new Date(Date.now() + 60000).toISOString(),
-          accessToken: 'access_interactive',
-          user: { id: 'user_interactive', username: 'tester' },
-        } as never;
-      }
-      throw new Error(`unexpected request to ${url}`);
-    });
-
-    await oxy.signInWithFedCM();
-    await oxy.signInWithFedCM();
-
-    // Interactive flow is never gated by the silent memo.
-    expect(getCallCount).toBe(2);
-  });
-});