@oxy.so/services 11.0.0 → 11.1.0

package/src/ui/boot/__tests__/coldBootNoIdpRedirect.test.ts

@@ -78,7 +78,7 @@ function makeHarness(overrides: Partial<RunProviderColdBootOptions> = {}): Harne
   const sessionClientStart = jest.fn(async () => undefined);
 
   const options: RunProviderColdBootOptions = {
-    oxyServices: {} as RunProviderColdBootOptions['oxyServices'],
+    oxyServices: { apps: { getPublic: jest.fn(async () => ({ id: 'registered-app', name: 'Registered App', type: 'first_party', isOfficial: false, isInternal: false, scopes: [] })) } } as unknown as RunProviderColdBootOptions['oxyServices'],
     authStore: makeEmptyAuthStore(),
     clientId: CLIENT_ID,
     sessionClient: { start: sessionClientStart } as unknown as SessionClient,
@@ -198,7 +198,7 @@ describe('runProviderColdBoot — no SDK-initiated IdP navigation (#691 phase 7b
       await commit.commitSession({ sessionId: 's1', userId: 'u1' });
       expect(options.commitSession).toHaveBeenCalledWith(
         { sessionId: 's1', userId: 'u1' },
-        { activate: true },
+        { activate: true, oauth: true },
       );
     });
   });
@@ -213,3 +213,57 @@ describe('runProviderColdBoot — no SDK-initiated IdP navigation (#691 phase 7b
     expect(mockRedirectToAuthorize).not.toHaveBeenCalled();
   });
 });
+
+describe('registered cold-boot classification', () => {
+  beforeEach(() => { mockRunSessionColdBoot.mockReset(); mockTryCompleteOAuthReturn.mockReset(); mockTryCompleteOAuthReturn.mockResolvedValue(false); });
+  it('external classification bypasses prior secrets, shared device and identity pin work', async () => {
+    const { options } = makeHarness();
+    (options.oxyServices.apps.getPublic as jest.Mock).mockResolvedValue({ id: 'external', name: 'External', type: 'third_party', isOfficial: false, isInternal: false, scopes: [] });
+    const beforeDeviceBoot = jest.fn();
+    await runProviderColdBoot({ ...options, beforeDeviceBoot });
+    expect(options.oxyServices.apps.getPublic).toHaveBeenCalledWith(CLIENT_ID, { cache: false });
+    expect(options.authStore.load).not.toHaveBeenCalled();
+    expect(options.authStore.clear).not.toHaveBeenCalled();
+    expect(options.syncDeviceCredentialToHost).not.toHaveBeenCalled();
+    expect(beforeDeviceBoot).not.toHaveBeenCalled();
+    expect(mockRunSessionColdBoot).not.toHaveBeenCalled();
+  });
+  it.each(['missing', 'inactive', 'offline', 'invalid'])('fails closed for %s before secrets and callback work', async (mode) => {
+    const { options } = makeHarness();
+    if (mode === 'missing') options.clientId = undefined;
+    else if (mode === 'invalid') (options.oxyServices.apps.getPublic as jest.Mock).mockResolvedValue({ type: 'unknown' });
+    else (options.oxyServices.apps.getPublic as jest.Mock).mockRejectedValue(new Error(mode));
+    await runProviderColdBoot(options);
+    expect(options.markAuthResolved).toHaveBeenCalled();
+    expect(options.authStore.load).not.toHaveBeenCalled();
+    expect(options.authStore.clear).not.toHaveBeenCalled();
+    expect(options.syncDeviceCredentialToHost).not.toHaveBeenCalled();
+    expect(mockRunSessionColdBoot).not.toHaveBeenCalled();
+    expect(mockTryCompleteOAuthReturn).not.toHaveBeenCalled();
+  });
+  it('a cold external OAuth callback never probes a previous device secret', async () => {
+    const { options } = makeHarness();
+    (options.oxyServices.apps.getPublic as jest.Mock).mockResolvedValue({ id: 'external', name: 'External', type: 'third_party', isOfficial: false, isInternal: false, scopes: [] });
+    mockTryCompleteOAuthReturn.mockImplementation(async ({ commitSession }) => {
+      await commitSession({ sessionId: 'isolated', userId: 'external-user', accessToken: 'isolated-bearer' }); return true;
+    });
+    await runProviderColdBoot(options);
+    expect(options.commitSession).toHaveBeenCalledWith({ sessionId: 'isolated', userId: 'external-user', accessToken: 'isolated-bearer' }, { activate: true, oauth: true });
+    expect(options.authStore.load).not.toHaveBeenCalled();
+    expect(options.syncDeviceCredentialToHost).not.toHaveBeenCalled();
+    expect(mockRunSessionColdBoot).not.toHaveBeenCalled();
+  });
+});
+
+it('an unresponsive registry resolves signed-out without a late privileged continuation', async () => {
+ jest.useFakeTimers();
+ try {
+  const {options}=makeHarness(); let release!: (app:unknown)=>void;
+  (options.oxyServices.apps.getPublic as jest.Mock).mockImplementation(()=>new Promise(resolve=>{release=resolve;}));
+  mockRunSessionColdBoot.mockReset(); mockTryCompleteOAuthReturn.mockReset();
+  const boot=runProviderColdBoot(options); await jest.advanceTimersByTimeAsync(5000); await boot;
+  expect(options.markAuthResolved).toHaveBeenCalled(); expect(options.authStore.load).not.toHaveBeenCalled();
+  release({id:'app',name:'Late',type:'first_party',isOfficial:true,isInternal:false,scopes:[]}); await Promise.resolve();
+  expect(mockRunSessionColdBoot).not.toHaveBeenCalled(); expect(mockTryCompleteOAuthReturn).not.toHaveBeenCalled();
+ } finally {jest.useRealTimers();}
+});

package/src/ui/boot/runProviderColdBoot.ts

@@ -1,3 +1,4 @@
+import { resolveApplicationSessionLane } from '../oauth/applicationSessionLane';
 import { logger as loggerUtil, type OxyServices } from '@oxy.so/core';
 import { runSessionColdBoot, type AuthStateStore, type IdentityBinding, type SessionMode } from '@oxy.so/core/session';
 import type { SessionClient } from '@oxy.so/core/session';
@@ -80,8 +81,14 @@ export interface RunProviderColdBootOptions {
   /** The identity binding required by `sessionMode: 'identity'`. */
   identity?: IdentityBinding;
   sessionClient: SessionClient;
+  /** Provider-owned fresh classifier, also used by explicit action recovery. */
+  resolveSessionLane?: () => Promise<'device' | 'oauth'>;
+  /** Identity pin work may run only after a fresh device classification. */
+  onClassified?: (lane: 'device' | 'oauth') => void | Promise<void>;
+  beforeDeviceBoot?: () => Promise<void>;
+  afterDeviceBoot?: () => Promise<void>;
   syncDeviceCredentialToHost: () => Promise<void>;
-  commitSession: (input: CommitInput, options: { activate: boolean }) => Promise<void>;
+  commitSession: (input: CommitInput, options: { activate: boolean; oauth?: boolean }) => Promise<void>;
   markAuthResolved: () => void;
   setTokenReady: (ready: boolean) => void;
 }
@@ -124,6 +131,11 @@ export async function runProviderColdBoot(opts: RunProviderColdBootOptions): Pro
   setTokenReady(false);
 
   try {
+    // Classification precedes every local-secret, shared-credential and identity
+    // probe. Unavailable registry metadata fails closed, including offline boot.
+    const lane = await (opts.resolveSessionLane?.() ?? resolveApplicationSessionLane(oxyServices, clientId));
+    await opts.onClassified?.(lane);
+    if (identityBound && lane !== 'device') return;
     // The redirect transport's RETURN leg. An app reaches it whenever the browser
     // BLOCKED the sign-in popup and `startWebOAuthSignIn` fell back to a
     // full-page redirect (`popup-blocked` / `popup-navigation-failed`), so it is
@@ -136,7 +148,7 @@ export async function runProviderColdBoot(opts: RunProviderColdBootOptions): Pro
           oxyServices,
           clientId,
           authRedirectUri,
-          commitSession: (input) => commitSession(input, { activate: true }),
+          commitSession: (input) => commitSession(input, { activate: true, oauth: true }),
         });
     if (oauthCompleted) {
       setTokenReady(true);
@@ -144,6 +156,13 @@ export async function runProviderColdBoot(opts: RunProviderColdBootOptions): Pro
       return;
     }
 
+    if (lane === 'oauth') {
+      setTokenReady(true);
+      return;
+    }
+
+    await opts.beforeDeviceBoot?.();
+
     // Best-effort connectivity probe up front: an EXPLICIT offline verdict skips
     // the two doomed network steps so routing settles immediately instead of
     // burning the overall deadline on a mint that cannot succeed. Any ambiguity
@@ -224,6 +243,7 @@ export async function runProviderColdBoot(opts: RunProviderColdBootOptions): Pro
         }
       },
     });
+    await opts.afterDeviceBoot?.();
   } catch (error) {
     if (__DEV__) {
       loggerUtil.error(

package/src/ui/components/OxySignInButton.tsx

@@ -1,3 +1,4 @@
+import { classifyApplicationSessionLane } from '../oauth/applicationSessionLane';
 import type React from 'react';
 import { useCallback, useState, useEffect, useRef } from 'react';
 import { type ViewStyle, type TextStyle, type StyleProp, Platform } from 'react-native';
@@ -142,6 +143,8 @@ export interface OxySignInButtonProps {
      * ```
      */
     onOAuthResult?: (result: OxyOAuthResult) => void;
+    /** Opt in to the shared SDK native finalizer. Mutually exclusive with onOAuthResult. */
+    nativeOAuthCompletion?: 'sdk';
 }
 
 const ACTION_KEYS: Record<OxySignInButtonAction, string> = {
@@ -188,9 +191,10 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
     showWhenAuthenticated = false,
     oauthRedirectUri,
     onOAuthResult,
+    nativeOAuthCompletion,
 }) => {
     const { t } = useI18n();
-    const { openAccountDialog, oxyServices, clientId, webAuthMode, startWebOAuthSignIn } = useOxy();
+    const { openAccountDialog, oxyServices, clientId, webAuthMode, startWebOAuthSignIn, startNativeOAuthSignIn } = useOxy();
     const { isAuthenticated, isLoading } = useAuthStore(
         useShallow((state) => ({ isAuthenticated: state.isAuthenticated, isLoading: state.isLoading }))
     );
@@ -228,7 +232,7 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
         if (cached && cached.clientId === clientId && cached.oxyServices === oxyServices) {
             return cached.promise;
         }
-        const promise = oxyServices.apps.getPublic(clientId).catch((error) => {
+        const promise = oxyServices.apps.getPublic(clientId, { cache: false }).catch((error) => {
             // Only clear if this is still the live entry (a later resolve may have
             // replaced it after a clientId/oxyServices change).
             if (appResolutionRef.current?.promise === promise) {
@@ -308,6 +312,14 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
                 return;
             }
 
+            if (nativeOAuthCompletion === 'sdk') {
+                if (onOAuthResult) { notifyNotConfigured(app.name); return; }
+                const result = await startNativeOAuthSignIn({ redirectUri: oauthRedirectUri });
+                if (result.status === 'failed') notifyFailed();
+                if (result.status === 'unsupported') notifyNotConfigured(app.name);
+                return;
+            }
+
             // Native: open the in-app auth session, then hand the handshake to the
             // RP so it can complete the token exchange from its deep-link callback.
             const [pkce, state] = await Promise.all([generatePkcePair(), generateOAuthState()]);
@@ -332,6 +344,8 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
             clientId,
             oauthRedirectUri,
             onOAuthResult,
+            nativeOAuthCompletion,
+            startNativeOAuthSignIn,
             startOfficialSignIn,
             startWebOAuthSignIn,
             shouldPreOpenPopup,
@@ -357,7 +371,7 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
                 const resolving = resolvePublicApplication();
                 if (!resolving) {
                     closeOAuthPopup(popup);
-                    startOfficialSignIn();
+                    notifyNotConfigured('this app');
                     return;
                 }
                 let app: PublicApplication;
@@ -373,7 +387,7 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
                     notifyFailed();
                     return;
                 }
-                if (app.type === 'third_party' && !app.isOfficial) {
+                if (classifyApplicationSessionLane(app) === 'oauth') {
                     await startThirdPartyOAuth(app, popup);
                     return;
                 }
@@ -392,6 +406,7 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
                 );
                 notifyFailed();
             } finally {
+                appResolutionRef.current = null;
                 routingRef.current = false;
             }
         },
@@ -400,6 +415,7 @@ export const OxySignInButton: React.FC<OxySignInButtonProps> = ({
             startOfficialSignIn,
             startThirdPartyOAuth,
             clientId,
+            notifyNotConfigured,
             notifyFailed,
         ],
     );