@oxy.so/core 1.8.0 → 1.8.1

package/dist/types/crypto/polyfill.d.ts

@@ -13,8 +13,23 @@
  *   2. Node — backed by the built-in `node:crypto` module (`webcrypto`, else
  *      `randomFillSync`). This is what a Node runtime WITHOUT a global WebCrypto
  *      (Node 18 script entrypoints, some embedded hosts) falls back to.
- *   3. React Native — `expo-crypto.getRandomBytes` (statically imported via the
- *      per-platform `platform/crypto` module in `@oxy.so/protocol`).
+ *   3. React Native — `expo-crypto.getRandomBytes`, through the dependency-free
+ *      `@oxy.so/protocol/random` entry.
+ *
+ * # Evaluation order — this module must import NOTHING that can capture the global
+ *
+ * `@noble/hashes` 1.x reads `globalThis.crypto` exactly once, when its
+ * `crypto.js` is evaluated, and `randomBytes` uses that captured binding for
+ * the lifetime of the app. ES imports are evaluated before the importing
+ * module's body, so every module this file imports runs BEFORE the shim below
+ * is installed. This file used to import `@oxy.so/protocol`'s root entry,
+ * which reaches `@noble/curves` → `@noble/hashes` through the envelope signer:
+ * on Hermes (no `globalThis.crypto` at startup) noble captured `undefined`
+ * before the shim existed, and every identity creation on Android failed with
+ * `crypto.getRandomValues must be defined`. Its imports are therefore limited
+ * to `buffer` and `@oxy.so/protocol/random`, both free of crypto libraries,
+ * and `index.ts` imports this file first. `__tests__/polyfillOrder.test.ts`
+ * guards both halves.
  *
  * Historically step (2) delegated to `@oxy.so/protocol`'s RN-only
  * `getRandomBytesRN`, which THROWS on Node — so any Node host lacking a global

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@oxy.so/core",
-  "version": "1.8.0",
+  "version": "1.8.1",
   "description": "OxyHQ SDK Foundation — API client, authentication, cryptographic identity, and shared utilities",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",
@@ -119,7 +119,7 @@
     "@noble/ciphers": "^1.3.0",
     "@noble/hashes": "^1.8.0",
     "@oxy.so/contracts": "^1.4.0",
-    "@oxy.so/protocol": "^1.1.0",
+    "@oxy.so/protocol": "^1.1.1",
     "@scure/bip39": "^1.6.0",
     "buffer": "^6.0.3",
     "express-rate-limit": "^8.6.0",

package/src/crypto/__tests__/polyfill.test.ts

@@ -13,7 +13,7 @@
 const mockGetRandomBytesRN = jest.fn<Uint8Array, [number]>();
 const mockState = { isNodeJS: true };
 
-jest.mock('@oxy.so/protocol', () => ({
+jest.mock('@oxy.so/protocol/random', () => ({
   isNodeJS: () => mockState.isNodeJS,
   getRandomBytesRN: (byteCount: number) => mockGetRandomBytesRN(byteCount),
 }));

package/src/crypto/__tests__/polyfillOrder.test.ts

@@ -0,0 +1,114 @@
+/**
+ * The crypto polyfill must be installed before ANY `@noble/*` module evaluates.
+ *
+ * `@noble/hashes` 1.x's `crypto.js` captures `globalThis.crypto` once, at module
+ * evaluation, and `randomBytes` uses that captured binding forever. Hermes has
+ * no `globalThis.crypto` at startup, so if noble is evaluated before
+ * `./polyfill` installs the shim, every random draw throws
+ * `crypto.getRandomValues must be defined` — which is exactly how identity
+ * creation broke on Android: the polyfill imported `@oxy.so/protocol`'s root
+ * entry, whose envelope signer reaches `@noble/curves` → `@noble/hashes`, and
+ * imports are evaluated before the polyfill body.
+ *
+ * Node's resolver picks noble's `cryptoNode.js` (the `node` export condition),
+ * which never captures the global, so a plain Node run cannot see the bug. The
+ * suites below substitute the REAL `crypto.js` that Metro resolves for React
+ * Native, remove `globalThis.crypto`, and load core in a fresh module registry.
+ */
+
+import { readFileSync } from 'node:fs';
+import { dirname, join, resolve } from 'node:path';
+
+type RandomBytes = (length?: number) => Uint8Array;
+
+const ORIGINAL_CRYPTO_DESCRIPTOR = Object.getOwnPropertyDescriptor(globalThis, 'crypto');
+
+/** noble's browser / React Native `crypto.js`: the variant that captures the global. */
+const NOBLE_CAPTURING_CRYPTO = join(dirname(require.resolve('@noble/hashes/utils')), 'crypto.js');
+
+/** Remove `globalThis.crypto` the way a Hermes host starts: no property at all. */
+function removeHostCrypto(): void {
+  if (!Reflect.deleteProperty(globalThis, 'crypto') || 'crypto' in globalThis) {
+    Object.defineProperty(globalThis, 'crypto', {
+      value: undefined,
+      configurable: true,
+      writable: true,
+    });
+  }
+}
+
+function restoreHostCrypto(): void {
+  Reflect.deleteProperty(globalThis, 'crypto');
+  if (ORIGINAL_CRYPTO_DESCRIPTOR) {
+    Object.defineProperty(globalThis, 'crypto', ORIGINAL_CRYPTO_DESCRIPTOR);
+  }
+}
+
+/**
+ * Run `body` in a fresh module registry that resolves `@noble/hashes/crypto` as
+ * a React Native bundle does, with no host `globalThis.crypto`.
+ */
+function withReactNativeNobleAndNoHostCrypto(body: () => void): void {
+  removeHostCrypto();
+  try {
+    jest.isolateModules(() => {
+      jest.doMock('@noble/hashes/crypto', () => jest.requireActual(NOBLE_CAPTURING_CRYPTO));
+      body();
+    });
+  } finally {
+    restoreHostCrypto();
+  }
+}
+
+describe('crypto polyfill evaluation order', () => {
+  it('reproduces the capture: noble evaluated before the polyfill has no randomness', () => {
+    // Guards the harness itself — if this ever stops throwing, the substitution
+    // no longer models the capturing variant and the suites below prove nothing.
+    withReactNativeNobleAndNoHostCrypto(() => {
+      const { randomBytes } = require('@noble/hashes/utils') as { randomBytes: RandomBytes };
+      require('../polyfill');
+      expect(() => randomBytes(32)).toThrow('crypto.getRandomValues must be defined');
+    });
+  });
+
+  it('importing @oxy.so/core installs the shim before noble captures the global', () => {
+    withReactNativeNobleAndNoHostCrypto(() => {
+      require('../../index');
+      const { randomBytes } = require('@noble/hashes/utils') as { randomBytes: RandomBytes };
+
+      const bytes = randomBytes(32);
+      expect(bytes).toHaveLength(32);
+      expect(bytes.some((byte) => byte !== 0)).toBe(true);
+    });
+  });
+
+  it('generates an identity (key pair + recovery mnemonic) through core', () => {
+    withReactNativeNobleAndNoHostCrypto(() => {
+      const core = require('../../index') as typeof import('../../index');
+      const { generateMnemonic } = require('@scure/bip39') as typeof import('@scure/bip39');
+      const { wordlist } = require('@scure/bip39/wordlists/english') as {
+        wordlist: string[];
+      };
+
+      // The two random draws `RecoveryPhraseService.generateIdentityWithRecovery`
+      // and `KeyManager.generateKeyPairSync` make — the ones Commons failed on.
+      expect(generateMnemonic(wordlist, 128).split(' ')).toHaveLength(12);
+      const keyPair = core.KeyManager.generateKeyPairSync();
+      expect(keyPair.privateKey).toMatch(/^[0-9a-f]{64}$/);
+    });
+  });
+
+  it('the polyfill imports nothing that can reach a crypto library', () => {
+    const source = readFileSync(resolve(__dirname, '..', 'polyfill.ts'), 'utf8');
+    const specifiers = [...source.matchAll(/^import\s+[^'"]*?['"]([^'"]+)['"]/gm)].map(
+      (match) => match[1],
+    );
+    expect(specifiers.sort()).toEqual(['@oxy.so/protocol/random', 'buffer']);
+  });
+
+  it('the core entry imports the polyfill before anything else', () => {
+    const source = readFileSync(resolve(__dirname, '..', '..', 'index.ts'), 'utf8');
+    const firstModuleReference = source.match(/^(?:import|export)\s[^;]*?['"]([^'"]+)['"]/m);
+    expect(firstModuleReference?.[1]).toBe('./crypto/polyfill');
+  });
+});

package/src/crypto/polyfill.ts

@@ -13,8 +13,23 @@
  *   2. Node — backed by the built-in `node:crypto` module (`webcrypto`, else
  *      `randomFillSync`). This is what a Node runtime WITHOUT a global WebCrypto
  *      (Node 18 script entrypoints, some embedded hosts) falls back to.
- *   3. React Native — `expo-crypto.getRandomBytes` (statically imported via the
- *      per-platform `platform/crypto` module in `@oxy.so/protocol`).
+ *   3. React Native — `expo-crypto.getRandomBytes`, through the dependency-free
+ *      `@oxy.so/protocol/random` entry.
+ *
+ * # Evaluation order — this module must import NOTHING that can capture the global
+ *
+ * `@noble/hashes` 1.x reads `globalThis.crypto` exactly once, when its
+ * `crypto.js` is evaluated, and `randomBytes` uses that captured binding for
+ * the lifetime of the app. ES imports are evaluated before the importing
+ * module's body, so every module this file imports runs BEFORE the shim below
+ * is installed. This file used to import `@oxy.so/protocol`'s root entry,
+ * which reaches `@noble/curves` → `@noble/hashes` through the envelope signer:
+ * on Hermes (no `globalThis.crypto` at startup) noble captured `undefined`
+ * before the shim existed, and every identity creation on Android failed with
+ * `crypto.getRandomValues must be defined`. Its imports are therefore limited
+ * to `buffer` and `@oxy.so/protocol/random`, both free of crypto libraries,
+ * and `index.ts` imports this file first. `__tests__/polyfillOrder.test.ts`
+ * guards both halves.
  *
  * Historically step (2) delegated to `@oxy.so/protocol`'s RN-only
  * `getRandomBytesRN`, which THROWS on Node — so any Node host lacking a global
@@ -23,7 +38,7 @@
  */
 
 import { Buffer } from 'buffer';
-import { getRandomBytesRN, isNodeJS } from '@oxy.so/protocol';
+import { getRandomBytesRN, isNodeJS } from '@oxy.so/protocol/random';
 
 const getGlobalObject = (): typeof globalThis => {
   if (typeof globalThis !== 'undefined') return globalThis;
@@ -125,7 +140,7 @@ const cryptoPolyfill: CryptoLike = {
       return array;
     }
     // React Native (and any non-Node host without WebCrypto): synchronous
-    // expo-crypto via @oxy.so/protocol's RN `platform/crypto` variant.
+    // expo-crypto via @oxy.so/protocol's RN `platform/random` variant.
     const bytes = getRandomBytesRN(array.byteLength);
     const uint8View = new Uint8Array(array.buffer, array.byteOffset, array.byteLength);
     uint8View.set(bytes);

package/src/index.ts

@@ -17,7 +17,10 @@
  * If a symbol does not appear here, it is NOT part of the public API.
  */
 
-// Ensure crypto polyfills are loaded before anything else
+// Ensure crypto polyfills are loaded before anything else. This MUST stay the
+// first import: `@noble/hashes` captures `globalThis.crypto` when it is
+// evaluated, so the shim has to exist before any module below reaches it (see
+// the evaluation-order note in `./crypto/polyfill`).
 import './crypto/polyfill';
 
 // ---------------------------------------------------------------------------