@overdeck/desktop 0.45.23 → 0.46.0

package/server/{review-verdict-feedback-C1Kg8n7t.js → review-verdict-feedback-BPDn4li_.js}

@@ -1,3 +1,3 @@
-import { n as init_review_verdict_feedback, t as deliverReviewVerdictFeedback } from "./review-verdict-feedback-CTRNtzXO.js";
+import { n as init_review_verdict_feedback, t as deliverReviewVerdictFeedback } from "./review-verdict-feedback-CELeUinh.js";
 init_review_verdict_feedback();
 export { deliverReviewVerdictFeedback };

package/server/{review-verdict-feedback-CTRNtzXO.js → review-verdict-feedback-CELeUinh.js}

@@ -1,17 +1,28 @@
 import { n as __esmMin } from "./rolldown-runtime-DNCzzKnI.js";
-import { Tn as init_projects, zn as resolveProjectFromIssueSync } from "./config-yaml-DvyMuOle.js";
-import { c as getReviewStatusSync, l as init_review_status } from "./review-status-A7quS5KJ.js";
-import { X as messageAgent, b as init_agents } from "./queries-6d7Cdtm7.js";
+import { Gn as init_projects, ar as resolveProjectFromIssueSync } from "./config-yaml-CmOPzmBb.js";
+import { f as init_review_status, r as clearFeedbackDeliveryStuck, u as getReviewStatusSync } from "./review-status-yljtTd-q.js";
+import { X as messageAgent, b as init_agents } from "./queries-DHJm7bTd.js";
 import { a as PAN_DIRNAME, p as init_types } from "./types-hraoaQIp.js";
-import { a as writeFeedbackFile, i as init_feedback_writer } from "./feedback-writer-C9b6ccN1.js";
-import { n as resolveIssueFeedbackTarget, r as surfaceIssueFeedbackNeedsYou, t as init_feedback_target } from "./feedback-target-CPS15Vte.js";
+import { a as writeFeedbackFile, i as init_feedback_writer } from "./feedback-writer-BG0RUZiu.js";
+import { n as resolveIssueFeedbackTarget, r as surfaceIssueFeedbackNeedsYou, t as init_feedback_target } from "./feedback-target-Dt9BsapX.js";
 import { join } from "node:path";
 import { Effect } from "effect";
 import { existsSync } from "node:fs";
 import { readFile, readdir, stat as stat$1 } from "node:fs/promises";
 import { execFile } from "node:child_process";
 import { promisify } from "node:util";
+import { createHash } from "node:crypto";
 //#region ../../lib/cloister/review-verdict-feedback.ts
+/**
+* Delivers durable review-verdict feedback to the work agent. Agent messages
+* use a key derived from the issue and review run so one review cycle is
+* model-visible at most once; callers without a run ID fall back to the
+* reviewed anchor, or deliver unkeyed if neither identity exists. ACP and
+* Channels targets fall back to unkeyed delivery because those transports
+* cannot enforce the key.
+* Repeated keyed suppressions surface a needs-you escalation before duplicate
+* delivery attempts consume the work agent's context window.
+*/
 async function findLatestSynthesis(workspacePath) {
 	const reviewRoot = join(workspacePath, PAN_DIRNAME, "review");
 	if (!existsSync(reviewRoot)) return null;
@@ -68,6 +79,8 @@ async function deliverReviewVerdictFeedbackPromise(opts) {
 	const resolved = resolveProjectFromIssueSync(issueId);
 	const workspacePath = opts.workspacePath ?? (resolved ? join(resolved.projectPath, "workspaces", `feature-${issueId.toLowerCase()}`) : void 0);
 	const existingStatus = getReviewStatusSync(issueId);
+	const deliveryIdentity = opts.runId ? `run:${opts.runId}` : existingStatus?.reviewedAtCommit ? `anchor:${existingStatus.reviewedAtCommit}` : void 0;
+	const dedupKey = deliveryIdentity ? `review-feedback:${issueId.toLowerCase()}:${createHash("sha256").update(deliveryIdentity).digest("hex").slice(0, 16)}` : void 0;
 	const synthesis = workspacePath && existsSync(workspacePath) ? await findLatestSynthesis(workspacePath) : null;
 	const markdownBody = buildReviewFeedbackBody({
 		issueId,
@@ -96,8 +109,33 @@ async function deliverReviewVerdictFeedbackPromise(opts) {
 		try {
 			const target = await resolveIssueFeedbackTarget(issueId, { itemId: opts.slotItemId });
 			if ("agentId" in target) try {
-				await messageAgent(target.agentId, message, "internal", { owesRework: true });
+				let deliveryOutcome;
+				try {
+					deliveryOutcome = await messageAgent(target.agentId, message, "internal", {
+						owesRework: true,
+						...dedupKey ? { dedupKey } : {}
+					});
+				} catch (err) {
+					if (!(err instanceof Error ? err.message : String(err)).includes("cannot enforce a dedup key")) throw err;
+					console.warn(`[review-verdict-feedback] ${target.agentId} cannot enforce keyed delivery; retrying unkeyed`);
+					deliveryOutcome = await messageAgent(target.agentId, message, "internal", { owesRework: true });
+				}
 				agentMessageSent = true;
+				let repeatedDeliveryLoop = false;
+				if (deliveryOutcome.deduplicated && dedupKey) {
+					const suppressedCount = (suppressedReviewFeedbackDeliveries.get(dedupKey) ?? 0) + 1;
+					suppressedReviewFeedbackDeliveries.set(dedupKey, suppressedCount);
+					repeatedDeliveryLoop = suppressedCount >= 2;
+					if (suppressedCount === 2) try {
+						await surfaceIssueFeedbackNeedsYou(issueId, REPEATED_DELIVERY_LOOP_MESSAGE, {
+							specialist: "review-agent",
+							feedbackPath: fileResult.filePath
+						});
+					} catch (err) {
+						console.warn(`[review-verdict-feedback] Could not surface repeated delivery loop for ${issueId}: ${err instanceof Error ? err.message : String(err)}`);
+					}
+				} else if (dedupKey) suppressedReviewFeedbackDeliveries.delete(dedupKey);
+				if (!repeatedDeliveryLoop) clearFeedbackDeliveryStuck(issueId);
 			} catch (err) {
 				const reason = err instanceof Error ? err.message : String(err);
 				console.warn(`[review-verdict-feedback] Could not message ${target.agentId}; feedback file remains available: ${reason}`);
@@ -129,7 +167,7 @@ async function deliverReviewVerdictFeedbackPromise(opts) {
 		agentMessageSent
 	};
 }
-var execFileAsync, PR_COMMENT_TIMEOUT_MS, deliverReviewVerdictFeedback;
+var execFileAsync, PR_COMMENT_TIMEOUT_MS, suppressedReviewFeedbackDeliveries, REPEATED_DELIVERY_LOOP_MESSAGE, deliverReviewVerdictFeedback;
 var init_review_verdict_feedback = __esmMin((() => {
 	init_agents();
 	init_projects();
@@ -139,9 +177,11 @@ var init_review_verdict_feedback = __esmMin((() => {
 	init_feedback_target();
 	execFileAsync = promisify(execFile);
 	PR_COMMENT_TIMEOUT_MS = 15e3;
+	suppressedReviewFeedbackDeliveries = /* @__PURE__ */ new Map();
+	REPEATED_DELIVERY_LOOP_MESSAGE = "Review feedback for this verdict was already delivered to the agent; the pipeline re-triggered delivery 3+ times — possible stuck loop. Investigate before the agent context burns.";
 	deliverReviewVerdictFeedback = (opts) => Effect.promise(() => deliverReviewVerdictFeedbackPromise(opts));
 }));
 //#endregion
 export { init_review_verdict_feedback as n, postPrComment as r, deliverReviewVerdictFeedback as t };
 
-//# sourceMappingURL=review-verdict-feedback-CTRNtzXO.js.map
+//# sourceMappingURL=review-verdict-feedback-CELeUinh.js.map

package/server/{rollup-WA0VD-Rr.js → rollup-DTNvelz9.js}

@@ -1,8 +1,8 @@
 import { n as __esmMin } from "./rolldown-runtime-DNCzzKnI.js";
-import { T as MemoryStatus, t as init_src } from "./src-U7_kTPEE.js";
-import { a as resolveArchiveDir, f as resolveStatusFile, i as init_paths, l as resolveObservationsFile, n as ensureDir, r as ensureParentDir, u as resolvePendingDir } from "./paths-_zEts6wc.js";
-import { i as init_settings, n as getMemoryRollupPendingThreshold } from "./settings-BZ5m1UCl.js";
-import { i as updateMemoryHealth, n as extractWithProviderPolicy, r as init_health, t as init_providers } from "./providers-DV7ec8l7.js";
+import { k as MemoryStatus, t as init_src } from "./src-CRmCHlma.js";
+import { a as resolveArchiveDir, f as resolveStatusFile, i as init_paths, l as resolveObservationsFile, n as ensureDir, r as ensureParentDir, u as resolvePendingDir } from "./paths-cXmOwSbh.js";
+import { i as init_settings, n as getMemoryRollupPendingThreshold } from "./settings-Bse1Pdcj.js";
+import { i as updateMemoryHealth, n as extractWithProviderPolicy, r as init_health, t as init_providers } from "./providers-evXhiQeg.js";
 import { Result, Schema } from "effect";
 import { dirname } from "path";
 import { randomUUID } from "crypto";
@@ -98,8 +98,8 @@ async function enqueueStatusRollupEvent(job) {
 		await configuredStatusRollupProcessor(job);
 		return;
 	}
-	const { initEventStore } = await import("./event-store-Cr5PQwFC.js");
-	const { synthesizeStatusRollup, commitStatusRollup } = await import("./rollup-B53Y81xK.js");
+	const { initEventStore } = await import("./event-store-ELqkVOn0.js");
+	const { synthesizeStatusRollup, commitStatusRollup } = await import("./rollup-DYZfq1c4.js");
 	await (await initEventStore()).appendAsync({
 		type: "memory.rollup_triggered",
 		timestamp: (/* @__PURE__ */ new Date()).toISOString(),
@@ -295,7 +295,7 @@ async function clearPendingTurns(projectId, issueId, pendingTurns) {
 	return cleared;
 }
 async function emitStatusUpdatedEvent(event) {
-	const { initEventStore } = await import("./event-store-Cr5PQwFC.js");
+	const { initEventStore } = await import("./event-store-ELqkVOn0.js");
 	await (await initEventStore()).appendAsync({
 		type: "memory.status_updated",
 		timestamp: (/* @__PURE__ */ new Date()).toISOString(),
@@ -446,4 +446,4 @@ var init_rollup = __esmMin((() => {
 //#endregion
 export { readCurrentStatus as a, init_pending as c, readArchivedStatuses as i, maybeTriggerStatusRollup as l, commitStatusRollup as n, readRecentObservations as o, init_rollup as r, synthesizeStatusRollup as s, buildStatusRollupPrompt as t, writePendingTurn as u };
 
-//# sourceMappingURL=rollup-WA0VD-Rr.js.map
+//# sourceMappingURL=rollup-DTNvelz9.js.map

package/server/{rollup-B53Y81xK.js → rollup-DYZfq1c4.js}

@@ -1,3 +1,3 @@
-import { n as commitStatusRollup, r as init_rollup, s as synthesizeStatusRollup } from "./rollup-WA0VD-Rr.js";
+import { n as commitStatusRollup, r as init_rollup, s as synthesizeStatusRollup } from "./rollup-DTNvelz9.js";
 init_rollup();
 export { commitStatusRollup, synthesizeStatusRollup };

package/server/{scanner-D2743cp8.js → scanner-CV35oSn4.js}

@@ -1,9 +1,9 @@
-import { B as getProviderEnvSync, Gr as sessionFilePath, H as init_providers, Nr as encodeClaudeProjectDir, Tn as init_projects, V as getProviderForModelSync, Vr as init_paths, a as getConversationsConfigSync, f as loadConfigSync, ir as FsError, it as getModelCapabilitySync, kn as listProjectsSync, lt as resolveModelIdSync, mr as init_errors, rr as ConfigError, st as init_model_capabilities, t as init_config_yaml } from "./config-yaml-DvyMuOle.js";
-import { d as getOverdeckDatabaseSync, f as init_infra } from "./infra-CzaSOgul.js";
-import { o as getPricingSync, s as init_cost, t as calculateCostSync } from "./cost-Ca0YTWDw.js";
-import { Ct as searchFtsSessions, Et as upsertDiscoveredSession, St as markEnrichmentFailed, Tt as updateEnrichment, bt as insertEmbedding, ct as countDiscoveredSessions, dt as findDiscoveredSessionIds, ft as findDiscoveredSessions, ht as getDiscoveredSessionByJsonlPath, lt as countFtsSessions, mt as getDiscoveredSessionById, pt as findEnrichedSessionIdsMissingEmbedding, st as buildFilterSql, ut as ensureDiscoveredSessionsSchema, vt as getEmbedding, wt as topKCosine, xt as loadEmbeddings, yt as init_discovered_sessions } from "./conversations-DbOs1e9Q.js";
-import { n as isBackgroundFeatureEnabled, t as init_features } from "./features-Dhxz-wLc.js";
-import { n as recordBackgroundAiCost, t as init_cost$1 } from "./cost-CW4WSe72.js";
+import { B as getProviderEnvSync, Fr as init_errors, Gn as init_projects, H as init_providers, Tr as FsError, V as getProviderForModelSync, Yn as listProjectsSync, a as getConversationsConfigSync, ci as init_paths, ei as encodeClaudeProjectDir, f as loadConfigSync, fi as sessionFilePath, it as getModelCapabilitySync, lt as resolveModelIdSync, st as init_model_capabilities, t as init_config_yaml, wr as ConfigError } from "./config-yaml-CmOPzmBb.js";
+import { d as getOverdeckDatabaseSync, f as init_infra } from "./infra-BjuxvjdS.js";
+import { o as getPricingSync, s as init_cost, t as calculateCostSync } from "./cost-Bgcub5kW.js";
+import { Ct as searchFtsSessions, Et as upsertDiscoveredSession, St as markEnrichmentFailed, Tt as updateEnrichment, bt as insertEmbedding, ct as countDiscoveredSessions, dt as findDiscoveredSessionIds, ft as findDiscoveredSessions, ht as getDiscoveredSessionByJsonlPath, lt as countFtsSessions, mt as getDiscoveredSessionById, pt as findEnrichedSessionIdsMissingEmbedding, st as buildFilterSql, ut as ensureDiscoveredSessionsSchema, vt as getEmbedding, wt as topKCosine, xt as loadEmbeddings, yt as init_discovered_sessions } from "./conversations-BUpYsOZg.js";
+import { n as isBackgroundFeatureEnabled, t as init_features } from "./features--nFkJY8v.js";
+import { n as recordBackgroundAiCost, t as init_cost$1 } from "./cost-CvxRrucd.js";
 import { Data, Duration, Effect, FileSystem } from "effect";
 import { createReadStream, promises } from "fs";
 import { basename, join, relative, resolve } from "path";
@@ -471,6 +471,7 @@ init_cost$1();
 */
 const MODEL_PROVIDERS = {
 	"claude-fable-5": "anthropic",
+	"claude-opus-5": "anthropic",
 	"claude-opus-4-8": "anthropic",
 	"claude-opus-4-7": "anthropic",
 	"claude-opus-4-6": "anthropic",
@@ -2458,12 +2459,12 @@ async function collectAgentDirFiles(root, warnings = []) {
 		const agentHarness = await readAgentHarness(agentDir);
 		const piHarness = agentHarness === "pi" || agentHarness === "ohmypi" ? agentHarness : "ohmypi";
 		result.push(...await collectPiFamilyRoot(join(agentDir, "sessions"), piHarness, warnings));
-		await collectAgentRootPiFiles(agentDir, piHarness, warnings, result);
+		await collectAgentRootFiles(agentDir, piHarness, warnings, result);
 		await collectJsonlFiles(join(agentDir, "codex-home", "sessions"), join(agentDir, "codex-home", "sessions"), "codex", warnings, result);
 	}
 	return result;
 }
-async function collectAgentRootPiFiles(agentDir, harness, warnings, result) {
+async function collectAgentRootFiles(agentDir, piHarness, warnings, result) {
 	let entries;
 	try {
 		entries = await promises.readdir(agentDir, { withFileTypes: true });
@@ -2473,10 +2474,16 @@ async function collectAgentRootPiFiles(agentDir, harness, warnings, result) {
 	}
 	for (const entry of entries) {
 		const name = String(entry.name);
-		if (entry.isFile() && isPiWorkAgentJsonl(name)) result.push({
+		if (!entry.isFile()) continue;
+		if (name === "acp-session.jsonl") result.push({
 			projectDir: agentDir,
 			jsonlPath: join(agentDir, name),
-			harness
+			harness: "acp"
+		});
+		else if (isPiWorkAgentJsonl(name)) result.push({
+			projectDir: agentDir,
+			jsonlPath: join(agentDir, name),
+			harness: piHarness
 		});
 	}
 }
@@ -2615,6 +2622,23 @@ async function parsePiSessionMetadata(filePath) {
 	result.filesTouched = [...filesSet];
 	return result;
 }
+async function parseAcpSessionMetadata(filePath) {
+	const result = emptySessionMetadata();
+	const toolsSet = /* @__PURE__ */ new Set();
+	await readJsonl(filePath, (entry) => {
+		const acpEntry = entry;
+		if (typeof acpEntry.timestamp !== "string" || typeof acpEntry.content !== "string" || !isAcpTranscriptRole(acpEntry.role)) return;
+		result.messageCount++;
+		recordTimestamp(result, acpEntry.timestamp);
+		if (!result.sessionId && typeof acpEntry.sessionId === "string" && acpEntry.sessionId.length > 0) result.sessionId = acpEntry.sessionId;
+		if (Array.isArray(acpEntry.toolCalls)) for (const toolCall of acpEntry.toolCalls) {
+			const name = toolCall.title?.trim() || toolCall.kind?.trim();
+			if (name) toolsSet.add(name);
+		}
+	});
+	result.toolsUsed = [...toolsSet];
+	return result;
+}
 async function parseCodexSessionMetadata(filePath) {
 	const result = emptySessionMetadata();
 	const modelCounts = {};
@@ -2717,6 +2741,9 @@ function recordTimestamp(result, ts) {
 	if (result.firstTs === null) result.firstTs = ts;
 	result.lastTs = ts;
 }
+function isAcpTranscriptRole(role) {
+	return role === "user" || role === "assistant" || role === "tool" || role === "system";
+}
 function normalizeModel(provider, model) {
 	if (typeof model !== "string" || model.length === 0) return null;
 	if (typeof provider === "string" && provider.length > 0 && !model.includes("/")) return `${provider}/${model}`;
@@ -2768,6 +2795,7 @@ async function scan(opts) {
 	const parseMetadata = (file) => {
 		if (file.harness === "pi" || file.harness === "ohmypi") return parsePiSessionMetadata(file.jsonlPath);
 		if (file.harness === "codex") return parseCodexSessionMetadata(file.jsonlPath);
+		if (file.harness === "acp") return parseAcpSessionMetadata(file.jsonlPath);
 		return parseJsonl(file.jsonlPath);
 	};
 	const resolveWorkspace = async (file, cwdFromFirstMessage) => {
@@ -2777,8 +2805,8 @@ async function scan(opts) {
 			workspaceHash: null,
 			warning: null
 		};
-		if (file.harness === "codex") return {
-			workspacePath: resolveCodexAgentWorkspace(file.jsonlPath),
+		if (file.harness === "codex" || file.harness === "acp") return {
+			workspacePath: resolveAgentWorkspace(file.jsonlPath),
 			workspaceHash: null,
 			warning: null
 		};
@@ -2951,7 +2979,7 @@ function combineCorrelation(base, sessionId, locatorCorrelationMap) {
 	const byLocator = locatorCorrelationMap.get(sessionId);
 	return byLocator ? mergeCorrelation(fallback, byLocator) : fallback;
 }
-function resolveCodexAgentWorkspace(jsonlPath) {
+function resolveAgentWorkspace(jsonlPath) {
 	const agentId = jsonlPath.replace(/\\/g, "/").match(/\/\.overdeck\/agents\/([^/]+)\//)?.[1];
 	if (!agentId) return null;
 	return getOverdeckDatabaseSync().prepare(`SELECT workspace FROM agents WHERE id = ?`).get(agentId)?.workspace ?? null;
@@ -3001,4 +3029,4 @@ function normalizeDir(dir) {
 //#endregion
 export { enrichSessions as a, searchSessions as c, CostThresholdError as i, embed as l, getSessionsFeedFacets as n, embedSessions as o, listSessionsFeed as r, parseRelativeTime as s, scan as t };
 
-//# sourceMappingURL=scanner-D2743cp8.js.map
+//# sourceMappingURL=scanner-CV35oSn4.js.map

package/server/{sequence-io-Cg0zYj_E.js → sequence-io-DF_8iuhV.js}

@@ -1,7 +1,7 @@
 import { n as __esmMin } from "./rolldown-runtime-DNCzzKnI.js";
-import { Ut as init_auto_commit, Wt as queueAutoCommit } from "./config-yaml-DvyMuOle.js";
-import { c as getReviewStatusSync, l as init_review_status } from "./review-status-A7quS5KJ.js";
-import { C as init_specs, S as getProjectPanPaths } from "./io-B3_AHDfr.js";
+import { ln as init_auto_commit, un as queueAutoCommit } from "./config-yaml-CmOPzmBb.js";
+import { f as init_review_status, u as getReviewStatusSync } from "./review-status-yljtTd-q.js";
+import { M as getProjectPanPaths, S as init_specs } from "./io-VHvc0Ssp.js";
 import { dirname, join } from "node:path";
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
 //#region ../../lib/backlog/types.ts
@@ -275,4 +275,4 @@ var init_sequence_io = __esmMin((() => {
 //#endregion
 export { parseSequenceMd as n, writeSequenceMd as r, init_sequence_io as t };
 
-//# sourceMappingURL=sequence-io-Cg0zYj_E.js.map
+//# sourceMappingURL=sequence-io-DF_8iuhV.js.map

package/server/{sequencer-agent-BGY8gjg-.js → sequencer-agent-B2WeCtGi.js}

@@ -1,8 +1,8 @@
 import { a as __toCommonJS, n as __esmMin } from "./rolldown-runtime-DNCzzKnI.js";
-import { c as getReviewStatusSync, l as init_review_status } from "./review-status-A7quS5KJ.js";
-import { Cr as getAgentRuntimeStateSync, Wn as getAgentStateSync, a as listRunningAgentsSync, b as init_agents, ft as stopAgent, ut as spawnRun, vn as determineModel } from "./queries-6d7Cdtm7.js";
-import { n as init_issue_service_singleton, r as issue_service_singleton_exports } from "./issue-service-singleton-B5ushCvE.js";
-import { n as parseSequenceMd, t as init_sequence_io } from "./sequence-io-Cg0zYj_E.js";
+import { f as init_review_status, u as getReviewStatusSync } from "./review-status-yljtTd-q.js";
+import { Ir as getAgentRuntimeStateSync, On as determineModel, a as listRunningAgentsSync, b as init_agents, dt as spawnRun, pt as stopAgent, rr as getAgentStateSync } from "./queries-DHJm7bTd.js";
+import { n as init_issue_service_singleton, r as issue_service_singleton_exports } from "./issue-service-singleton-DmCh7EHj.js";
+import { n as parseSequenceMd, t as init_sequence_io } from "./sequence-io-DF_8iuhV.js";
 import { dirname, join } from "node:path";
 import { Effect } from "effect";
 import { existsSync, readFileSync, readdirSync, statSync } from "node:fs";
@@ -324,4 +324,4 @@ var init_sequencer_agent = __esmMin((() => {
 //#endregion
 export { spawnSequencerAgent as a, init_sequencer_agent as i, clearFinishedSequencerRun as n, getSequencerRunStatus as r, SEQUENCER_AGENT_ID as t };
 
-//# sourceMappingURL=sequencer-agent-BGY8gjg-.js.map
+//# sourceMappingURL=sequencer-agent-B2WeCtGi.js.map