@overdeck/desktop 0.45.15 → 0.45.18

package/sync-sources/hooks/ask-user-question-hook

@@ -49,7 +49,13 @@ if declare -f pan_resolve_agent_id >/dev/null && pan_resolve_agent_id; then
   fi
 fi
 
-REASON='Your question has been surfaced to the operator in the Overdeck dashboard, where they answer it directly. Restate the question and its options to the operator as a short plain-text message and wait for their reply (it arrives as a normal user message).'
+# The literal "(PAN-1520)" marker is LOAD-BEARING: scanPendingInputsPromise
+# (src/lib/agent-enrichment.ts, ASK_USER_QUESTION_HOOK_DENY_MARKER) keys on it
+# to keep the question PENDING after this deny. A deny reason without the
+# marker is treated as a real operator answer — the dashboard modal,
+# notification, and needs-you entry never fire (this exact regression shipped
+# in a rewording and silently killed AUQ detection until 2026-07-13).
+REASON='Your question has been surfaced to the operator in the Overdeck dashboard, where they answer it directly. Restate the question and its options to the operator as a short plain-text message and wait for their reply (it arrives as a normal user message). (PAN-1520)'
 
 CONTEXT=$(echo "$INPUT" | jq -r '
   def fmt_option:

package/sync-sources/hooks/codex-notify-hook

@@ -8,11 +8,16 @@
 // can detect turn-end activity. Also writes a `completed` marker used by
 // the recovery path to detect agent idle state.
 
-'use strict';
+// This file is installed extensionless to ~/.overdeck/bin/ and invoked as
+// `node codex-notify-hook`. Node 22 loads an extensionless entry point as an ES
+// module, so this hook MUST use ESM `import` syntax — `require` throws
+// "require is not defined in ES module scope" and the whole hook dies before it
+// can write a heartbeat or signal the synthesis agent (PAN-2675).
 
-const { join } = require('node:path');
-const { homedir } = require('node:os');
-const { writeFileSync, mkdirSync, existsSync } = require('node:fs');
+import { join } from 'node:path';
+import { homedir, tmpdir } from 'node:os';
+import { writeFileSync, mkdirSync, existsSync, readFileSync, statSync, unlinkSync, appendFileSync } from 'node:fs';
+import { spawnSync } from 'node:child_process';
 
 const agentId = process.env.OVERDECK_AGENT_ID;
 if (!agentId) process.exit(0); // Not a Overdeck-managed agent
@@ -20,11 +25,8 @@ if (!agentId) process.exit(0); // Not a Overdeck-managed agent
 // Read event JSON from stdin (Codex delivers via stdin by default).
 let eventData = {};
 try {
-  const chunks = [];
-  process.stdin.setEncoding('utf8');
-  for (const chunk of []) { chunks.push(chunk); }
   // Synchronous stdin read — Codex provides the event before invoking the shim.
-  const raw = require('node:fs').readFileSync('/dev/stdin', 'utf8').trim();
+  const raw = readFileSync('/dev/stdin', 'utf8').trim();
   if (raw) eventData = JSON.parse(raw);
 } catch {
   // Ignore parse errors — best-effort heartbeat.
@@ -60,3 +62,57 @@ try {
 try {
   writeFileSync(join(agentDir, 'turn-completed'), timestamp + '\n');
 } catch { /* ignore */ }
+
+// PAN-2675: interactive convoy reviewer (codex harness) finished a turn. If it
+// wrote its report and hasn't signaled yet, deliver REVIEWER_READY to the
+// synthesis agent — the codex mirror of the claude-code Stop-hook block
+// (PAN-1557). A turn-end with no report is left alone: Deacon's REVIEWER_TIMEOUT
+// is the failure path, so we never emit a premature REVIEWER_FAILED.
+// Pattern: agent-<issueId>-review-<subRole>
+try {
+  if (/^agent-.+-review-(security|correctness|performance|requirements)$/.test(agentId)) {
+    const statePath = join(agentDir, 'state.json');
+    const markerPath = join(agentDir, 'reviewer-signaled');
+    if (existsSync(statePath) && !existsSync(markerPath)) {
+      let state = {};
+      try { state = JSON.parse(readFileSync(statePath, 'utf8')); } catch { /* leave empty */ }
+      const outPath = typeof state.reviewOutputPath === 'string' ? state.reviewOutputPath : '';
+      const subRole = typeof state.reviewSubRole === 'string' ? state.reviewSubRole : '';
+      const synthId = typeof state.reviewSynthesisAgentId === 'string' ? state.reviewSynthesisAgentId : '';
+      const reportNonEmpty = outPath && existsSync(outPath) && statSync(outPath).size > 0;
+      if (outPath && subRole && synthId && reportNonEmpty) {
+        // Deliver via load-buffer + paste-buffer + Enter on the overdeck socket
+        // (matches the Stop-hook and the project's tmux-delivery rule). The
+        // synthesis session is an interactive tmux session, so the paste reaches
+        // its prompt. Best-effort: if delivery fails, do NOT write the marker so
+        // a later turn can retry.
+        const tmpFile = join(tmpdir(), `reviewer-ready-${agentId}-${process.pid}-${Date.now()}`);
+        let delivered = false;
+        try {
+          writeFileSync(tmpFile, `REVIEWER_READY ${subRole} ${outPath}`);
+          spawnSync('tmux', ['-L', 'overdeck', 'load-buffer', tmpFile], { stdio: 'ignore' });
+          const paste = spawnSync('tmux', ['-L', 'overdeck', 'paste-buffer', '-t', synthId], { stdio: 'ignore' });
+          if (paste.status === 0) {
+            // Let the pasted text render before sending Enter (~300ms), matching
+            // the async-tmux delivery pattern.
+            Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 300);
+            spawnSync('tmux', ['-L', 'overdeck', 'send-keys', '-t', synthId, 'C-m'], { stdio: 'ignore' });
+            delivered = true;
+          }
+        } catch { /* best-effort */ }
+        try { unlinkSync(tmpFile); } catch { /* ignore */ }
+        if (delivered) {
+          try { writeFileSync(markerPath, ''); } catch { /* ignore */ }
+          try {
+            const logsDir = join(overdeckHome, 'logs');
+            mkdirSync(logsDir, { recursive: true });
+            appendFileSync(
+              join(logsDir, 'hooks.log'),
+              `[${new Date().toISOString()}] codex-notify-hook: ${agentId} signaled REVIEWER_READY ${subRole} to ${synthId}\n`,
+            );
+          } catch { /* ignore */ }
+        }
+      }
+    }
+  }
+} catch { /* best-effort — never crash the hook */ }