@outputai/http 0.5.2-next.93dd22e.0 → 0.5.2-next.b54869d.0

package/dist/cost.spec.js

@@ -1,4 +1,5 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { Response } from 'undici';
 import { requestIdSymbol } from './consts.js';
 vi.mock('@outputai/core/sdk_activity_integration', () => {
     class HTTPRequestCost {
@@ -25,6 +26,7 @@ vi.mock('@outputai/core/sdk_activity_integration', () => {
 });
 import { Tracing, emitEvent } from '@outputai/core/sdk_activity_integration';
 import { addRequestCost } from './cost.js';
+import { addRequestIdToResponse } from './fetch/utils.js';
 const tracing = vi.mocked(Tracing, true);
 const emit = vi.mocked(emitEvent, true);
 describe('addRequestCost', () => {
@@ -79,4 +81,25 @@ describe('addRequestCost', () => {
         const attribute = tracing.addEventAttribute.mock.calls[0][0].attribute;
         expect(emit).toHaveBeenCalledWith('cost:http:request', attribute);
     });
+    // ky clones the response before passing it to afterResponse hooks. Without
+    // the clone-propagation patch in addRequestIdToResponse, this path silently
+    // dropped cost (warned "did not originate from @outputai/http") for every
+    // service client that emits cost from inside a ky hook.
+    it('records cost on a cloned response (regression: ky afterResponse hooks)', () => {
+        const response = new Response(undefined, { status: 200 });
+        addRequestIdToResponse(response, 'evt-clone-1');
+        const cloned = response.clone();
+        addRequestCost(cloned, 4.2);
+        expect(console.warn).not.toHaveBeenCalled();
+        expect(tracing.addEventAttribute).toHaveBeenCalledWith({
+            eventId: 'evt-clone-1',
+            attribute: expect.objectContaining({
+                type: Tracing.Attribute.HTTPRequestCost.TYPE,
+                requestId: 'evt-clone-1',
+                total: 4.2
+            })
+        });
+        const attribute = tracing.addEventAttribute.mock.calls[0][0].attribute;
+        expect(emit).toHaveBeenCalledWith('cost:http:request', attribute);
+    });
 });

package/dist/fetch/utils.d.ts

@@ -35,11 +35,11 @@ export declare const redactHeaders: (headers: Headers) => Record<string, unknown
  */
 export declare const parseBody: (r: Request | Response) => Promise<string | object>;
 /**
- * Adds a non-enumerable, non-configurable and non-writable property to a response.
- *
- * This property is identified by a unique symbol and contains the id of the request.
- *
- * @param response
- * @param requestId
+ * Tag a response in place with its request id so downstream code (e.g.
+ * `addRequestCost`) can correlate. Stores the id under a private symbol AND
+ * patches `clone()` so the tag propagates to clones — ky clones the response
+ * before invoking `afterResponse` hooks, and undici headers are immutable on
+ * received responses, so a symbol re-attached inside `clone()` is the only
+ * path that survives.
  */
-export declare const addRequestIdToResponse: (response: Response, requestId: string) => Response;
+export declare const addRequestIdToResponse: (response: Response, requestId: string) => void;

package/dist/fetch/utils.js

@@ -91,11 +91,24 @@ export const parseBody = async (r) => {
     }
 };
 /**
- * Adds a non-enumerable, non-configurable and non-writable property to a response.
- *
- * This property is identified by a unique symbol and contains the id of the request.
- *
- * @param response
- * @param requestId
+ * Tag a response in place with its request id so downstream code (e.g.
+ * `addRequestCost`) can correlate. Stores the id under a private symbol AND
+ * patches `clone()` so the tag propagates to clones — ky clones the response
+ * before invoking `afterResponse` hooks, and undici headers are immutable on
+ * received responses, so a symbol re-attached inside `clone()` is the only
+ * path that survives.
  */
-export const addRequestIdToResponse = (response, requestId) => Object.defineProperty(response, requestIdSymbol, { value: requestId, enumerable: false, configurable: false, writable: false });
+export const addRequestIdToResponse = (response, requestId) => {
+    Object.defineProperty(response, requestIdSymbol, { value: requestId, enumerable: false, configurable: false, writable: false });
+    const originalClone = response.clone.bind(response);
+    Object.defineProperty(response, 'clone', {
+        value: function clone() {
+            const cloned = originalClone();
+            addRequestIdToResponse(cloned, requestId);
+            return cloned;
+        },
+        enumerable: false,
+        configurable: true,
+        writable: true
+    });
+};

package/dist/fetch/utils.spec.js

@@ -252,10 +252,9 @@ describe('fetch/utils', () => {
         });
     });
     describe('addRequestIdToResponse', () => {
-        it('stores request id under requestIdSymbol and returns the same response', () => {
+        it('stores request id under requestIdSymbol on the response', () => {
             const response = new Response('ok');
-            const enriched = addRequestIdToResponse(response, 'req-123');
-            expect(enriched).toBe(response);
+            addRequestIdToResponse(response, 'req-123');
             expect(response[requestIdSymbol]).toBe('req-123');
         });
         it('defines request id as non-enumerable, non-writable and non-configurable', () => {
@@ -270,5 +269,14 @@ describe('fetch/utils', () => {
                 value: 'req-456'
             });
         });
+        it('propagates the request id to clones (ky afterResponse passes the clone)', () => {
+            const response = new Response('ok');
+            addRequestIdToResponse(response, 'req-789');
+            const cloned = response.clone();
+            expect(cloned[requestIdSymbol]).toBe('req-789');
+            // recursion: clones of clones inherit too
+            const grandchild = cloned.clone();
+            expect(grandchild[requestIdSymbol]).toBe('req-789');
+        });
     });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@outputai/http",
-  "version": "0.5.2-next.93dd22e.0",
+  "version": "0.5.2-next.b54869d.0",
   "description": "Framework abstraction to make HTTP calls with tracing",
   "type": "module",
   "main": "dist/index.js",
@@ -11,7 +11,7 @@
   "dependencies": {
     "ky": "1.14.3",
     "undici": "8.1.0",
-    "@outputai/core": "0.5.2-next.93dd22e.0"
+    "@outputai/core": "0.5.2-next.b54869d.0"
   },
   "license": "Apache-2.0",
   "publishConfig": {