@outputai/core 0.9.3-next.c318502.0 → 0.10.1-dev.b7b2fbe.0

package/src/worker/webpack_loaders/workflow_validator/index.mjs

@@ -9,26 +9,13 @@ import {
   isWorkflowPath,
   isAbsoluteWorkflowJsResource
 } from '../tools.js';
-
-/**
- * Files where a bare npm import may bind to child workflows (catalog packages, etc.).
- * Matches {@link collectTargetImports} for `workflow.js`; steps/evaluators need the same
- * binding knowledge for fn-body validation only.
- * @param {string} filename - Absolute resource path.
- * @returns {boolean}
- */
-const fileMayBindBareNpmWorkflowImports = filename => {
-  const n = filename.replace( /\\/g, '/' );
-  return isAbsoluteWorkflowJsResource( filename ) ||
-    isAnyStepsPath( n ) || isAnyEvaluatorsPath( n );
-};
 import {
   isBareNpmSpecifier,
   resolveBareImportSpecifiersAsWorkflows,
   resolveBareDestructuredRequireAsWorkflows,
   resolveBareDefaultRequireAsWorkflow
-} from '../npm_workflow_export_resolve.js';
-import { ComponentFile } from '../consts.js';
+} from './npm_workflow_export_resolve.js';
+import { ComponentFactory, ComponentFile } from '../consts.js';
 import {
   isCallExpression,
   isFunctionExpression,
@@ -41,6 +28,19 @@ import {
   isStringLiteral
 } from '@babel/types';
 
+/**
+ * Files where a bare npm import may bind to child workflows (catalog packages, etc.).
+ * Matches {@link collectTargetImports} for `workflow.js`; steps/evaluators need the same
+ * binding knowledge for fn-body validation only.
+ * @param {string} filename - Absolute resource path.
+ * @returns {boolean}
+ */
+const fileMayBindBareNpmWorkflowImports = filename => {
+  const n = filename.replace( /\\/g, '/' );
+  return isAbsoluteWorkflowJsResource( filename ) ||
+    isAnyStepsPath( n ) || isAnyEvaluatorsPath( n );
+};
+
 // Handle CJS/ESM interop for Babel packages when executed as a webpack loader
 const traverse = traverseModule.default ?? traverseModule;
 
@@ -72,28 +72,77 @@ const getFileKindLabel = filename => {
  * @param {string} filename - The file path where the call occurs
  */
 const validateInstantiationLocation = ( calleeName, filename ) => {
-  if ( calleeName === 'step' && !isAnyStepsPath( filename ) ) {
+  if ( calleeName === ComponentFactory.STEP && !isAnyStepsPath( filename ) ) {
     throw new Error( `Invalid instantiation location: step() can only be called in files with 'steps' in the path. Found in: ${filename}` );
   }
-  if ( calleeName === 'evaluator' && !isAnyEvaluatorsPath( filename ) ) {
+  if ( calleeName === ComponentFactory.EVALUATOR && !isAnyEvaluatorsPath( filename ) ) {
     throw new Error( `Invalid instantiation location: evaluator() can only be called in files with 'evaluators' in the path. Found in: ${filename}` );
   }
-  if ( calleeName === 'workflow' && !isWorkflowPath( filename ) ) {
+  if ( calleeName === ComponentFactory.WORKFLOW && !isWorkflowPath( filename ) ) {
     throw new Error( `Invalid instantiation location: workflow() can only be called in files with 'workflow' in the path. Found in: ${filename}` );
   }
 };
 
+const validateActivityCallsAreInsideFunctions = ( {
+  ast, filename, localStepIds, localEvaluatorIds, importedStepIds, importedEvaluatorIds
+} ) => {
+  traverse( ast, {
+    CallExpression: path => {
+      const callee = path.node.callee;
+      if ( !isIdentifier( callee ) || path.getFunctionParent() ) {
+        return;
+      }
+
+      const { name } = callee;
+      const violation = [
+        [ ComponentFactory.STEP, localStepIds.has( name ) || importedStepIds.has( name ) ],
+        [ ComponentFactory.EVALUATOR, localEvaluatorIds.has( name ) || importedEvaluatorIds.has( name ) ]
+      ].find( v => v[1] )?.[0];
+
+      if ( violation ) {
+        throw new Error( `Invalid top-level ${violation} call '${name}' in ${filename}. Activities can only be invoked inside functions.` );
+      }
+    }
+  } );
+};
+
+const isActivityPath = specifier => isAnyStepsPath( specifier ) || isAnyEvaluatorsPath( specifier );
+
+const validateActivityImportShape = ( specifier, specifiers ) => {
+  if ( !isActivityPath( specifier ) ) {
+    return;
+  }
+
+  if ( specifiers.some( s => !isImportSpecifier( s ) ) ) {
+    throw new Error(
+      `Invalid activity import from "${specifier}": use named imports only. ` +
+      'Default and namespace imports from steps/evaluators files cannot be rewritten.'
+    );
+  }
+};
+
+const validateActivityExportShape = ( fileKind, node ) => {
+  if ( ![ ComponentFile.STEPS, ComponentFile.EVALUATORS ].includes( fileKind ) ) {
+    return;
+  }
+
+  if ( node.type === 'ExportDefaultDeclaration' || node.type === 'ExportAllDeclaration' ) {
+    throw new Error( 'Invalid activity export: steps/evaluators files must use named exports only.' );
+  }
+};
+
 /**
  * Webpack loader that validates component instantiation and fn body calls.
  * Returns the source unchanged unless a validation error is found.
  *
  * Rules enforced:
  *  - Instantiation location: step() must be in steps path, evaluator() in evaluators path, workflow() in workflow path
+ *  - Activity files must use named exports only
+ *  - Activity imports/requires must use named bindings so the rewriter can target each call
+ *  - Top-level activity calls are rejected
  *  - steps.js `fn`: calling any step, evaluator, or workflow inside fn body emits warning
  *  - evaluators.js `fn`: calling any step, evaluator, or workflow inside fn body emits warning
  *
- * NOTE: Import restrictions have been removed - any file can import any other file.
- *
  * @param {string|Buffer} source
  * @param {any} inputMap
  * @this {import('webpack').LoaderContext<{}>}
@@ -122,6 +171,8 @@ export default function workflowValidatorLoader( source, inputMap ) {
       ImportDeclaration: path => {
         const specifier = path.node.source.value;
 
+        validateActivityImportShape( specifier, path.node.specifiers );
+
         if ( isBareNpmSpecifier( specifier ) && fileMayBindBareNpmWorkflowImports( filename ) ) {
           const outcome = resolveBareImportSpecifiersAsWorkflows( {
             fromAbsoluteFile: filename,
@@ -152,6 +203,12 @@ export default function workflowValidatorLoader( source, inputMap ) {
           }
         }
       },
+      ExportDefaultDeclaration: path => {
+        validateActivityExportShape( fileKind, path.node );
+      },
+      ExportAllDeclaration: path => {
+        validateActivityExportShape( fileKind, path.node );
+      },
       VariableDeclarator: path => {
         const init = path.node.init;
         if ( !isCallExpression( init ) ) {
@@ -159,20 +216,20 @@ export default function workflowValidatorLoader( source, inputMap ) {
         }
 
         // Validate instantiation location for step/evaluator/workflow calls
-        if ( isIdentifier( init.callee, { name: 'step' } ) ) {
-          validateInstantiationLocation( 'step', filename );
+        if ( isIdentifier( init.callee, { name: ComponentFactory.STEP } ) ) {
+          validateInstantiationLocation( ComponentFactory.STEP, filename );
           if ( isIdentifier( path.node.id ) ) {
             localStepIds.add( path.node.id.name );
           }
         }
-        if ( isIdentifier( init.callee, { name: 'evaluator' } ) ) {
-          validateInstantiationLocation( 'evaluator', filename );
+        if ( isIdentifier( init.callee, { name: ComponentFactory.EVALUATOR } ) ) {
+          validateInstantiationLocation( ComponentFactory.EVALUATOR, filename );
           if ( isIdentifier( path.node.id ) ) {
             localEvaluatorIds.add( path.node.id.name );
           }
         }
-        if ( isIdentifier( init.callee, { name: 'workflow' } ) ) {
-          validateInstantiationLocation( 'workflow', filename );
+        if ( isIdentifier( init.callee, { name: ComponentFactory.WORKFLOW } ) ) {
+          validateInstantiationLocation( ComponentFactory.WORKFLOW, filename );
         }
 
         // CommonJS requires: collect identifiers for fn body call checks
@@ -208,6 +265,12 @@ export default function workflowValidatorLoader( source, inputMap ) {
 
           // Collect imported identifiers from require patterns
           const reqType = getFileKind( toAbsolutePath( fileDir, req ) );
+          if ( [ ComponentFile.STEPS, ComponentFile.EVALUATORS ].includes( reqType ) && !isObjectPattern( path.node.id ) ) {
+            throw new Error(
+              `Invalid activity require from "${req}": use destructured requires only. ` +
+              'Default-style requires from steps/evaluators files cannot be rewritten.'
+            );
+          }
           if ( reqType === ComponentFile.STEPS && isObjectPattern( path.node.id ) ) {
             for ( const prop of path.node.id.properties ) {
               if ( isObjectProperty( prop ) && isIdentifier( prop.value ) ) {
@@ -229,6 +292,10 @@ export default function workflowValidatorLoader( source, inputMap ) {
       }
     } );
 
+    validateActivityCallsAreInsideFunctions( {
+      ast, filename, localStepIds, localEvaluatorIds, importedStepIds, importedEvaluatorIds
+    } );
+
     // Function-body call validations for steps/evaluators files
     if ( [ ComponentFile.STEPS, ComponentFile.EVALUATORS ].includes( fileKind ) ) {
       traverse( ast, {
@@ -248,9 +315,9 @@ export default function workflowValidatorLoader( source, inputMap ) {
                 const { name } = callee;
                 const fileLabel = getFileKindLabel( filename );
                 const violation = [
-                  [ 'step', localStepIds.has( name ) || importedStepIds.has( name ) ],
-                  [ 'evaluator', localEvaluatorIds.has( name ) || importedEvaluatorIds.has( name ) ],
-                  [ 'workflow', importedWorkflowIds.has( name ) ]
+                  [ ComponentFactory.STEP, localStepIds.has( name ) || importedStepIds.has( name ) ],
+                  [ ComponentFactory.EVALUATOR, localEvaluatorIds.has( name ) || importedEvaluatorIds.has( name ) ],
+                  [ ComponentFactory.WORKFLOW, importedWorkflowIds.has( name ) ]
                 ].find( v => v[1] )?.[0];
 
                 if ( violation ) {