@outputai/core 0.10.1-next.fc0a41f.0 → 0.11.0

package/src/temporal/index.d.ts

@@ -0,0 +1,32 @@
+import type { Client, WorkflowHandle } from '@temporalio/client';
+
+/**
+ * Worker-side access to the Temporal layer.
+ *
+ * `createTemporalClient()` is available after the worker establishes its Temporal
+ * connection. `getCurrentWorkflowHandle()` is only available from Temporal Activities.
+ *
+ * > [!WARNING]
+ * > These are not Temporal sandbox safe, do not import in workflows directly.
+ * > These require the worker runtime, so in unit tests, mock the functions.
+ *
+ * @packageDocumentation
+ */
+
+/**
+ * Creates a Temporal [Client](https://typescript.temporal.io/api/classes/client.Client)
+ * instance with the same connection and namespace as the worker.
+ *
+ * @remarks
+ * - Only available after the worker establishes its Temporal connection.
+ */
+export declare const createTemporalClient: () => Client;
+
+/**
+ * Return the [WorkflowHandle](https://typescript.temporal.io/api/interfaces/client.WorkflowHandle)
+ * for the current workflow execution.
+ *
+ * @remarks
+ * - Only available from a Temporal Activity running in the worker.
+ */
+export declare const getCurrentWorkflowHandle: () => WorkflowHandle;

package/src/temporal/index.js

@@ -0,0 +1 @@
+export { createTemporalClient, getCurrentWorkflowHandle } from './client.js';

package/src/tracing/trace_engine.js

@@ -1,12 +1,13 @@
 import { Storage } from '#async_storage';
 import { EventEmitter } from 'node:events';
-import { serializeError } from './tools/utils.js';
+import { serializeError } from '#helpers/error_serializer';
 import { isStringboolTrue } from '#helpers/string';
 import * as localProcessor from './processors/local/index.js';
 import * as s3Processor from './processors/s3/index.js';
 import { createChildLogger } from '#logger';
 import { EventAction } from './trace_consts.js';
 import { BaseAttribute } from './trace_attribute.js';
+import { TransparentFatalError } from '#errors';
 
 const log = createChildLogger( 'Tracing' );
 
@@ -51,7 +52,7 @@ export const init = async () => {
       try {
         await p.exec( ...args );
       } catch ( error ) {
-        log.error( 'Processor execution error', { processor: p.name, error: error.message, stack: error.stack } );
+        log.error( 'Processor execution error', { processor: p.name, error: serializeError( error ) } );
       }
     } );
   }
@@ -87,15 +88,12 @@ export const addEventAction = ( action, { kind, name, id, parentId, details, tra
 export function addEventActionWithContext( action, options ) {
   const storeContent = Storage.load();
   if ( storeContent ) { // If there is no storageContext this was not called from a Temporal environment
-    const { parentId, traceInfo, addAttribute } = storeContent;
-    if ( action === EventAction.ADD_ATTR ) {
-      const attribute = options.details;
-      if ( !( attribute instanceof BaseAttribute ) ) {
-        throw new Error( `Event ${EventAction.ADD_ATTR} argument is not a BaseAttribute instance` );
-      } else {
-        addAttribute( options.details );
-      }
+    const { parentId, traceInfo } = storeContent;
+    if ( action === EventAction.ADD_ATTR && !( options.details instanceof BaseAttribute ) ) {
+      throw new Error( `Event ${EventAction.ADD_ATTR} argument is not a BaseAttribute instance` );
     }
-    addEventAction( action, { ...options, parentId, traceInfo } );
+    /** Unwraps Transparent error set in details so it behaves like in the interceptors */
+    const details = options.details instanceof TransparentFatalError ? options.details.cause : options.details;
+    addEventAction( action, { ...options, details, parentId, traceInfo } );
   }
 };

package/src/tracing/trace_engine.spec.js

@@ -5,10 +5,15 @@ vi.mock( '#async_storage', () => ( {
   Storage: { load: storageLoadMock }
 } ) );
 
-const logWarnMock = vi.fn();
+const serializeErrorMock = vi.fn( error => ( {
+  name: error.name,
+  message: error.message
+} ) );
+vi.mock( '#helpers/error_serializer', () => ( { serializeError: serializeErrorMock } ) );
+
 const logErrorMock = vi.fn();
 vi.mock( '#logger', () => ( {
-  createChildLogger: () => ( { warn: logWarnMock, error: logErrorMock } )
+  createChildLogger: () => ( { error: logErrorMock } )
 } ) );
 
 const localInitMock = vi.fn( async () => {} );
@@ -71,6 +76,24 @@ describe( 'tracing/trace_engine', () => {
     expect( payload.traceInfo ).toBe( traceInfo );
   } );
 
+  it( 'init() logs processor failures with serialized stacks', async () => {
+    process.env.OUTPUT_TRACE_LOCAL_ON = '1';
+    const processorError = new Error( 'processor failed' );
+    localExecMock.mockRejectedValueOnce( processorError );
+    const { init, addEventAction } = await loadTraceEngine();
+    await init();
+
+    addEventAction( 'start', {
+      kind: 'step', name: 'N', id: '1', parentId: 'p', details: null, traceInfo
+    } );
+
+    await vi.waitFor( () => expect( logErrorMock ).toHaveBeenCalledWith( 'Processor execution error', {
+      processor: 'LOCAL',
+      error: { name: 'Error', message: 'processor failed' }
+    } ) );
+    expect( serializeErrorMock ).toHaveBeenCalledWith( processorError );
+  } );
+
   it( 'addEventAction() emits an entry consumed by processors', async () => {
     process.env.OUTPUT_TRACE_LOCAL_ON = 'on';
     const { init, addEventAction } = await loadTraceEngine();
@@ -87,34 +110,34 @@ describe( 'tracing/trace_engine', () => {
     expect( payload.entry.details ).toBe( 'done' );
   } );
 
-  it( 'addEventAction() does not emit when traceInfo is absent', async () => {
-    process.env.OUTPUT_TRACE_LOCAL_ON = '1';
+  it( 'addEventAction() serializes error details before emitting', async () => {
+    process.env.OUTPUT_TRACE_LOCAL_ON = 'on';
     const { init, addEventAction } = await loadTraceEngine();
     await init();
+    const error = new TypeError( 'step failed' );
 
-    addEventAction( 'start', {
-      kind: 'step', name: 'X', id: '1', parentId: 'p', details: {},
-      traceInfo: undefined
+    addEventAction( 'error', {
+      kind: 'step', name: 'S', id: '3', parentId: 'p3', details: error,
+      traceInfo
+    } );
+
+    expect( serializeErrorMock ).toHaveBeenCalledWith( error );
+    expect( localExecMock.mock.calls[0][0].entry.details ).toEqual( {
+      name: 'TypeError',
+      message: 'step failed'
     } );
-    expect( localExecMock ).not.toHaveBeenCalled();
   } );
 
-  it( 'addEventAction() emits when kind is INTERNAL_STEP', async () => {
+  it( 'addEventAction() does not emit when traceInfo is absent', async () => {
     process.env.OUTPUT_TRACE_LOCAL_ON = '1';
     const { init, addEventAction } = await loadTraceEngine();
     await init();
 
     addEventAction( 'start', {
-      kind: 'internal_step', name: 'Internal', id: '1', parentId: 'p', details: {},
-      traceInfo
-    } );
-    expect( localExecMock ).toHaveBeenCalledTimes( 1 );
-    expect( localExecMock.mock.calls[0][0].entry ).toMatchObject( {
-      kind: 'internal_step',
-      name: 'Internal',
-      id: '1',
-      parentId: 'p'
+      kind: 'step', name: 'X', id: '1', parentId: 'p', details: {},
+      traceInfo: undefined
     } );
+    expect( localExecMock ).not.toHaveBeenCalled();
   } );
 
   it( 'addEventActionWithContext() uses storage when available', async () => {
@@ -135,13 +158,34 @@ describe( 'tracing/trace_engine', () => {
     expect( payload.entry.action ).toBe( 'tick' );
   } );
 
-  it( 'addEventActionWithContext() records ADD_ATTR attributes through storage context', async () => {
+  it( 'addEventActionWithContext() unwraps transparent errors without mutating options', async () => {
     process.env.OUTPUT_TRACE_LOCAL_ON = 'true';
-    const addAttributeMock = vi.fn();
     storageLoadMock.mockReturnValue( {
       parentId: 'ctx-p',
-      traceInfo,
-      addAttribute: addAttributeMock
+      traceInfo
+    } );
+    const { init, addEventActionWithContext } = await loadTraceEngine();
+    const { TransparentFatalError } = await import( '#errors' );
+    await init();
+
+    const cause = new TypeError( 'provider rejected request' );
+    const error = new TransparentFatalError( cause );
+    const options = { kind: 'llm', name: 'generate', id: 'llm-1', details: error };
+    addEventActionWithContext( 'error', options );
+
+    expect( options.details ).toBe( error );
+    expect( serializeErrorMock ).toHaveBeenCalledWith( cause );
+    expect( localExecMock.mock.calls[0][0].entry.details ).toEqual( {
+      name: 'TypeError',
+      message: 'provider rejected request'
+    } );
+  } );
+
+  it( 'addEventActionWithContext() emits validated ADD_ATTR trace entries', async () => {
+    process.env.OUTPUT_TRACE_LOCAL_ON = 'true';
+    storageLoadMock.mockReturnValue( {
+      parentId: 'ctx-p',
+      traceInfo
     } );
     const { init, addEventActionWithContext } = await loadTraceEngine();
     const { EventAction } = await import( './trace_consts.js' );
@@ -151,8 +195,6 @@ describe( 'tracing/trace_engine', () => {
     const attribute = new Attribute.HTTPRequestCount( 'https://example.test', 'req-1' );
     addEventActionWithContext( EventAction.ADD_ATTR, { kind: 'http', name: 'request', id: 'req-1', details: attribute } );
 
-    expect( addAttributeMock ).toHaveBeenCalledTimes( 1 );
-    expect( addAttributeMock ).toHaveBeenCalledWith( attribute );
     expect( localExecMock ).toHaveBeenCalledTimes( 1 );
     expect( localExecMock.mock.calls[0][0] ).toEqual( {
       traceInfo,
@@ -170,11 +212,9 @@ describe( 'tracing/trace_engine', () => {
 
   it( 'addEventActionWithContext() throws on invalid ADD_ATTR signal payloads', async () => {
     process.env.OUTPUT_TRACE_LOCAL_ON = 'true';
-    const addAttributeMock = vi.fn();
     storageLoadMock.mockReturnValue( {
       parentId: 'ctx-p',
-      traceInfo,
-      addAttribute: addAttributeMock
+      traceInfo
     } );
     const { init, addEventActionWithContext } = await loadTraceEngine();
     const { EventAction } = await import( './trace_consts.js' );
@@ -186,7 +226,6 @@ describe( 'tracing/trace_engine', () => {
       { kind: 'http', name: 'request', id: 'req-1', details: invalidAttribute }
     ) ).toThrow( /not a BaseAttribute instance/ );
 
-    expect( addAttributeMock ).not.toHaveBeenCalled();
     expect( localExecMock ).not.toHaveBeenCalled();
   } );
 

package/src/worker/catalog_workflow/catalog_job.js

@@ -38,7 +38,7 @@ export class CatalogJob {
         throw e;
       }
       if ( !( e instanceof WorkflowNotFoundError ) ) {
-        log.warn( 'Error describing catalog workflow', { error: e } );
+        log.warn( 'Error describing catalog workflow', { error: e.message } );
       }
       return false;
     } );
@@ -52,7 +52,7 @@ export class CatalogJob {
         throw e;
       }
       if ( !( e instanceof WorkflowNotFoundError ) ) {
-        log.warn( 'Error describing catalog workflow', { error: e } );
+        log.warn( 'Error describing catalog workflow', { error: e.message } );
       }
       return false;
     } );
@@ -66,7 +66,7 @@ export class CatalogJob {
         throw e;
       }
       if ( !( e instanceof WorkflowNotFoundError ) ) {
-        log.warn( 'Error completing previous catalog workflow', { error: e } );
+        log.warn( 'Error completing previous catalog workflow', { error: e.message } );
       }
     } );
   };

package/src/worker/catalog_workflow/catalog_job.spec.js

@@ -121,7 +121,7 @@ describe( 'CatalogJob', () => {
 
     await job.run();
 
-    expect( mockLog.warn ).toHaveBeenCalledWith( 'Error completing previous catalog workflow', { error: completeError } );
+    expect( mockLog.warn ).toHaveBeenCalledWith( 'Error completing previous catalog workflow', { error: completeError.message } );
     expect( workflowStartMock ).toHaveBeenCalledWith( 'catalog', expect.any( Object ) );
     expect( job.error ).toBeNull();
   } );

package/src/worker/index.js

@@ -18,7 +18,10 @@ import { BusEventType } from '#consts';
 import { setupTelemetry } from './telemetry.js';
 import { TemporalConnectionMonitor } from './connection_monitor.js';
 import { bindGlobalFunctions } from './global_functions.js';
+import { setupClientConfig } from '#temporal/client';
 import { runOnce } from '#helpers/function';
+import { serializeError } from '#helpers/error_serializer';
+import { setupTemporalLogger } from './temporal_logger.js';
 
 import './log_hooks.js';
 
@@ -51,6 +54,9 @@ const state = {
 const callerDir = process.argv[2];
 
 const execute = async () => {
+  log.info( 'Setup Temporal Logger' );
+  setupTemporalLogger();
+
   log.info( 'Loading config...', { callerDir } );
   await loadHooks( callerDir );
 
@@ -81,6 +87,9 @@ const execute = async () => {
 
   state.connection = await NativeConnection.connect( { address, tls: Boolean( apiKey ), apiKey, proxy } );
 
+  // add configs for the /temporal endpoint
+  setupClientConfig( { connection: state.connection, namespace } );
+
   log.info( 'Creating connection monitor...' );
   state.connectionMonitor = new TemporalConnectionMonitor( state.connection );
 
@@ -219,7 +228,7 @@ execute()
     log.info( 'Bye' );
   } )
   .catch( async error => {
-    log.error( 'Fatal error', { error: error.message, stack: error.stack } );
+    log.error( 'Fatal error', { error: serializeError( error ) } );
 
     mainEventBus.emit( BusEventType.RUNTIME_ERROR, { error } );
 

package/src/worker/index.spec.js

@@ -14,7 +14,10 @@ const {
   mockWorker,
   promises,
   resetPromises,
+  serializeErrorMock,
+  setupClientConfigMock,
   setupInterruptionHandlerMock,
+  setupTemporalLoggerMock,
   setupTelemetryMock
 } = vi.hoisted( () => {
   const createDeferred = () => {
@@ -117,16 +120,20 @@ const {
     mockWorker,
     promises,
     resetPromises,
+    serializeErrorMock: vi.fn( error => ( {
+      name: error.name,
+      message: error.message,
+      stack: error.stack
+    } ) ),
+    setupClientConfigMock: vi.fn(),
     setupInterruptionHandlerMock: vi.fn(),
+    setupTemporalLoggerMock: vi.fn(),
     setupTelemetryMock: vi.fn()
   };
 } );
 
 vi.mock( '#logger', () => ( { createChildLogger: () => mockLog } ) );
-vi.mock( '#consts', async importOriginal => {
-  const actual = await importOriginal();
-  return { ...actual };
-} );
+vi.mock( '#helpers/error_serializer', () => ( { serializeError: serializeErrorMock } ) );
 const initTracing = vi.fn().mockResolvedValue( undefined );
 vi.mock( '#tracing', () => ( { init: initTracing } ) );
 vi.mock( '#bus', () => ( { mainEventBus: mainEventBusMock } ) );
@@ -161,6 +168,8 @@ vi.mock( './catalog_workflow/catalog_job.js', () => ( {
   } )
 } ) );
 vi.mock( './log_hooks.js', () => ( {} ) );
+vi.mock( './temporal_logger.js', () => ( { setupTemporalLogger: setupTemporalLoggerMock } ) );
+vi.mock( '#temporal/client', () => ( { setupClientConfig: setupClientConfigMock } ) );
 vi.mock( '@temporalio/worker', () => ( {
   NativeConnection: { connect: vi.fn().mockResolvedValue( mockConnection ) },
   Worker: { create: vi.fn().mockResolvedValue( mockWorker ) }
@@ -217,6 +226,7 @@ describe( 'worker/index', () => {
     await vi.waitFor( () => expect( Worker.create ).toHaveBeenCalled() );
 
     expect( loadHooksMock ).toHaveBeenCalledWith( '/test/caller/dir' );
+    expect( setupTemporalLoggerMock ).toHaveBeenCalledOnce();
     expect( loadWorkflowsMock ).toHaveBeenCalledWith( '/test/caller/dir' );
     expect( loadActivitiesMock ).toHaveBeenCalledWith( '/test/caller/dir', [] );
     expect( initTracing ).toHaveBeenCalled();
@@ -228,6 +238,10 @@ describe( 'worker/index', () => {
       apiKey: undefined,
       proxy: undefined
     } );
+    expect( setupClientConfigMock ).toHaveBeenCalledWith( {
+      connection: mockConnection,
+      namespace: configValues.namespace
+    } );
     expect( bindGlobalFunctionsMock ).toHaveBeenCalledTimes( 1 );
     expect( bindGlobalFunctionsMock.mock.invocationCallOrder[0] ).toBeLessThan(
       NativeConnection.connect.mock.invocationCallOrder[0]
@@ -356,9 +370,10 @@ describe( 'worker/index', () => {
 
     await vi.waitFor( () => {
       expect( mockLog.error ).toHaveBeenCalledWith( 'Fatal error', expect.objectContaining( {
-        error: 'Big Failure'
+        error: expect.objectContaining( { message: 'Big Failure' } )
       } ) );
     } );
+    expect( serializeErrorMock ).toHaveBeenCalledWith( error );
     expect( mainEventBusMock.emit ).toHaveBeenCalledWith( expect.any( String ), { error } );
     await vi.waitFor( () => expect( exitMock ).toHaveBeenCalledWith( 1 ) );
     expect( flushPendingHooksMock ).toHaveBeenCalledOnce();
@@ -378,7 +393,7 @@ describe( 'worker/index', () => {
 
     await vi.waitFor( () => {
       expect( mockLog.error ).toHaveBeenCalledWith( 'Fatal error', expect.objectContaining( {
-        error: 'connection lost'
+        error: expect.objectContaining( { message: 'connection lost' } )
       } ) );
     } );
     expect( mockWorker.shutdown ).toHaveBeenCalledOnce();
@@ -398,7 +413,7 @@ describe( 'worker/index', () => {
 
     await vi.waitFor( () => {
       expect( mockLog.error ).toHaveBeenCalledWith( 'Fatal error', expect.objectContaining( {
-        error: 'catalog failed'
+        error: expect.objectContaining( { message: 'catalog failed' } )
       } ) );
     } );
     expect( mockWorker.shutdown ).toHaveBeenCalledOnce();
@@ -418,7 +433,7 @@ describe( 'worker/index', () => {
     expect( catalogJobInstance.interrupt ).not.toHaveBeenCalled();
     await vi.waitFor( () => {
       expect( mockLog.error ).toHaveBeenCalledWith( 'Fatal error', expect.objectContaining( {
-        error: 'worker create failed'
+        error: expect.objectContaining( { message: 'worker create failed' } )
       } ) );
     } );
   } );

package/src/worker/interceptors/activity.js

@@ -1,12 +1,14 @@
-import { Context, activityInfo as activityInfoFn } from '@temporalio/activity';
+import { Context, activityInfo as activityInfoFn, ApplicationFailure } from '@temporalio/activity';
+import { CompleteAsyncError, TemporalFailure } from '@temporalio/common';
 import { Storage } from '#async_storage';
 import * as Tracing from '#tracing';
 import { headersToObject } from './headers.js';
-import { ACTIVITY_WRAPPER_VERSION_FIELD, BusEventType, METADATA_ACCESS_SYMBOL } from '#consts';
+import { ActivitySpecialOutput, BusEventType, METADATA_ACCESS_SYMBOL } from '#consts';
 import { activityHeartbeatEnabled, activityHeartbeatIntervalMs } from '../configs.js';
 import { mainEventBus } from '#bus';
-import { aggregateAttributes } from '#helpers/aggregations';
-import { buildApplicationFailureWithDetails } from '#helpers/errors';
+import { inheritsFromAnyNamedType } from '#helpers/errors';
+import { serializeError } from '#helpers/error_serializer';
+import { FatalError, TransparentFatalError } from '#errors';
 
 /*
   This interceptor wraps every activity execution with cross-cutting concerns:
@@ -51,12 +53,9 @@ export class ActivityExecutionInterceptor {
     }
 
     const state = {
-      heartbeat: null,
-      attributes: []
+      heartbeat: null
     };
 
-    const addAttribute = attribute => state.attributes.push( attribute );
-
     // Adds context accessible information
     const storageContext = {
       parentId: activityId,
@@ -64,8 +63,7 @@ export class ActivityExecutionInterceptor {
       activityInfo,
       workflowDetails,
       workflowFilename,
-      traceInfo,
-      addAttribute
+      traceInfo
     };
 
     mainEventBus.emit( BusEventType.ACTIVITY_START, { activityInfo, workflowDetails, outputActivityKind } );
@@ -77,19 +75,34 @@ export class ActivityExecutionInterceptor {
 
       const output = await Storage.runWithContext( async _ => next( input ), storageContext );
 
-      const aggregations = state.attributes.length > 0 ? aggregateAttributes( state.attributes ) : null;
-
-      mainEventBus.emit( BusEventType.ACTIVITY_END, { activityInfo, aggregations, workflowDetails, outputActivityKind } );
+      mainEventBus.emit( BusEventType.ACTIVITY_END, { activityInfo, workflowDetails, outputActivityKind } );
       Tracing.addEventEnd( { id: activityId, details: output, traceInfo } );
 
-      return { [ACTIVITY_WRAPPER_VERSION_FIELD]: 1, output, aggregations };
+      return output;
 
     } catch ( error ) {
-      const aggregations = state.attributes.length > 0 ? aggregateAttributes( state.attributes ) : null;
-      mainEventBus.emit( BusEventType.ACTIVITY_ERROR, { activityInfo, aggregations, workflowDetails, outputActivityKind, error } );
-      Tracing.addEventError( { id: activityId, details: error, traceInfo } );
-
-      throw aggregations ? buildApplicationFailureWithDetails( error, { aggregations } ) : error;
+      // Record async completion handoff as a trace end without emitting a bus event.
+      if ( error instanceof CompleteAsyncError ) {
+        Tracing.addEventEnd( { id: activityId, details: ActivitySpecialOutput.ASYNC_HANDOFF, traceInfo } );
+        throw error;
+      }
+
+      const unwrappedError = error instanceof TransparentFatalError ? error.cause : error;
+
+      Tracing.addEventError( { id: activityId, details: unwrappedError, traceInfo } );
+      mainEventBus.emit( BusEventType.ACTIVITY_ERROR, { activityInfo, workflowDetails, outputActivityKind, error: unwrappedError } );
+
+      // Native Temporal errors are just re-thrown
+      if ( error instanceof TemporalFailure ) {
+        throw error;
+      }
+
+      const nonRetryable = error instanceof FatalError || inheritsFromAnyNamedType( error, activityInfo.retryPolicy?.nonRetryableErrorTypes ?? [] );
+      throw ApplicationFailure.fromError( unwrappedError, {
+        nonRetryable,
+        cause: unwrappedError,
+        details: [ { error: serializeError( unwrappedError, { dropKeys: [ 'stack' ] } ) } ]
+      } );
     } finally {
       clearInterval( state.heartbeat );
     }