@output.ai/core 0.5.4 → 0.5.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@output.ai/core",
-  "version": "0.5.4",
+  "version": "0.5.5",
   "description": "The core module of the output framework",
   "type": "module",
   "exports": {
@@ -40,7 +40,7 @@
     "stacktrace-parser": "0.1.11",
     "undici": "7.18.2",
     "winston": "3.17.0",
-    "zod": "4.1.12"
+    "zod": "^4.3.6"
   },
   "license": "Apache-2.0",
   "publishConfig": {

package/src/tracing/trace_engine.js

@@ -23,7 +23,7 @@ const processors = [
     name: 'REMOTE',
     init: s3Processor.init,
     exec: s3Processor.exec,
-    getDestination: localProcessor.getDestination
+    getDestination: s3Processor.getDestination
   }
 ];
 

package/src/tracing/trace_engine.spec.js

@@ -87,6 +87,18 @@ describe( 'tracing/trace_engine', () => {
     expect( localExecMock ).not.toHaveBeenCalled();
   } );
 
+  it( 'addEventPhase() does not emit when kind is INTERNAL_STEP', async () => {
+    process.env.OUTPUT_TRACE_LOCAL_ON = '1';
+    const { init, addEventPhase } = await loadTraceEngine();
+    await init();
+
+    addEventPhase( 'start', {
+      kind: 'internal_step', name: 'Internal', id: '1', parentId: 'p', details: {},
+      executionContext: { disableTrace: false }
+    } );
+    expect( localExecMock ).not.toHaveBeenCalled();
+  } );
+
   it( 'addEventPhaseWithContext() uses storage when available', async () => {
     process.env.OUTPUT_TRACE_LOCAL_ON = 'true';
     storageLoadMock.mockReturnValue( {
@@ -128,23 +140,60 @@ describe( 'tracing/trace_engine', () => {
     expect( localExecMock ).not.toHaveBeenCalled();
   } );
 
-  it( 'getDestinations() returns null for each value when executionContext.disableTrace is true', async () => {
-    process.env.OUTPUT_TRACE_LOCAL_ON = '1';
-    process.env.OUTPUT_TRACE_REMOTE_ON = '1';
-    const { getDestinations } = await loadTraceEngine();
-    const result = getDestinations( { workflowId: 'w1', workflowName: 'WF', startTime: 1, disableTrace: true } );
-    expect( result ).toEqual( { local: null, remote: null } );
-    expect( localGetDestinationMock ).not.toHaveBeenCalled();
-    expect( s3GetDestinationMock ).not.toHaveBeenCalled();
-  } );
-
-  it( 'getDestinations() returns processor destinations when disableTrace is false', async () => {
-    process.env.OUTPUT_TRACE_LOCAL_ON = '1';
-    process.env.OUTPUT_TRACE_REMOTE_ON = '0';
-    const { getDestinations } = await loadTraceEngine();
+  describe( 'getDestinations()', () => {
     const executionContext = { workflowId: 'w1', workflowName: 'WF', startTime: 1, disableTrace: false };
-    const result = getDestinations( executionContext );
-    expect( result ).toEqual( { local: '/local/path.json', remote: null } );
-    expect( localGetDestinationMock ).toHaveBeenCalledWith( executionContext );
+
+    it( 'returns null for both when traces are off (env vars unset)', async () => {
+      const { getDestinations } = await loadTraceEngine();
+      const result = getDestinations( executionContext );
+      expect( result ).toEqual( { local: null, remote: null } );
+      expect( localGetDestinationMock ).not.toHaveBeenCalled();
+      expect( s3GetDestinationMock ).not.toHaveBeenCalled();
+    } );
+
+    it( 'returns null for both when executionContext.disableTrace is true', async () => {
+      process.env.OUTPUT_TRACE_LOCAL_ON = '1';
+      process.env.OUTPUT_TRACE_REMOTE_ON = '1';
+      const { getDestinations } = await loadTraceEngine();
+      const result = getDestinations( { ...executionContext, disableTrace: true } );
+      expect( result ).toEqual( { local: null, remote: null } );
+      expect( localGetDestinationMock ).not.toHaveBeenCalled();
+      expect( s3GetDestinationMock ).not.toHaveBeenCalled();
+    } );
+
+    it( 'returns both destinations when both traces are on', async () => {
+      process.env.OUTPUT_TRACE_LOCAL_ON = '1';
+      process.env.OUTPUT_TRACE_REMOTE_ON = 'true';
+      const { getDestinations } = await loadTraceEngine();
+      const result = getDestinations( executionContext );
+      expect( result ).toEqual( {
+        local: '/local/path.json',
+        remote: 'https://bucket.s3.amazonaws.com/key.json'
+      } );
+      expect( localGetDestinationMock ).toHaveBeenCalledTimes( 1 );
+      expect( localGetDestinationMock ).toHaveBeenCalledWith( executionContext );
+      expect( s3GetDestinationMock ).toHaveBeenCalledTimes( 1 );
+      expect( s3GetDestinationMock ).toHaveBeenCalledWith( executionContext );
+    } );
+
+    it( 'returns local only when local trace on and remote off', async () => {
+      process.env.OUTPUT_TRACE_LOCAL_ON = '1';
+      process.env.OUTPUT_TRACE_REMOTE_ON = '0';
+      const { getDestinations } = await loadTraceEngine();
+      const result = getDestinations( executionContext );
+      expect( result ).toEqual( { local: '/local/path.json', remote: null } );
+      expect( localGetDestinationMock ).toHaveBeenCalledWith( executionContext );
+      expect( s3GetDestinationMock ).not.toHaveBeenCalled();
+    } );
+
+    it( 'returns remote only when local trace off and remote on', async () => {
+      process.env.OUTPUT_TRACE_LOCAL_ON = '0';
+      process.env.OUTPUT_TRACE_REMOTE_ON = 'true';
+      const { getDestinations } = await loadTraceEngine();
+      const result = getDestinations( executionContext );
+      expect( result ).toEqual( { local: null, remote: 'https://bucket.s3.amazonaws.com/key.json' } );
+      expect( localGetDestinationMock ).not.toHaveBeenCalled();
+      expect( s3GetDestinationMock ).toHaveBeenCalledWith( executionContext );
+    } );
   } );
 } );