@output.ai/core 0.4.8 → 0.4.9-dev.pr326-21ac1cf

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@output.ai/core",
-  "version": "0.4.8",
+  "version": "0.4.9-dev.pr326-21ac1cf",
   "description": "The core module of the output framework",
   "type": "module",
   "exports": {

package/src/tracing/processors/s3/configs.js

@@ -6,7 +6,8 @@ const envVarSchema = z.object( {
   OUTPUT_AWS_SECRET_ACCESS_KEY: z.string(),
   OUTPUT_TRACE_REMOTE_S3_BUCKET: z.string(),
   OUTPUT_REDIS_URL: z.string(),
-  OUTPUT_REDIS_TRACE_TTL: z.coerce.number().int().positive().default( 60 * 60 * 24 * 7 ) // 7 days
+  OUTPUT_REDIS_TRACE_TTL: z.coerce.number().int().positive().default( 60 * 60 * 24 * 7 ), // 7 days
+  OUTPUT_TRACE_UPLOAD_DELAY_MS: z.coerce.number().int().nonnegative().default( 10_000 ) // 10s
 } );
 
 const env = {};
@@ -19,6 +20,7 @@ export const loadEnv = () => {
   env.remoteS3Bucket = parsedFields.OUTPUT_TRACE_REMOTE_S3_BUCKET;
   env.redisUrl = parsedFields.OUTPUT_REDIS_URL;
   env.redisIncompleteWorkflowsTTL = parsedFields.OUTPUT_REDIS_TRACE_TTL;
+  env.traceUploadDelayMs = parsedFields.OUTPUT_TRACE_UPLOAD_DELAY_MS;
 };
 
 export const getVars = () => {

package/src/tracing/processors/s3/index.js

@@ -83,6 +83,12 @@ export const exec = async ( { entry, executionContext } ) => {
     return;
   }
 
+  // Wait for straggler entries from other workers to land in Redis before uploading
+  const delayMs = getVars().traceUploadDelayMs;
+  if ( delayMs > 0 ) {
+    await new Promise( resolve => setTimeout( resolve, delayMs ) );
+  }
+
   const content = buildTraceTree( await getEntries( cacheKey ) );
   // if the trace tree is incomplete it will return null, in this case we can safely discard
   if ( !content ) {

package/src/tracing/processors/s3/index.spec.js

@@ -1,4 +1,4 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 
 const loadEnvMock = vi.fn();
 const getVarsMock = vi.fn( () => ( {
@@ -29,8 +29,13 @@ vi.mock( '../../tools/build_trace_tree.js', () => ( { default: buildTraceTreeMoc
 
 describe( 'tracing/processors/s3', () => {
   beforeEach( () => {
+    vi.useFakeTimers();
     vi.clearAllMocks();
-    getVarsMock.mockReturnValue( { remoteS3Bucket: 'bkt', redisIncompleteWorkflowsTTL: 3600 } );
+    getVarsMock.mockReturnValue( { remoteS3Bucket: 'bkt', redisIncompleteWorkflowsTTL: 3600, traceUploadDelayMs: 10_000 } );
+  } );
+
+  afterEach( () => {
+    vi.useRealTimers();
   } );
 
   it( 'init(): loads config and ensures redis client is created', async () => {
@@ -57,8 +62,10 @@ describe( 'tracing/processors/s3', () => {
 
     await exec( { ...ctx, entry: { name: 'A', phase: 'start', timestamp: startTime, parentId: 'root' } } );
     await exec( { ...ctx, entry: { name: 'A', phase: 'tick', timestamp: startTime + 1, parentId: 'root' } } );
-    // Root end: no parentId and not start
-    await exec( { ...ctx, entry: { name: 'A', phase: 'end', timestamp: startTime + 2 } } );
+    // Root end: no parentId and not start — triggers the 10s delay before upload
+    const endPromise = exec( { ...ctx, entry: { name: 'A', phase: 'end', timestamp: startTime + 2 } } );
+    await vi.advanceTimersByTimeAsync( 10_000 );
+    await endPromise;
 
     // Accumulation happened 3 times
     expect( redisMulti.zAdd ).toHaveBeenCalledTimes( 3 );
@@ -78,7 +85,7 @@ describe( 'tracing/processors/s3', () => {
   } );
 
   it( 'getDestination(): returns S3 URL using bucket and key from getVars', async () => {
-    getVarsMock.mockReturnValue( { remoteS3Bucket: 'my-bucket', redisIncompleteWorkflowsTTL: 3600 } );
+    getVarsMock.mockReturnValue( { remoteS3Bucket: 'my-bucket', redisIncompleteWorkflowsTTL: 3600, traceUploadDelayMs: 10_000 } );
     const { getDestination } = await import( './index.js' );
     const startTime = Date.parse( '2020-01-02T03:04:05.678Z' );
     const url = getDestination( { workflowId: 'id1', workflowName: 'WF', startTime } );
@@ -111,7 +118,9 @@ describe( 'tracing/processors/s3', () => {
     zRangeMock.mockResolvedValue( [ JSON.stringify( { id: 'wf', phase: 'end', timestamp: startTime } ) ] );
     buildTraceTreeMock.mockReturnValueOnce( null );
 
-    await exec( { ...ctx, entry: { id: 'wf', phase: 'end', timestamp: startTime } } );
+    const endPromise = exec( { ...ctx, entry: { id: 'wf', phase: 'end', timestamp: startTime } } );
+    await vi.advanceTimersByTimeAsync( 10_000 );
+    await endPromise;
 
     expect( buildTraceTreeMock ).toHaveBeenCalledTimes( 1 );
     expect( uploadMock ).not.toHaveBeenCalled();