@output.ai/core 0.4.4 → 0.4.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@output.ai/core",
-  "version": "0.4.4",
+  "version": "0.4.5",
   "description": "The core module of the output framework",
   "type": "module",
   "exports": {

package/src/tracing/processors/s3/index.js

@@ -3,6 +3,9 @@ import { getRedisClient } from './redis_client.js';
 import buildTraceTree from '../../tools/build_trace_tree.js';
 import { EOL } from 'node:os';
 import { loadEnv, getVars } from './configs.js';
+import { createChildLogger } from '#logger';
+
+const log = createChildLogger( 'S3 Processor' );
 
 const createRedisKey = ( { workflowId, workflowName } ) => `traces/${workflowName}/${workflowId}`;
 
@@ -81,6 +84,11 @@ export const exec = async ( { entry, executionContext } ) => {
   }
 
   const content = buildTraceTree( await getEntries( cacheKey ) );
+  // if the trace tree is incomplete it will return null, in this case we can safely discard
+  if ( !content ) {
+    log.warn( 'Incomplete trace file discarded', { workflowId, error: 'incomplete_trace_file' } );
+    return;
+  }
   await upload( {
     key: getS3Key( { workflowId, workflowName, startTime } ),
     content: JSON.stringify( content, undefined, 2 ) + EOL

package/src/tracing/processors/s3/index.spec.js

@@ -87,5 +87,21 @@ describe( 'tracing/processors/s3', () => {
       'https://my-bucket.s3.amazonaws.com/WF/2020/01/02/2020-01-02-03-04-05-678Z_id1.json'
     );
   } );
+
+  it( 'exec(): when buildTraceTree returns null (incomplete tree), does not upload or bust cache', async () => {
+    const { exec } = await import( './index.js' );
+    const startTime = Date.parse( '2020-01-02T03:04:05.678Z' );
+    const ctx = { executionContext: { workflowId: 'id1', workflowName: 'WF', startTime } };
+
+    redisMulti.exec.mockResolvedValue( [] );
+    zRangeMock.mockResolvedValue( [ JSON.stringify( { id: 'wf', phase: 'end', timestamp: startTime } ) ] );
+    buildTraceTreeMock.mockReturnValueOnce( null );
+
+    await exec( { ...ctx, entry: { id: 'wf', phase: 'end', timestamp: startTime } } );
+
+    expect( buildTraceTreeMock ).toHaveBeenCalledTimes( 1 );
+    expect( uploadMock ).not.toHaveBeenCalled();
+    expect( delMock ).not.toHaveBeenCalled();
+  } );
 } );
 

package/src/tracing/tools/build_trace_tree.js

@@ -46,7 +46,7 @@ const createEntry = id => ( {
  * The result tree has a single root: the only node without parentId, normally the workflow itself.
  *
  * @param {object[]} entries - The list of entries
- * @returns {void}
+ * @returns {object}
  */
 export default entries => {
   const nodes = new Map();
@@ -71,6 +71,9 @@ export default entries => {
     }
   }
 
-  const root = nodes.get( entries.find( e => !e.parentId ).id );
-  return root;
+  const rootNode = nodes.get( entries.find( e => !e.parentId )?.id );
+  if ( !rootNode ) {
+    return null;
+  }
+  return rootNode;
 };

package/src/tracing/tools/build_trace_tree.spec.js

@@ -1,7 +1,32 @@
 import { describe, it, expect } from 'vitest';
-import buildLogTree from './build_trace_tree.js';
+import buildTraceTree from './build_trace_tree.js';
 
 describe( 'build_trace_tree', () => {
+  it( 'returns null when entries is empty', () => {
+    expect( buildTraceTree( [] ) ).toBeNull();
+  } );
+
+  it( 'returns null when there is no root (all entries have parentId)', () => {
+    const entries = [
+      { id: 'a', parentId: 'x', phase: 'start', name: 'a', timestamp: 1 },
+      { id: 'b', parentId: 'a', phase: 'start', name: 'b', timestamp: 2 }
+    ];
+    expect( buildTraceTree( entries ) ).toBeNull();
+  } );
+
+  it( 'error phase sets error and endedAt on node', () => {
+    const entries = [
+      { kind: 'wf', id: 'r', parentId: undefined, phase: 'start', name: 'root', details: {}, timestamp: 100 },
+      { kind: 'step', id: 's', parentId: 'r', phase: 'start', name: 'step', details: {}, timestamp: 200 },
+      { kind: 'step', id: 's', parentId: 'r', phase: 'error', name: 'step', details: { message: 'failed' }, timestamp: 300 }
+    ];
+    const result = buildTraceTree( entries );
+    expect( result ).not.toBeNull();
+    expect( result.children ).toHaveLength( 1 );
+    expect( result.children[0].error ).toEqual( { message: 'failed' } );
+    expect( result.children[0].endedAt ).toBe( 300 );
+  } );
+
   it( 'builds a tree from workflow/step/IO entries with grouping and sorting', () => {
     const entries = [
       // workflow start
@@ -28,7 +53,7 @@ describe( 'build_trace_tree', () => {
       { kind: 'workflow', phase: 'end', name: 'wf', id: 'wf', parentId: undefined, details: { ok: true }, timestamp: 3000 }
     ];
 
-    const result = buildLogTree( entries );
+    const result = buildTraceTree( entries );
 
     const expected = {
       id: 'wf',