@output.ai/core 0.1.8-dev.pr156.ac53caf → 0.1.8-dev.pr156.f70e0a1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@output.ai/core",
-  "version": "0.1.8-dev.pr156.ac53caf",
+  "version": "0.1.8-dev.pr156.f70e0a1",
   "description": "The core module of the output framework",
   "type": "module",
   "exports": {

package/src/tracing/processors/local/index.js

@@ -4,56 +4,66 @@ import { fileURLToPath } from 'url';
 import buildTraceTree from '../../tools/build_trace_tree.js';
 import { EOL } from 'node:os';
 
-const oneWeekInMS = 1000 * 60 * 60 * 24 * 7;
 const __dirname = dirname( fileURLToPath( import.meta.url ) );
-const tempDir = join( __dirname, 'temp', 'traces' );
+
+const PURGE_TEMP_FILES_THRESHOLD = 1000 * 60 * 60 * 24 * 7; // 1 week in milliseconds
+
+// The path to the project root
+const LOCAL_PROJECT_ROOT_PATH = process.argv[2] || process.cwd();
+
+// The path to the local trace logs
+const LOCAL_TRACE_LOG_PATH = join( LOCAL_PROJECT_ROOT_PATH, 'logs' );
+
+// The path to the temporary trace logs
+const TMP_TRACE_LOG_PATH = join( __dirname, 'temp', 'traces' );
 
 const accumulate = ( { entry, executionContext: { workflowId, startTime } } ) => {
-  const path = join( tempDir, `${startTime}_${workflowId}.trace` );
+  const path = join( TMP_TRACE_LOG_PATH, `${startTime}_${workflowId}.trace` );
   appendFileSync( path, JSON.stringify( entry ) + EOL, 'utf-8' );
   return readFileSync( path, 'utf-8' ).split( EOL ).slice( 0, -1 ).map( v => JSON.parse( v ) );
 };
 
-const cleanupOldTempFiles = ( threshold = Date.now() - oneWeekInMS ) =>
-  readdirSync( tempDir )
+const cleanupOldTempFiles = ( threshold = Date.now() - PURGE_TEMP_FILES_THRESHOLD ) =>
+  readdirSync( TMP_TRACE_LOG_PATH )
     .filter( f => +f.split( '_' )[0] < threshold )
-    .forEach( f => rmSync( join( tempDir, f ) ) );
+    .forEach( f => rmSync( join( TMP_TRACE_LOG_PATH, f ) ) );
 
 /**
- * Init this processor
+ * Get the host trace log path, which is used for reporting trace locations.
+ * In containerized environments (e.g., Docker), this can be different from the local path
+ * to map container paths to host filesystem paths.
+ * @returns {string} The host trace log path from HOST_TRACE_PATH env var, or local path as fallback
  */
-export const init = () => {
-  mkdirSync( tempDir, { recursive: true } );
-  cleanupOldTempFiles();
+const getHostTraceLogPath = () => {
+  return process.env.HOST_TRACE_PATH || LOCAL_TRACE_LOG_PATH;
 };
 
 /**
- * Get the container base path for writing trace files
- * Always writes to the local working directory, regardless of HOST_TRACE_PATH
- * @returns {string} The base path where traces should be written in the container
+ * Init this processor
  */
-const getContainerBasePath = () => {
-  return join( process.cwd(), 'logs' );
+export const init = () => {
+  mkdirSync( TMP_TRACE_LOG_PATH, { recursive: true } );
+  cleanupOldTempFiles();
 };
 
 /**
- * Get the base path for reporting trace file locations
- * Uses HOST_TRACE_PATH if set (for reporting to host), otherwise uses local path
- * @returns {string} The base path where traces can be accessed from the host
+ * Get the local file system path for ALL file I/O operations (read/write)
+ * Uses the project root path passed as argv[2], falls back to cwd
+ * @param {string} workflowName - The name of the workflow
+ * @returns {string} The local filesystem path for file operations
  */
-const getBasePath = () => {
-  return process.env.HOST_TRACE_PATH || join( process.cwd(), 'logs' );
+const getLocalOutputDir = workflowName => {
+  return join( LOCAL_PROJECT_ROOT_PATH, 'logs', 'runs', workflowName );
 };
 
 /**
- * Get the output directory for trace files
+ * Get the host path for reporting trace file locations to users
+ * Uses HOST_TRACE_PATH if set (for Docker), otherwise uses project root
  * @param {string} workflowName - The name of the workflow
- * @param {boolean} useContainerPath - If true, uses container path for writing; otherwise uses host path for reporting
- * @returns {string} The output directory path
+ * @returns {string} The path to report to users/API
  */
-const getOutputDir = ( workflowName, useContainerPath = false ) => {
-  const basePath = useContainerPath ? getContainerBasePath() : getBasePath();
-  return join( basePath, 'runs', workflowName );
+const getReportOutputDir = workflowName => {
+  return join( getHostTraceLogPath(), 'runs', workflowName );
 };
 
 const buildOutputFileName = ( { startTime, workflowId } ) => {
@@ -75,8 +85,8 @@ export const exec = ( { entry, executionContext } ) => {
   const { workflowId, workflowName, startTime } = executionContext;
   const content = buildTraceTree( accumulate( { entry, executionContext } ) );
 
-  // Use container path for writing files (true flag)
-  const dir = getOutputDir( workflowName, true );
+  // Always use local path for writing files
+  const dir = getLocalOutputDir( workflowName );
   const path = join( dir, buildOutputFileName( { startTime, workflowId } ) );
 
   mkdirSync( dir, { recursive: true } );
@@ -92,5 +102,6 @@ export const exec = ( { entry, executionContext } ) => {
  * @returns {string} The absolute path where the trace will be saved
  */
 export const getDestination = ( { startTime, workflowId, workflowName } ) => {
-  return join( getOutputDir( workflowName ), buildOutputFileName( { workflowId, startTime } ) );
+  // Use report path for reporting to users/API
+  return join( getReportOutputDir( workflowName ), buildOutputFileName( { workflowId, startTime } ) );
 };

package/src/tracing/processors/local/index.spec.js

@@ -40,6 +40,7 @@ describe( 'tracing/processors/local', () => {
 
     init();
 
+    // Should create temp dir relative to module location using __dirname
     expect( mkdirSyncMock ).toHaveBeenCalledWith( expect.stringMatching( /temp\/traces$/ ), { recursive: true } );
     expect( rmSyncMock ).toHaveBeenCalledTimes( 1 );
   } );