@output.ai/core 0.1.8-dev.pr156.16605c1 → 0.1.8-dev.pr156.ac53caf

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@output.ai/core",
-  "version": "0.1.8-dev.pr156.16605c1",
+  "version": "0.1.8-dev.pr156.ac53caf",
   "description": "The core module of the output framework",
   "type": "module",
   "exports": {

package/src/tracing/processors/local/index.js

@@ -28,15 +28,32 @@ export const init = () => {
 };
 
 /**
- * Get the base path for trace file storage
- * @returns {string} The base path where traces should be written
+ * Get the container base path for writing trace files
+ * Always writes to the local working directory, regardless of HOST_TRACE_PATH
+ * @returns {string} The base path where traces should be written in the container
+ */
+const getContainerBasePath = () => {
+  return join( process.cwd(), 'logs' );
+};
+
+/**
+ * Get the base path for reporting trace file locations
+ * Uses HOST_TRACE_PATH if set (for reporting to host), otherwise uses local path
+ * @returns {string} The base path where traces can be accessed from the host
  */
 const getBasePath = () => {
   return process.env.HOST_TRACE_PATH || join( process.cwd(), 'logs' );
 };
 
-const getOutputDir = workflowName => {
-  return join( getBasePath(), 'runs', workflowName );
+/**
+ * Get the output directory for trace files
+ * @param {string} workflowName - The name of the workflow
+ * @param {boolean} useContainerPath - If true, uses container path for writing; otherwise uses host path for reporting
+ * @returns {string} The output directory path
+ */
+const getOutputDir = ( workflowName, useContainerPath = false ) => {
+  const basePath = useContainerPath ? getContainerBasePath() : getBasePath();
+  return join( basePath, 'runs', workflowName );
 };
 
 const buildOutputFileName = ( { startTime, workflowId } ) => {
@@ -58,7 +75,8 @@ export const exec = ( { entry, executionContext } ) => {
   const { workflowId, workflowName, startTime } = executionContext;
   const content = buildTraceTree( accumulate( { entry, executionContext } ) );
 
-  const dir = getOutputDir( workflowName );
+  // Use container path for writing files (true flag)
+  const dir = getOutputDir( workflowName, true );
   const path = join( dir, buildOutputFileName( { startTime, workflowId } ) );
 
   mkdirSync( dir, { recursive: true } );

package/src/tracing/processors/local/index.spec.js

@@ -29,6 +29,7 @@ describe( 'tracing/processors/local', () => {
     vi.clearAllMocks();
     store.files.clear();
     process.argv[2] = '/tmp/project';
+    delete process.env.HOST_TRACE_PATH; // Clear HOST_TRACE_PATH for clean tests
   } );
 
   it( 'init(): creates temp dir and cleans up old files', async () => {
@@ -78,5 +79,70 @@ describe( 'tracing/processors/local', () => {
     expect( destination ).toMatch( /^\/|^[A-Z]:\\/i ); // Starting with / or Windows drive letter
     expect( destination ).toContain( '/logs/runs/test-workflow/2020-01-02-03-04-05-678Z_workflow-id-123.json' );
   } );
+
+  it( 'exec(): writes to container path regardless of HOST_TRACE_PATH', async () => {
+    const { exec, init } = await import( './index.js' );
+
+    // Set HOST_TRACE_PATH to simulate Docker environment
+    process.env.HOST_TRACE_PATH = '/host/path/logs';
+
+    init();
+
+    const startTime = Date.parse( '2020-01-02T03:04:05.678Z' );
+    const ctx = { executionContext: { workflowId: 'id1', workflowName: 'WF', startTime } };
+
+    exec( { ...ctx, entry: { name: 'A', phase: 'start', timestamp: startTime } } );
+
+    expect( writeFileSyncMock ).toHaveBeenCalledTimes( 1 );
+    const [ writtenPath ] = writeFileSyncMock.mock.calls.at( -1 );
+
+    // Should write to process.cwd()/logs, NOT to HOST_TRACE_PATH
+    expect( writtenPath ).not.toContain( '/host/path/logs' );
+    expect( writtenPath ).toMatch( /logs\/runs\/WF\// );
+  } );
+
+  it( 'getDestination(): returns HOST_TRACE_PATH when set', async () => {
+    const { getDestination } = await import( './index.js' );
+
+    // Set HOST_TRACE_PATH to simulate Docker environment
+    process.env.HOST_TRACE_PATH = '/host/path/logs';
+
+    const startTime = Date.parse( '2020-01-02T03:04:05.678Z' );
+    const workflowId = 'workflow-id-123';
+    const workflowName = 'test-workflow';
+
+    const destination = getDestination( { startTime, workflowId, workflowName } );
+
+    // Should return HOST_TRACE_PATH-based path for reporting
+    expect( destination ).toBe( '/host/path/logs/runs/test-workflow/2020-01-02-03-04-05-678Z_workflow-id-123.json' );
+  } );
+
+  it( 'separation of write and report paths works correctly', async () => {
+    const { exec, getDestination, init } = await import( './index.js' );
+
+    // Set HOST_TRACE_PATH to simulate Docker environment
+    process.env.HOST_TRACE_PATH = '/Users/ben/project/logs';
+
+    init();
+
+    const startTime = Date.parse( '2020-01-02T03:04:05.678Z' );
+    const workflowId = 'workflow-id-123';
+    const workflowName = 'test-workflow';
+    const ctx = { executionContext: { workflowId, workflowName, startTime } };
+
+    // Execute to write file
+    exec( { ...ctx, entry: { name: 'A', phase: 'start', timestamp: startTime } } );
+
+    // Get destination for reporting
+    const destination = getDestination( { startTime, workflowId, workflowName } );
+
+    // Verify write path is local
+    const [ writtenPath ] = writeFileSyncMock.mock.calls.at( -1 );
+    expect( writtenPath ).not.toContain( '/Users/ben/project' );
+    expect( writtenPath ).toMatch( /logs\/runs\/test-workflow\// );
+
+    // Verify report path uses HOST_TRACE_PATH
+    expect( destination ).toBe( '/Users/ben/project/logs/runs/test-workflow/2020-01-02-03-04-05-678Z_workflow-id-123.json' );
+  } );
 } );